On 19.01.2010 03:29, Carl-Daniel Hailfinger wrote:
On 19.01.2010 01:10, Sean Nelson wrote:
I'm going to do one last patch, some of the ST chips use 82802ab functions and I'm going to change them to stm50flw0x0x but keep probe_82802ab; They are functionally the same.
Convert ST to block erasers: ST M25Px ST M29Fx ST M29Wx ST M50FLWx ST M50FWx ST M50LPW116
Signed-off-by: Sean Nelson audiohacked@gmail.com
ERROR: Flash chip M25P128 erase function 0 region walking resulted in 0x2000000 bytes total, expected 0x1000000 bytes. Please report a bug at flashrom@flashrom.org ERROR: Flash chip M50FW002 erase function 1 region walking resulted in 0x100000 bytes total, expected 0x040000 bytes. Please report a bug at flashrom@flashrom.org
I might add that reviewing this one was more difficult because it used standard 3 lines of context and it was not obvious to which chips the patch belonged.
Regards, Carl-Daniel