carl-daniel wrote:
[Paul, I included you in CC because you wrote the ft2232 code.]
thanks carl.
Hi,
On 15.09.2009 19:49, Stefan Reinauer wrote:
this patch fixes all 27 flashrom source code issues reported by LLVM/clang's scan-build (r79326, new build on the way).
Signed-off-by: Stefan Reinauer stepan@coresystems.de
The following parts of the patch are Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
sst28sf040.c (definitely) sharplhf00l04.c (we shouldn't enter ID mode at all) stm50flw0x0x.c (we shouldn't enter ID mode at all) serprog.c (serprog_die should be killed, but for now...)
I can do the ID mode removal in a followup patch.
The serprog.c change is correct, but we need a design review of serprog anyway and I hope to kill serprog_die() completely in that review. ft2232_spi.c is a bit special because I don't have any idea what port_val is used for. It looks like a dead variable, but maybe it was intended to track the status of other lines besides CS# and in that case we should keep the variable and fill it with the correct value.
it looks dead to me. i tracked it back as coming from the bitbang.c sample code that came (i think) with libftdi, and in my copy of that code, at least, it's already a useless variable. get rid of it.
paul
In 82802ab.c I miss some of the commented out commands. Some of them should be fixed and reenabled (especially the chip protection status).
Regards, Carl-Daniel
=--------------------- paul fox, pgf@foxharp.boston.ma.us (arlington, ma, where it's 58.8 degrees)