Re: [flashrom] [PATCH] flashchips.c: Typo. s/don't/doesn't/

[Carl-Daniel Hailfinger]

On 12.06.2010 22:48, Paul Menzel wrote:
> Signed-off-by: Paul Menzel

Thanks!
Could you make a few changes as outlined below?
> flashchips.c |   52 ++++++++++++++++++++++++++--------------------------
>  1 files changed, 26 insertions(+), 26 deletions(-)
>
> diff --git a/flashchips.c b/flashchips.c
> index a82c373..70a4ff1 100644
> --- a/flashchips.c
> +++ b/flashchips.c
> @@ -155,7 +155,7 @@ struct flashchip flashchips[] = {
>    	.feature_bits	= FEATURE_ADDR_2AA | FEATURE_SHORT_RESET,
>    	.tested		= TEST_UNTESTED,
>    	.probe		= probe_jedec,
> .probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (am29f040b.c) */
> .probe_timing	= TIMING_IGNORED, /* routine doesn't use probe_timing (am29f040b.c) */

Needs to be TIMING_FIXME and you can remove the comment.
> .block_erasers	=
> {
> 	{
>
> @@ -181,7 +181,7 @@ struct flashchip flashchips[] = {
>    	.feature_bits	= FEATURE_ADDR_2AA | FEATURE_SHORT_RESET,
>    	.tested		= TEST_UNTESTED,
>    	.probe		= probe_jedec,
> .probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (am29f040b.c) */
> .probe_timing	= TIMING_IGNORED, /* routine doesn't use probe_timing (am29f040b.c) */

TIMING_FIXME
> .block_erasers	=
> {
> 	{
>
> @@ -233,7 +233,7 @@ struct flashchip flashchips[] = {
>    	.feature_bits	= FEATURE_ADDR_2AA | FEATURE_SHORT_RESET,
>    	.tested		= TEST_UNTESTED,
>    	.probe		= probe_jedec,
> .probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (am29f040b.c) */
> .probe_timing	= TIMING_IGNORED, /* routine doesn't use probe_timing (am29f040b.c) */

TIMING_FIXME
> .block_erasers	=
> {
> 	{
>
> @@ -259,7 +259,7 @@ struct flashchip flashchips[] = {
>    	.feature_bits	= FEATURE_ADDR_2AA | FEATURE_SHORT_RESET,
>    	.tested		= TEST_UNTESTED,
>    	.probe		= probe_jedec,
> .probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (am29f040b.c) */
> .probe_timing	= TIMING_IGNORED, /* routine doesn't use probe_timing (am29f040b.c) */

TIMING_FIXME
> .block_erasers	=
> {
> 	{
>
> @@ -1230,7 +1230,7 @@ struct flashchip flashchips[] = {
>    	.feature_bits	= FEATURE_ADDR_2AA | FEATURE_SHORT_RESET,
>    	.tested		= TEST_UNTESTED,
>    	.probe		= probe_jedec,
> .probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (mx29f002.c) */
> .probe_timing	= TIMING_IGNORED, /* routine doesn't use probe_timing (mx29f002.c) */

TIMING_FIXME
> .block_erasers	=
> {
> 	{
>
> @@ -1261,7 +1261,7 @@ struct flashchip flashchips[] = {
>    	.feature_bits	= FEATURE_ADDR_2AA | FEATURE_SHORT_RESET,
>    	.tested		= TEST_OK_PRW,
>    	.probe		= probe_jedec,
> .probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (mx29f002.c) */
> .probe_timing	= TIMING_IGNORED, /* routine doesn't use probe_timing (mx29f002.c) */

TIMING_FIXME
> .block_erasers	=
> {
> 	{
>
> @@ -1292,7 +1292,7 @@ struct flashchip flashchips[] = {
>    	.feature_bits	= FEATURE_ADDR_2AA | FEATURE_SHORT_RESET,
>    	.tested		= TEST_UNTESTED,
>    	.probe		= probe_jedec,
> .probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (am29f040b.c) */
> .probe_timing	= TIMING_IGNORED, /* routine doesn't use probe_timing (am29f040b.c) */

TIMING_FIXME
> .block_erasers	=
> {
> 	{
>
> @@ -2280,7 +2280,7 @@ struct flashchip flashchips[] = {
>    	.feature_bits	= FEATURE_ADDR_SHIFTED | FEATURE_EITHER_RESET,
>    	.tested		= TEST_UNTESTED,
>    	.probe		= probe_m29f400bt,
> .probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (m29f400bt.c) */
> .probe_timing	= TIMING_IGNORED, /* routine doesn't use probe_timing (m29f400bt.c) */
> .block_erasers	=
> {
> 	{
>
> @@ -2311,7 +2311,7 @@ struct flashchip flashchips[] = {
>    	.feature_bits	= FEATURE_ADDR_SHIFTED | FEATURE_EITHER_RESET,
>    	.tested		= TEST_UNTESTED,
>    	.probe		= probe_m29f400bt,
> .probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (m29f400bt.c) */
> .probe_timing	= TIMING_IGNORED, /* routine doesn't use probe_timing (m29f400bt.c) */
> .block_erasers	=
> {
> 	{
>
> @@ -2931,7 +2931,7 @@ struct flashchip flashchips[] = {
>    	.feature_bits	= FEATURE_ADDR_2AA | FEATURE_SHORT_RESET,
>    	.tested		= TEST_UNTESTED,
>    	.probe		= probe_jedec,
> .probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (mx29f002.c) */
> .probe_timing	= TIMING_IGNORED, /* routine doesn't use probe_timing (mx29f002.c) */

TIMING_FIXME
> .block_erasers	=
> {
> 	{
>
> @@ -2963,7 +2963,7 @@ struct flashchip flashchips[] = {
>    	.feature_bits	= FEATURE_ADDR_2AA | FEATURE_SHORT_RESET,
>    	.tested		= TEST_UNTESTED,
>    	.probe		= probe_jedec,
> .probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (mx29f002.c) */
> .probe_timing	= TIMING_IGNORED, /* routine doesn't use probe_timing (mx29f002.c) */

TIMING_FIXME
> .block_erasers	=
> {
> 	{
>
> @@ -2995,7 +2995,7 @@ struct flashchip flashchips[] = {
>    	.feature_bits	= FEATURE_ADDR_2AA | FEATURE_SHORT_RESET,
>    	.tested		= TEST_UNTESTED,
>    	.probe		= probe_jedec,
> .probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (mx29f002.c) */
> .probe_timing	= TIMING_IGNORED, /* routine doesn't use probe_timing (mx29f002.c) */

TIMING_FIXME
> .block_erasers	=
> {
> 	{
>
> @@ -3026,7 +3026,7 @@ struct flashchip flashchips[] = {
>    	.feature_bits	= FEATURE_ADDR_2AA | FEATURE_SHORT_RESET,
>    	.tested		= TEST_OK_PRW,
>    	.probe		= probe_jedec,
> .probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (mx29f002.c) */
> .probe_timing	= TIMING_IGNORED, /* routine doesn't use probe_timing (mx29f002.c) */

TIMING_FIXME
> .block_erasers	=
> {
> 	{
>
> @@ -3057,7 +3057,7 @@ struct flashchip flashchips[] = {
>    	.feature_bits	= FEATURE_ADDR_2AA | FEATURE_SHORT_RESET,
>    	.tested		= TEST_UNTESTED,
>    	.probe		= probe_jedec,
> .probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (mx29f002.c) */
> .probe_timing	= TIMING_IGNORED, /* routine doesn't use probe_timing (mx29f002.c) */

TIMING_FIXME
> .block_erasers	=
> {
> 	{
>
> @@ -3917,7 +3917,7 @@ struct flashchip flashchips[] = {
>    	.feature_bits	= 0,
>    	.tested		= TEST_UNTESTED,
>    	.probe		= probe_82802ab,
> .probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (sst28sf040.c) */
> .probe_timing	= TIMING_IGNORED, /* routine doesn't use probe_timing (sst28sf040.c) */
> .block_erasers	=
> {
> 	{
>
> @@ -4368,7 +4368,7 @@ struct flashchip flashchips[] = {
>    	.feature_bits	= FEATURE_REGISTERMAP,
>    	.tested		= TEST_UNTESTED,
>    	.probe		= probe_82802ab,
> .probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (sst49lfxxxc.c) */
> .probe_timing	= TIMING_IGNORED, /* routine doesn't use probe_timing (sst49lfxxxc.c) */
> .block_erasers	=
> {
> 	{
>
> @@ -4431,7 +4431,7 @@ struct flashchip flashchips[] = {
>    	.feature_bits	= FEATURE_REGISTERMAP,
>    	.tested		= TEST_UNTESTED,
>    	.probe		= probe_82802ab,
> .probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (sst49lfxxxc.c) */
> .probe_timing	= TIMING_IGNORED, /* routine doesn't use probe_timing (sst49lfxxxc.c) */
> .block_erasers	=
> {
> 	{
>
> @@ -4463,7 +4463,7 @@ struct flashchip flashchips[] = {
>    	.feature_bits	= FEATURE_REGISTERMAP,
>    	.tested		= TEST_OK_PRW,
>    	.probe		= probe_82802ab,
> .probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (sst49lfxxxc.c) */
> .probe_timing	= TIMING_IGNORED, /* routine doesn't use probe_timing (sst49lfxxxc.c) */
> .block_erasers	=
> {
> 	{
>
> @@ -4640,7 +4640,7 @@ struct flashchip flashchips[] = {
>    	.feature_bits	= FEATURE_REGISTERMAP,
>    	.tested		= TEST_OK_PRW,
>    	.probe		= probe_82802ab,
> .probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (sst49lfxxxc.c) */
> .probe_timing	= TIMING_IGNORED, /* routine doesn't use probe_timing (sst49lfxxxc.c) */
> .block_erasers	=
> {
> 	{
>
> @@ -5040,7 +5040,7 @@ struct flashchip flashchips[] = {
>    	.feature_bits	= FEATURE_ADDR_2AA | FEATURE_EITHER_RESET,
>    	.tested		= TEST_UNTESTED,
>    	.probe		= probe_jedec,
> .probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (am29f040b.c) */
> .probe_timing	= TIMING_IGNORED, /* routine doesn't use probe_timing (am29f040b.c) */

TIMING_FIXME
> .block_erasers	=
> {
> 	{
>
> @@ -5067,7 +5067,7 @@ struct flashchip flashchips[] = {
>    	.feature_bits	= FEATURE_ADDR_SHIFTED | FEATURE_EITHER_RESET,
>    	.tested		= TEST_UNTESTED,
>    	.probe		= probe_m29f400bt,
> .probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (m29f400bt.c) */
> .probe_timing	= TIMING_IGNORED, /* routine doesn't use probe_timing (m29f400bt.c) */
> .block_erasers	=
> {
> 	{
>
> @@ -5313,7 +5313,7 @@ struct flashchip flashchips[] = {
>    	.feature_bits	= FEATURE_REGISTERMAP,
>    	.tested		= TEST_UNTESTED,
>    	.probe		= probe_82802ab,
> .probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (sst49lfxxxc.c) */
> .probe_timing	= TIMING_IGNORED, /* routine doesn't use probe_timing (sst49lfxxxc.c) */
> .block_erasers	=
> {
> 	{
>
> @@ -5345,7 +5345,7 @@ struct flashchip flashchips[] = {
>    	.feature_bits	= FEATURE_REGISTERMAP,
>    	.tested		= TEST_UNTESTED,
>    	.probe		= probe_82802ab,
> .probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (82802ab.c) */
> .probe_timing	= TIMING_IGNORED, /* routine doesn't use probe_timing (82802ab.c) */
> .block_erasers	=
> {
> 	{
>
> @@ -5372,7 +5372,7 @@ struct flashchip flashchips[] = {
>    	.feature_bits	= FEATURE_REGISTERMAP,
>    	.tested		= TEST_OK_PR,
>    	.probe		= probe_82802ab,
> .probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (82802ab.c) */
> .probe_timing	= TIMING_IGNORED, /* routine doesn't use probe_timing (82802ab.c) */
> .block_erasers	=
> {
> 	{
>
> @@ -5399,7 +5399,7 @@ struct flashchip flashchips[] = {
>    	.feature_bits	= FEATURE_REGISTERMAP,
>    	.tested		= TEST_OK_PR,
>    	.probe		= probe_82802ab,
> .probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (82802ab.c) */
> .probe_timing	= TIMING_IGNORED, /* routine doesn't use probe_timing (82802ab.c) */
> .block_erasers	=
> {
> 	{
>
> @@ -6010,7 +6010,7 @@ struct flashchip flashchips[] = {
>    	.feature_bits	= FEATURE_LONG_RESET,
>    	.tested		= TEST_OK_PRW,
>    	.probe		= probe_w29ee011,
> .probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (w29ee011.c) */
> .probe_timing	= TIMING_IGNORED, /* routine doesn't use probe_timing (w29ee011.c) */
> .block_erasers	=
> {
> 	{

Basically, all chips using probe_jedec have to replace TIMING_IGNORED
with TIMING_FIXME. If you have some time, you could even look up the
correct timing (value is in microseconds, and if there is no delay/wait
in the datasheet, use TIMING_ZERO as special value).

For the chip using probe_82802ab it would be nice to have the correct
delay value in the comment after TIMING_IGNORED if someone ever finds
the time to convert probe_82802ab to use the timing value.

Regards,
Carl-Daniel