Re: [flashrom] [PATCH] Fix parallel-style programmer access from SPI

[Carl-Daniel Hailfinger]

Am 01.03.2012 23:15 schrieb Carl-Daniel Hailfinger:
> Fix parallel-style programmer access from ITE IT87/Winbond W83627 SPI
>
> The ITE IT87 SPI driver uses a trick to speed up reading and writing:
> If a flash chip is 512 kByte or less, the flash chip can be completely
> mapped in memory and both read and write accesses are faster that way.
> The current IT87 SPI code did use the parallel programmer interface for
> memory mapped reads and writes, but that's the wrong abstraction. It has
> been fixed to use mmio_read*/mmio_write* for that purpose.
>
> The Winbond W83627 SPI driver uses the same trick in its read path for
> all supported chip sizes. Fix it the same way.
>
> Switch internal_chip_readn to use mmio_readn as proper abstraction.
>
> Kudos to Michael Karcher for spotting the bugs.
>
> Reported-by: Johan Svensson 
> Signed-off-by: Carl-Daniel Hailfinger 
> Acked-by: Michael Karcher 
> Tested-by: Johan Svensson

And committed in r1511.

Regards,
Carl-Daniel