On 05.12.2009 00:54, Michael Spang wrote:
On Fri, Dec 4, 2009 at 6:41 PM, Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net wrote:
Hi Luc,
I almost committed this patch, then I found a line which you might object to. We have a lspci for exactly this board from another user. Subject: [flashrom] Asus M2V-MX information From: Michael Spang mspang@csclub.uwaterloo.ca
On 30.11.2009 10:19, David Bartley wrote:
{0x1106, 0x3337, 0x1043, 0x80ed, 0x1106, 0xB188, 0, 0, NULL, NULL, "ASUS", "M2V-MX", board_asus_m2v_mx},David developed this patch on the very board that lspci output was from. Does it differ in some way from what you expect?
No, it's just that subsystem IDs with 0x0 in that table trigger a "unsafe match" mechanism in flashrom and autodetection will fail. Picking a different PCI device which has (hopefully board-specific) subsystem IDs enables auto-matching. You couldn't have known that. I asked Luc to look into this because he is our expert in picking the best hopefully-unique subsystem IDs.
Side note: We really need a flashrom.org upload interface which accepts lspci/flashrom/superiotool data and can extract best matches automatically.
Regards, Carl-Daniel