Re: [flashrom] [PATCH] Add IT8705 autodetection, Shuttle AK38N info

[Carl-Daniel Hailfinger]

On 10.07.2010 17:38, Uwe Hermann wrote:
> On Fri, Jul 09, 2010 at 06:39:40PM +0200, Carl-Daniel Hailfinger wrote:
> > Autodetect the ITE IT8705 Super I/O and enable flash writes if it
>                        ^
>
> Missing 'F' in the commit message.
> > performs LPC->Parallel translation.
> > Remove board enables which triggered the IT8705 write enable manually.
>                                              ^
>                                            Ditto

Sorry, I got that wrong during cut-n-paste.
> > Change the IT87 SPI special case to cover IT87 LPC->SPI and
> > LPC->Parallel translation.
> >
> > Signed-off-by: Carl-Daniel Hailfinger
> >
> > Tested on Syntax SV266A.
> > Acked-by: Paul Menzel
> >
> > Tested on Shuttle AK38N, all operations work fine.
> > Acked-by: Uwe Hermann
>
> Retested this version on AK38N, still works fine.
>
> Acked-by: Uwe Hermann

Thanks, committed in r1073.
> Please feel free to commit. I will do a review against the datasheet
> when time permits, but no need to wait for that, the code has been
> tested and reviewed by multiple people now, I don't expect issues.

I changed the code as you suggested.
> I'll attach flashrom and superiotool output on Shuttle AK38N for reference.

Thanks.

Regards,
Carl-Daniel