Re: [flashrom] [PATCH 05/11] warn if SMM BIOS Write Protection is detected in BIOS_CNTL

[Carl-Daniel Hailfinger]

Am 28.05.2011 05:38 schrieb Stefan Tauner:
> Signed-off-by: Stefan Tauner

With minor changes:

Acked-by: Carl-Daniel Hailfinger
> chipset_enable.c |   11 ++++++++++-
>  1 files changed, 10 insertions(+), 1 deletions(-)
>
> diff --git a/chipset_enable.c b/chipset_enable.c
> index 83b49ad..1f6f74c 100644
> --- a/chipset_enable.c
> +++ b/chipset_enable.c
> @@ -264,8 +264,17 @@ static int enable_flash_ich(struct pci_dev *dev, const char *name,
>    	     (old & (1 << 0)) ? "en" : "dis");
>    msg_pdbg("BIOS_CNTL is 0x%x\n", old);
> new = old | 1;
> /*
> * Quote from the 6 Series datasheet:

Please include a datasheet number so others can find it easily.
> * "5: SMM BIOS Write Protect Disable (SMM_BWP)

Maybe "Bit 5: SMM..."
> * 1 = BIOS region SMM protection is enabled.
> * The BIOS Region is not writable unless all processors are in SMM."
> * In earlier chipsets this bit is reserved. */
>
> if (old & (1 << 5)) {
> msg_pinfo("WARNING: BIOS region SMM protection is enabled!\n");
>
> }
>
> new = old | 1;
> if (new == old)
> return 0;

Regards,
Carl-Daniel