Re: [flashrom] [PATCH] Disallow the internal programmer on non-x86 for now

[Vladimir 'φ-coder/phcoder' Serbinenko]

Carl-Daniel Hailfinger wrote:
> On 26.05.2010 08:22, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> > Carl-Daniel Hailfinger wrote:
> > > The internal programmer needs correct information about flash_base and
> > > chip window top/bottom alignment on non-x86 before it can be used. Abort
> > > any internal programmer action for now until the code is fixed.
> > >
> > > Signed-off-by: Carl-Daniel Hailfinger
> > >
> > > +#else
> > > /* FIXME: Remove this unconditional abort once all PCI drivers are
> > > * converted to use little-endian accesses for memory BARs.
> > > */
> > > msg_perr("Your platform is not supported yet for the internal "
> > >  "programmer because it has not been converted from native "
> > >  "endian to little endian access yet.\n"
> > >  "Aborting.\n");
> >
> > Should have been "external".
>
> Are you sure? This warning is part of the internal (main onboard flash)
> programmer.
> Although this warning should be added for external PCI-based
> programmers, such a change is not part of this patch because I want to
> fix them instead of marking them as broken.

Then I misread the code. Sorry for noise.
> Regards,
> Carl-Daniel