Am Freitag, den 18.06.2010, 10:49 +0200 schrieb David Borg:
First: Thank you for submitting this patch to flashrom.
However, I'm not sure what the page_size should be. Datasheet:
No one is. page_size is an underspecified setting that is used in completely different way in different contexts. For byte-wise JEDEC chips, I think the value is not used at all (which should be the long-term goal for every chip, as page_size should get replaced by better defined parameters).
http://www.datasheetarchive.com/pdf/Datasheet-029/DSA00514421.pdf
Thanks for the link. On reading that data sheet, I found that the datasheet uses 10-bit addresses for the commands (555/2AA). This is expressed as "FEATURE_ADDR_2AA" in flashrom. Could you try whether the patch still works with this feature flag added, and if yes resubmit with it? Your chip seems to ignore the high address bits (which is common behaviour), thats why 5555/2AAA also works.
Except for FEATURE_ADDR_2AA, the patch is
Acked-by: Michael Karcher flashrom@mkarcher.dialup.fu-berlin.de
Signed-off-by: David Borg (borg.db@gmail.com)
Can you please use angle brackets in the Sign-Off?
Regards, Michael Karcher