Hi,
On Sat, Jan 18, 2020 at 7:31 PM Nico Huber nico.h@gmx.de wrote:
Hi,
On 14.01.20 17:10, Carl-Daniel Hailfinger wrote:
commit e28d75ed7204d7fac2c0fac13978098530b0574e dropped some logic during refactoring. PCI-based programmers now fail to initialize IFF the desired PCI device not the last one enumerated by libpci.
yup, I already commented on that change post-merge. Just waited for the holidays to pass, no reaction after all so I pushed a revert: https://review.coreboot.org/c/flashrom/+/38319
I noticed the revert today. I'm not sure what unit tests are good for without, for example, regression tests on hardware.
Nico _______________________________________________ flashrom mailing list -- flashrom@flashrom.org To unsubscribe send an email to flashrom-leave@flashrom.org
Best regards,
Angel