2 Dec
2009
2 Dec
'09
6:14 p.m.
Hi Carl-Daniel,
On 2009-12-02 16:51, Carl-Daniel Hailfinger wrote:
Is there any reason you can't call enable_flash_ich(dev, name, 0xd8)? That would eliminate some of the code.
It's a matter of taste actually.
Using enable_flash_ich would eliminate only printf_debug lines and half of one PCI register value modification.
If I do all inside the function then I use word-access once instead of using byte-access twice. I'm also able to print out the state of prefetch_flag right after lock_enable and write_enable but before the whole 16-bit register value.
Best regards, Adam