Hello Vadim,
thank you for the patch!
On 27.03.2010 17:14, Vadim Girlin wrote:
Flashrom v0.9.1-r985 was unable to detect SPI flash chip (SST25VF080B) on Gigabyte GA-MA770-UD3 (rev 1.0) - http://www.gigabyte.com.tw/Products/Motherboard/Products_Spec.aspx?ProductID...
After this patch flashrom detected the chip. Reading, erasing and writing also works.
Index: it87spi.c
--- it87spi.c (revision 985) +++ it87spi.c (working copy) @@ -103,6 +103,7 @@ switch (id) { case 0x8716: case 0x8718:
- case 0x8720: enter_conf_mode_ite(port); /* NOLDN, reg 0x24, mask out lowest bit (suspend) */ tmp = sio_read(port, 0x24) & 0xFE;
Perfect. We'd like to merge that patch before releasing flashrom 0.9.2.
I attached the logs. Hope this helps.
Yes, indeed. It seems that your board has valid settings for SB700 SPI, and still uses the IT8720 for SPI. I've never seen that before, and your log shows that our decision to let the IT87* SPI override the chipset SPI was a good idea.
Could you please send a reply with a Signed-off-by: line? The coreboot/flashrom development guidelines have a short explanation: http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure
It allows us to keep track of who contributed code and makes auditing easier.
Thanks again!
Regards, Carl-Daniel