Re: [flashrom] [PATCH] Convert PCI-based programmers to LE MMIO accessors

[Michael Manulis]

On Wed, Jul 14, 2010 at 4:03 PM, Carl-Daniel Hailfinger <
[e-mail]> wrote:
> Hi Michael,
>
> I have added [e-mail] to CC again to make sure others can
> follow us.
>
> On 12.07.2010 20:06, Michael Manulis wrote:
> > I finally got around to checking your patch.  Short story, flashrom could
> > not find any flash chips.  The log as follows.  I had to make one change
>
> to
> > get the code to compile on PPC, here's the diff:
> > Index: chipset_enable.c
> >
> > --- chipset_enable.c    (revision 1075)
> > +++ chipset_enable.c    (working copy)
> > @@ -33,10 +33,10 @@
> >  #include <unistd.h>
> >  #include "flash.h"
> >
> > +#define NOT_DONE_YET 1
> >
> > #if defined(__i386__) || defined(__x86_64__)
> >
> > -#define NOT_DONE_YET 1
> >
> > static int enable_flash_ali_m1533(struct pci_dev *dev, const char *name)
> >  {
> >         uint8_t tmp;
>
> Thanks. I already had that change in my local tree, but forgot to push it.
> > Output from flashrom -L and -V
> >
> > ./flashrom -LV
> > flashrom v0.9.2-r1075 on Linux 2.6.16.13-vsm (ppc), built with libpci
> > 2.2.4-pre4, GCC 4.1.2 20061115 (prerelease) (Debian 4.1.1-21), big endian
> > flashrom is free software, get the source code at
>
> http://www.flashrom.org
> > [...]
> > Supported PCI devices flashrom can use as programmer:
> >
> > Silicon Image PCI0680 Ultra ATA-133 Host Ctrl [1095:680]
> > Silicon Image SiI 3112 [SATALink/SATARaid] SATA Ctrl [1095:3112]
> > Silicon Image SiI 3114 [SATALink/SATARaid] SATA Ctrl [1095:3114]
> > Silicon Image SiI 3124 PCI-X SATA Ctrl [1095:3124] (untested)
> > Silicon Image SiI 3132 SATA Raid II Ctrl [1095:3132]
> > Silicon Image SiI 3512 [SATALink/SATARaid] SATA Ctrl [1095:3512]
>
> (untested)
> > # ./flashrom -V
> > flashrom v0.9.2-r1075 on Linux 2.6.16.13-vsm (ppc), built with libpci
> > 2.2.4-pre4, GCC 4.1.2 20061115 (prerelease) (Debian 4.1.1-21), big endian
> > flashrom is free software, get the source code at
>
> http://www.flashrom.org
> > Calibrating delay loop... OS timer resolution is 1 usecs, 500M loops per
> > second, 10 myus = 10 us, 100 myus = 100 us, 1000 myus = 1001 us, 10000
>
> myus
> > = 10004
> > us, 4 myus = 4 us, OK.
> > Initializing internal programmer
> > Processor detection/init failed.
> > Aborting.
> > Error: Programmer initialization failed.
>
> Good. That's expected when using the default internal programmer. IIRC
> you wanted to flash the SATA controller on your CurtisWright Raptor.
> Could you try
> flashrom -p satasii -V
>
> That one should work.
>
> Regards,
> Carl-Daniel

I ran the following commands to test the patch:

./flashrom -p satasii -V
./flashrom -p satasii -Vr sata.dump
ls -lh sata.dump
./flashrom -p satasii -VE
./flashrom -p satasii -Vr zero.dump
hexdump zero.dump
./flashrom -p satasii -Vw sata.dump
./flashrom -p satasii -Vv sata.dump

I attached the log as the file is 100K and I was reluctant to just paste it
in the body.

The log is also available on pastebin.com at http://pastebin.com/kHkynj7s

Please let me know if you would like me to run other tests.

Misha Manulis