Am 20.07.2012 20:51 schrieb Patrick Georgi:
attached patch hides hwaccess.h (which is usually not necessary to use flashrom as library) from the public interface at flash.h. For the most part, this simply adds the header to driver .c files, but it also required a small workaround to handle libpci types used in a bunch of prototypes.
Rationale: hwaccess.h at that place conflicts with libpayload which brings its own hardware access functions (which are wrapped properly to match flashrom's expectations in hwaccess.h already). They should also not matter in other contexts (and if someone requires them, they can still include hwaccess.h where needed).
Thanks for your patch.
Librarification of flashrom requires some more patches, like pulling out some functions of the CLI code - even if doit() is by no means a pretty interface, it makes things simpler. But one step after the other...
I have some makefile patch pending which makes libflashrom usage easier. I should fix that one and resend it.
Signed-off-by: Patrick Georgi patrick.georgi@secunet.com
Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net and committed in r1549.
Admin note: Apparently patchwork didn't pick up this thread.
Regards, Carl-Daniel