Am 31.01.2012 07:57 schrieb Stefan Tauner:
On Mon, 30 Jan 2012 09:38:52 +0100 "Feldschmid, Ingo" ifel@msc-ge.com wrote:
The detection mechanism should now work for all boards with Tunnel Creek CPU with EG20T southbridge from vendor "MSC Vertriebs GmbH". I tried to narrow it down with the CPU/chipset/DMI combination, since we don't have any company-specific pci devices on this board.
Signed-off-by: Ingo Feldschmid ifel@msc-ge.com
thanks for the rework!
Acked-by: Stefan Tauner stefan.tauner@student.tuwien.ac.at
Glad to see this merged. It's a good way to demonstrate how phase 2 in board matching should be used.
i have changed a few things additionally: most noteworthy i have changed the board enable to return 0 instead of 1. this is not checked atm, but if it ever will, then 0 will be the right choice. I have also added a debug print so that "DMI chassis-type is not specific enough." is followed by "Laptop detection overridden by P2 board enable." in verbose output.
Yes, that makes sense. Thanks for reworking and fine-tuning this patch!
Regards, Carl-Daniel