Re: [flashrom] [Flashrom] [PATCH] Separate Makefile's main OBJS list into Programmer, Chip, Lib, CLI object lists

[Carl-Daniel Hailfinger]

On 22.12.2009 20:32, Sean Nelson wrote:
> This patch shouldn't affect anything else in patchwork. It just splits
> $(OBJS) in Makefile into separate lists for Programmer, Chip, and CLI
> related files/objects. This should help later on figuring out where
> files may go for a libflashrom library.
>
> Signed-off-by: Sean Nelson
>
> commit 4df344c1a743a7d4ee633ce07706f3fb51f28074
> Author: Sean Nelson 
> Date:   Tue Dec 22 11:03:33 2009 -0800
> Modify Makfile to separate the main object list into Programmer, Chip, CLI lists.
> Signed-off-by: Sean Nelson <[e-mail]>

Maybe it is the fault of my mail client, but it seems your comment is
indented by 4 spaces.
> diff --git a/Makefile b/Makefile
> index 77731ed..4f4d870 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -43,11 +43,18 @@ endif
>
> LIBS += -lpci
>
> -OBJS = jedec.o stm50flw0x0x.o w39v080fa.o sharplhf00l04.o w29ee011.o \
> +CHIP_OBJS = jedec.o stm50flw0x0x.o w39v080fa.o sharplhf00l04.o w29ee011.o \
>    sst28sf040.o am29f040b.o mx29f002.o m29f400bt.o pm29f002.o w39v040c.o \
>    w49f002u.o 82802ab.o pm49fl00x.o sst49lf040.o en29f002a.o m29f002.o \
> sst49lfxxxc.o sst_fwhub.o flashchips.o layout.o spi.o \
> flashrom.o print.o physmap.o internal.o udelay.o
> sst49lfxxxc.o sst_fwhub.o spi.o
>
> +CLI_OBJS = flashrom.o print.o

Can you change print_wiki.o to be added to CLI_OBJS?
> +LIB_OBJS = flashchips.o layout.o physmap.o udelay.o

flashchips.o belongs to CHIP_OBJS.
physmap.o and udelay.o are PROGRAMMER_OBJS
> +PROGRAMMER_OBJS = internal.o
>
> +OBJS = $(CHIP_OBJS) $(CLI_OBJS) $(PROGRAMMER_OBJS) $(LIB_OBJS)
>
> all: pciutils features dep $(PROGRAM)

And can you please convert all the programmers to go to PROGRAMMER_OBJS
as well?
pcidev.o and serial.o are special. Not sure whether they are
PROGRAMMER_OBJS stuff or LIB_OBJS.

Thanks.

Regards,
Carl-Daniel