On 12/11/09 6:58 PM, Carl-Daniel Hailfinger wrote:
Awesome stuff. A must-have for 0.9.2. It touches a lot of code, so I'd like to merge it as the last patch before 0.9.2 to minimize conflicts.
Minor comments:
- MSG_NORMAL: Not 100% sure if this name is best (_INFO or _NOTICE or
_DEFAULT maybe).
- flashrom_print.c: Maybe rename it to flashrom_output.c and move stuff
like progress printing in there, but I'm open to leaving it as is.
- Conditional compilation: Should the code in flashrom_print.c be #ifdef
STANDALONE or somesuch?
- Makefile: Did you forget to hook up the new file in Makefile?
Regards, Carl-Daniel
Changed MSG_NORMAL to MSG_INFO. Renamed the new file to flashrom_output.c Hooked up the new file in Makefile.
If someone more experienced with va_list could help me; currently the output is all funky, please fix it. I really have no idea what I'm doing with the va_list code in print(). The Problem could be my macbook, but everything compiles just fine. As long as someone could fix my little bug and/or no one has a problem with my patch:
Signed-off-by: Sean Nelson audiohacked@gmail.com