On 03.07.2010 11:41, Michael Karcher wrote:
Am Freitag, den 02.07.2010, 21:36 +0200 schrieb Carl-Daniel Hailfinger:
OK, so we keep this as-is now. I still think that we can change even now how the variable is initialized. Current state is that the variable is initalized from the command line parser (which is client code). Even if it stays a global variable, I think we should have the client pass the pointer through programmer_init into the library than having it directly access global variables, but again, we don't have to beat this horse to death. I just want to make the point clear.
programmer_param is now a parameter of programmer_init. The variable is still global, though, but at least a frontend doesn't have to set it directly anymore.
Great. Each global variable removed fromthe frontend->backend interface is a win for libflashrom.
Patch looks fine now on skimming over it, I did intense review on the previous iterations.
Acked-by: Michael Karcher flashrom@mkarcher.dialup.fu-berlin.de
Thanks, committed in r1068.
Regards, Carl-Daniel