On Thu, 25 Aug 2011 14:56:56 +0200 Idwer Vollering vidwer@gmail.com wrote:
2011/8/20 Stefan Tauner stefan.tauner@student.tuwien.ac.at:
Telling the user to use "force_I_want_a_brick" if it is not even a laptop, is a bit over-the-top. Introduce a new laptop parameter "this_is_not_a_laptop" that allows to force operation, but only if the detection is not sure.
complicates the whole thing a bit. could do without the extra variable and new part of the if condition, if we allow the this_is_not_a_laptop parameter to always work, not only if the laptop detection is uncertain. it will be undocumented and only visible to the user together with the warning anyway...
I was curious whether the currently present overriding parameter works in combination with the parameter in this patch, and it does: $ sudo ./flashrom -V -p internal:laptop=force_I_want_a_brick -p internal:laptop=this_is_not_a_laptop flashrom v0.9.4-r1418 on FreeBSD 9.0-BETA1 (i386), built with libpci 3.1.7, GCC 4.2.2 20070831 prerelease [FreeBSD], little endian (etcetera)
Do you think this behaviour is desired?
the force_I_want_a_brick will override the other one (which is then neither used nor checked). i think that is ok... this is already way too sophisticated imho. :) but thanks for pointing it out, i have not thought about it yet. do you think this is a problem?