Re: [flashrom] [PATCH] Add programmer for the MSTAR I2C ISP protocol

[Alexandre Boeglin]

Hello,

Le lundi 05 mai 2014 à 01:10, Stefan Tauner a écrit:
> I did not carefully review the patch yet, just a few remarks:
> We need a proper sign-off from you to include the patch, see
> http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure
> I'd like to have at least a dedicated paragraph in the manpage that
> gives some background information, and some explanation regarding
> the dev syntax of course.
> The coding style does not completely follow ours, e.g. the braces
> after ifs should be on the same line.
> The progress print needs to go, I think. It has been decided long ago
> that we either do this right(tm) or not at all. flashrom should never
> go into infinite loops and it should also not be interrupted, hence a
> progress bar is only a placebo, he just have to be patient.

Here's a new version of the patch. I addressed your comments and added a
"noreset" option, aiming to prevent the display SoC from trying to read
a corrupted firmware.
I also added background information to the manpage, and fixed a leak (I
previously forgot to free the buffer I malloced).

Best regards,
Alex