Re: [flashrom] [Patch] Remove filename parameter from chip_safety_check()

[Stefan Reinauer]

* David Hendricks  [101015 03:03]:
> Seems like the filename parameter was left in by accident.
>
> This patch has only been compile tested.
>
> Signed-off-by: David Hendricks

Nice spotting!

Acked-by: Stefan Reinauer
>
> Index: flashrom-foo/flashrom.c
>
> --- flashrom-foo.orig/flashrom.c	2010-10-14 17:47:27.000000000 -0700
> +++ flashrom-foo/flashrom.c	2010-10-14 17:47:33.000000000 -0700
> @@ -1543,7 +1543,7 @@
>  /* FIXME: This function signature needs to be improved once doit() has a better
> function signature.
>
> */
> -int chip_safety_check(struct flashchip *flash, int force, char *filename, int read_it, int write_it, int erase_it, int verify_it)
> +int chip_safety_check(struct flashchip *flash, int force, int read_it, int write_it, int erase_it, int verify_it)
>  {
>    if (!programmer_may_write && (write_it || erase_it)) {
>    	msg_perr("Write/erase is not working yet on your programmer in "
> @@ -1606,7 +1606,7 @@
>    int ret = 0;
>    unsigned long size;
> if (chip_safety_check(flash, force, filename, read_it, write_it, erase_it, verify_it)) {
> if (chip_safety_check(flash, force, read_it, write_it, erase_it, verify_it)) {
> msg_cerr("Aborting.\n");
> programmer_shutdown();
> return 1;