Re: [flashrom] [PATCH] AMIC A25LxxPx

[Carl-Daniel Hailfinger]

Hi Daniel,

thanks a lot for your patch.

On 12.07.2010 22:46, Daniel Lenski wrote:
> This patch adds the following chips, all untested, based on the AMIC
> datasheets:
>    http://www.amictechnology.com/pdf/A25L20P.pdf covers:
>    	AMIC A25L05PT
>    	AMIC A25L05PU
>    	AMIC A25L10PT
>    	AMIC A25L10PU
>    	AMIC A25L20PT
>    	AMIC A25L20PU
>    http://www.amictechnology.com/pdf/A25L16P.pdf covers:
>    	AMIC A25L16PT
>    	AMIC A25L16PU
>
> In comments, it also clarifies the situation surrounding the A25L40PT
> and A25L40PU chips, which share the same RDID values, despite the fact
> that their erase block layouts are different.  Rudolf Marek tested and
> confirmed the distinct erase block layouts of these chips, so I also
> marked them as TEST_OK_PREW.
>
> Finally, it adds a pretty-printer for the AMIC SPI chips, and a generic
> AMIC chip type.
>
> Signed-off-by: Daniel Lenski

I have changed the whitespace in a few places, added the .unlock
function to the chip definitions and added the 0x60 chip erase command
to the A25L16P* family chips.

Acked-by: Carl-Daniel Hailfinger 
and committed in r1096.

Side note: If anyone is looking for the datasheet for the
not-yet-supported A25L032 family, here it is:
http://www.amictechnology.com/pdf/A25L032.pdf

Regards,
Carl-Daniel