Re: [flashrom] [PATCH] ICH SPI fixes/cleanup

[Carl-Daniel Hailfinger]

On 11.02.2010 05:31, David Hendricks wrote:
> On Thu, Dec 17, 2009 at 2:15 PM, Carl-Daniel Hailfinger <
> [e-mail]> wrote:
> > This megapatch rewrites substantial parts of ICH SPI to actually do what
> > the SPI layer wants instead of its own weird idea about commands
> > (running unrequested commands, running modified commands).
> > Besides that, there is a fair share of cleanups as well.
>
> I tested this out on an NM10-based reference board, which is based off the
> ICH7, so at least we can say it was tested :-)
>
> The patch also fixes a bad assumption about preopcodes (Carl-Daniel's third
> comment), so now it works with my SST25VF016B SPI flash chip.
>
> I'm not a committer, but for what it's worth:
> Acked-by: David Hendricks

Thanks for the review.
Committed in r894.

Regards,
Carl-Daniel