On Fri, 19 Oct 2012 02:03:05 +0200 Niklas Söderlund niso@kth.se wrote:
Propagate the error code using return values instead.
Signed-off-by: Niklas Söderlund niso@kth.se
Hi Niklas and thanks for your patch.
cli_classic.c | 3 +-- flash.h | 2 +- print.c | 14 +++++++++----- 3 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/cli_classic.c b/cli_classic.c index 4ae375c..7bcd4a6 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -363,8 +363,7 @@ int main(int argc, char *argv[]) #endif
if (list_supported) {
print_supported();
ret = 0;
goto out; }ret = print_supported();
cli_classic should continue to decide the exit value the flashrom process uses eventually, so i have changed the hunk above slightly.
Acked-by: Stefan Tauner stefan.tauner@student.tuwien.ac.at and committed in r1614.