On Tue, Jun 14, 2011 at 03:36:30PM +0200, Stefan Tauner wrote:
nicintel and nicintel_spi are far apart from each other in the list, which is probably ok because the list seems to be divided in non-spi and spi programmers (which maybe should be indicated somehow). it seems to be unsorted apart from that. later in the paragraph describing the pci= option the order is different. maybe we should introduce some consistent order?
Yeah, we could think about that, right now most lists (also in Makefile, etc) of programmers are mostly unsorted. But that should be a different patch. Not really high priority, though.
besides that i think your changes are ok.
can we merge this with the (somewhat hidden) manpage patch from andrew (http://patchwork.coreboot.org/patch/3109/)? i have attached a patch which has yours merged with andrew's with a small additional change (line 411), and i have added myself to the list of authors.
Looks good.
Acked-by: Uwe Hermann uwe@hermann-uwe.de
Uwe.