On Wed, 17 Apr 2013 12:01:01 +0200 Leonardo Guardati leonardo@guardati.it wrote:
On Sat, Apr 13, 2013 at 01:49:54AM +0200, Stefan Tauner wrote:
i'll post new patches in a minute (one corrected msr patch and an independent hwaccess.c patch that should fix netbsd hopefully and makes the defines more usable and sane and should be tested on openbsd too). i'd be very glad if you could test them on top of current HEAD again.
sorry for the delay, I've just checked out the last version of flashrom, then I applied your 2 patches:
- http://patchwork.coreboot.org/patch/3936/ (hwaccess.c)
- http://patchwork.coreboot.org/patch/3937/ (physmap.c)
There is only a wrong member name to fix on physmap.c (line 415) (the patch attached works with patch #3937 already applied)
I should definitely not code when tired without being able to compile test my nonsense. :) sorry!
After the fix the code works: I've tested the checksum of an already flashed image, then wrote another image and checked again the checksum.
Thank You.
Leonardo.
P.S. I confirm the OpenBSD msr probe failure is tinyBIOS related. When the bios is coreboot, the probe is successfull.
Ok, I'll wait for someone to check the NetBSD-related changes and commit the two patches then. Thanks a lot for testing - this kind of contribution is invaluable to us.