On Mon, Mar 7, 2011 at 4:39 PM, Carl-Daniel Hailfinger < c-d.hailfinger.devel.2006@gmx.net> wrote:
Auf 05.03.2011 21:56, Carl-Daniel Hailfinger schrieb:
Auf 04.03.2011 18:44, Carl-Daniel Hailfinger schrieb:
New version. I fixed a few return codes not to return an error in case no action was needed, and killed an exit(1).
flashrom currently only supports exactly one Super I/O or Embedded Controller, and this means quite a few notebooks and a small subset of desktop/server boards cannot be handled reliably and easily. Allow detection and initialization of up to 3 Super I/O and/or EC chips.
Please test with boards using
- IT8705 MEMW enable for parallel flash
- IT8712/IT8716/... SPI flash
- IT85* laptops (probably Cr-48)
This patch applies on top of [PATCH] IT85* cleanups/fixes .
Thanks to Thomas Schneider for testing on a board with IT87* SPI. Test report (success) is here: http://paste.flashrom.org/view.php?id=379
David, this patch should now apply cleanly against the vanilla flashrom tree. Could you please make a single run of latest svn with this patch on top with the following command: flashrom -V
The EC should be detected, but it should _not_ be activated. Automatic activation will happen once http://patchwork.coreboot.org/patch/2737/ (or an equivalent patch) is merged so we can handle whitelisted laptops safely.
This patch looks good. I patched it in and the resulting binary was able to detect the IT8500 on the Cr-48, but as you mentioned the it was not activated. Log attached.
And fwiw, Acked-by: David Hendricks dhendrix@google.com