On Tue, 24 May 2011 18:15:52 -0700 Stefan Reinauer stefan.reinauer@coreboot.org wrote:
- if (old& (5<< 1)) {
msg_pinfo("WARNING: BIOS region SMM protection is enabled!\n");
return -1;
You might still be successful doing the write, in case the SMM handler does not enforce the protection, so maybe you should just print a warning but not return here?
ok
also: 1<<5 of course! thanks joshua for reporting this