On 01.11.2010 23:30, Idwer Vollering wrote:
2010/11/1 David Hendricks wrote:
On Sat, Oct 30, 2010 at 12:43 AM, Paul Menzel wrote:
Am Samstag, den 30.10.2010, 02:16 +0200 schrieb Carl-Daniel Hailfinger:
Use mktemp unconditionally for security reasons. Avoid non-portable seq.
Signed-off-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Acked-by: Idwer Vollering vidwer@gmail.com
Thanks, committed in r1221.
--- flashrom-torturescript_portability/util/flashrom_partial_write_test.sh (Revision 1219) +++ flashrom-torturescript_portability/util/flashrom_partial_write_test.sh (Arbeitskopie) @@ -34,8 +34,12 @@ echo "testing flashrom binary: ${FLASHROM}"
OLDDIR=$(pwd) -if [ -z "$TMPDIR" ]; then
TMPDIR=$(mktemp -d) # test data location
+# test data location +TMPDIR=$(mktemp -d -t flashrom_test.XXXXXXXXXX) +if [ "$?" != "0" ] ; then
echo "Could not create temporary directory"
Full stop at the end.
I just checked the error message from mkdir and it doesn't have a full stop at the end either. IMHO consistency for the error message style is a good idea.
Is `mktemp` always installed? If not will there be an error message – passed down from Bash – indicating that it needs to be installed?
It is safe to assume it is.
Unless you're using some oddball shell on some old QNX version, sh will detect a missing mktemp and treat it like a failed mktemp.
Regards, Carl-Daniel