flashrom

flashrom@flashrom.org

5 participants
9161 discussions

[PATCH] Kill unneeded #include
by Carl-Daniel Hailfinger 22 Jun '10

22 Jun '10

Kill unneeded #include wherever possible. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: flashrom-include_cleanup/hwaccess.c =================================================================== --- flashrom-include_cleanup/hwaccess.c (Revision 1056) +++ flashrom-include_cleanup/hwaccess.c (Arbeitskopie) @@ -21,10 +21,12 @@ #include <stdint.h> #include <string.h> #include <stdlib.h> +#include <sys/types.h> +#if !defined (__DJGPP__) #include <unistd.h> #include <fcntl.h> -#include <sys/types.h> #include <errno.h> +#endif #include "flash.h" #if defined(__i386__) || defined(__x86_64__) @@ -42,12 +44,14 @@ void get_io_perms(void) { +#if defined(__DJGPP__) + /* We have full permissions by default. */ + return; +#else #if defined (__sun) && (defined(__i386) || defined(__amd64)) if (sysi86(SI86V86, V86SC_IOPL, PS_IOPL) != 0) { #elif defined(__FreeBSD__) || defined (__DragonFly__) if ((io_fd = open("/dev/io", O_RDWR)) < 0) { -#elif __DJGPP__ - if (0) { #else if (iopl(3) != 0) { #endif @@ -55,6 +59,7 @@ "You need to be root.\n", strerror(errno)); exit(1); } +#endif } void release_io_perms(void) Index: flashrom-include_cleanup/physmap.c =================================================================== --- flashrom-include_cleanup/physmap.c (Revision 1056) +++ flashrom-include_cleanup/physmap.c (Arbeitskopie) @@ -23,13 +23,17 @@ #include <unistd.h> #include <stdio.h> #include <sys/types.h> -#include <sys/stat.h> -#include <fcntl.h> #include <stdlib.h> #include <string.h> -#include <errno.h> #include "flash.h" +/* Do we need any file access or ioctl for physmap or MSR? */ +#if !defined(__DJGPP__) +#include <sys/stat.h> +#include <fcntl.h> +#include <errno.h> +#endif + #ifdef __DJGPP__ #include <dpmi.h> #include <sys/nearptr.h> Index: flashrom-include_cleanup/chipset_enable.c =================================================================== --- flashrom-include_cleanup/chipset_enable.c (Revision 1056) +++ flashrom-include_cleanup/chipset_enable.c (Arbeitskopie) @@ -27,12 +27,10 @@ #define _LARGEFILE64_SOURCE -#include <unistd.h> #include <stdlib.h> #include <string.h> #include <sys/types.h> -#include <sys/stat.h> -#include <fcntl.h> +#include <unistd.h> #include "flash.h" #if defined(__i386__) || defined(__x86_64__) Index: flashrom-include_cleanup/internal.c =================================================================== --- flashrom-include_cleanup/internal.c (Revision 1056) +++ flashrom-include_cleanup/internal.c (Arbeitskopie) @@ -21,10 +21,7 @@ #include <stdint.h> #include <string.h> #include <stdlib.h> -#include <fcntl.h> #include <sys/types.h> -#include <sys/stat.h> -#include <errno.h> #include "flash.h" #if NEED_PCI == 1 -- http://www.hailfinger.org/

2 2

[commit] r1057 - trunk
by repository service 22 Jun '10

22 Jun '10

Author: hailfinger Date: Tue Jun 22 01:20:15 2010 New Revision: 1057 URL: http://flashrom.org/trac/coreboot/changeset/1057 Log: Kill unneeded #include wherever possible. Tested on Linux, FreeBSD, NetBSD, OpenBSD, DOS. Thanks to Jonathan A. Kollasch and Idwer Vollering for testing. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Idwer Vollering <vidwer+lists.flashrom(a)gmail.com> Modified: trunk/chipset_enable.c trunk/hwaccess.c trunk/internal.c trunk/physmap.c Modified: trunk/chipset_enable.c ============================================================================== --- trunk/chipset_enable.c Mon Jun 21 18:12:22 2010 (r1056) +++ trunk/chipset_enable.c Tue Jun 22 01:20:15 2010 (r1057) @@ -27,12 +27,10 @@ #define _LARGEFILE64_SOURCE -#include <unistd.h> #include <stdlib.h> #include <string.h> #include <sys/types.h> -#include <sys/stat.h> -#include <fcntl.h> +#include <unistd.h> #include "flash.h" #if defined(__i386__) || defined(__x86_64__) Modified: trunk/hwaccess.c ============================================================================== --- trunk/hwaccess.c Mon Jun 21 18:12:22 2010 (r1056) +++ trunk/hwaccess.c Tue Jun 22 01:20:15 2010 (r1057) @@ -21,10 +21,12 @@ #include <stdint.h> #include <string.h> #include <stdlib.h> +#include <sys/types.h> +#if !defined (__DJGPP__) #include <unistd.h> #include <fcntl.h> -#include <sys/types.h> #include <errno.h> +#endif #include "flash.h" #if defined(__i386__) || defined(__x86_64__) @@ -42,12 +44,14 @@ void get_io_perms(void) { +#if defined(__DJGPP__) + /* We have full permissions by default. */ + return; +#else #if defined (__sun) && (defined(__i386) || defined(__amd64)) if (sysi86(SI86V86, V86SC_IOPL, PS_IOPL) != 0) { #elif defined(__FreeBSD__) || defined (__DragonFly__) if ((io_fd = open("/dev/io", O_RDWR)) < 0) { -#elif __DJGPP__ - if (0) { #else if (iopl(3) != 0) { #endif @@ -55,6 +59,7 @@ "You need to be root.\n", strerror(errno)); exit(1); } +#endif } void release_io_perms(void) Modified: trunk/internal.c ============================================================================== --- trunk/internal.c Mon Jun 21 18:12:22 2010 (r1056) +++ trunk/internal.c Tue Jun 22 01:20:15 2010 (r1057) @@ -21,10 +21,7 @@ #include <stdint.h> #include <string.h> #include <stdlib.h> -#include <fcntl.h> #include <sys/types.h> -#include <sys/stat.h> -#include <errno.h> #include "flash.h" #if NEED_PCI == 1 Modified: trunk/physmap.c ============================================================================== --- trunk/physmap.c Mon Jun 21 18:12:22 2010 (r1056) +++ trunk/physmap.c Tue Jun 22 01:20:15 2010 (r1057) @@ -23,13 +23,17 @@ #include <unistd.h> #include <stdio.h> #include <sys/types.h> -#include <sys/stat.h> -#include <fcntl.h> #include <stdlib.h> #include <string.h> -#include <errno.h> #include "flash.h" +/* Do we need any file access or ioctl for physmap or MSR? */ +#if !defined(__DJGPP__) +#include <sys/stat.h> +#include <fcntl.h> +#include <errno.h> +#endif + #ifdef __DJGPP__ #include <dpmi.h> #include <sys/nearptr.h>

1 0

Support for HY29F002TC-90 rom
by David Borg 21 Jun '10

21 Jun '10

Hey all, I have the HY29F002TC-90 ( http://www.alldatasheet.com/datasheet-pdf/pdf/82789/HYNIX/HY29F002TC-90.html) rom on a Gigabyte motherboard (GA-6VX7-4X) but flashrom is not detecting it. What can I do to have it recognized and enable reading and re-flashing? Output of flashrom -V is attached (flashrom.txt). Thanks, David

3 8

[commit] r1056 - trunk
by repository service 21 Jun '10

21 Jun '10

Author: hailfinger Date: Mon Jun 21 18:12:22 2010 New Revision: 1056 URL: http://flashrom.org/trac/coreboot/changeset/1056 Log: Add support for Hyundai HY29F002 and HY29F002B. Signed-off-by: David Borg <borg.db(a)gmail.com> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/flashchips.c trunk/flashchips.h Modified: trunk/flashchips.c ============================================================================== --- trunk/flashchips.c Sun Jun 20 13:04:26 2010 (r1055) +++ trunk/flashchips.c Mon Jun 21 18:12:22 2010 (r1056) @@ -2363,6 +2363,68 @@ }, { + .vendor = "Hyundai", + .name = "HY29F002T", + .bustype = CHIP_BUSTYPE_PARALLEL, + .manufacture_id = HYUNDAI_ID, + .model_id = HY_29F002T, + .total_size = 256, + .page_size = 256 * 1024, + .feature_bits = FEATURE_EITHER_RESET, /* Some revisions may need FEATURE_ADDR_2AA */ + .tested = TEST_OK_PREW, + .probe = probe_jedec, + .probe_timing = TIMING_ZERO, /* Datasheet has no timing info specified */ + .block_erasers = + { + { + .eraseblocks = { + {64 * 1024, 3}, + {32 * 1024, 1}, + {8 * 1024, 2}, + {16 * 1024, 1}, + }, + .block_erase = erase_sector_jedec, + }, { + .eraseblocks = { {256 * 1024, 1} }, + .block_erase = erase_chip_block_jedec, + }, + }, + .write = write_jedec_1, + .read = read_memmapped, + }, + + { + .vendor = "Hyundai", + .name = "HY29F002B", + .bustype = CHIP_BUSTYPE_PARALLEL, + .manufacture_id = HYUNDAI_ID, + .model_id = HY_29F002B, + .total_size = 256, + .page_size = 256 * 1024, + .feature_bits = FEATURE_EITHER_RESET, /* Some revisions may need FEATURE_ADDR_2AA */ + .tested = TEST_UNTESTED, + .probe = probe_jedec, + .probe_timing = TIMING_ZERO, /* Datasheet has no timing info specified */ + .block_erasers = + { + { + .eraseblocks = { + {16 * 1024, 1}, + {8 * 1024, 2}, + {32 * 1024, 1}, + {64 * 1024, 3}, + }, + .block_erase = erase_sector_jedec, + }, { + .eraseblocks = { {256 * 1024, 1} }, + .block_erase = erase_chip_block_jedec, + }, + }, + .write = write_jedec_1, + .read = read_memmapped, + }, + + { .vendor = "Intel", .name = "28F001BX-B", .bustype = CHIP_BUSTYPE_PARALLEL, Modified: trunk/flashchips.h ============================================================================== --- trunk/flashchips.h Sun Jun 20 13:04:26 2010 (r1055) +++ trunk/flashchips.h Mon Jun 21 18:12:22 2010 (r1056) @@ -242,7 +242,8 @@ #define HY_29LV800B 0x5B #define HY_29F040A 0xA4 #define HY_29F400B 0xAB /* Same as HY_29F400AB */ -#define HY_29F002 0xB0 +#define HY_29F002B 0x34 +#define HY_29F002T 0xB0 #define HY_29LV400T 0xB9 #define HY_29LV400B 0xBA #define HY_29F080 0xD5

1 0

probe for SST20EE010 fails
by Guenter 21 Jun '10

21 Jun '10

Hi, I've a chip which is from SST and labeled as PH29EE010 150-3CF. flashrom doesnt detect this chip although it should as -L stats: flashrom -L | grep 29EE010 SST SST29EE010 P R W 128 Parallel if I check for the chip it still fails and reads flash content: flashrom -V -c SST29EE010 flashrom v0.9.2-r1039 on Linux 2.6.27-3 (i586), built with libpci 2.2.4-pre4, GCC 4.1.2 20061115 (prerelease) (Debian 4.1.1-21), little endian flashrom is free software, get the source code at http://www.flashrom.org Calibrating delay loop... OS timer resolution is 9 usecs, 200M loops per second, 10 myus = 17 us, 100 myus = 231 us, 1000 myus = 1042 us, 10000 myus = 10133 us, 36 myus = 45 us, OK. Initializing internal programmer No coreboot table found. DMI string system-manufacturer: "System Manufacturer" DMI string system-product-name: "System Name" DMI string system-version: "System Version" DMI string baseboard-manufacturer: "ASUSTeK Computer INC." DMI string baseboard-product-name: "P5A-B" DMI string baseboard-version: "REV 1.XX" DMI string chassis-type: "Unknown" Found chipset "ALi M1533", enabling flash write... chipset PCI ID is 10b9:1533, OK. This chipset supports the following protocols: Non-SPI. Probing for SST SST29EE010, 128 KB: probe_jedec_common: id1 0x25, id2 0xfb, id1 is normal flash content, id2 is normal flash content No EEPROM/flash device found. Note: flashrom can never write if the flash chip isn't found automatically. but if I now probe for Winbond W29C011 then flashrom of course fails but shows the right flash ID: flashrom -V -c W29EE011 flashrom v0.9.2-r1039 on Linux 2.6.27-3 (i586), built with libpci 2.2.4-pre4, GCC 4.1.2 20061115 (prerelease) (Debian 4.1.1-21), little endian flashrom is free software, get the source code at http://www.flashrom.org Calibrating delay loop... OS timer resolution is 8 usecs, 29M loops per second, delay more than 10% too short (got 24% of expected delay), recalculating... 32M loops per second, delay more than 10% too short (got 25% of expected delay), recalculating... 34M loops per second, delay more than 10% too short (got 27% of expected delay), recalculating... 33M loops per second, delay more than 10% too short (got 25% of expected delay), recalculating... 32M loops per second, delay loop is unreliable, trying to continue 10 myus = 11 us, 100 myus = 24 us, 1000 myus = 285 us, 10000 myus = 1605 us, 32 myus = 14 us, OK. Initializing internal programmer No coreboot table found. DMI string system-manufacturer: "System Manufacturer" DMI string system-product-name: "System Name" DMI string system-version: "System Version" DMI string baseboard-manufacturer: "ASUSTeK Computer INC." DMI string baseboard-product-name: "P5A-B" DMI string baseboard-version: "REV 1.XX" DMI string chassis-type: "Unknown" Found chipset "ALi M1533", enabling flash write... chipset PCI ID is 10b9:1533, OK. This chipset supports the following protocols: Non-SPI. Probing for Winbond W29EE011, 128 KB: probe_w29ee011: id1 0xbf, id2 0x07 No EEPROM/flash device found. Note: flashrom can never write if the flash chip isn't found automatically. so what is obvious is the huge difference with the calibrating loop, and then that the probe for W29EE011 gives "id1 0xbf, id2 0x07" which is exactly what the datasheet from SST outlines for the SST29EE010 ... I really wonder what goes on there sine - as -L shows - this chip is marked as "P R W" ... Gün.

2 2

flashrom -V
by Jim Lunsford 20 Jun '10

20 Jun '10

my first flashrom -V is attached as document jim lunsford do you want others?

1 0

[PATCH] Fill in buses_supported for remaining Intel chipsets
by Carl-Daniel Hailfinger 20 Jun '10

20 Jun '10

Fill in buses_supported for remaining Intel chipsets (ICH0-ICH5, Poulsbo). Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: flashrom-ich_bustype/chipset_enable.c =================================================================== --- flashrom-ich_bustype/chipset_enable.c (revision 1033) +++ flashrom-ich_bustype/chipset_enable.c (working copy) @@ -286,6 +286,7 @@ * FWH_DEC_EN1, but they are called FB_SEL1, FB_SEL2, FB_DEC_EN1 and * FB_DEC_EN2. */ + buses_supported = CHIP_BUSTYPE_FWH; return enable_flash_ich(dev, name, 0x4e); } @@ -399,6 +400,7 @@ if (new != old) pci_write_byte(dev, 0xd9, new); + buses_supported = CHIP_BUSTYPE_FWH; return 0; } -- http://www.hailfinger.org/

2 2

[commit] r1055 - trunk
by repository service 20 Jun '10

20 Jun '10

Author: hailfinger Date: Sun Jun 20 13:04:26 2010 New Revision: 1055 URL: http://flashrom.org/trac/coreboot/changeset/1055 Log: Fill in buses_supported for remaining Intel chipsets (ICH0-ICH5, Poulsbo). Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Sean Nelson <audiohacked(a)gmail.com> Modified: trunk/chipset_enable.c Modified: trunk/chipset_enable.c ============================================================================== --- trunk/chipset_enable.c Sun Jun 20 13:02:33 2010 (r1054) +++ trunk/chipset_enable.c Sun Jun 20 13:04:26 2010 (r1055) @@ -288,6 +288,7 @@ * FWH_DEC_EN1, but they are called FB_SEL1, FB_SEL2, FB_DEC_EN1 and * FB_DEC_EN2. */ + buses_supported = CHIP_BUSTYPE_FWH; return enable_flash_ich(dev, name, 0x4e); } @@ -401,6 +402,7 @@ if (new != old) pci_write_byte(dev, 0xd9, new); + buses_supported = CHIP_BUSTYPE_FWH; return 0; }

1 0

[PATCH] Kill fake SPI D8 chip erase
by Carl-Daniel Hailfinger 20 Jun '10

20 Jun '10

The SPI opcode 0xd8 is not a chip erase opcode on any chip out there. Besides that, the function as implemented just walks the chip and ignores sector sizes. Sector erase with SPI opcode 0xd8 is of course still supported. Kill a declaration for a nonexisting function while we're at it. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: flashrom-kill_fake_spi_chip_erase_d8/spi25.c =================================================================== --- flashrom-kill_fake_spi_chip_erase_d8/spi25.c (Revision 1028) +++ flashrom-kill_fake_spi_chip_erase_d8/spi25.c (Arbeitskopie) @@ -652,29 +652,6 @@ return 0; } -int spi_chip_erase_d8(struct flashchip *flash) -{ - int i, rc = 0; - int total_size = flash->total_size * 1024; - int erase_size = 64 * 1024; - - spi_disable_blockprotect(); - - msg_cinfo("Erasing chip: \n"); - - for (i = 0; i < total_size / erase_size; i++) { - rc = spi_block_erase_d8(flash, i * erase_size, erase_size); - if (rc) { - msg_cerr("Error erasing block at 0x%x\n", i); - break; - } - } - - msg_cinfo("\n"); - - return rc; -} - /* Sector size is usually 4k, though Macronix eliteflash has 64k */ int spi_block_erase_20(struct flashchip *flash, unsigned int addr, unsigned int blocklen) { Index: flashrom-kill_fake_spi_chip_erase_d8/chipdrivers.h =================================================================== --- flashrom-kill_fake_spi_chip_erase_d8/chipdrivers.h (Revision 1028) +++ flashrom-kill_fake_spi_chip_erase_d8/chipdrivers.h (Arbeitskopie) @@ -35,8 +35,6 @@ int spi_write_disable(void); int spi_chip_erase_60(struct flashchip *flash); int spi_chip_erase_c7(struct flashchip *flash); -int spi_chip_erase_60_c7(struct flashchip *flash); -int spi_chip_erase_d8(struct flashchip *flash); int spi_block_erase_20(struct flashchip *flash, unsigned int addr, unsigned int blocklen); int spi_block_erase_52(struct flashchip *flash, unsigned int addr, unsigned int blocklen); int spi_block_erase_d7(struct flashchip *flash, unsigned int addr, unsigned int blocklen); -- http://www.hailfinger.org/

2 2

[commit] r1054 - trunk
by repository service 20 Jun '10

20 Jun '10

Author: hailfinger Date: Sun Jun 20 13:02:33 2010 New Revision: 1054 URL: http://flashrom.org/trac/coreboot/changeset/1054 Log: The SPI opcode 0xd8 is not a chip erase opcode on any chip out there. Besides that, the function as implemented just walks the chip and ignores sector sizes. Sector erase with SPI opcode 0xd8 is of course still supported. Kill a declaration for a nonexisting function while we're at it. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Sean Nelson <audiohacked(a)gmail.com> Modified: trunk/chipdrivers.h trunk/spi25.c Modified: trunk/chipdrivers.h ============================================================================== --- trunk/chipdrivers.h Sun Jun 20 12:58:32 2010 (r1053) +++ trunk/chipdrivers.h Sun Jun 20 13:02:33 2010 (r1054) @@ -35,8 +35,6 @@ int spi_write_disable(void); int spi_chip_erase_60(struct flashchip *flash); int spi_chip_erase_c7(struct flashchip *flash); -int spi_chip_erase_60_c7(struct flashchip *flash); -int spi_chip_erase_d8(struct flashchip *flash); int spi_block_erase_20(struct flashchip *flash, unsigned int addr, unsigned int blocklen); int spi_block_erase_52(struct flashchip *flash, unsigned int addr, unsigned int blocklen); int spi_block_erase_d7(struct flashchip *flash, unsigned int addr, unsigned int blocklen); Modified: trunk/spi25.c ============================================================================== --- trunk/spi25.c Sun Jun 20 12:58:32 2010 (r1053) +++ trunk/spi25.c Sun Jun 20 13:02:33 2010 (r1054) @@ -646,29 +646,6 @@ return 0; } -int spi_chip_erase_d8(struct flashchip *flash) -{ - int i, rc = 0; - int total_size = flash->total_size * 1024; - int erase_size = 64 * 1024; - - spi_disable_blockprotect(); - - msg_cinfo("Erasing chip: \n"); - - for (i = 0; i < total_size / erase_size; i++) { - rc = spi_block_erase_d8(flash, i * erase_size, erase_size); - if (rc) { - msg_cerr("Error erasing block at 0x%x\n", i); - break; - } - } - - msg_cinfo("\n"); - - return rc; -} - /* Sector size is usually 4k, though Macronix eliteflash has 64k */ int spi_block_erase_20(struct flashchip *flash, unsigned int addr, unsigned int blocklen) {

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom