flashrom

flashrom@flashrom.org

9164 discussions

[commit] r1604 - trunk
by repository service 23 Sep '12

23 Sep '12

Author: stefanct Date: Sun Sep 23 14:14:28 2012 New Revision: 1604 URL: http://flashrom.org/trac/flashrom/changeset/1604 Log: Fix memleaks in dmi.c. In dmi_init() we populate static char *dmistrings[] with values that get later compared in dmi_match(). Those strings are actually strduped in get_dmi_string() and hence need to be freed later. This patch accomplishes this by registering another shutdown method. Also, the tangling pointers are nulled when the memories are freed. This bug was found thanks to valgrind. Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/dmi.c Modified: trunk/dmi.c ============================================================================== --- trunk/dmi.c Sun Sep 23 00:56:09 2012 (r1603) +++ trunk/dmi.c Sun Sep 23 14:14:28 2012 (r1604) @@ -144,16 +144,29 @@ result = strdup(answerbuf); if (!result) - puts("WARNING: Out of memory - DMI support fails"); + msg_perr("WARNING: Out of memory - DMI support fails"); return result; } +static int dmi_shutdown(void *data) +{ + int i; + for (i = 0; i < ARRAY_SIZE(dmistrings); i++) { + free(dmistrings[i]); + dmistrings[i] = NULL; + } + return 0; +} + void dmi_init(void) { int i; char *chassis_type; + if (register_shutdown(dmi_shutdown, NULL)) + return; + has_dmi_support = 1; for (i = 0; i < ARRAY_SIZE(dmidecode_names); i++) { dmistrings[i] = get_dmi_string(dmidecode_names[i]);

1 0

2 flashes on SPI bus
by Andrei Dolnikov 23 Sep '12

23 Sep '12

Hello folks, I would like to use a flashrom utility to access 2 serial flashes on the SPI bus of my x86 board, but I'm struggling with the second one. So I'm looking for any help, hints or advices which can help me to solve this issue. I have custom x86 board (Atom n450 CPU, ICH8M chipset) which have 2 serial flashes installed on it. The first one is SST25VF016B and the second one is Numonyx M45PE16. The M45PE16 is pretty the similar to the M25PE16. Both this chips are connected to the SPI bus of the ICH8M chipset, the CS (chip select) signal of the SST25VF is routed to the SPI_CS0 and the CS signal of the M45PE16 is routed to the SPI_CS1. I can successfully read, erase and write the SST flash. Trying to figure out if flashrom utility can find the second Numonyx flash I've added the proper description for it to the flashchips.c (actually I've leaved it the same as for M25PE16 but changed model_id field). Unfortunately it didn't help me at all. So I'm wondering if flashrom can't find M45PE16 flash because of cleared SPI_CS1 signal and how can I enable it? Does flashrom utility support such kind of configurations or does it simply searching for the flash on CS0? Probably some of you have some ideas on enabling SPI_CS1 or even some useful links etc. Unfortunately the official Intel ICH8M documentation looks kind of complicated and no so clear to me. I'll of course digg into it but any help, hints or advices are highly appreciated! Thanks in advance, xborodax.

2 1

Re: [flashrom] [PATCH 3/3] Fix memleak in the dummyflasher.
by Carl-Daniel Hailfinger 23 Sep '12

23 Sep '12

Am 14.09.2012 00:38 schrieb Stefan Tauner: > emu_persistent_image was not freed correctly. > > This bug was found thanks to valgrind. > > Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Good find! Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Regards, Carl-Daniel -- http://www.hailfinger.org/

2 1

[commit] r1603 - trunk
by repository service 23 Sep '12

23 Sep '12

Author: stefanct Date: Sun Sep 23 00:56:09 2012 New Revision: 1603 URL: http://flashrom.org/trac/flashrom/changeset/1603 Log: Fix a memleak in the dummyflasher. emu_persistent_image was not freed correctly. This bug was found thanks to valgrind. Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/dummyflasher.c Modified: trunk/dummyflasher.c ============================================================================== --- trunk/dummyflasher.c Sat Sep 22 03:38:06 2012 (r1602) +++ trunk/dummyflasher.c Sun Sep 23 00:56:09 2012 (r1603) @@ -150,8 +150,9 @@ if (emu_chip != EMULATE_NONE) { if (emu_persistent_image) { msg_pdbg("Writing %s\n", emu_persistent_image); - write_buf_to_file(flashchip_contents, emu_chip_size, - emu_persistent_image); + write_buf_to_file(flashchip_contents, emu_chip_size, emu_persistent_image); + free(emu_persistent_image); + emu_persistent_image = NULL; } free(flashchip_contents); }

1 0

Re: [flashrom] flashrom problem
by Idwer Vollering 23 Sep '12

23 Sep '12

2012/9/22 Jonas Peres <jones.strat(a)gmail.com>: > My bios is unknow state before flashing with flashbios > Please help Don't restart your computer. No hacer reinicie su ordenador. > > Best regards > Jonas Peres > > _______________________________________________ > flashrom mailing list > flashrom(a)flashrom.org > http://www.flashrom.org/mailman/listinfo/flashrom

1 0

Re: [flashrom] Flashrom problem
by Stefan Tauner 23 Sep '12

23 Sep '12

On Sat, 22 Sep 2012 22:43:25 +0100 Jonas Peres <jones.strat(a)gmail.com> wrote: > Sorry, forgot to send report from flashrom > There he goes. > Sorry about my inglish. > > Regards > Jonas Peres hello jonas, your log was not really complete. if you still have the output of the failing write operation, please resend it. you are using a very, very old version of flashrom, it would be a very good idea to update. first of all you should verify that the bios contents are still valid. did you make a backup of the old chip content? if so, then please use flashrom -v "backup file" to verify it is still there. it would be best if you could join us on IRC so that we can help you faster and better. you can do so in a web browser: http://webchat.freenode.net/?channels=flashrom&uio=d4 -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

Re: [flashrom] Flashrom problem
by Idwer Vollering 23 Sep '12

23 Sep '12

2012/9/22 Jonas Peres <jones.strat(a)gmail.com>: > Sorry, forgot to send report from flashrom > There he goes. > Sorry about my inglish. > > Regards > Jonas Peres The version of flashrom you have installed (v0.9.1) is really old, we recommend to use the latest stable release or compile from subversion code: http://www.flashrom.org/Downloads#Installation_from_source Furthermore, the output you sent is incomplete (or flashrom aborted/segfaulted). Idwer

1 0

Flashrom problem
by Jonas Peres 23 Sep '12

23 Sep '12

Sorry, forgot to send report from flashrom There he goes. Sorry about my inglish. Regards Jonas Peres

1 0

flashrom problem
by Jonas Peres 23 Sep '12

23 Sep '12

My bios is unknow state before flashing with flashbios Please help Best regards Jonas Peres

1 0

[commit] r1602 - trunk
by repository service 22 Sep '12

22 Sep '12

Author: stefanct Date: Sat Sep 22 03:38:06 2012 New Revision: 1602 URL: http://flashrom.org/trac/flashrom/changeset/1602 Log: Generify a25.c's SRWD printing function and move it to spi25.c. Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Acked-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Modified: trunk/a25.c trunk/chipdrivers.h trunk/spi25.c Modified: trunk/a25.c ============================================================================== --- trunk/a25.c Fri Sep 21 14:52:50 2012 (r1601) +++ trunk/a25.c Sat Sep 22 03:38:06 2012 (r1602) @@ -23,12 +23,6 @@ /* Prettyprint the status register. Works for AMIC A25L series. */ -static void spi_prettyprint_status_register_amic_a25_srwd(uint8_t status) -{ - msg_cdbg("Chip status register: Status Register Write Disable " - "(SRWD) is %sset\n", (status & (1 << 7)) ? "" : "not "); -} - int spi_prettyprint_status_register_amic_a25l05p(struct flashctx *flash) { uint8_t status; @@ -36,7 +30,7 @@ status = spi_read_status_register(flash); msg_cdbg("Chip status register is %02x\n", status); - spi_prettyprint_status_register_amic_a25_srwd(status); + spi_prettyprint_status_register_srwd(status); spi_prettyprint_status_register_bit(status, 6); spi_prettyprint_status_register_bit(status, 5); spi_prettyprint_status_register_bit(status, 4); @@ -52,7 +46,7 @@ status = spi_read_status_register(flash); msg_cdbg("Chip status register is %02x\n", status); - spi_prettyprint_status_register_amic_a25_srwd(status); + spi_prettyprint_status_register_srwd(status); spi_prettyprint_status_register_bit(status, 6); spi_prettyprint_status_register_bit(status, 5); spi_prettyprint_status_register_bp(status, 2); @@ -67,7 +61,7 @@ status = spi_read_status_register(flash); msg_cdbg("Chip status register is %02x\n", status); - spi_prettyprint_status_register_amic_a25_srwd(status); + spi_prettyprint_status_register_srwd(status); msg_cdbg("Chip status register: Sector Protect Size (SEC) " "is %i KB\n", (status & (1 << 6)) ? 4 : 64); msg_cdbg("Chip status register: Top/Bottom (TB) " @@ -85,7 +79,7 @@ status = spi_read_status_register(flash); msg_cdbg("Chip status register is %02x\n", status); - spi_prettyprint_status_register_amic_a25_srwd(status); + spi_prettyprint_status_register_srwd(status); msg_cdbg("Chip status register: Sector Protect Size (SEC) " "is %i KB\n", (status & (1 << 6)) ? 4 : 64); msg_cdbg("Chip status register: Top/Bottom (TB) " Modified: trunk/chipdrivers.h ============================================================================== --- trunk/chipdrivers.h Fri Sep 21 14:52:50 2012 (r1601) +++ trunk/chipdrivers.h Sat Sep 22 03:38:06 2012 (r1602) @@ -53,6 +53,7 @@ int spi_write_status_register(struct flashctx *flash, int status); void spi_prettyprint_status_register_bit(uint8_t status, int bit); void spi_prettyprint_status_register_bp(uint8_t status, int bp); +void spi_prettyprint_status_register_srwd(uint8_t status); void spi_prettyprint_status_register_welwip(uint8_t status); int spi_prettyprint_status_register(struct flashctx *flash); int spi_disable_blockprotect(struct flashctx *flash); Modified: trunk/spi25.c ============================================================================== --- trunk/spi25.c Fri Sep 21 14:52:50 2012 (r1601) +++ trunk/spi25.c Sat Sep 22 03:38:06 2012 (r1602) @@ -315,7 +315,13 @@ return readarr[0]; } -/* Prettyprint the status register. Common definitions. */ +/* Common highest bit: Status Register Write Disable (SRWD). */ +void spi_prettyprint_status_register_srwd(uint8_t status) +{ + msg_cdbg("Chip status register: Status Register Write Disable (SRWD) is %sset\n", + (status & (1 << 7)) ? "" : "not "); +} + void spi_prettyprint_status_register_welwip(uint8_t status) { msg_cdbg("Chip status register: Write Enable Latch (WEL) is " @@ -366,10 +372,8 @@ */ void spi_prettyprint_status_register_st_m25p(uint8_t status) { - msg_cdbg("Chip status register: Status Register Write Disable " - "(SRWD) is %sset\n", (status & (1 << 7)) ? "" : "not "); - msg_cdbg("Chip status register: Bit 6 is " - "%sset\n", (status & (1 << 6)) ? "" : "not "); + spi_prettyprint_status_register_srwd(status); + spi_prettyprint_status_register_bit(status, 6); spi_prettyprint_status_register_common(status); }

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom