flashrom

flashrom@flashrom.org

9164 discussions

Re: [flashrom] flashrom OPCODES for SPI
by Stefan Tauner 13 Dec '12

13 Dec '12

On Wed, 12 Dec 2012 11:13:49 +0400 Николай Николаев <evrinoma(a)gmail.com> wrote: > i'm trying to reprogram spi chip with bios. My sdk-board is consist from > motherboard and especial board. Motherboard has own flash bios chip like a > mx25l6405 and chip SPI interface QM67. Especial board has a spi flash chip > sst25vf016. Used jumpers i'm easy select flash bios chip for programming, > and i select chip sst25vf016. Chip set QM67 is locked to change value > registers opcodes and preop codes. This is codes value match with mx25l6405 > codes. And i can't reprogram selected chip, because opcodes select chip > didn't match with opcodes stored in QM67. > In function > spi_write_status_register Flashrom source code algorithm trying change mode > spi status register to write by sending unlock command JEDEC_WRSR and > JEDEC_EWSR = 0x50. But preop codes register have a value JEDEC_WREN=0x06, > and don't have a value JEDEC_EWSR=0x50. And STATUS register can't be > unlocked, if i change value JEDEC_EWSR on 0x06 (chip sst25vf016 support > this code) the STATUS register is unlock successful. Hi, I don't have a complete SST25VF016 datasheet. In the SST25VF080 datasheet WREN is mentioned but not in relation to WRSR but only "normal" erase/write functions. The SST25VF016B datasheet however clearly states: "The WREN instruction may also be used to allow execution of the Write-Status-Register (WRSR) instruction" It is of course possible that both, the SST25VF080 and the SST25VF016, support WREN for WRSR and your report is a good hint that this is true. Can you confirm that you have the SST25VF016 and not some variation like the SST25VF016B? The "right" way to add support for you would have been to change the chip definition of the SST25VF016B in flashchips.c by swapping FEATURE_WRSR_EWSR for FEATURE_WRSR_EITHER. As you saw in spi_write_status_register, using WREN is the default if both are supported (or none is selected). I have done so in my local branch for the 016 and 80(A) chips and will commit that later. > And now we have a read > and erase function but function write doesn't work, because algorithm use > default_spi_write_aai function. That function use opcode > JEDEC_AAI_WORD_PROGRAMM but opcodes and preopcodes registers doesn't have > this code and we can't write new bios image in flash. But if we will be use > function spi_chip_write_1 we successful write our image into flash chip > sst25vf016. Good. > What you think about, if we exclude some parameters from structure FLASHCTX > (like a feature_bits) and add array of OPCODES (with real opcodes for real > chip) and add function to detect access opcodes for used chips? There is nothing wrong with the feature bits, although the chipset code (in your case ichspi.c) could be more intelligent in handling this (ATM the write enable commands are handled by generic code only). The Intel chipsets are very special and your case even more, so I don't want to introduce complicated changes just because of this (also with the fix i mentioned earlier, it should just work now even on your configuration, feel free to disprove me). The write command/opcode is different. Clearly we want to have something similar to the erasers so that we can have multiple write functions/opcodes per flash chip. This is on my TODO list, but I don't have much time to work on it... -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

W836xx: SuperMicro X8DTU-F: flashrom -V
by Scott Silverman 12 Dec '12

12 Dec '12

# ./flashrom --programmer internal -V flashrom v0.9.6.1-r1564 on Linux 2.6.29.6-sxtickless (x86_64) flashrom is free software, get the source code at http://www.flashrom.org flashrom was built with libpci 2.2.3, GCC 4.1.2 20080704 (Red Hat 4.1.2-48), little endian Command line (3 args): ./flashrom --programmer internal -V Calibrating delay loop... OS timer resolution is 1 usecs, 1466M loops per second, 10 myus = 10 us, 100 myus = 100 us, 1000 myus = 1001 us, 10000 myus = 10012 us, 4 myus = 4 us, OK. Initializing internal programmer No coreboot table found. DMI string system-manufacturer: "Supermicro" DMI string system-product-name: "X8DTU" DMI string system-version: "1234567890" DMI string baseboard-manufacturer: "Supermicro" DMI string baseboard-product-name: "X8DTU" DMI string baseboard-version: "1234567890" DMI string chassis-type: "Main Server Chassis" W836xx enter config mode worked or we were already in config mode. W836xx leave config mode had no effect. Active config mode, unknown reg 0x20 ID: 1a. Please send the output of "flashrom -V" to flashrom(a)flashrom.org with W836xx: your board name: flashrom -V as the subject to help us finish support for your Super I/O. Thanks. Found chipset "Intel ICH10R" with PCI ID 8086:3a16. Enabling flash write... 0x7fffffff/0x7fffffff FWH IDSEL: 0x0 0x7fffffff/0x7fffffff FWH IDSEL: 0x0 0x7fffffff/0x7fffffff FWH IDSEL: 0x1 0x7fffffff/0x7fffffff FWH IDSEL: 0x1 0x7fffffff/0x7fffffff FWH IDSEL: 0x2 0x7fffffff/0x7fffffff FWH IDSEL: 0x2 0x7fffffff/0x7fffffff FWH IDSEL: 0x3 0x7fffffff/0x7fffffff FWH IDSEL: 0x3 0x7fffffff/0x7fffffff FWH IDSEL: 0x4 0x7fffffff/0x7fffffff FWH IDSEL: 0x5 0x7fffffff/0x7fffffff FWH IDSEL: 0x6 0x7fffffff/0x7fffffff FWH IDSEL: 0x7 0x7fffffff/0x7fffffff FWH decode enabled 0x7fffffff/0x7fffffff FWH decode enabled 0x7fffffff/0x7fffffff FWH decode enabled 0x7fffffff/0x7fffffff FWH decode enabled 0x7fffffff/0x7fffffff FWH decode enabled 0x7fffffff/0x7fffffff FWH decode enabled 0x7fffffff/0x7fffffff FWH decode enabled 0x7fffffff/0x7fffffff FWH decode enabled 0x7fffffff/0x7fffffff FWH decode disabled 0x7fffffff/0x7fffffff FWH decode disabled 0x7fffffff/0x7fffffff FWH decode disabled 0x7fffffff/0x7fffffff FWH decode disabled Maximum FWH chip size: 0x100000 bytes BIOS Lock Enable: disabled, BIOS Write Enable: disabled, BIOS_CNTL is 0x0 Root Complex Register Block address = 0xfed1c000 GCS = 0x460: BIOS Interface Lock-Down: disabled, Boot BIOS Straps: 0x1 (SPI) Top Swap : not enabled SPIBAR = 0xfed1c000 + 0x3800 0x04: 0x2008 (HSFS) HSFS: FDONE=0, FCERR=0, AEL=0, BERASE=1, SCIP=0, FDOPSS=1, FDV=0, FLOCKDN=0 Programming OPCODES... done 0x08: 0x003fffc0 (FADDR) 0x90: 0x04 (SSFS) SSFS: SCIP=0, FDONE=1, FCERR=0, AEL=0 0x91: 0x007f10 (SSFC) SSFC: SCGO=0, ACS=0, SPOP=0, COP=1, DBC=63, SME=0, SCF=0 0x94: 0x5006 (PREOP) 0x96: 0x463b (OPTYPE) 0x98: 0x05d80302 (OPMENU) 0x9C: 0xc79f0190 (OPMENU+4) 0xA0: 0x00000000 (BBAR) SPI Read Configuration: prefetching disabled, caching enabled, OK. The following protocols are supported: FWH, SPI. Probing for AMIC A25L05PT, 64 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for AMIC A25L05PU, 64 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for AMIC A25L10PT, 128 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for AMIC A25L10PU, 128 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for AMIC A25L20PT, 256 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for AMIC A25L20PU, 256 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for AMIC A25L40PT, 512 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for AMIC A25L40PU, 512 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for AMIC A25L80P, 1024 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for AMIC A25L16PT, 2048 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for AMIC A25L16PU, 2048 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for AMIC A25L512, 64 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for AMIC A25L010, 128 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for AMIC A25L020, 256 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for AMIC A25L040, 512 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for AMIC A25L080, 1024 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for AMIC A25L016, 2048 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for AMIC A25L032, 4096 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for AMIC A25LQ032, 4096 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Atmel AT25DF021, 256 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Atmel AT25DF041A, 512 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Atmel AT25DF081, 1024 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Atmel AT25DF081A, 1024 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Atmel AT25DF161, 2048 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Atmel AT25DF321, 4096 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Chip status register is 00 Found Atmel flash chip "AT25DF321" (4096 kB, SPI) at physical address 0xffc00000. Chip status register is 00 Chip status register: Sector Protection Register Lock (SRPL) is not set Chip status register: Bit 6 is not set Chip status register: Erase/Program Error (EPE) is not set Chip status register: WP# pin (WPP) is asserted Chip status register: Software Protection Status (SWP): no sectors are protected Chip status register: Write Enable Latch (WEL) is not set Chip status register: Write In Progress (WIP/BUSY) is not set Probing for Atmel AT25DF321A, 4096 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Atmel AT25DF641(A), 8192 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Atmel AT25DQ161, 2048 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Atmel AT25F512B, 64 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Atmel AT25FS010, 128 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Atmel AT25FS040, 512 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Atmel AT26DF041, 512 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Atmel AT26DF081A, 1024 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Atmel AT26DF161, 2048 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Atmel AT26DF161A, 2048 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Atmel AT26F004, 512 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Atmel AT45CS1282, 16896 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Atmel AT45DB011D, 128 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Atmel AT45DB021D, 256 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Atmel AT45DB041D, 512 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Atmel AT45DB081D, 1024 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Atmel AT45DB161D, 2048 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Atmel AT45DB321C, 4224 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Atmel AT45DB321D, 4096 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Atmel AT45DB642D, 8192 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for EMST F25L008A, 1024 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25B05, 64 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25B05T, 64 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25B10, 128 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25B10T, 128 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25B20, 256 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25B20T, 256 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25B40, 512 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25B40T, 512 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25B80, 1024 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25B80T, 1024 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25B16, 2048 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25B16T, 2048 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25B32, 4096 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25B32T, 4096 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25B64, 8192 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25B64T, 8192 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25F05, 64 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25F10, 128 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25F20, 256 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25F40, 512 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25F80, 1024 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25F16, 2048 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25F32, 4096 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25Q40, 512 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25Q80(A), 1024 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25Q16, 2048 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25Q32(A/B), 4096 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25Q64, 8192 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25Q128, 16384 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25QH16, 2048 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon EN25QH32, 4096 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for GigaDevice GD25Q20, 256 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for GigaDevice GD25Q40, 512 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for GigaDevice GD25Q80, 1024 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for GigaDevice GD25Q16, 2048 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for GigaDevice GD25Q32, 4096 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for GigaDevice GD25Q64, 8192 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for GigaDevice GD25Q128, 16384 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Macronix MX25L512, 64 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Macronix MX25L1005, 128 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Macronix MX25L2005, 256 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Macronix MX25L4005, 512 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Macronix MX25L8005, 1024 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Macronix MX25L1605, 2048 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Macronix MX25L1635D, 2048 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Macronix MX25L1635E, 2048 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Macronix MX25L3205, 4096 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Macronix MX25L3235D, 4096 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Macronix MX25L6405, 8192 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Macronix MX25L12805, 16384 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Numonyx M25PE10, 128 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Numonyx M25PE20, 256 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Numonyx M25PE40, 512 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Numonyx M25PE80, 1024 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Numonyx M25PE16, 2048 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Numonyx N25Q064, 8192 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for PMC Pm25LV010, 128 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for PMC Pm25LV016B, 2048 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for PMC Pm25LV020, 256 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for PMC Pm25LV040, 512 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for PMC Pm25LV080B, 1024 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for PMC Pm25LV512, 64 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Sanyo LF25FW203A, 2048 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Spansion S25FL004A, 512 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Spansion S25FL008A, 1024 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Spansion S25FL016A, 2048 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Spansion S25FL032A, 4096 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Spansion S25FL064A, 8192 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for SST SST25LF040A, 512 kB: probe_spi_res2: id1 0xff, id2 0xff Probing for SST SST25LF080A, 1024 kB: probe_spi_res2: id1 0xff, id2 0xff Probing for SST SST25VF010, 128 kB: probe_spi_rems: id1 0xff, id2 0xff Probing for SST SST25VF016B, 2048 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for SST SST25VF032B, 4096 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for SST SST25VF064C, 8192 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for SST SST25VF040, 512 kB: probe_spi_rems: id1 0xff, id2 0xff Probing for SST SST25VF040B, 512 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for SST SST25VF040B.REMS, 512 kB: probe_spi_rems: id1 0xff, id2 0xff Probing for SST SST25VF080B, 1024 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for ST M25P05-A, 64 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for ST M25P05, 64 kB: Ignoring RES in favour of RDID. Probing for ST M25P10-A, 128 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for ST M25P10, 128 kB: Ignoring RES in favour of RDID. Probing for ST M25P20, 256 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for ST M25P40, 512 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for ST M25P40-old, 512 kB: Ignoring RES in favour of RDID. Probing for ST M25P80, 1024 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for ST M25P16, 2048 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for ST M25P32, 4096 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for ST M25P64, 8192 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for ST M25P128, 16384 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for ST M25PX16, 2048 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for ST M25PX32, 4096 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for ST M25PX64, 8192 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Winbond W25Q80, 1024 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Winbond W25Q16, 2048 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Winbond W25Q32, 4096 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Winbond W25Q64, 8192 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Winbond W25Q128, 16384 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Winbond W25X10, 128 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Winbond W25X20, 256 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Winbond W25X40, 512 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Winbond W25X80, 1024 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Winbond W25X16, 2048 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Winbond W25X32, 4096 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Winbond W25X64, 8192 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Unknown SFDP-capable chip, 0 kB: No SFDP signature found. Probing for AMIC unknown AMIC SPI chip, 0 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Atmel unknown Atmel SPI chip, 0 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Eon unknown Eon SPI chip, 0 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Macronix unknown Macronix SPI chip, 0 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for PMC unknown PMC SPI chip, 0 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for SST unknown SST SPI chip, 0 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for ST unknown ST SPI chip, 0 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Sanyo unknown Sanyo SPI chip, 0 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Generic unknown SPI chip (RDID), 0 kB: probe_spi_rdid_generic: id1 0x1f, id2 0x4700 Probing for Generic unknown SPI chip (REMS), 0 kB: probe_spi_rems: id1 0xff, id2 0xff Probing for Atmel AT49LH002, 256 kB: probe_82802ab: id1 0x41, id2 0x4d, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Intel 82802AB, 512 kB: probe_82802ab: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Intel 82802AC, 1024 kB: probe_82802ab: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for PMC Pm49FL002, 256 kB: probe_jedec_common: id1 0x41, id2 0x4d, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for PMC Pm49FL004, 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Sharp LHF00L04, 1024 kB: probe_82802ab: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for SST SST49LF002A/B, 256 kB: probe_jedec_common: id1 0x41, id2 0x4d, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for SST SST49LF003A/B, 384 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for SST SST49LF004A/B, 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for SST SST49LF004C, 512 kB: probe_82802ab: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for SST SST49LF008A, 1024 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for SST SST49LF008C, 1024 kB: probe_82802ab: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for SST SST49LF016C, 2048 kB: Chip size 2048 kB is bigger than supported size 1024 kB of chipset/board/programmer for FWH interface, probe/read/erase/write may fail. probe_82802ab: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for ST M50FLW040A, 512 kB: probe_82802ab: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for ST M50FLW040B, 512 kB: probe_82802ab: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for ST M50FLW080A, 1024 kB: probe_82802ab: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for ST M50FLW080B, 1024 kB: probe_82802ab: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for ST M50FW002, 256 kB: probe_82802ab: id1 0x41, id2 0x4d, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for ST M50FW016, 2048 kB: Chip size 2048 kB is bigger than supported size 1024 kB of chipset/board/programmer for FWH interface, probe/read/erase/write may fail. probe_82802ab: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for ST M50FW040, 512 kB: probe_82802ab: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for ST M50FW080, 1024 kB: probe_82802ab: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Winbond W39V040FA, 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Winbond W39V040FB, 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Winbond W39V040FC, 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Winbond W49V002FA, 256 kB: probe_jedec_common: id1 0x41, id2 0x4d, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Winbond W39V080FA, 1024 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Winbond W39V080FA (dual mode), 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Found Atmel flash chip "AT25DF321" (4096 kB, SPI). No operations were specified. Restoring MMIO space at 0x7fc32bb528a0 Restoring MMIO space at 0x7fc32bb5289c Restoring MMIO space at 0x7fc32bb52898 Restoring MMIO space at 0x7fc32bb52896 Restoring MMIO space at 0x7fc32bb52894 Restoring PCI config space for 00:1f:0 reg 0xdc Thanks, Scott Silverman | IT | Simplex Investments | 312-360-2444 230 S. LaSalle St., Suite 4-100, Chicago, IL 60604

1 0

32 kB chip compatibility
by Sebastian S. Slowalk 12 Dec '12

12 Dec '12

Hi, just wanted to know why flashrom isn't compatible for 32 kB chips, (i.e. 27c256 ones). I'm working with car ECU's eproms and would thank that. Thanks anyway, Sebastian

2 2

Re: [flashrom] [PATCH 3/3] [RFC] Unify usbdev_status and pcidev_status into dev_status.
by Carl-Daniel Hailfinger 12 Dec '12

12 Dec '12

Am 17.11.2012 20:09 schrieb Stefan Tauner: > Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Is there a reason you introduce a .devices struct member inside struct programmer_entry in patch 1 just to rename it to .dev in patch 3? Regards, Carl-Daniel > diff --git a/flashrom.c b/flashrom.c > index d873276..ae8f70c 100644 > --- a/flashrom.c > +++ b/flashrom.c > @@ -65,7 +65,7 @@ const struct programmer_entry programmer_table[] = { > { > .name = "internal", > .type = OTHER, > - .devices.note = NULL, > + .devs.note = NULL, > .init = internal_init, > .map_flash_region = physmap, > .unmap_flash_region = physunmap, > @@ -78,7 +78,7 @@ const struct programmer_entry programmer_table[] = { > .name = "dummy", > .type = OTHER, > /* FIXME */ > - .devices.note = "Dummy device, does nothing and logs all accesses\n", > + .devs.note = "Dummy device, does nothing and logs all accesses\n", > .init = dummy_init, > .map_flash_region = dummy_map, > .unmap_flash_region = dummy_unmap, > @@ -90,7 +90,7 @@ const struct programmer_entry programmer_table[] = { > { > .name = "nic3com", > .type = PCI, > - .devices.pci = nics_3com, > + .devs.status = nics_3com, > .init = nic3com_init, > .map_flash_region = fallback_map, > .unmap_flash_region = fallback_unmap, > @@ -103,7 +103,7 @@ const struct programmer_entry programmer_table[] = { > /* This programmer works for Realtek RTL8139 and SMC 1211. */ > .name = "nicrealtek", > .type = PCI, > - .devices.pci = nics_realtek, > + .devs.status = nics_realtek, > .init = nicrealtek_init, > .map_flash_region = fallback_map, > .unmap_flash_region = fallback_unmap, > @@ -115,7 +115,7 @@ const struct programmer_entry programmer_table[] = { > { > .name = "nicnatsemi", > .type = PCI, > - .devices.pci = nics_natsemi, > + .devs.status = nics_natsemi, > .init = nicnatsemi_init, > .map_flash_region = fallback_map, > .unmap_flash_region = fallback_unmap, > @@ -127,7 +127,7 @@ const struct programmer_entry programmer_table[] = { > { > .name = "gfxnvidia", > .type = PCI, > - .devices.pci = gfx_nvidia, > + .devs.status = gfx_nvidia, > .init = gfxnvidia_init, > .map_flash_region = fallback_map, > .unmap_flash_region = fallback_unmap, > @@ -139,7 +139,7 @@ const struct programmer_entry programmer_table[] = { > { > .name = "drkaiser", > .type = PCI, > - .devices.pci = drkaiser_pcidev, > + .devs.status = drkaiser_pcidev, > .init = drkaiser_init, > .map_flash_region = fallback_map, > .unmap_flash_region = fallback_unmap, > @@ -151,7 +151,7 @@ const struct programmer_entry programmer_table[] = { > { > .name = "satasii", > .type = PCI, > - .devices.pci = satas_sii, > + .devs.status = satas_sii, > .init = satasii_init, > .map_flash_region = fallback_map, > .unmap_flash_region = fallback_unmap, > @@ -163,7 +163,7 @@ const struct programmer_entry programmer_table[] = { > { > .name = "atahpt", > .type = PCI, > - .devices.pci = ata_hpt, > + .devs.status = ata_hpt, > .init = atahpt_init, > .map_flash_region = fallback_map, > .unmap_flash_region = fallback_unmap, > @@ -175,7 +175,7 @@ const struct programmer_entry programmer_table[] = { > { > .name = "ft2232_spi", > .type = USB, > - .devices.usb = devs_ft2232spi, > + .devs.status = devs_ft2232spi, > .init = ft2232_spi_init, > .map_flash_region = fallback_map, > .unmap_flash_region = fallback_unmap, > @@ -188,7 +188,7 @@ const struct programmer_entry programmer_table[] = { > .name = "serprog", > .type = OTHER, > /* FIXME */ > - .devices.note = "All programmer devices speaking the serprog protocol\n", > + .devs.note = "All programmer devices speaking the serprog protocol\n", > .init = serprog_init, > .map_flash_region = fallback_map, > .unmap_flash_region = fallback_unmap, > @@ -201,7 +201,7 @@ const struct programmer_entry programmer_table[] = { > .name = "buspirate_spi", > .type = OTHER, > /* FIXME */ > - .devices.note = "Dangerous Prototypes Bus Pirate\n", > + .devs.note = "Dangerous Prototypes Bus Pirate\n", > .init = buspirate_spi_init, > .map_flash_region = fallback_map, > .unmap_flash_region = fallback_unmap, > @@ -214,7 +214,7 @@ const struct programmer_entry programmer_table[] = { > .name = "dediprog", > .type = OTHER, > /* FIXME */ > - .devices.note = "Dediprog SF100\n", > + .devs.note = "Dediprog SF100\n", > .init = dediprog_init, > .map_flash_region = fallback_map, > .unmap_flash_region = fallback_unmap, > @@ -227,7 +227,7 @@ const struct programmer_entry programmer_table[] = { > .name = "rayer_spi", > .type = OTHER, > /* FIXME */ > - .devices.note = "RayeR parallel port programmer\n", > + .devs.note = "RayeR parallel port programmer\n", > .init = rayer_spi_init, > .map_flash_region = fallback_map, > .unmap_flash_region = fallback_unmap, > @@ -240,7 +240,7 @@ const struct programmer_entry programmer_table[] = { > .name = "pony_spi", > .type = OTHER, > /* FIXME */ > - .devices.note = "Programmers compatible with SI-Prog, serbang or AJAWe\n", > + .devs.note = "Programmers compatible with SI-Prog, serbang or AJAWe\n", > .init = pony_spi_init, > .map_flash_region = fallback_map, > .unmap_flash_region = fallback_unmap, > @@ -252,7 +252,7 @@ const struct programmer_entry programmer_table[] = { > { > .name = "nicintel", > .type = PCI, > - .devices.pci = nics_intel, > + .devs.status = nics_intel, > .init = nicintel_init, > .map_flash_region = fallback_map, > .unmap_flash_region = fallback_unmap, > @@ -264,7 +264,7 @@ const struct programmer_entry programmer_table[] = { > { > .name = "nicintel_spi", > .type = PCI, > - .devices.pci = nics_intel_spi, > + .devs.status = nics_intel_spi, > .init = nicintel_spi_init, > .map_flash_region = fallback_map, > .unmap_flash_region = fallback_unmap, > @@ -276,7 +276,7 @@ const struct programmer_entry programmer_table[] = { > { > .name = "ogp_spi", > .type = PCI, > - .devices.pci = ogp_spi, > + .devs.status = ogp_spi, > .init = ogp_spi_init, > .map_flash_region = fallback_map, > .unmap_flash_region = fallback_unmap, > @@ -288,7 +288,7 @@ const struct programmer_entry programmer_table[] = { > { > .name = "satamv", > .type = PCI, > - .devices.pci = satas_mv, > + .devs.status = satas_mv, > .init = satamv_init, > .map_flash_region = fallback_map, > .unmap_flash_region = fallback_unmap, > @@ -300,7 +300,7 @@ const struct programmer_entry programmer_table[] = { > { > .name = "linux_spi", > .type = OTHER, > - .devices.note = "Device files /dev/spidev*.*\n", > + .devs.note = "Device files /dev/spidev*.*\n", > .init = linux_spi_init, > .map_flash_region = fallback_map, > .unmap_flash_region = fallback_unmap, > diff --git a/programmer.h b/programmer.h > index 21fa707..90033a9 100644 > --- a/programmer.h > +++ b/programmer.h > @@ -96,15 +96,22 @@ enum programmer_type { > struct programmer_entry { > const char *vendor; > const char *name; > const enum programmer_type type; > union { > const struct pcidev_status *const pci; > const struct usbdev_status *const usb; > const char *const note; > - } devices; > + } devs; > > int (*init) (void); > -- http://www.hailfinger.org/

2 3

flashrom OPCODES for SPI
by Николай Николаев 12 Dec '12

12 Dec '12

hello i'm trying to reprogram spi chip with bios. My sdk-board is consist from motherboard and especial board. Motherboard has own flash bios chip like a mx25l6405 and chip SPI interface QM67. Especial board has a spi flash chip sst25vf016. Used jumpers i'm easy select flash bios chip for programming, and i select chip sst25vf016. Chip set QM67 is locked to change value registers opcodes and preop codes. This is codes value match with mx25l6405 codes. And i can't reprogram selected chip, because opcodes select chip didn't match with opcodes stored in QM67. In function spi_write_status_register Flashrom source code algorithm trying change mode spi status register to write by sending unlock command JEDEC_WRSR and JEDEC_EWSR = 0x50. But preop codes register have a value JEDEC_WREN=0x06, and don't have a value JEDEC_EWSR=0x50. And STATUS register can't be unlocked, if i change value JEDEC_EWSR on 0x06 (chip sst25vf016 support this code) the STATUS register is unlock successful. And now we have a read and erase function but function write doesn't work, because algorithm use default_spi_write_aai function. That function use opcode JEDEC_AAI_WORD_PROGRAMM but opcodes and preopcodes registers doesn't have this code and we can't write new bios image in flash. But if we will be use function spi_chip_write_1 we successful write our image into flash chip sst25vf016. What you think about, if we exclude some parameters from structure FLASHCTX (like a feature_bits) and add array of OPCODES (with real opcodes for real chip) and add function to detect access opcodes for used chips? sorry for my English

1 0

Re: [flashrom] [PATCH 1/3] Refactor PCI and USB device status printing.
by Carl-Daniel Hailfinger 12 Dec '12

12 Dec '12

Am 17.11.2012 20:09 schrieb Stefan Tauner: > To be able to get rid of lots of #ifdefs and centralize programmer-specific > data more... > - introduce two new fields to struct programmer_entry, namely > enum type (OTHER, USB, PCI) and union devices (pcidev_status, usbdev_status > or char *note). > - use those fields to generate device listings in print.c and print_wiki.c. > > Bonus: add printing of USB devices to print_wiki.c and count supported PCI > and USB devices. > > Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Good idea. I have a few comments, otherwise it looks OK. Note: I have not checked the wiki output, I only reviewed the code. I trust you have checked the wiki output for changes. > --- > flashrom.c | 48 ++++++++++++++++++- > ft2232_spi.c | 13 ------ > pcidev.c | 13 ------ > print.c | 148 +++++++++++++++++++--------------------------------------- > print_wiki.c | 141 ++++++++++++++++++++++++++++++++++--------------------- > programmer.h | 41 ++++++++++------ > 6 files changed, 211 insertions(+), 193 deletions(-) > > diff --git a/flashrom.c b/flashrom.c > index 2299b06..d873276 100644 > --- a/flashrom.c > +++ b/flashrom.c > @@ -64,6 +64,8 @@ const struct programmer_entry programmer_table[] = { > #if CONFIG_INTERNAL == 1 > { > .name = "internal", > + .type = OTHER, > + .devices.note = NULL, > .init = internal_init, > .map_flash_region = physmap, > .unmap_flash_region = physunmap, > @@ -84,6 +89,8 @@ const struct programmer_entry programmer_table[] = { > #if CONFIG_NIC3COM == 1 > { > .name = "nic3com", > + .type = PCI, > + .devices.pci = nics_3com, If we reference the device list here, can we kill the code in each programmer which mentions the device list explicitly and use pgm->devices->pci there? Otherwise there's a good chance someone will forget one or the other reference and wonder why --list and actual recognized programmer devices differ. > .init = nic3com_init, > .map_flash_region = fallback_map, > .unmap_flash_region = fallback_unmap, > @@ -185,6 +212,9 @@ const struct programmer_entry programmer_table[] = { > #if CONFIG_DEDIPROG == 1 > { > .name = "dediprog", > + .type = OTHER, Regression. The old code lists all devices. > + /* FIXME */ > + .devices.note = "Dediprog SF100\n", > .init = dediprog_init, > .map_flash_region = fallback_map, > .unmap_flash_region = fallback_unmap, > diff --git a/print.c b/print.c > index d7bdbfe..4b23ca0 100644 > --- a/print.c > +++ b/print.c > @@ -433,8 +433,32 @@ static void print_supported_boards_helper(const struct board_info *boards, > } > #endif > For consistency, we should introduce NEED_USB here. That would need Makefile glue, but I think it's worth it, especially now that there are Dediprog patches which change the libusb-0 dependency to a libusb-1 dependency. > +void print_supported_usbdevs(const struct usbdev_status *devs) > +{ > + int i; > + > + msg_pinfo("USB devices:\n"); > + for (i = 0; devs[i].vendor_name != NULL; i++) { > + msg_pinfo("%s %s [%04x:%04x]%s\n", devs[i].vendor_name, devs[i].device_name, devs[i].vendor_id, > + devs[i].device_id, (devs[i].status == NT) ? " (untested)" : ""); > + } > +} > + > +#if NEED_PCI == 1 > +void print_supported_pcidevs(const struct pcidev_status *devs) > +{ > + int i; > + > + for (i = 0; devs[i].vendor_name != NULL; i++) { > + msg_pinfo("%s %s [%04x:%04x]%s\n", devs[i].vendor_name, devs[i].device_name, devs[i].vendor_id, > + devs[i].device_id, (devs[i].status == NT) ? " (untested)" : ""); > + } > +} > +#endif > + > int print_supported(void) > { > + unsigned int i; > if (print_supported_chips()) > return 1; > > @@ -449,107 +473,31 @@ int print_supported(void) > msg_ginfo("\n"); > print_supported_boards_helper(laptops_known, "laptops"); > #endif > -#if CONFIG_DUMMY == 1 > - msg_ginfo("\nSupported devices for the %s programmer:\n", > - programmer_table[PROGRAMMER_DUMMY].name); > - /* FIXME */ > - msg_ginfo("Dummy device, does nothing and logs all accesses\n"); > -#endif > [...] > -#if CONFIG_LINUX_SPI == 1 > - msg_ginfo("\nSupported devices for the %s programmer:\n", > - programmer_table[PROGRAMMER_LINUX_SPI].name); > - msg_ginfo("Device files /dev/spidev*.*\n"); > + for (i = 0; i < PROGRAMMER_INVALID; i++) { > + const struct programmer_entry prog = programmer_table[i]; > + switch (prog.type) { NEED_USB again. > + case USB: > + msg_ginfo("\nSupported USB devices for the %s programmer:\n", prog.name); > + print_supported_usbdevs(prog.devices.usb); > + break; > +#if NEED_PCI == 1 > + case PCI: > + msg_ginfo("\nSupported PCI devices for the %s programmer:\n", prog.name); > + print_supported_pcidevs(prog.devices.pci); > + break; > #endif > + case OTHER: > + if (prog.devices.note == NULL) > + break; Interesting logic. I'm not saying it is wrong, but it's not immediately obvious that .note=NULL means the programmer won't be listed at all. I fear this might be forgotten by future programmer driver authors, but then again I should update my programmer code generation script and push it to svn so this won't be a problem in the future. > + msg_ginfo("\nSupported devices for the %s programmer:\n", prog.name); > + msg_ginfo("%s", prog.devices.note); > + break; > + default: > + msg_gerr("\n%s: %s: Uninitialized programmer type! Please report a bug at " > + "flashrom(a)flashrom.org\n", __func__, prog.name); > + break; > + } > + } > return 0; > } > > diff --git a/print_wiki.c b/print_wiki.c > index 617053c..17e2e85 100644 > --- a/print_wiki.c > +++ b/print_wiki.c > @@ -302,9 +298,18 @@ static void print_supported_chips_wiki(int cols) > printf("|}\n\n"); > } > > -/* Not needed for CONFIG_INTERNAL, but for all other PCI-based programmers. */ > -#if CONFIG_NIC3COM+CONFIG_NICREALTEK+CONFIG_NICNATSEMI+CONFIG_GFXNVIDIA+CONFIG_DRKAISER+CONFIG_SATASII+CONFIG_ATAHPT+CONFIG_NICINTEL+CONFIG_NICINTEL_SPI+CONFIG_OGP_SPI+CONFIG_SATAMV >= 1 > -static void print_supported_pcidevs_wiki(const struct pcidev_status *devs) > +/* Following functions are not needed when no PCI/USB programmers are compiled in, > + * but since print_wiki code has no size constraints we include it unconditionally. */ Heh. > +static int count_supported_pcidevs_wiki(const struct pcidev_status *devs) > +{ > + unsigned int count = 0; > + unsigned int i = 0; > + for (i = 0; devs[i].vendor_name != NULL; i++) AFAICS this should segfault in case a driver has prog.type=PCI and prog.devices.pci==NULL. Not a problem, but maybe we should catch this case (as well as the USB case) in a selftest function during startup? That would also help during programmer development. > + count++; > + return count; > +} > + > +static void print_supported_pcidevs_wiki_helper(const struct pcidev_status *devs) > { > int i = 0; > static int c = 0; > @@ -313,14 +318,81 @@ static void print_supported_pcidevs_wiki(const struct pcidev_status *devs) > c = !c; > > for (i = 0; devs[i].vendor_name != NULL; i++) { > - printf("|- bgcolor=\"#%s\"\n| %s || %s || " > - "%04x:%04x || {{%s}}\n", (c) ? "eeeeee" : "dddddd", > - devs[i].vendor_name, devs[i].device_name, > - devs[i].vendor_id, devs[i].device_id, > + printf("|- bgcolor=\"#%s\"\n| %s || %s || %04x:%04x || {{%s}}\n", (c) ? "eeeeee" : "dddddd", > + devs[i].vendor_name, devs[i].device_name, devs[i].vendor_id, devs[i].device_id, > (devs[i].status == NT) ? "?3" : "OK"); > } > } > -#endif > + > +static int count_supported_usbdevs_wiki(const struct usbdev_status *devs) > +{ > + unsigned int count = 0; > + unsigned int i = 0; > + for (i = 0; devs[i].vendor_name != NULL; i++) > + count++; > + return count; > +} > + > +static void print_supported_usbdevs_wiki_helper(const struct usbdev_status *devs) > +{ > + int i = 0; > + static int c = 0; > + > + /* Alternate colors if the vendor changes. */ > + c = !c; > + > + for (i = 0; devs[i].vendor_name != NULL; i++) { > + printf("|- bgcolor=\"#%s\"\n| %s || %s || %04x:%04x || {{%s}}\n", (c) ? "eeeeee" : "dddddd", > + devs[i].vendor_name, devs[i].device_name, devs[i].vendor_id, devs[i].device_id, > + (devs[i].status == NT) ? "?3" : "OK"); > + } > +} > + > +static void print_supported_devs_wiki() > +{ > + unsigned int pci_count = 0; > + unsigned int usb_count = 0; > + unsigned int i; > + > + for (i = 0; i < PROGRAMMER_INVALID; i++) { > + const struct programmer_entry prog = programmer_table[i]; > + switch (prog.type) { > + case USB: > + usb_count += count_supported_usbdevs_wiki(prog.devices.usb); > + break; > + case PCI: > + pci_count += count_supported_pcidevs_wiki(prog.devices.pci); > + break; > + case OTHER: > + default: > + break; > + } > + } > + > + printf("\n== PCI Devices ==\n\n" > + "Total amount of supported PCI devices flashrom can use as a programmer: '''%d'''\n\n" > + "{%s%s", pci_count, th_start, programmer_th); > + > + for (i = 0; i < PROGRAMMER_INVALID; i++) { > + const struct programmer_entry prog = programmer_table[i]; > + if (prog.type == PCI) { > + print_supported_pcidevs_wiki_helper(prog.devices.pci); > + } > + } > + printf("\n|}\n\n|}\n"); > + > + printf("\n== USB Devices ==\n\n" > + "Total amount of supported USB devices flashrom can use as a programmer: '''%d'''\n\n" > + "{%s%s", usb_count, th_start, programmer_th); > + > + for (i = 0; i < PROGRAMMER_INVALID; i++) { > + const struct programmer_entry prog = programmer_table[i]; > + if (prog.type == USB) { > + print_supported_usbdevs_wiki_helper(prog.devices.usb); > + } > + } > + printf("\n|}\n\n|}\n"); > +} > > void print_supported_wiki(void) > { > @@ -332,41 +404,6 @@ void print_supported_wiki(void) > print_supported_chipsets_wiki(3); > print_supported_boards_wiki(); > #endif > - printf("%s%s%s", programmer_intro, th_start, programmer_th); > - > -#if CONFIG_NIC3COM == 1 > - print_supported_pcidevs_wiki(nics_3com); > -#endif > -#if CONFIG_NICREALTEK == 1 > - print_supported_pcidevs_wiki(nics_realtek); > -#endif > -#if CONFIG_NICNATSEMI == 1 > - print_supported_pcidevs_wiki(nics_natsemi); > -#endif > -#if CONFIG_GFXNVIDIA == 1 > - print_supported_pcidevs_wiki(gfx_nvidia); > -#endif > -#if CONFIG_DRKAISER == 1 > - print_supported_pcidevs_wiki(drkaiser_pcidev); > -#endif > -#if CONFIG_SATASII == 1 > - print_supported_pcidevs_wiki(satas_sii); > -#endif > -#if CONFIG_ATAHPT == 1 > - print_supported_pcidevs_wiki(ata_hpt); > -#endif > -#if CONFIG_NICINTEL == 1 > - print_supported_pcidevs_wiki(nics_intel); > -#endif > -#if CONFIG_NICINTEL_SPI == 1 > - print_supported_pcidevs_wiki(nics_intel_spi); > -#endif > -#if CONFIG_OGP_SPI == 1 > - print_supported_pcidevs_wiki(ogp_spi); > -#endif > -#if CONFIG_SATAMV == 1 > - print_supported_pcidevs_wiki(satas_mv); > -#endif > - printf("\n|}\n\n|}\n"); > + print_supported_devs_wiki(); > } > > diff --git a/programmer.h b/programmer.h > index dedec67..21fa707 100644 > --- a/programmer.h > +++ b/programmer.h > @@ -90,9 +90,21 @@ enum programmer { > PROGRAMMER_INVALID /* This must always be the last entry. */ > }; > > +enum programmer_type { > + PCI = 1, /* to detect uninitialized values */ > + USB, > + OTHER, > +}; > + > struct programmer_entry { > const char *vendor; > const char *name; > + const enum programmer_type type; > + union { > + const struct pcidev_status *const pci; > + const struct usbdev_status *const usb; > + const char *const note; Neat! > + } devices; > > int (*init) (void); > > @@ -221,13 +233,6 @@ void internal_delay(int usecs); > extern uint32_t io_base_addr; > extern struct pci_access *pacc; > extern struct pci_dev *pcidev_dev; > -struct pcidev_status { > - uint16_t vendor_id; > - uint16_t device_id; > - const enum test_state status; > - const char *vendor_name; > - const char *device_name; > -}; > uintptr_t pcidev_readbar(struct pci_dev *dev, int bar); > uintptr_t pcidev_init(int bar, const struct pcidev_status *devs); > /* rpci_write_* are reversible writes. The original PCI config space register > @@ -244,6 +249,21 @@ int rpci_write_long(struct pci_dev *dev, int reg, uint32_t data); > void print_supported_pcidevs(const struct pcidev_status *devs); > #endif > > +struct usbdev_status { > + uint16_t vendor_id; > + uint16_t device_id; > + const enum test_state status; > + const char *vendor_name; > + const char *device_name; > +}; > +struct pcidev_status { > + uint16_t vendor_id; > + uint16_t device_id; > + const enum test_state status; > + const char *vendor_name; > + const char *device_name; > +}; Hm. You moved the struct pcidev_status and usbdev_status outside the #ifdef protecting it. Given that this has no impact on code generation, I don't have a big problem with it. This is a question we should eventually decide: Do we want unused struct declarations inside #ifdef or not? Such a decision should not hold up merging this code, I just wanted to mention it. > + > #if CONFIG_INTERNAL == 1 > /* board_enable.c */ > int board_parse_parameter(const char *boardstring, const char **vendor, const char **model); > @@ -422,13 +442,6 @@ extern const struct pcidev_status ata_hpt[]; > > /* ft2232_spi.c */ > #if CONFIG_FT2232_SPI == 1 > -struct usbdev_status { > - uint16_t vendor_id; > - uint16_t device_id; > - const enum test_state status; > - const char *vendor_name; > - const char *device_name; > -}; > int ft2232_spi_init(void); > extern const struct usbdev_status devs_ft2232spi[]; > void print_supported_usbdevs(const struct usbdev_status *devs); Regards, Carl-Daniel -- http://www.hailfinger.org/

2 1

Re: [flashrom] Dell Alienware Aurora R2
by Stefan Tauner 12 Dec '12

12 Dec '12

On Mon, 3 Dec 2012 15:32:47 +0100 "Gilles Antonetti / Gmail" <gilles.antonetti(a)gmail.com> wrote: > 0x54: 0x00000000 FREG0: WARNING: Flash Descriptor region (0x00000000-0x00000fff) is read-only. > 0x58: 0x03ff0200 FREG1: BIOS region (0x00200000-0x003fffff) is read-write. > 0x5C: 0x01ff0001 FREG2: WARNING: Management Engine region (0x00001000-0x001fffff) is locked.Hello Gilles, thanks for your report! The problem is the locked ME region as quoted above. We are working on unlocking it or working around it, but intel does not provide us any documentation so please do not expect a solution soon (or ever). I have added the board to our list of (un)supported boards (with an appropriate note) and will commit that later together with other small changes. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

Re: [flashrom] mail archives down?
by Patrick Georgi 11 Dec '12

11 Dec '12

Am 2012-12-10 09:55, schrieb Idwer Vollering: > Works for me. This however looks wrong: > http://www.flashrom.org/pipermail/flashrom/2012-December/000073.html Sorry, misconfiguration on my part. Mails between yesterday evening and 8am this morning (both CET) got lost on their way to the archive. Patrick

2 2

Re: [flashrom] Erase Fails on Winmate I370 Motherboard with PMC Pm49FL004 Flash Chip
by Stefan Tauner 10 Dec '12

10 Dec '12

On Mon, 10 Dec 2012 14:35:54 -0500 sdbarnes(a)rockwellcollins.com wrote: > I think I have verified that there is no issue with flashrom 0.9.3 and the > PMC Pm49FL004 chip. > > I had received some Pm49FL004 chips from a vendor with a WinMate I330 BIOS > load (an I330 message was being displayed briefly on BIOS POST). Am I > correct in assuming that some portion of the BIOS (e.g.,boot block) cannot > be updated with flashrom? that depends on how the boot block (or any other range) is protected, there are various schemes to do this. the most common one is to use a dedicated write protection pin for the whole device or the boot block (or both), which can be changed by a GPIO of the southbridge or super i/o chip (flashrom supports a huge number of mainboards that need this, but each had to be added manually). but there are also some flash chips that can be locked by software which is done by the BIOS before the OS even loads (and there are various other schemes involving the chipset). the log you provided indicated that *if at all* there were only bits changed from 0 to 1 (by erasing whole blocks). this may have been because you rerun flashrom to obtain the log and the actual changes were done in an earlier run. flashrom would then skip every block that is already equal... > I never saw a checksum error after rebooting my > motherboard and I know that my BIOS defaults had been updated from the > factory defaults. > > I have since received some more Pm49FL004 chips from the same vendor with > a WinMate I370 BIOS load and flashing these chips with a different I370 > image works with flashrom-0.9.3 without any issues. this would OTOH indicate that there is no (hardware) write protection in place... i so am a bit puzzled ATM about what's the real issue (if there is any) and what happened exactly. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

Re: [flashrom] Erase Fails on Winmate I370 Motherboard with PMC Pm49FL004 Flash Chip
by Stefan Tauner 10 Dec '12

10 Dec '12

On Mon, 10 Dec 2012 10:44:01 -0500 sdbarnes(a)rockwellcollins.com wrote: > Despite the verification failure, the motherboard appears to function > properly with the new flash image that is written. Below is the flashrom > verbose output: > > > > flashrom v0.9.3-r1250 on Linux 2.6.32.59 (i686), built with libpci 3.1.7, > … > Found chip "PMC Pm49FL004" (512 KB, LPC,FWH) at physical address > 0xfff80000. > … > Erasing and writing flash chip... Looking at blockwise erase function 0... > trying... 0x000000-0x000fff:S, 0x001000-0x001fff:S, 0x002000-0x002fff:S, > 0x003000-0x003fff:S, 0x004000-0x004fff:S, 0x005000-0x005fff:S, > 0x006000-0x006fff:S, 0x007000-0x007fff:S, 0x008000-0x008fff:S, > 0x009000-0x009fff:S, 0x00a000-0x00afff:S, 0x00b000-0x00bfff:S, > 0x00c000-0x00cfff:S, 0x00d000-0x00dfff:S, 0x00e000-0x00efff:S, > 0x00f000-0x00ffff:S, 0x010000-0x010fff:S, 0x011000-0x011fff:S, > 0x012000-0x012fff:S, 0x013000-0x013fff:S, 0x014000-0x014fff:S, > 0x015000-0x015fff:S, 0x016000-0x016fff:S, 0x017000-0x017fff:S, > 0x018000-0x018fff:S, 0x019000-0x019fff:S, 0x01a000-0x01afff:S, > 0x01b000-0x01bfff:S, 0x01c000-0x01cfff:S, 0x01d000-0x01dfff:S, > 0x01e000-0x01efff:S, 0x01f000-0x01ffff:S, 0x020000-0x020fff:S, > 0x021000-0x021fff:S, 0x022000-0x022fff:S, 0x023000-0x023fff:S, > 0x024000-0x024fff:S, 0x025000-0x025fff:S, 0x026000-0x026fff:S, > 0x027000-0x027fff:S, 0x028000-0x028fff:S, 0x029000-0x029fff:S, > 0x02a000-0x02afff:S, 0x02b000-0x02bfff:S, 0x02c000-0x02cfff:S, > 0x02d000-0x02dfff:S, 0x02e000-0x02efff:S, 0x02f000-0x02ffff:S, > 0x030000-0x030fff:S, 0x031000-0x031fff:S, 0x032000-0x032fff:S, > 0x033000-0x033fff:S, 0x034000-0x034fff:S, 0x035000-0x035fff:S, > 0x036000-0x036fff:S, 0x037000-0x037fff:S, 0x038000-0x038fff:S, > 0x039000-0x039fff:S, 0x03a000-0x03afff:S, 0x03b000-0x03bfff:S, > 0x03c000-0x03cfff:S, 0x03d000-0x03dfff:S, 0x03e000-0x03efff:S, > 0x03f000-0x03ffff:S, 0x040000-0x040fff:S, 0x041000-0x041fff:S, > 0x042000-0x042fff:S, 0x043000-0x043fff:S, 0x044000-0x044fff:S, > 0x045000-0x045fff:S, 0x046000-0x046fff:S, 0x047000-0x047fff:S, > 0x048000-0x048fff:S, 0x049000-0x049fff:S, 0x04a000-0x04afff:S, > 0x04b000-0x04bfff:S, 0x04c000-0x04cfff:S, 0x04d000-0x04dfff:S, > 0x04e000-0x04efff:S, 0x04f000-0x04ffff:S, 0x050000-0x050fff:S, > 0x051000-0x051fff:S, 0x052000-0x052fff:S, 0x053000-0x053fff:S, > 0x054000-0x054fff:S, 0x055000-0x055fff:S, 0x056000-0x056fff:S, > 0x057000-0x057fff:S, 0x058000-0x058fff:S, 0x059000-0x059fff:S, > 0x05a000-0x05afff:S, 0x05b000-0x05bfff:S, 0x05c000-0x05cfff:S, > 0x05d000-0x05dfff:S, 0x05e000-0x05efff:S, 0x05f000-0x05ffff:S, > 0x060000-0x060fff:S, 0x061000-0x061fff:S, 0x062000-0x062fff:S, > 0x063000-0x063fff:S, 0x064000-0x064fff:S, 0x065000-0x065fff:S, > 0x066000-0x066fff:S, 0x067000-0x067fff:S, 0x068000-0x068fff:S, > 0x069000-0x069fff:S, 0x06a000-0x06afff:S, 0x06b000-0x06bfff:S, > 0x06c000-0x06cfff:S, 0x06d000-0x06dfff:S, 0x06e000-0x06efff:S, > 0x06f000-0x06ffff:S, 0x070000-0x070fff:EERASE FAILED at 0x00070002! > Expected=0xff, Read=0x00, failed byte count from 0x00070000-0x00070fff: > 0xf70 > ERASE FAILED! > > > Looking at blockwise erase function 1... trying... 0x000000-0x00ffff:S, > 0x010000-0x01ffff:S, 0x020000-0x02ffff:S, 0x030000-0x03ffff:S, > 0x040000-0x04ffff:S, 0x050000-0x05ffff:S, 0x060000-0x06ffff:S, > 0x070000-0x07ffff:EERASE FAILED at 0x00070002! Expected=0xff, Read=0x00, > failed byte count from 0x00070000-0x0007ffff: 0xfd35 > ERASE FAILED! > > > Looking at blockwise erase function 2... trying... > 0x000000-0x07ffff:EERASE FAILED at 0x00000000! Expected=0xff, Read=0x49, > failed byte count from 0x00000000-0x0007ffff: 0x53f0b > ERASE FAILED! > > > Looking at blockwise erase function 3... not defined. trying... > > Done. > Verifying flash... VERIFY FAILED at 0x0007010b! Expected=0x7c, Read=0x70, > failed byte count from 0x00000000-0x0007ffff: 0x9f2 > Your flash chip is in an unknown state. > Get help on IRC at irc.freenode.net (channel #flashrom) or > mail flashrom(a)flashrom.org with FAILED: your board name in the subject > line! > ------------------------------------------------------------------------------- > DO NOT REBOOT OR POWEROFF! > Restoring PCI config space for 00:1f:0 reg 0xdc i am not entirely sure, but i think 0.9.3 can not distinguish between an unknown state and the old, safe state the flash was before flashrom tried to erase. in your case it would be possible then that the whole flash chip is write protected and nothing changed/was deleted at all, which would explain the bootable condition of the system (i.e. you were lucky). if that is true we will need to add a small routine that disables the write protection on that mainboard (if there is no jumper oder bios option to do so). please send us the output of 'lspci -nn', 'lspci -nnvvvxxx', 'superiotool -deV' (run all commands as root), thanks. if not too much of a hassle you should also upgrade flashrom before further attempts. JFYI: your first message was stuck in the moderation queue because it was sent before you subscribed. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom