flashrom

flashrom@flashrom.org

5 participants
9161 discussions

[PATCH 5a/10] 4BA: W25Q256.V declaration update to work via direct funcs
by Boris Baykov 11 Jan '15

11 Jan '15

This patch doesn't work with W25Q256.V chip. DON'T try to use it! It's here just to show how new direct-4ba functions can be used to define new chips in the flashchips array. Patched files ------------- flashchips.c + modified definition of Winbond W25Q256BV/W25Q256FV chips Signed-off-by: Boris Baykov <dev(a)borisbaykov.com>, Russia, Jan 2014 --- diff -U 5 -N ./flashrom/flashchips.c ./flashrom-1868-4ba-5a/flashchips.c --- ./flashrom/flashchips.c 2015-01-11 02:03:38.000000000 +0300 +++ ./flashrom-1868-4ba-5a/flashchips.c 2015-01-10 19:17:40.000000000 +0300 @@ -13329,32 +13329,33 @@ .total_size = 32768, .page_size = 256, /* supports SFDP */ /* OTP: 1024B total, 256B reserved; read 0x48; write 0x42, erase 0x44, read ID 0x4B */ /* FOUR_BYTE_ADDR: supports 4-bytes addressing mode */ - .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_SUPPORT | FEATURE_4BA_DIRECT_READ, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_SUPPORT | FEATURE_4BA_DIRECT_READ + | FEATURE_4BA_DIRECT_WRITE | FEATURE_4BA_ALL_ERASERS_DIRECT, .four_bytes_addr_funcs = { - .enter_4ba = spi_enter_4ba_b7_we, /* enter 4-bytes addressing mode by CMD B7 + WREN */ - .read_nbyte = spi_nbyte_read_4ba_direct, /* read directly from any mode, no need to enter 4ba */ - .program_byte = spi_byte_program_4ba, /* write from 4-bytes addressing mode */ - .program_nbyte = spi_nbyte_program_4ba /* write from 4-bytes addressing mode */ + .enter_4ba = NULL, /* no need to enter 4-bytes addressing mode */ + .read_nbyte = spi_nbyte_read_4ba_direct, /* read from any mode, no need to enter 4ba */ + .program_byte = spi_byte_program_4ba_direct, /* write from any mode, no need to enter 4ba */ + .program_nbyte = spi_nbyte_program_4ba_direct /* write from any mode, no need to enter 4ba */ }, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = { { .eraseblocks = { {4 * 1024, 8192} }, - .block_erase = spi_block_erase_20_4ba, /* erases 4k from 4-bytes addressing mode */ + .block_erase = spi_block_erase_21_4ba_direct, /* erases 4k from any mode */ }, { .eraseblocks = { {32 * 1024, 1024} }, - .block_erase = spi_block_erase_52_4ba, /* erases 32k from 4-bytes addressing mode */ + .block_erase = spi_block_erase_5c_4ba_direct, /* erases 32k from any mode */ }, { .eraseblocks = { {64 * 1024, 512} }, - .block_erase = spi_block_erase_d8_4ba, /* erases 64k from 4-bytes addressing mode */ + .block_erase = spi_block_erase_dc_4ba_direct, /* erases 64k from any mode */ }, { .eraseblocks = { {32 * 1024 * 1024, 1} }, .block_erase = spi_block_erase_60, }, { .eraseblocks = { {32 * 1024 * 1024, 1} },

1 0

[PATCH 2/10] 4BA: Flashrom integration for the 4-bytes addressing extensions
by Boris Baykov 11 Jan '15

11 Jan '15

This patch integrates code of the previous patch into Flashrom's code. All the integrations is around 3 functions spi_nbyte_read, spi_nbyte_program and spi_byte_program. After this patch then are not static and can be called by their pointers saved in flashchips array. Also I added to flashrom.c some code to switch a chip to 4-bytes addressing mode. And one error message is corrected in spi.c because it's not suitable for 32-bit addresses. Patched files ------------- flash.h + added set of 4-bytes address functions to flashchip structure definition flashrom.c + added switch to 4-bytes addressing more for chips which support it serprog.c + added 4-bytes addressing spi_nbyte_read call to serprog_spi_read spi.c + fixed flash chip size check in spi_chip_read spi25.c + added 4-bytes addressing spi_nbyte_read call to spi_read_chunked + added 4-bytes addressing spi_nbyte_program call to spi_write_chunked + added 4-bytes addressing spi_byte_program call to spi_chip_write_1 Signed-off-by: Boris Baykov <dev(a)borisbaykov.com>, Russia, Jan 2014 --- diff -U 5 -N ./flashrom/flash.h ./flashrom-1868-4ba-2/flash.h --- ./flashrom/flash.h 2015-01-11 01:55:15.000000000 +0300 +++ ./flashrom-1868-4ba-2/flash.h 2015-01-10 18:59:50.000000000 +0300 @@ -168,10 +168,18 @@ unsigned int total_size; /* Chip page size in bytes */ unsigned int page_size; int feature_bits; + /* set of function pointers to use in 4-bytes addressing mode */ + struct four_bytes_addr_funcs_set { + int (*enter_4ba) (struct flashctx *flash); + int (*read_nbyte) (struct flashctx *flash, unsigned int addr, uint8_t *bytes, unsigned int len); + int (*program_byte) (struct flashctx *flash, unsigned int addr, const uint8_t databyte); + int (*program_nbyte) (struct flashctx *flash, unsigned int addr, const uint8_t *bytes, unsigned int len); + } four_bytes_addr_funcs; + /* Indicate how well flashrom supports different operations of this flash chip. */ struct tested { enum test_state probe; enum test_state read; enum test_state erase; diff -U 5 -N ./flashrom/flashrom.c ./flashrom-1868-4ba-2/flashrom.c --- ./flashrom/flashrom.c 2015-01-11 01:55:15.000000000 +0300 +++ ./flashrom-1868-4ba-2/flashrom.c 2015-01-10 15:42:06.000000000 +0300 @@ -1934,10 +1934,33 @@ * erase and write. */ if (flash->chip->unlock) flash->chip->unlock(flash); + /* Switching to 4-Bytes Addressing mode if flash chip supports it */ + if(flash->chip->feature_bits & FEATURE_4BA_SUPPORT) { + /* Do not switch if chip is already in 4-bytes addressing mode */ + if (flash->chip->feature_bits & FEATURE_4BA_ONLY) { + msg_cdbg("Flash chip is already in 4-bytes addressing mode.\n"); + } + /* Go to 4-Bytes Addressing mode */ + else { + if (!flash->chip->four_bytes_addr_funcs.enter_4ba) { + msg_cerr("No function for Enter 4-bytes addressing mode for this flash chip.\n" + "Please report to flashrom(a)flashrom.org\n"); + return 1; + } + + if(flash->chip->four_bytes_addr_funcs.enter_4ba(flash)) { + msg_cerr("Switching to 4-bytes addressing mode failed!\n"); + return 1; + } + + msg_cdbg("Switched to 4-bytes addressing mode.\n"); + } + } + if (read_it) { return read_flash_to_file(flash, filename); } oldcontents = malloc(size); diff -U 5 -N ./flashrom/serprog.c ./flashrom-1868-4ba-2/serprog.c --- ./flashrom/serprog.c 2015-01-11 01:55:15.000000000 +0300 +++ ./flashrom-1868-4ba-2/serprog.c 2015-01-10 18:43:32.000000000 +0300 @@ -935,11 +935,14 @@ unsigned int i, cur_len; const unsigned int max_read = spi_master_serprog.max_data_read; for (i = 0; i < len; i += cur_len) { int ret; cur_len = min(max_read, (len - i)); - ret = spi_nbyte_read(flash, start + i, buf + i, cur_len); + ret = (flash->chip->feature_bits & FEATURE_4BA_SUPPORT) == 0 + ? spi_nbyte_read(flash, start + i, buf + i, cur_len) + : flash->chip->four_bytes_addr_funcs.read_nbyte(flash, + start + i, buf + i, cur_len); if (ret) return ret; } return 0; } diff -U 5 -N ./flashrom/spi25.c ./flashrom-1868-4ba-2/spi25.c --- ./flashrom/spi25.c 2015-01-11 01:55:15.000000000 +0300 +++ ./flashrom-1868-4ba-2/spi25.c 2015-01-10 18:42:42.000000000 +0300 @@ -26,10 +26,11 @@ #include "flash.h" #include "flashchips.h" #include "chipdrivers.h" #include "programmer.h" #include "spi.h" +#include "spi4ba.h" static int spi_rdid(struct flashctx *flash, unsigned char *readarr, int bytes) { static const unsigned char cmd[JEDEC_RDID_OUTSIZE] = { JEDEC_RDID }; int ret; @@ -964,11 +965,14 @@ starthere = max(start, i * page_size); /* Length of bytes in the range in this page. */ lenhere = min(start + len, (i + 1) * page_size) - starthere; for (j = 0; j < lenhere; j += chunksize) { toread = min(chunksize, lenhere - j); - rc = spi_nbyte_read(flash, starthere + j, buf + starthere - start + j, toread); + rc = (flash->chip->feature_bits & FEATURE_4BA_SUPPORT) == 0 + ? spi_nbyte_read(flash, starthere + j, buf + starthere - start + j, toread) + : flash->chip->four_bytes_addr_funcs.read_nbyte(flash, starthere + j, + buf + starthere - start + j, toread); if (rc) break; } if (rc) break; @@ -1009,11 +1013,14 @@ starthere = max(start, i * page_size); /* Length of bytes in the range in this page. */ lenhere = min(start + len, (i + 1) * page_size) - starthere; for (j = 0; j < lenhere; j += chunksize) { towrite = min(chunksize, lenhere - j); - rc = spi_nbyte_program(flash, starthere + j, buf + starthere - start + j, towrite); + rc = (flash->chip->feature_bits & FEATURE_4BA_SUPPORT) == 0 + ? spi_nbyte_program(flash, starthere + j, buf + starthere - start + j, towrite) + : flash->chip->four_bytes_addr_funcs.program_nbyte(flash, starthere + j, + buf + starthere - start + j, towrite); if (rc) break; while (spi_read_status_register(flash) & SPI_SR_WIP) programmer_delay(10); } @@ -1035,11 +1042,13 @@ { unsigned int i; int result = 0; for (i = start; i < start + len; i++) { - result = spi_byte_program(flash, i, buf[i - start]); + result = (flash->chip->feature_bits & FEATURE_4BA_SUPPORT) == 0 + ? spi_byte_program(flash, i, buf[i - start]) + : flash->chip->four_bytes_addr_funcs.program_byte(flash, i, buf[i - start]); if (result) return 1; while (spi_read_status_register(flash) & SPI_SR_WIP) programmer_delay(10); } diff -U 5 -N ./flashrom/spi.c ./flashrom-1868-4ba-2/spi.c --- ./flashrom/spi.c 2015-01-11 01:55:15.000000000 +0300 +++ ./flashrom-1868-4ba-2/spi.c 2015-01-10 18:39:45.000000000 +0300 @@ -108,11 +108,14 @@ /* Check if the chip fits between lowest valid and highest possible * address. Highest possible address with the current SPI implementation * means 0xffffff, the highest unsigned 24bit number. */ addrbase = spi_get_valid_read_addr(flash); - if (addrbase + flash->chip->total_size * 1024 > (1 << 24)) { + /* Show flash chip size warning if flash chip doesn't support + 4-Bytes Addressing mode and last address excedes 24 bits */ + if (!(flash->chip->feature_bits & FEATURE_4BA_SUPPORT) && + addrbase + flash->chip->total_size * 1024 > (1 << 24)) { msg_perr("Flash chip size exceeds the allowed access window. "); msg_perr("Read will probably fail.\n"); /* Try to get the best alignment subject to constraints. */ addrbase = (1 << 24) - flash->chip->total_size * 1024; }

1 0

[PATCH 3/10] 4BA: Winbond W25Q256.V chip (32MB) declaration, 4-bytes addr mode
by Boris Baykov 11 Jan '15

11 Jan '15

Here is the definition of new W25Q256xV chip with new functions pointers for 4-bytes addressing reads and writes. Erase functions pointers are changed in their old places. New feature flags for 4-bytes mode added. Patched files ------------- flashchips.c + added definition for Winbond W25Q256BV/W25Q256FV chips Signed-off-by: Boris Baykov <dev(a)borisbaykov.com>, Russia, Jan 2014 --- diff -U 5 -N ./flashrom/flashchips.c ./flashrom-1868-4ba-3/flashchips.c --- ./flashrom/flashchips.c 2015-01-11 01:55:15.000000000 +0300 +++ ./flashrom-1868-4ba-3/flashchips.c 2015-01-10 19:14:01.000000000 +0300 @@ -13320,10 +13320,58 @@ .voltage = {2700, 3600}, }, { .vendor = "Winbond", + .name = "W25Q256.V", + .bustype = BUS_SPI, + .manufacture_id = WINBOND_NEX_ID, + .model_id = WINBOND_NEX_W25Q256_V, + .total_size = 32768, + .page_size = 256, + /* supports SFDP */ + /* OTP: 1024B total, 256B reserved; read 0x48; write 0x42, erase 0x44, read ID 0x4B */ + /* FOUR_BYTE_ADDR: supports 4-bytes addressing mode */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_SUPPORT, + .four_bytes_addr_funcs = + { + .enter_4ba = spi_enter_4ba_b7_we, /* enter 4-bytes addressing mode by CMD B7 + WREN */ + .read_nbyte = spi_nbyte_read_4ba, /* read from 4-bytes addressing mode */ + .program_byte = spi_byte_program_4ba, /* write from 4-bytes addressing mode */ + .program_nbyte = spi_nbyte_program_4ba /* write from 4-bytes addressing mode */ + }, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 8192} }, + .block_erase = spi_block_erase_20_4ba, /* erases 4k from 4-bytes addressing mode */ + }, { + .eraseblocks = { {32 * 1024, 1024} }, + .block_erase = spi_block_erase_52_4ba, /* erases 32k from 4-bytes addressing mode */ + }, { + .eraseblocks = { {64 * 1024, 512} }, + .block_erase = spi_block_erase_d8_4ba, /* erases 64k from 4-bytes addressing mode */ + }, { + .eraseblocks = { {32 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {32 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_plain, /* TODO: improve */ + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2700, 3600}, + }, + + { + .vendor = "Winbond", .name = "W25Q20.W", .bustype = BUS_SPI, .manufacture_id = WINBOND_NEX_ID, .model_id = WINBOND_NEX_W25Q20_W, .total_size = 256,

1 0

[PATCH 4a/10] 4BA: W25Q256.V declaration update to work using Extended Address.Register
by Boris Baykov 11 Jan '15

11 Jan '15

The 4a patch is made to show how can you define chips with access via Extebded Address Register. This patch is fully working but not required. Patched files ------------- flashchips.c + modified definition of Winbond W25Q256BV/W25Q256FV chips Signed-off-by: Boris Baykov <dev(a)borisbaykov.com>, Russia, Jan 2014 --- diff -U 5 -N ./flashrom/flashchips.c ./flashrom-1868-4ba-4a/flashchips.c --- ./flashrom/flashchips.c 2015-01-11 02:03:38.000000000 +0300 +++ ./flashrom-1868-4ba-4a/flashchips.c 2015-01-10 19:23:32.000000000 +0300 @@ -13329,32 +13329,33 @@ .total_size = 32768, .page_size = 256, /* supports SFDP */ /* OTP: 1024B total, 256B reserved; read 0x48; write 0x42, erase 0x44, read ID 0x4B */ /* FOUR_BYTE_ADDR: supports 4-bytes addressing mode */ - .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_SUPPORT, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_SUPPORT + | FEATURE_4BA_EXTENDED_ADDR_REG, .four_bytes_addr_funcs = { - .enter_4ba = spi_enter_4ba_b7_we, /* enter 4-bytes addressing mode by CMD B7 + WREN */ - .read_nbyte = spi_nbyte_read_4ba, /* read from 4-bytes addressing mode */ - .program_byte = spi_byte_program_4ba, /* write from 4-bytes addressing mode */ - .program_nbyte = spi_nbyte_program_4ba /* write from 4-bytes addressing mode */ + .enter_4ba = NULL, /* no need to enter 4-bytes addressing mode */ + .read_nbyte = spi_nbyte_read_4ba_ereg, /* read using ext.addr.reg from 3-bytes mode */ + .program_byte = spi_byte_program_4ba_ereg, /* write using ext.addr.reg from 3-bytes mode */ + .program_nbyte = spi_nbyte_program_4ba_ereg /* write using ext.addr.reg from 3-bytes mode */ }, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = { { .eraseblocks = { {4 * 1024, 8192} }, - .block_erase = spi_block_erase_20_4ba, /* erases 4k from 4-bytes addressing mode */ + .block_erase = spi_block_erase_20_4ba_ereg, /* erases 4k using ext.addr.reg from 3-bytes mode */ }, { .eraseblocks = { {32 * 1024, 1024} }, - .block_erase = spi_block_erase_52_4ba, /* erases 32k from 4-bytes addressing mode */ + .block_erase = spi_block_erase_52_4ba_ereg, /* erases 32k using ext.addr.reg from 3-bytes mode */ }, { .eraseblocks = { {64 * 1024, 512} }, - .block_erase = spi_block_erase_d8_4ba, /* erases 64k from 4-bytes addressing mode */ + .block_erase = spi_block_erase_d8_4ba_ereg, /* erases 64k using ext.addr.reg from 3-bytes mode */ }, { .eraseblocks = { {32 * 1024 * 1024, 1} }, .block_erase = spi_block_erase_60, }, { .eraseblocks = { {32 * 1024 * 1024, 1} },

1 0

[PATCH 10/10] 4BA: Some small visual changes for 4-byte addresses
by Boris Baykov 11 Jan '15

11 Jan '15

Reason to patch: %06x isn't enough to show 32-bit address. Patched files ------------- flashrom.c + changed in address print %06x to %08x for support of 32MB+ chips Signed-off-by: Boris Baykov <dev(a)borisbaykov.com>, Russia, Jan 2014 --- diff -U 5 -N ./flashrom/flashrom.c ./flashrom-1868-4ba-A/flashrom.c --- ./flashrom/flashrom.c 2015-01-11 01:55:16.000000000 +0300 +++ ./flashrom-1868-4ba-A/flashrom.c 2015-01-10 18:48:45.000000000 +0300 @@ -1366,12 +1366,12 @@ "non-empty erase function. Not an error.\n"); if (!done) continue; if (done != chip->total_size * 1024) { msg_gerr("ERROR: Flash chip %s erase function %i " - "region walking resulted in 0x%06x bytes total," - " expected 0x%06x bytes. Please report a bug at" + "region walking resulted in 0x%08x bytes total," + " expected 0x%08x bytes. Please report a bug at" " flashrom(a)flashrom.org\n", chip->name, k, done, chip->total_size * 1024); ret = 1; } if (!eraser.block_erase) @@ -1481,11 +1481,11 @@ len = eraser.eraseblocks[i].size; for (j = 0; j < eraser.eraseblocks[i].count; j++) { /* Print this for every block except the first one. */ if (i || j) msg_cdbg(", "); - msg_cdbg("0x%06x-0x%06x", start, + msg_cdbg("0x%08x-0x%08x", start, start + len - 1); if (do_something(flash, start, len, param1, param2, eraser.block_erase)) { return 1; }

1 0

Re: [flashrom] support for flashrom@flashrom.org
by Stefan Tauner 10 Jan '15

10 Jan '15

On Sat, 10 Jan 2015 20:13:49 +0200 Marius Cirsta <mforce2(a)gmail.com> wrote: > Hi, > > I have a HP DL365 G1 server and I found that it has a Spansion > S29GL032M90TFIR3 flash chip. I was support was introduced for some > similar flash chips but the ones from Spansion are still not > supported. > > Any difficulty in adding support for this one ? If needed I can try > and add support myself. I'm also willing to test it on my server ( at > least read, maybe even write ). Hi Marius, I have added support for other 29GL chips in r1835. I can not remember why I have left out those from Spansion... I guess because there were so many and I got fed up with it at the time :) I can't remember any specific problems with them, so adding should be relatively simply. I have even added the chip IDs to flashchips.h so you would only need to add the respective definitions to flashchips.c. If everything works as planned and I have not forgotten some hiding dragons... ;) -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

support for flashrom@flashrom.org
by Marius Cirsta 10 Jan '15

10 Jan '15

Hi, I have a HP DL365 G1 server and I found that it has a Spansion S29GL032M90TFIR3 flash chip. I was support was introduced for some similar flash chips but the ones from Spansion are still not supported. Any difficulty in adding support for this one ? If needed I can try and add support myself. I'm also willing to test it on my server ( at least read, maybe even write ).

1 0

Re: [flashrom] Add new Macronix MX25L6495F support
by Stefan Tauner 10 Jan '15

10 Jan '15

On Wed, 15 Oct 2014 18:13:54 +0800 alexlu6(a)mxic.com.tw wrote: > > Dear sirs, > > This mail comes from Macronix to add the new MX25L6495F flash chip > support > in the flashrom project in order to help the adoption of the chip for > Google Chromium OS. > Please help to review it. Thanks a lot! Hello Alex, I'd like to add support for this chip to vanilla flashrom as well but could not find a public datasheet to add a few additional bits. Will this chip and a respective datasheet be available publicly? -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 3

[commit] r1868 - trunk
by repository service 10 Jan '15

10 Jan '15

Author: stefanct Date: Sat Jan 10 16:59:54 2015 New Revision: 1868 URL: http://flashrom.org/trac/flashrom/changeset/1868 Log: Fix support for Macronix MX25L6495F. Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Acked-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Modified: trunk/flashchips.c Modified: trunk/flashchips.c ============================================================================== --- trunk/flashchips.c Sat Jan 10 10:33:14 2015 (r1867) +++ trunk/flashchips.c Sat Jan 10 16:59:54 2015 (r1868) @@ -7280,6 +7280,7 @@ }, { + .vendor = "Macronix", .name = "MX25L6495F", .bustype = BUS_SPI, .manufacture_id = MACRONIX_ID,

1 0

Re: [flashrom] [PATCH 0/5] Cross Compilation Refinements
by Stefan Tauner 10 Jan '15

10 Jan '15

On Mon, 5 Jan 2015 01:12:38 +0100 Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> wrote: > I have created some cross compilation fixes while working on the buildbot. > Most of them are compile-tested apart from the following platforms: > - Solaris (I could not get any variant to install in VirtualBox on > ESXi in a timely manner). > - MIPS no cross compiler binary package available at buildbot host > - SPARC is currently also untested. No intended changes there though. Committed in r1862-r1866. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom