- flashrom - mail.coreboot.org

W836xx: your board name: flashrom -V
by Mohit Keswani 05 Dec '15

05 Dec '15

Output for flashrom attached. Please support my board. I;ve bought the latest lenovo y700.

1 0

Re: [flashrom] Ch431 programmer
by Stefan Tauner 04 Dec '15

04 Dec '15

On Tue, 1 Dec 2015 09:25:46 +0200 Ran Weizman <ranwzmn(a)gmail.com> wrote: > Hi > Thanks a lot, unfortunately my chip model is not supported by Flashrom. And that won't change if you don't tell us what model it is :) -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 2

[PATCH 0/1] Add support for reading the current flash contents from a file
by Paul Kocialkowski 04 Dec '15

04 Dec '15

Here is an example script that I'm using to read the flash contents to a file once and update it as I flash newer versions of the software: #!/bin/sh flashrom="flashrom" programmer="ft2232_spi:type=openmoko,divisor=8" contents="~/flash-contents.img" image="$1" if [ -z $image ] then echo "Reading initial flash contents" timeb=$( date +%s ) $flashrom -p $programmer -r $contents timea=$( date +%s ) echo "Time: "$(( $timea - $timeb ))" seconds" else echo "Writing new flash contents" timeb=$( date +%s ) $flashrom -p $programmer -w $image -C $contents --noverify timea=$( date +%s ) cp $image $contents echo "Time: "$(( $timea - $timeb ))" seconds" fi

1 1

[PATCH v3 1/2] Add support for selecting the erased bit value with a flag
by Paul Kocialkowski 03 Dec '15

03 Dec '15

Most flash chips are erased to ones and programmed to zeros. However, some other flash chips, such as the ENE KB9012 internal flash, work the opposite way. Signed-off-by: Paul Kocialkowski <contact(a)paulk.fr> --- flash.h | 5 ++++- flashrom.c | 39 +++++++++++++++++++++------------------ 2 files changed, 25 insertions(+), 19 deletions(-) diff --git a/flash.h b/flash.h index 24861ba..8d557fe 100644 --- a/flash.h +++ b/flash.h @@ -123,6 +123,9 @@ enum write_granularity { #define FEATURE_WRSR_EITHER (FEATURE_WRSR_EWSR | FEATURE_WRSR_WREN) #define FEATURE_OTP (1 << 8) #define FEATURE_QPI (1 << 9) +#define FEATURE_ERASED_ZERO (1 << 10) + +#define ERASED_VALUE(flash) (((flash)->chip->feature_bits & FEATURE_ERASED_ZERO) ? 0x00 : 0xff) enum test_state { OK = 0, @@ -275,7 +278,7 @@ int probe_flash(struct registered_master *mst, int startchip, struct flashctx *f int read_flash_to_file(struct flashctx *flash, const char *filename); char *extract_param(const char *const *haystack, const char *needle, const char *delim); int verify_range(struct flashctx *flash, const uint8_t *cmpbuf, unsigned int start, unsigned int len); -int need_erase(const uint8_t *have, const uint8_t *want, unsigned int len, enum write_granularity gran); +int need_erase(const uint8_t *have, const uint8_t *want, unsigned int len, enum write_granularity gran, const uint8_t erased_value); void print_version(void); void print_buildinfo(void); void print_banner(void); diff --git a/flashrom.c b/flashrom.c index c9c7e31..bd8ef3f 100644 --- a/flashrom.c +++ b/flashrom.c @@ -673,12 +673,13 @@ int check_erased_range(struct flashctx *flash, unsigned int start, { int ret; uint8_t *cmpbuf = malloc(len); + const uint8_t erased_value = ERASED_VALUE(flash); if (!cmpbuf) { msg_gerr("Could not allocate memory!\n"); exit(1); } - memset(cmpbuf, 0xff, len); + memset(cmpbuf, erased_value, len); ret = verify_range(flash, cmpbuf, start, len); free(cmpbuf); return ret; @@ -731,7 +732,7 @@ out_free: } /* Helper function for need_erase() that focuses on granularities of gran bytes. */ -static int need_erase_gran_bytes(const uint8_t *have, const uint8_t *want, unsigned int len, unsigned int gran) +static int need_erase_gran_bytes(const uint8_t *have, const uint8_t *want, unsigned int len, unsigned int gran, const uint8_t erased_value) { unsigned int i, j, limit; for (j = 0; j < len / gran; j++) { @@ -741,7 +742,7 @@ static int need_erase_gran_bytes(const uint8_t *have, const uint8_t *want, unsig continue; /* have needs to be in erased state. */ for (i = 0; i < limit; i++) - if (have[j * gran + i] != 0xff) + if (have[j * gran + i] != erased_value) return 1; } return 0; @@ -761,7 +762,7 @@ static int need_erase_gran_bytes(const uint8_t *have, const uint8_t *want, unsig * @gran write granularity (enum, not count) * @return 0 if no erase is needed, 1 otherwise */ -int need_erase(const uint8_t *have, const uint8_t *want, unsigned int len, enum write_granularity gran) +int need_erase(const uint8_t *have, const uint8_t *want, unsigned int len, enum write_granularity gran, const uint8_t erased_value) { int result = 0; unsigned int i; @@ -776,31 +777,31 @@ int need_erase(const uint8_t *have, const uint8_t *want, unsigned int len, enum break; case write_gran_1byte: for (i = 0; i < len; i++) - if ((have[i] != want[i]) && (have[i] != 0xff)) { + if ((have[i] != want[i]) && (have[i] != erased_value)) { result = 1; break; } break; case write_gran_128bytes: - result = need_erase_gran_bytes(have, want, len, 128); + result = need_erase_gran_bytes(have, want, len, 128, erased_value); break; case write_gran_256bytes: - result = need_erase_gran_bytes(have, want, len, 256); + result = need_erase_gran_bytes(have, want, len, 256, erased_value); break; case write_gran_264bytes: - result = need_erase_gran_bytes(have, want, len, 264); + result = need_erase_gran_bytes(have, want, len, 264, erased_value); break; case write_gran_512bytes: - result = need_erase_gran_bytes(have, want, len, 512); + result = need_erase_gran_bytes(have, want, len, 512, erased_value); break; case write_gran_528bytes: - result = need_erase_gran_bytes(have, want, len, 528); + result = need_erase_gran_bytes(have, want, len, 528, erased_value); break; case write_gran_1024bytes: - result = need_erase_gran_bytes(have, want, len, 1024); + result = need_erase_gran_bytes(have, want, len, 1024, erased_value); break; case write_gran_1056bytes: - result = need_erase_gran_bytes(have, want, len, 1056); + result = need_erase_gran_bytes(have, want, len, 1056, erased_value); break; case write_gran_1byte_implicit_erase: /* Do not erase, handle content changes from anything->0xff by writing 0xff. */ @@ -1424,6 +1425,7 @@ static int erase_and_write_block_helper(struct flashctx *flash, unsigned int starthere = 0, lenhere = 0; int ret = 0, skip = 1, writecount = 0; enum write_granularity gran = flash->chip->gran; + const uint8_t erased_value = ERASED_VALUE(flash); /* curcontents and newcontents are opaque to walk_eraseregions, and * need to be adjusted here to keep the impression of proper abstraction @@ -1431,7 +1433,7 @@ static int erase_and_write_block_helper(struct flashctx *flash, curcontents += start; newcontents += start; msg_cdbg(":"); - if (need_erase(curcontents, newcontents, len, gran)) { + if (need_erase(curcontents, newcontents, len, gran, erased_value)) { msg_cdbg("E"); ret = erasefn(flash, start, len); if (ret) @@ -1441,7 +1443,7 @@ static int erase_and_write_block_helper(struct flashctx *flash, return -1; } /* Erase was successful. Adjust curcontents. */ - memset(curcontents, 0xff, len); + memset(curcontents, erased_value, len); skip = 0; } /* get_next_write() sets starthere to a new value after the call. */ @@ -1938,6 +1940,7 @@ int doit(struct flashctx *flash, int force, const char *filename, int read_it, int ret = 0; unsigned long size = flash->chip->total_size * 1024; int read_all_first = 1; /* FIXME: Make this configurable. */ + const uint8_t erased_value = ERASED_VALUE(flash); if (chip_safety_check(flash, force, read_it, write_it, erase_it, verify_it)) { msg_cerr("Aborting.\n"); @@ -1964,15 +1967,15 @@ int doit(struct flashctx *flash, int force, const char *filename, int read_it, msg_gerr("Out of memory!\n"); exit(1); } - /* Assume worst case: All bits are 0. */ - memset(oldcontents, 0x00, size); + /* Assume worst case: All bits are not erased. */ + memset(oldcontents, ~erased_value, size); newcontents = malloc(size); if (!newcontents) { msg_gerr("Out of memory!\n"); exit(1); } - /* Assume best case: All bits should be 1. */ - memset(newcontents, 0xff, size); + /* Assume best case: All bits should be erased. */ + memset(newcontents, erased_value, size); /* Side effect of the assumptions above: Default write action is erase * because newcontents looks like a completely erased chip, and * oldcontents being completely 0x00 means we have to erase everything -- 1.9.1

2 5

Re: [flashrom] Ch431 programmer
by Stefan Tauner 01 Dec '15

01 Dec '15

On Thu, 26 Nov 2015 00:31:02 +0200 Ran Weizman <ranwzmn(a)gmail.com> wrote: > Hi, I have the CH341, device with version4.03, is Flashrom gonna support it > in the future ? > Can I help with something ? (I'm not a dev just Linux user. ) > Thanks > Ran Hi Ran, yes, and yes. You can test the existing patch for that programmer, see http://www.flashrom.org/pipermail/flashrom/2015-November/014009.html -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

2 1

Re: [flashrom] [PATCH] Rigorously check integrity of I/O stream data.
by Urja Rannikko 29 Nov '15

29 Nov '15

Hi, On Sun, Nov 22, 2015 at 7:43 PM, Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> wrote: > Even if fwrite() succeeds the data is not necessarily out of the clib's buffers > and writing it eventually could fail. Even if the data is flushed out (explicitly by > fflush() or implicitly by fclose()) the kernel might still hold a buffer. > > Previously we have ignored this to a large extent - even in important cases > like writing the flash contents to a file. The results can be truncated > images that would brick the respective machine if written back as is (though > flashrom would not allow that due to a size mismatch). flashrom would not > indicate the problem in any output - so far we only check the return value > of fwrite() that is not conclusive. > > This patch checks the return values of all related system calls like fclose() > unless we only read the file and are not really interested in output errors. > In the latter case the return value is casted to void to document this fact. > Additionally, this patch explicitly calls fflush() and fsync() (on regular files only) > to do the best we can to guarantee the read image reaches the disk safely. > > Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> > --- > flashrom.c | 67 +++++++++++++++++++++++++++++++++++++----------------- > layout.c | 6 ++--- > processor_enable.c | 4 ++-- > 3 files changed, 51 insertions(+), 26 deletions(-) > > diff --git a/flashrom.c b/flashrom.c > index c9c7e31..6e5fd68 100644 > --- a/flashrom.c > +++ b/flashrom.c > @@ -28,6 +28,7 @@ > #include <sys/stat.h> > #endif > #include <string.h> > +#include <unistd.h> > #include <stdlib.h> > #include <errno.h> > #include <ctype.h> > @@ -1255,36 +1256,39 @@ int read_buf_from_file(unsigned char *buf, unsigned long size, > msg_gerr("Error: No file I/O support in libpayload\n"); > return 1; > #else > - unsigned long numbytes; > - FILE *image; > - struct stat image_stat; > + int ret = 0; > > + FILE *image; > if ((image = fopen(filename, "rb")) == NULL) { > msg_gerr("Error: opening file \"%s\" failed: %s\n", filename, strerror(errno)); > return 1; > } > + > + struct stat image_stat; > if (fstat(fileno(image), &image_stat) != 0) { > msg_gerr("Error: getting metadata of file \"%s\" failed: %s\n", filename, strerror(errno)); > - fclose(image); > - return 1; > + ret = 1; > + goto out; > } > if (image_stat.st_size != size) { > msg_gerr("Error: Image size (%jd B) doesn't match the flash chip's size (%lu B)!\n", > (intmax_t)image_stat.st_size, size); > - fclose(image); > - return 1; > - } > - numbytes = fread(buf, 1, size, image); > - if (fclose(image)) { > - msg_gerr("Error: closing file \"%s\" failed: %s\n", filename, strerror(errno)); > - return 1; > + ret = 1; > + goto out; > } > + > + unsigned long numbytes = fread(buf, 1, size, image); > if (numbytes != size) { > msg_gerr("Error: Failed to read complete file. Got %ld bytes, " > "wanted %ld!\n", numbytes, size); > - return 1; > + ret = 1; > } > - return 0; > +out: > + if (fclose(image)) { > + msg_gerr("Error: closing file \"%s\" failed: %s\n", filename, strerror(errno)); > + ret = 1; > + } > + return ret; > #endif > } Why do this goto stuff and fclose fail reporting to read_buf_from_file? I'd suggest same handling as below for layout files etc (= (void)fclose()). > > @@ -1294,8 +1298,8 @@ int write_buf_to_file(const unsigned char *buf, unsigned long size, const char * > msg_gerr("Error: No file I/O support in libpayload\n"); > return 1; > #else > - unsigned long numbytes; > FILE *image; > + int ret = 0; > > if (!filename) { > msg_gerr("No filename specified.\n"); > @@ -1306,14 +1310,35 @@ int write_buf_to_file(const unsigned char *buf, unsigned long size, const char * > return 1; > } > > - numbytes = fwrite(buf, 1, size, image); > - fclose(image); > + unsigned long numbytes = fwrite(buf, 1, size, image); > if (numbytes != size) { > - msg_gerr("File %s could not be written completely.\n", > - filename); > - return 1; > + msg_gerr("Error: file %s could not be written completely.\n", filename); > + ret = 1; > + goto out; > } > - return 0; > + if (fflush(image)) { > + msg_gerr("Error: flushing file \"%s\" failed: %s\n", filename, strerror(errno)); > + ret = 1; > + } > + struct stat image_stat; > + if (fstat(fileno(image), &image_stat) != 0) { > + msg_gerr("Error: getting metadata of file \"%s\" failed: %s\n", filename, strerror(errno)); > + ret = 1; > + goto out; > + } > + /* Try to fsync only regular files. */ > + if (S_ISREG(image_stat.st_mode)) { > + if (fsync(fileno(image))) { > + msg_gerr("Error: fsyncing file \"%s\" failed: %s\n", filename, strerror(errno)); > + ret = 1; > + } > + } > +out: > + if (fclose(image)) { > + msg_gerr("Error: closing file \"%s\" failed: %s\n", filename, strerror(errno)); > + ret = 1; > + } > + return ret; > #endif > } > > diff --git a/layout.c b/layout.c > index 0b9f6e5..d039451 100644 > --- a/layout.c > +++ b/layout.c > @@ -65,7 +65,7 @@ int read_romlayout(const char *name) > if (num_rom_entries >= MAX_ROMLAYOUT) { > msg_gerr("Maximum number of ROM images (%i) in layout " > "file reached.\n", MAX_ROMLAYOUT); > - fclose(romlayout); > + (void)fclose(romlayout); > return 1; > } > if (2 != fscanf(romlayout, "%s %s\n", tempstr, rom_entries[num_rom_entries].name)) > @@ -80,7 +80,7 @@ int read_romlayout(const char *name) > tstr2 = strtok(NULL, ":"); > if (!tstr1 || !tstr2) { > msg_gerr("Error parsing layout file. Offending string: \"%s\"\n", tempstr); > - fclose(romlayout); > + (void)fclose(romlayout); > return 1; > } > rom_entries[num_rom_entries].start = strtol(tstr1, (char **)NULL, 16); > @@ -95,7 +95,7 @@ int read_romlayout(const char *name) > rom_entries[i].end, rom_entries[i].name); > } > > - fclose(romlayout); > + (void)fclose(romlayout); > > return 0; > } > diff --git a/processor_enable.c b/processor_enable.c > index 1361dd5..117aa1e 100644 > --- a/processor_enable.c > +++ b/processor_enable.c > @@ -57,11 +57,11 @@ static int is_loongson(void) > ptr++; > while (*ptr && isspace((unsigned char)*ptr)) > ptr++; > - fclose(cpuinfo); > + (void)fclose(cpuinfo); > return (strncmp(ptr, "ICT Loongson-2 V0.3", strlen("ICT Loongson-2 V0.3")) == 0) || > (strncmp(ptr, "Godson2 V0.3 FPU V0.1", strlen("Godson2 V0.3 FPU V0.1")) == 0); > } > - fclose(cpuinfo); > + (void)fclose(cpuinfo); > return 0; > } > #endif > -- > Kind regards, Stefan Tauner > > > _______________________________________________ > flashrom mailing list > flashrom(a)flashrom.org > http://www.flashrom.org/mailman/listinfo/flashrom If you fix that (or convince me that you want to print reading fclose failure), this is acked by me. -- Urja Rannikko

1 0

W836xx: Dell Latitude E4310: flashrom -V
by Daniel Golle 27 Nov '15

27 Nov '15

flashrom v0.9.8-r1888 on Linux 4.2.5-1-ARCH (x86_64) flashrom is free software, get the source code at http://www.flashrom.org flashrom was built with libpci 3.3.0, GCC 4.9.2 20150204 (prerelease), little endian Command line (3 args): flashrom -V -p internal Calibrating delay loop... OS timer resolution is 1 usecs, 1563M loops per second, 10 myus = 11 us, 100 myus = 107 us, 1000 myus = 1003 us, 10000 myus = 10287 us, 4 myus = 4 us, OK. Initializing internal programmer No coreboot table found. Using Internal DMI decoder. DMI string chassis-type: "Laptop" Laptop detected via DMI. DMI string system-manufacturer: "Dell Inc." DMI string system-product-name: "Latitude E4310" DMI string system-version: "0001" DMI string baseboard-manufacturer: "Dell Inc." DMI string baseboard-product-name: "0D8H24" DMI string baseboard-version: "A00" ========================================================================

1 0

Ch431 programmer
by Ran Weizman 25 Nov '15

25 Nov '15

Hi, I have the CH341, device with version4.03, is Flashrom gonna support it in the future ? Can I help with something ? (I'm not a dev just Linux user. ) Thanks Ran

1 0

Raspberry EN25F32
by Andrea Vinci 24 Nov '15

24 Nov '15

Hi, I’ve try to flash Eon flash chip "EN25F32” with flashrom on raspberry pi 2. The rpi found the programmer /dev/spidev0.0 but cannot recognise the chip. Someone else have the same problem or have try this? Thanks -- Andrea Vinci

1 0

Re: [flashrom] CH341 patch request
by Stefan Tauner 24 Nov '15

24 Nov '15

On Wed, 30 Sep 2015 15:18:12 +0200 Ádám Attila Nagy <osiixy(a)gmail.com> wrote: > Thank you! > That happens time to time but I am really grateful that you have even not > forgotten it. > > I am really looking forward to this cheapass programmer being arrived and > testing it with your code. Hi Ádám, here is a branch that should actually work: https://github.com/urjaman/flashrom/tree/ch341a -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

2 1

EN25F32 on raspberry 2
by Andrea Vinci 23 Nov '15

23 Nov '15

Hi, I read from http://www.flashrom.org/pipermail/flashrom/2014-September/012951.html that you have successful test the chip EN25F32 with flashrom. I try to flash this chip with a raspberry 2 but the software doesn’t recognise the chip. Can you give me more info about your test? I found this circuit, can you say me if it is right for my case? Thanks. -- Darka

1 0

Re: [flashrom] [PATCH] Rigorously check integrity of I/O stream data.
by Stefan Tauner 22 Nov '15

22 Nov '15

On Sun, 22 Nov 2015 18:29:34 +0100 Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> wrote: > Nevertheless I think we should merge this patch ASAP. Or maybe with a goto from the error state of fwrite to the fclose call (skipping fflush and fsync if fwrite fails), because there is really no benefit of doing these calls in that case - it even produces one more error output when trying to fsync /dev/full... OTOH fsyncing often fails on non-regular files (e.g. /dev/null) even though everything works as intended... *sigh* -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 1

[PATCH] Rigorously check integrity of I/O stream data.
by Stefan Tauner 22 Nov '15

22 Nov '15

Even if fwrite() succeeds the data is not necessarily out of the clib's buffers and writing it eventually could fail. Even if the data is flushed out (explicitly by fflush() or implicitly by fclose()) the kernel might still hold a buffer. Previously we have ignored this to a large extent - even in important cases like writing the flash contents to a file. The results can be truncated images that would brick the respective machine if written back as is (though flashrom would not allow that due to a size mismatch). flashrom would not indicate the problem in any output - so far we only check the return value of fwrite() that is not conclusive. This patch checks the return values of all related system calls like fclose() unless we only read the file and are not really interested in output errors. In the latter case the return value is casted to void to document this fact. Additionally, this patch explicitly calls fflush() and fsync() to do the best we can to guarantee the read image reaches the disk safely. Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> --- flashrom.c | 56 ++++++++++++++++++++++++++++++++++-------------------- layout.c | 6 +++--- processor_enable.c | 4 ++-- 3 files changed, 40 insertions(+), 26 deletions(-) The reason why I was investigating this at all was a user report on IRC that showed that flashrom on OpenWRT would create a truncated file if there is not enough space left on the file system to store the flash image file. After adding support for uclibc on our buildbot I was able to reproduce the problem. Unfortunately, checking the return value of fclose() does not help with uclibc, nor does calling fflush() or fsync() - uclibc is simply broken in this regard, cf.: https://bugs.gentoo.org/show_bug.cgi?id=543972 https://bugs.uclibc.org/5156 glibc and musl are not affected. Both notice the problem at fwrite() time. Nevertheless I think we should merge this patch ASAP. diff --git a/flashrom.c b/flashrom.c index c9c7e31..3b2388b 100644 --- a/flashrom.c +++ b/flashrom.c @@ -28,6 +28,7 @@ #include <sys/stat.h> #endif #include <string.h> +#include <unistd.h> #include <stdlib.h> #include <errno.h> #include <ctype.h> @@ -1255,36 +1256,39 @@ int read_buf_from_file(unsigned char *buf, unsigned long size, msg_gerr("Error: No file I/O support in libpayload\n"); return 1; #else - unsigned long numbytes; - FILE *image; - struct stat image_stat; + int ret = 0; + FILE *image; if ((image = fopen(filename, "rb")) == NULL) { msg_gerr("Error: opening file \"%s\" failed: %s\n", filename, strerror(errno)); return 1; } + + struct stat image_stat; if (fstat(fileno(image), &image_stat) != 0) { msg_gerr("Error: getting metadata of file \"%s\" failed: %s\n", filename, strerror(errno)); - fclose(image); - return 1; + ret = 1; + goto out; } if (image_stat.st_size != size) { msg_gerr("Error: Image size (%jd B) doesn't match the flash chip's size (%lu B)!\n", (intmax_t)image_stat.st_size, size); - fclose(image); - return 1; - } - numbytes = fread(buf, 1, size, image); - if (fclose(image)) { - msg_gerr("Error: closing file \"%s\" failed: %s\n", filename, strerror(errno)); - return 1; + ret = 1; + goto out; } + + unsigned long numbytes = fread(buf, 1, size, image); if (numbytes != size) { msg_gerr("Error: Failed to read complete file. Got %ld bytes, " "wanted %ld!\n", numbytes, size); - return 1; + ret = 1; } - return 0; +out: + if (fclose(image)) { + msg_gerr("Error: closing file \"%s\" failed: %s\n", filename, strerror(errno)); + ret = 1; + } + return ret; #endif } @@ -1294,8 +1298,8 @@ int write_buf_to_file(const unsigned char *buf, unsigned long size, const char * msg_gerr("Error: No file I/O support in libpayload\n"); return 1; #else - unsigned long numbytes; FILE *image; + int ret = 0; if (!filename) { msg_gerr("No filename specified.\n"); @@ -1306,14 +1310,24 @@ int write_buf_to_file(const unsigned char *buf, unsigned long size, const char * return 1; } - numbytes = fwrite(buf, 1, size, image); - fclose(image); + unsigned long numbytes = fwrite(buf, 1, size, image); if (numbytes != size) { - msg_gerr("File %s could not be written completely.\n", - filename); - return 1; + msg_gerr("Error: file %s could not be written completely.\n", filename); + ret = 1; } - return 0; + if (fflush(image)) { + msg_gerr("Error: flushing file \"%s\" failed: %s\n", filename, strerror(errno)); + ret = 1; + } + if (fsync(fileno(image))) { + msg_gerr("Error: fsyncing file \"%s\" failed: %s\n", filename, strerror(errno)); + ret = 1; + } + if (fclose(image)) { + msg_gerr("Error: closing file \"%s\" failed: %s\n", filename, strerror(errno)); + ret = 1; + } + return ret; #endif } diff --git a/layout.c b/layout.c index 0b9f6e5..d039451 100644 --- a/layout.c +++ b/layout.c @@ -65,7 +65,7 @@ int read_romlayout(const char *name) if (num_rom_entries >= MAX_ROMLAYOUT) { msg_gerr("Maximum number of ROM images (%i) in layout " "file reached.\n", MAX_ROMLAYOUT); - fclose(romlayout); + (void)fclose(romlayout); return 1; } if (2 != fscanf(romlayout, "%s %s\n", tempstr, rom_entries[num_rom_entries].name)) @@ -80,7 +80,7 @@ int read_romlayout(const char *name) tstr2 = strtok(NULL, ":"); if (!tstr1 || !tstr2) { msg_gerr("Error parsing layout file. Offending string: \"%s\"\n", tempstr); - fclose(romlayout); + (void)fclose(romlayout); return 1; } rom_entries[num_rom_entries].start = strtol(tstr1, (char **)NULL, 16); @@ -95,7 +95,7 @@ int read_romlayout(const char *name) rom_entries[i].end, rom_entries[i].name); } - fclose(romlayout); + (void)fclose(romlayout); return 0; } diff --git a/processor_enable.c b/processor_enable.c index 1361dd5..117aa1e 100644 --- a/processor_enable.c +++ b/processor_enable.c @@ -57,11 +57,11 @@ static int is_loongson(void) ptr++; while (*ptr && isspace((unsigned char)*ptr)) ptr++; - fclose(cpuinfo); + (void)fclose(cpuinfo); return (strncmp(ptr, "ICT Loongson-2 V0.3", strlen("ICT Loongson-2 V0.3")) == 0) || (strncmp(ptr, "Godson2 V0.3 FPU V0.1", strlen("Godson2 V0.3 FPU V0.1")) == 0); } - fclose(cpuinfo); + (void)fclose(cpuinfo); return 0; } #endif -- Kind regards, Stefan Tauner

1 0

Image size doesn't match the flash chip's size
by Adam Nielsen 22 Nov '15

22 Nov '15

Hi all, I'm in the process of setting up a retro PC (a 286) and because the machine's BIOS doesn't support IDE drives, I am hoping to put the open source XTIDE BIOS in this machine as an option ROM. I have a network card that can make EEPROMs visible at the right memory locations, so all I need to do is flash the XTIDE code onto an EEPROM and install it in the old PC. I have an EEPROM I am planning to use for this (an SST29EE020) and I'm using a 3Com NIC to attempt to flash the XTIDE code into it. However when I try this, I get an error: Error: Image size (8192 B) doesn't match the flash chip's size (262144 B)! While I understand this would normally be a problem, for me it's fine - I'm only interested in the first 8kB and the rest of the chip is not important to me. But I couldn't find any options to tell flashrom to continue and flash anyway, and --force didn't help. My first thought was that perhaps I just need to pad the ROM image out so that it matches the chip size, but then I run into a problem. The chip is 256kB, but the 3Com NIC is apparently (according to flashrom) only capable of addressing up to 128kB. This means if I force it, the second 128kB (the padding) will probably just get written over the first 128kB, overwriting the data I want to keep. I guess I could pad out the 8kB XTIDE image to only 128kB, then double that to get a 256kB image, but it's all very kludgy! Since flashrom has options to erase the chip, would it be possible to add another option to allow partial flashing? This would allow me to flash my 8kB image without worrying about address wraparound or having to flash 248kB of blanks when I don't have to! BTW flashrom (latest stable) tells me the SST29EE020 is untested, so I would be happy to report back with my results, assuming you accept flashing a 256kB chip in a 128kB programmer as a valid test ;-) Many thanks, Adam.

2 3

[PATCH] Add support for SST25WF080B 1 MB flash.
by Ben Gardner 22 Nov '15

22 Nov '15

Apart from the JEDEC ID (621614) the difference from the SST25WF080 is that it lacks op codes 0xAD (AAI Word program) and 0x52 (32K erase). Tested under Linux with spidev. Signed-off-by: Ben Gardner <bgardner(a)wabtec.com> --- flashchips.c | 35 +++++++++++++++++++++++++++++++++++ flashchips.h | 3 ++- 2 files changed, 37 insertions(+), 1 deletion(-) diff --git a/flashchips.c b/flashchips.c index 8b5d1ec..b71bd2c 100644 --- a/flashchips.c +++ b/flashchips.c @@ -11803,6 +11803,41 @@ const struct flashchip flashchips[] = { { .vendor = "SST", + .name = "SST25WF080B", + .bustype = BUS_SPI, + .manufacture_id = SST_ID_62, + .model_id = SST_SST25WF080B, + .total_size = 1024, + .page_size = 256, + .feature_bits = FEATURE_WRSR_EITHER, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 256} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {64 * 1024, 16} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + }, + }, + .printlock = spi_prettyprint_status_register_sst25, /* *does* have a BP3 but it is useless */ + .unlock = spi_disable_blockprotect_bp3_srwd, + .write = spi_chip_write_256, + .read = spi_chip_read, /* Fast read (0x0B) supported */ + .voltage = {1650, 1950}, + }, + + { + .vendor = "SST", .name = "SST28SF040A", .bustype = BUS_PARALLEL, .manufacture_id = SST_ID, diff --git a/flashchips.h b/flashchips.h index 07ae49d..d6b2b8d 100644 --- a/flashchips.h +++ b/flashchips.h @@ -659,6 +659,7 @@ * byte of device ID is related to log(bitsize) at least for some chips. */ #define SST_ID 0xBF /* SST */ +#define SST_ID_62 0x62 /* SST */ #define SST_SST25LF020_REMS 0x43 /* REMS or RES opcode */ #define SST_SST25WF512 0x2501 #define SST_SST25WF010 0x2502 @@ -669,7 +670,7 @@ * IDs and were not spotted in the wild yet. Their datasheets show a 4 byte long response w/o a vendor ID. */ #define SST_SST25WF020A /* 0x62 0x16 0x12 0x00 */ #define SST_SST25WF040B /* 0x62 0x16 0x13 0x00 */ -#define SST_SST25WF080B /* 0x62 0x16 0x14 0x00 */ +#define SST_SST25WF080B 0x1614 /* 0x62 0x16 0x14 0x00 */ #define SST_SST25VF512_REMS 0x48 /* REMS or RES opcode, same as SST25VF512A */ #define SST_SST25VF010_REMS 0x49 /* REMS or RES opcode, same as SST25VF010A */ #define SST_SST25VF020_REMS 0x43 /* REMS or RES opcode, same as SST25LF020A */ -- 1.9.1 This email and any attachments are only for use by the intended recipient(s) and may contain legally privileged, confidential, proprietary or otherwise private information. Any unauthorized use, reproduction, dissemination, distribution or other disclosure of the contents of this e-mail or its attachments is strictly prohibited. If you have received this email in error, please notify the sender immediately and delete the original. Neither this information block, the typed name of the sender, nor anything else in this message is intended to constitute an electronic signature unless a specific statement to the contrary is included in this message.

3 2

Re: [flashrom] flashrom on PowerPC
by Stefan Tauner 22 Nov '15

22 Nov '15

On Fri, 20 Nov 2015 17:16:44 +0100 Peter Lemenkov <lemenkov(a)gmail.com> wrote: > Hello All! > > 2011-10-23 0:20 GMT+02:00 Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at>: > > On Wed, 27 Jul 2011 18:20:19 +0200 > > Mattias Mattsson <vitplister(a)gmail.com> wrote: > > > >> Hi all, > >> > >> I was able to run flashrom under Linux on PPC (big endian) hardware > >> with two small modifications in internal.c and processor_enable.c (see > >> attached patch). Not sure if this is the right way to do it but it > >> seems to work for me. > >> > > > > i am resending this patch (unchanged) because patchwork did not pick it > > up correctly. please do send one patch per mail only in the future > > until we have something really working. :) > > Sorry for bringing up this again but what's the status of this? It > does works on old PPC-based Apple Macs and it still applies cleanly. > Maybe it's time to apply this, otherwise we won't see any potential > users very soon :) Hi Peter, it does not apply to the current version, but that's not the issue. It seems like a simple hack that was not thought through completely and I certainly won't merge it as is. IMHO the things mentioned in the comment in internal.c below the single hunk needs to be addressed first. I am not sure ATM what that even means and won't look into it soon. Also, I don't think it would even work in its current form (no programmer registration happens there that was introduced since the original patch)... -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

[commit] r1901 - trunk
by repository service 22 Nov '15

22 Nov '15

Author: stefanct Date: Sun Nov 22 03:23:31 2015 New Revision: 1901 URL: http://flashrom.org/trac/flashrom/changeset/1901 Log: Add support for SST SST25WF020A, SST25WF040B, SST25WF080B. Apart from the strange ID (using Sanyo's vendor ID 0x62) the main difference from the plain SST25WF series is that they lack op codes 0xAD (AAI Word program) and 0x52 (32K erase). The smallest version does not support dual I/O operations either. SST25WF080B was tested under Linux with spidev. Tested-by: Ben Gardner <bgardner(a)wabtec.com> Signed-off-by: Ben Gardner <bgardner(a)wabtec.com> Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Acked-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Modified: trunk/chipdrivers.h trunk/flashchips.c trunk/flashchips.h trunk/spi25_statusreg.c Modified: trunk/chipdrivers.h ============================================================================== --- trunk/chipdrivers.h Sun Nov 22 00:35:47 2015 (r1900) +++ trunk/chipdrivers.h Sun Nov 22 03:23:31 2015 (r1901) @@ -72,6 +72,7 @@ int spi_prettyprint_status_register_bp3_srwd(struct flashctx *flash); int spi_prettyprint_status_register_bp4_srwd(struct flashctx *flash); int spi_prettyprint_status_register_bp2_bpl(struct flashctx *flash); +int spi_prettyprint_status_register_bp2_tb_bpl(struct flashctx *flash); int spi_disable_blockprotect(struct flashctx *flash); int spi_disable_blockprotect_bp1_srwd(struct flashctx *flash); int spi_disable_blockprotect_bp2_srwd(struct flashctx *flash); Modified: trunk/flashchips.c ============================================================================== --- trunk/flashchips.c Sun Nov 22 00:35:47 2015 (r1900) +++ trunk/flashchips.c Sun Nov 22 03:23:31 2015 (r1901) @@ -11857,6 +11857,111 @@ { .vendor = "SST", + .name = "SST25WF020A", + .bustype = BUS_SPI, + .manufacture_id = SANYO_ID, /* See flashchips.h */ + .model_id = SST_SST25WF020A, + .total_size = 256, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_UNTESTED, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 64} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {64 * 1024, 4} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {256 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {256 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + }, + }, + .printlock = spi_prettyprint_status_register_bp2_tb_bpl, + .unlock = spi_disable_blockprotect_bp2_srwd, + .write = spi_chip_write_256, + .read = spi_chip_read, /* Fast read (0x0B) supported */ + .voltage = {1650, 1950}, + }, + + { + .vendor = "SST", + .name = "SST25WF040B", + .bustype = BUS_SPI, + .manufacture_id = SANYO_ID, /* See flashchips.h */ + .model_id = SST_SST25WF040B, + .total_size = 512, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_UNTESTED, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 128} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {64 * 1024, 8} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {512 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {512 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + }, + }, + .printlock = spi_prettyprint_status_register_bp2_tb_bpl, + .unlock = spi_disable_blockprotect_bp2_srwd, + .write = spi_chip_write_256, + .read = spi_chip_read, /* Fast read (0x0B), dual O (0x3B), dual I/O read (0xBB) supported */ + .voltage = {1650, 1950}, + }, + + { + .vendor = "SST", + .name = "SST25WF080B", + .bustype = BUS_SPI, + .manufacture_id = SANYO_ID, /* See flashchips.h */ + .model_id = SST_SST25WF080B, + .total_size = 1024, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 256} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {64 * 1024, 16} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + }, + }, + .printlock = spi_prettyprint_status_register_bp2_tb_bpl, + .unlock = spi_disable_blockprotect_bp2_srwd, + .write = spi_chip_write_256, + .read = spi_chip_read, /* Fast read (0x0B), dual O (0x3B), dual I/O read (0xBB) supported */ + .voltage = {1650, 1950}, + }, + + { + .vendor = "SST", .name = "SST25VF080B", .bustype = BUS_SPI, .manufacture_id = SST_ID, Modified: trunk/flashchips.h ============================================================================== --- trunk/flashchips.h Sun Nov 22 00:35:47 2015 (r1900) +++ trunk/flashchips.h Sun Nov 22 03:23:31 2015 (r1901) @@ -670,11 +670,12 @@ #define SST_SST25WF020 0x2503 #define SST_SST25WF040 0x2504 #define SST_SST25WF080 0x2505 -/* There exist some successors to members of the SST25WF family with alphabetic suffixes. They have very weird - * IDs and were not spotted in the wild yet. Their datasheets show a 4 byte long response w/o a vendor ID. */ -#define SST_SST25WF020A /* 0x62 0x16 0x12 0x00 */ -#define SST_SST25WF040B /* 0x62 0x16 0x13 0x00 */ -#define SST_SST25WF080B /* 0x62 0x16 0x14 0x00 */ +/* There exist some successors to members of the SST25WF family with alphabetic suffixes. Their datasheets show + * a 4 byte long response w/o a vendor ID. The first byte is 0x62 that is actually Sanyo's and might be due to + * a collaboration in the mid 2000ies between Sanyo and SST. */ +#define SST_SST25WF020A 0x1612 +#define SST_SST25WF040B 0x1613 +#define SST_SST25WF080B 0x1614 #define SST_SST25VF512_REMS 0x48 /* REMS or RES opcode, same as SST25VF512A */ #define SST_SST25VF010_REMS 0x49 /* REMS or RES opcode, same as SST25VF010A */ #define SST_SST25VF020_REMS 0x43 /* REMS or RES opcode, same as SST25LF020A */ Modified: trunk/spi25_statusreg.c ============================================================================== --- trunk/spi25_statusreg.c Sun Nov 22 00:35:47 2015 (r1900) +++ trunk/spi25_statusreg.c Sun Nov 22 03:23:31 2015 (r1901) @@ -374,6 +374,19 @@ return 0; } +int spi_prettyprint_status_register_bp2_tb_bpl(struct flashctx *flash) +{ + uint8_t status = spi_read_status_register(flash); + spi_prettyprint_status_register_hex(status); + + spi_prettyprint_status_register_bpl(status); + spi_prettyprint_status_register_bit(status, 6); + msg_cdbg("Chip status register: Top/Bottom (TB) is %s\n", (status & (1 << 5)) ? "bottom" : "top"); + spi_prettyprint_status_register_bp(status, 2); + spi_prettyprint_status_register_welwip(status); + return 0; +} + /* === Amic === * FIXME: spi_disable_blockprotect is incorrect but works fine for chips using * spi_prettyprint_status_register_bp1_srwd or

1 0

Re: [flashrom] Winbond flash chip "W39V080FA" (1024 kB, FWH)
by Stefan Tauner 22 Nov '15

22 Nov '15

On Sun, 22 Nov 2015 00:37:20 +0100 "Fabian Hoffmann" <fab1997(a)gmx.net> wrote: > Habe seit kurzem ein neues Mainboard und kann den Command deshalb leider nicht ausführen. Das alte MB funktioniert aber noch. OK, if you ever happen to start it up again please think of flashrom ;) -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

SST49LF040B
by Rikard Åhlund 22 Nov '15

22 Nov '15

Flash Chip : SST49LF040B Mainboard : NF-M2S (Acer E380) Erase And Write Tested and working

2 1

CHIPSET: ASRock N68C-S UCC
by Alexey Belyaev 22 Nov '15

22 Nov '15

Здравствуйте, Flashrom. BIOS image was readed successfully! http://www.asrock.com/mb/NVIDIA/N68C-S%20UCC/index.ru.asp $ lspci 00:00.0 RAM memory: NVIDIA Corporation MCP61 Host Bridge (rev a1) 00:01.0 ISA bridge: NVIDIA Corporation MCP61 LPC Bridge (rev a2) 00:01.1 SMBus: NVIDIA Corporation MCP61 SMBus (rev a2) 00:01.2 RAM memory: NVIDIA Corporation MCP61 Memory Controller (rev a2) 00:02.0 USB controller: NVIDIA Corporation MCP61 USB 1.1 Controller (rev a3) 00:02.1 USB controller: NVIDIA Corporation MCP61 USB 2.0 Controller (rev a3) 00:04.0 PCI bridge: NVIDIA Corporation MCP61 PCI bridge (rev a1) 00:05.0 Audio device: NVIDIA Corporation MCP61 High Definition Audio (rev a2) 00:06.0 IDE interface: NVIDIA Corporation MCP61 IDE (rev a2) 00:07.0 Bridge: NVIDIA Corporation MCP61 Ethernet (rev a2) 00:08.0 IDE interface: NVIDIA Corporation MCP61 SATA Controller (rev a2) 00:08.1 IDE interface: NVIDIA Corporation MCP61 SATA Controller (rev a2) 00:09.0 PCI bridge: NVIDIA Corporation MCP61 PCI Express bridge (rev a2) 00:0b.0 PCI bridge: NVIDIA Corporation MCP61 PCI Express bridge (rev a2) 00:0c.0 PCI bridge: NVIDIA Corporation MCP61 PCI Express bridge (rev a2) 00:0d.0 VGA compatible controller: NVIDIA Corporation C61 [GeForce 7025 / nForce 630a] (rev a2) 00:18.0 Host bridge: Advanced Micro Devices, Inc. [AMD] Family 10h Processor HyperTransport Configuration 00:18.1 Host bridge: Advanced Micro Devices, Inc. [AMD] Family 10h Processor Address Map 00:18.2 Host bridge: Advanced Micro Devices, Inc. [AMD] Family 10h Processor DRAM Controller 00:18.3 Host bridge: Advanced Micro Devices, Inc. [AMD] Family 10h Processor Miscellaneous Control 00:18.4 Host bridge: Advanced Micro Devices, Inc. [AMD] Family 10h Processor Link Control 01:08.0 Network controller: Ralink corp. RT5360 Wireless 802.11n 1T/1R 01:0a.0 Ethernet controller: Intel Corporation 82545GM Gigabit Ethernet Controller (rev 04) 02:00.0 Network controller: Qualcomm Atheros AR9485 Wireless Network Adapter (rev 01) 03:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller (rev 06) -- С уважением, Alexey mailto:spider@spider.vc

2 3

Re: [flashrom] Flash chip/chipset not found
by Stefan Tauner 22 Nov '15

22 Nov '15

Hi Mark, thanks for the testing! We have merged the patch with r1900 now and marked the chipset as supported. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

Re: [flashrom] Winbond flash chip "W39V080FA" (1024 kB, FWH)
by Stefan Tauner 22 Nov '15

22 Nov '15

On Tue, 3 Nov 2015 14:47:37 +0100 "Fabian Hoffmann" <fab1997(a)gmx.net> wrote: > Hello, you may be interested on the following log. > My system: > OS: Arch Linux 64-Bit > Mainboard: ASUS P5LD2-VM/S 4.00g (MAXDATA OEM-Board, pretty rare I think. It is not listed on the ASUS page.) > CPU: Intel Core 2 Duo E4400 @ 2 GHz > > Flash read went almost fine, I was able to extract the bootlogo out of the rom file, but the MD5 hash sum of the rom file didn't match with an original rom file. Hi Fabian, you should be able to use the code that supports other versions of the P5LD2-VM mainboard to enable writing. Something like this: flashrom --programmer internal:mainboard="ASUS:P5LD2-VM DH" -w modded0404.rom -o ./flashrom-write.txt Should work, I think. Can you please provide us with the output of the following command so that we can add auto-detection for your version too. lspci -nnxxxvv The MD5 mismatch might be normal. The BIOS might use the flash memory as persistent storage area... that is common nowadays. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

2 1

[commit] r1900 - trunk
by repository service 22 Nov '15

22 Nov '15

Author: stefanct Date: Sun Nov 22 00:35:47 2015 New Revision: 1900 URL: http://flashrom.org/trac/flashrom/changeset/1900 Log: Add support for VIA VT8251. Seems to work on IBM SurePOS 700 and IBM (now Toshiba) AnyPlace Kiosk Model 4838-310. Tested-by: Jason Vannest <Jason_Vannest(a)abercrombie.com> Tested-by: Rowlinson Mark <Mark.Rowlinson(a)uk.fujitsu.com> Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/chipset_enable.c Modified: trunk/chipset_enable.c ============================================================================== --- trunk/chipset_enable.c Sat Nov 14 03:55:22 2015 (r1899) +++ trunk/chipset_enable.c Sun Nov 22 00:35:47 2015 (r1900) @@ -1582,6 +1582,7 @@ {0x1106, 0x3147, OK, "VIA", "VT8233A", enable_flash_vt823x}, {0x1106, 0x3177, OK, "VIA", "VT8235", enable_flash_vt823x}, {0x1106, 0x3227, OK, "VIA", "VT8237(R)", enable_flash_vt823x}, + {0x1106, 0x3287, OK, "VIA", "VT8251", enable_flash_vt823x}, {0x1106, 0x3337, OK, "VIA", "VT8237A", enable_flash_vt823x}, {0x1106, 0x3372, OK, "VIA", "VT8237S", enable_flash_vt8237s_spi}, {0x1106, 0x8231, NT, "VIA", "VT8231", enable_flash_vt823x},

1 0

Asus M2N-MX/DVI2
by Лисовой Игорь 21 Nov '15

21 Nov '15

2 2

Re: [flashrom] SFDP has autodetected a flash chip which is not natively supported by flashrom yet
by Stefan Tauner 21 Nov '15

21 Nov '15

On Thu, 5 Nov 2015 23:20:34 -0500 Greg Tippitt <greg(a)tippitt.net> wrote: > I run the Ubuntu 14.04 LTS version, and forgot to check for an updated > version of flashrom. > > I tried it, and the flash seem to go fine. The BIOS update didn't solve > the problem I was having, but it Flashrom did its part valiantly. Hello Greg, thanks for your report! I have added your board to our list of supported hardware and will commit that later together with other small changes. If possible, please always include a (verbose) log with such reports so that we can verify them and also look for oddities that might be interesting for our future work, thanks. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

Re: [flashrom] Fwd: Unable to make a dump of Macronix MX 25L3205D
by Stefan Tauner 21 Nov '15

21 Nov '15

On Sat, 21 Nov 2015 03:23:05 +1300 Sergio <businessnzd(a)gmail.com> wrote: > Hi. I was trying to make a dump of my Macbook Pro 15 Mid-2010 chip and was > unsuccessful. > Previously I was able to make dumps and write them to the Macbook Pro 13 > Early-2011 and Late-2011 models with similar EFI chips. I've tried > different pinouts and AUX Low/HIGH (just in case) and it didn't worked. I > use Bus Pirate v3.0a with latest updated Firmware 6.1. In the log it says > 5.1 but the same result I've got with the 6.1 Firmware of Bus Pirate.The > exact EFI chip model that I was unable to read is MX 25L3205D. Attaching > the log file for more info. In other attempts, without specifying chip it > gives me just Generic type of chip with 0 voltages. Any info/help would be > greatly appreciated. Hi, I'd say a power problem is most likely. The beta 6.2 firmware of the bus pirate would improve performance a bit but I think apart from that it is irrelevant in this case. Try powering the system with a dedicated power supply. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

[PATCH] Fix compilation with only one enabled programmer.
by Stefan Tauner 21 Nov '15

21 Nov '15

Compilers are free to use an unsigned data type for enumerations without negative elements. Our enumeration of all programmers is one such instance. Also, compilers will warn about comparisons of unsigned enum expressions < 0. If we enable only a single programmer then PROGRAMMER_INVALID will be 1. We do some run-time checks of loop counters of an unsigned enumaration type against PROGRAMMER_INVALID in the form of if (p < PROGRAMMER_INVALID - 1) which get optimized to if (p < 0) This makes the check always false and the compiler warnings compulsory. This patch adds #ifdefs guarding these checks if there is only one programmer enabled. --- One can enable a single programmer by running grep CONFIG_ Makefile |fgrep '?= yes'|grep -vi serprog |sed "s/ .*/=no/"|xargs make CONFIG_SERPROG=yes Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> --- flashrom.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/flashrom.c b/flashrom.c index c9c7e31..abb917b 100644 --- a/flashrom.c +++ b/flashrom.c @@ -1633,10 +1633,13 @@ void list_programmers(const char *delim) enum programmer p; for (p = 0; p < PROGRAMMER_INVALID; p++) { msg_ginfo("%s", programmer_table[p].name); + +#if PROGRAMMER_INVALID > 1 if (p < PROGRAMMER_INVALID - 1) msg_ginfo("%s", delim); +#endif } - msg_ginfo("\n"); + msg_ginfo("\n"); } void list_programmers_linebreak(int startcol, int cols, int paren) @@ -1668,6 +1671,7 @@ void list_programmers_linebreak(int startcol, int cols, int paren) } msg_ginfo("%s", pname); remaining -= pnamelen; +#if PROGRAMMER_INVALID > 1 if (p < PROGRAMMER_INVALID - 1) { msg_ginfo(","); remaining--; @@ -1675,6 +1679,9 @@ void list_programmers_linebreak(int startcol, int cols, int paren) if (paren) msg_ginfo(")"); } +#else + msg_ginfo(")"); +#endif } } -- Kind regards, Stefan Tauner

1 0

Re: [flashrom] flashrom on PowerPC
by Stefan Tauner 20 Nov '15

20 Nov '15

On Wed, 27 Jul 2011 18:20:19 +0200 Mattias Mattsson <vitplister(a)gmail.com> wrote: > Hi all, > > I was able to run flashrom under Linux on PPC (big endian) hardware > with two small modifications in internal.c and processor_enable.c (see > attached patch). Not sure if this is the right way to do it but it > seems to work for me. > i am resending this patch (unchanged) because patchwork did not pick it up correctly. please do send one patch per mail only in the future until we have something really working. :) -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

2 1

Fwd: Unable to make a dump of Macronix MX 25L3205D
by Sergio 20 Nov '15

20 Nov '15

Hi. I was trying to make a dump of my Macbook Pro 15 Mid-2010 chip and was unsuccessful. Previously I was able to make dumps and write them to the Macbook Pro 13 Early-2011 and Late-2011 models with similar EFI chips. I've tried different pinouts and AUX Low/HIGH (just in case) and it didn't worked. I use Bus Pirate v3.0a with latest updated Firmware 6.1. In the log it says 5.1 but the same result I've got with the 6.1 Firmware of Bus Pirate.The exact EFI chip model that I was unable to read is MX 25L3205D. Attaching the log file for more info. In other attempts, without specifying chip it gives me just Generic type of chip with 0 voltages. Any info/help would be greatly appreciated. Cheers, Sergio

1 0

[PATCH 3/3] Add support for linking statically with CONFIG_STATIC=yes.
by Stefan Tauner 15 Nov '15

15 Nov '15

This is loosly based on the following changes of chromiumos: - flashrom: Add default pkg-config definition. Change-Id: I28744af0fd2d2d0bcc4569a5fbef370321691267 - Fix FT2232 feature on static builds. Change-Id: I70d4a7bda573b64cb18429a21792455b018c4cba Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> --- Makefile | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Makefile b/Makefile index 3f96a15..1c6a823 100644 --- a/Makefile +++ b/Makefile @@ -72,6 +72,11 @@ LDFLAGS += -L$(LIBS_BASE)/lib -Wl,-rpath -Wl,$(LIBS_BASE)/lib PKG_CONFIG_LIBDIR ?= $(LIBS_BASE)/lib/pkgconfig endif +ifeq ($(CONFIG_STATIC),yes) +PKG_CONFIG += --static +LDFLAGS += -static +endif + dummy_for_make_3_80:=$(shell printf "Build started on " >$(BUILD_DETAILS_FILE) ; date >>$(BUILD_DETAILS_FILE) ; echo >>$(BUILD_DETAILS_FILE)) debug_shell = $(shell export LC_ALL=C ; { echo 'exec: export LC_ALL=C ; { $(1) ; }' >&2; { $(1) ; } | tee -a $(BUILD_DETAILS_FILE) ; echo >&2 ; } 2>>$(BUILD_DETAILS_FILE)) ############################################################################### -- Kind regards, Stefan Tauner

1 0

[PATCH 2/3] Make make errors more less flashily.
by Stefan Tauner 15 Nov '15

15 Nov '15

Previously we have hid almost all error messages from called tools like pkg-config or the compiler in the "configure" step. Only exceptions were the library checks because Carl-Daniel felt it improved usability in case of missing headers etc. However, this makes the output of the makefile less readable and in the case of pkg-config fallbacks the error messages are actually expected. Instead of throwing a part of the detailed stderr outputs of the tools into the face of the users and completely hiding others, write all of them into a separate log file instead. Also, disable implicit rules because we don't need them and they just make the build slower. Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> --- Makefile | 134 +++++++++++++++++++++++++++++++++++---------------------------- 1 file changed, 74 insertions(+), 60 deletions(-) diff --git a/Makefile b/Makefile index e68b106..3f96a15 100644 --- a/Makefile +++ b/Makefile @@ -37,6 +37,8 @@ MANDIR ?= $(PREFIX)/share/man CFLAGS ?= -Os -Wall -Wshadow EXPORTDIR ?= . RANLIB ?= ranlib +PKG_CONFIG ?= pkg-config +BUILD_DETAILS_FILE ?= build_details.txt # The following parameter changes the default programmer that will be used if there is no -p/--programmer # argument given when running flashrom. The predefined setting does not enable any default so that every @@ -70,6 +72,8 @@ LDFLAGS += -L$(LIBS_BASE)/lib -Wl,-rpath -Wl,$(LIBS_BASE)/lib PKG_CONFIG_LIBDIR ?= $(LIBS_BASE)/lib/pkgconfig endif +dummy_for_make_3_80:=$(shell printf "Build started on " >$(BUILD_DETAILS_FILE) ; date >>$(BUILD_DETAILS_FILE) ; echo >>$(BUILD_DETAILS_FILE)) +debug_shell = $(shell export LC_ALL=C ; { echo 'exec: export LC_ALL=C ; { $(1) ; }' >&2; { $(1) ; } | tee -a $(BUILD_DETAILS_FILE) ; echo >&2 ; } 2>>$(BUILD_DETAILS_FILE)) ############################################################################### # General OS-specific settings. # 1. Prepare for later by gathering information about host and target OS @@ -90,7 +94,7 @@ endif # IMPORTANT: The following line must be placed before TARGET_OS is ever used # (of course), but should come after any lines setting CC because the line # below uses CC itself. -override TARGET_OS := $(strip $(shell LC_ALL=C $(CC) $(CPPFLAGS) -E os.h 2>/dev/null | grep -v '^\#' | grep '"' | cut -f 2 -d'"')) +override TARGET_OS := $(strip $(call debug_shell,$(CC) $(CPPFLAGS) -E os.h 2>/dev/null | grep -v '^\#' | grep '"' | cut -f 2 -d'"')) ifeq ($(TARGET_OS), Darwin) CPPFLAGS += -I/opt/local/include -I/usr/local/include @@ -326,7 +330,7 @@ endif # IMPORTANT: The following line must be placed before ARCH is ever used # (of course), but should come after any lines setting CC because the line # below uses CC itself. -override ARCH := $(strip $(shell LC_ALL=C $(CC) $(CPPFLAGS) -E archtest.c 2>/dev/null | grep -v '^\#' | grep '"' | cut -f 2 -d'"')) +override ARCH := $(strip $(call debug_shell,$(CC) $(CPPFLAGS) -E archtest.c 2>/dev/null | grep -v '^\#' | grep '"' | cut -f 2 -d'"')) # PCI port I/O support is unimplemented on PPC/MIPS/SPARC and unavailable on ARM. # Right now this means the drivers below only work on x86. @@ -615,14 +619,14 @@ endif ifeq ($(CONFIG_FT2232_SPI), yes) # This is a totally ugly hack. -FEATURE_CFLAGS += $(shell LC_ALL=C grep -q "FTDISUPPORT := yes" .features && printf "%s" "-D'CONFIG_FT2232_SPI=1'") +FEATURE_CFLAGS += $(call debug_shell,grep -q "FTDISUPPORT := yes" .features && printf "%s" "-D'CONFIG_FT2232_SPI=1'") NEED_FTDI := yes PROGRAMMER_OBJS += ft2232_spi.o endif ifeq ($(CONFIG_USBBLASTER_SPI), yes) # This is a totally ugly hack. -FEATURE_CFLAGS += $(shell LC_ALL=C grep -q "FTDISUPPORT := yes" .features && printf "%s" "-D'CONFIG_USBBLASTER_SPI=1'") +FEATURE_CFLAGS += $(call debug_shell,grep -q "FTDISUPPORT := yes" .features && printf "%s" "-D'CONFIG_USBBLASTER_SPI=1'") NEED_FTDI := yes PROGRAMMER_OBJS += usbblaster_spi.o endif @@ -634,11 +638,11 @@ NEED_USB := yes endif ifeq ($(NEED_FTDI), yes) -FTDILIBS := $(shell ([ -n "$(PKG_CONFIG_LIBDIR)" ] && export PKG_CONFIG_LIBDIR="$(PKG_CONFIG_LIBDIR)" ); pkg-config --libs libftdi1 || pkg-config --libs libftdi || printf "%s" "-lftdi -lusb") -FEATURE_CFLAGS += $(shell LC_ALL=C grep -q "FT232H := yes" .features && printf "%s" "-D'HAVE_FT232H=1'") -FTDI_INCLUDES := $(shell ([ -n "$(PKG_CONFIG_LIBDIR)" ] && export PKG_CONFIG_LIBDIR="$(PKG_CONFIG_LIBDIR)" ); pkg-config --cflags-only-I libftdi1) +FTDILIBS := $(call debug_shell,[ -n "$(PKG_CONFIG_LIBDIR)" ] && export PKG_CONFIG_LIBDIR="$(PKG_CONFIG_LIBDIR)"; { $(PKG_CONFIG) --libs libftdi1 || $(PKG_CONFIG) --libs libftdi || printf "%s" "-lftdi -lusb" ; }) +FEATURE_CFLAGS += $(call debug_shell,grep -q "FT232H := yes" .features && printf "%s" "-D'HAVE_FT232H=1'") +FTDI_INCLUDES := $(call debug_shell,[ -n "$(PKG_CONFIG_LIBDIR)" ] && export PKG_CONFIG_LIBDIR="$(PKG_CONFIG_LIBDIR)" ; $(PKG_CONFIG) --cflags-only-I libftdi1 ) FEATURE_CFLAGS += $(FTDI_INCLUDES) -FEATURE_LIBS += $(shell LC_ALL=C grep -q "FTDISUPPORT := yes" .features && printf "%s" "$(FTDILIBS)") +FEATURE_LIBS += $(call debug_shell,grep -q "FTDISUPPORT := yes" .features && printf "%s" "$(FTDILIBS)") # We can't set NEED_USB here because that would transform libftdi auto-enabling # into a hard requirement for libusb, defeating the purpose of auto-enabling. endif @@ -710,13 +714,13 @@ endif ifeq ($(CONFIG_LINUX_SPI), yes) # This is a totally ugly hack. -FEATURE_CFLAGS += $(shell LC_ALL=C grep -q "LINUX_SPI_SUPPORT := yes" .features && printf "%s" "-D'CONFIG_LINUX_SPI=1'") +FEATURE_CFLAGS += $(call debug_shell,grep -q "LINUX_SPI_SUPPORT := yes" .features && printf "%s" "-D'CONFIG_LINUX_SPI=1'") PROGRAMMER_OBJS += linux_spi.o endif ifeq ($(CONFIG_MSTARDDC_SPI), yes) # This is a totally ugly hack. -FEATURE_CFLAGS += $(shell LC_ALL=C grep -q "LINUX_I2C_SUPPORT := yes" .features && printf "%s" "-D'CONFIG_MSTARDDC_SPI=1'") +FEATURE_CFLAGS += $(call debug_shell,grep -q "LINUX_I2C_SUPPORT := yes" .features && printf "%s" "-D'CONFIG_MSTARDDC_SPI=1'") NEED_LINUX_I2C := yes PROGRAMMER_OBJS += mstarddc_spi.o endif @@ -734,7 +738,7 @@ endif ifeq ($(NEED_PCI), yes) CHECK_LIBPCI = yes FEATURE_CFLAGS += -D'NEED_PCI=1' -FEATURE_CFLAGS += $(shell LC_ALL=C grep -q "OLD_PCI_GET_DEV := yes" .libdeps && printf "%s" "-D'OLD_PCI_GET_DEV=1'") +FEATURE_CFLAGS += $(call debug_shell,grep -q "OLD_PCI_GET_DEV := yes" .libdeps && printf "%s" "-D'OLD_PCI_GET_DEV=1'") PROGRAMMER_OBJS += pcidev.o physmap.o hwaccess.o ifeq ($(TARGET_OS), NetBSD) @@ -761,7 +765,13 @@ endif ifeq ($(NEED_USB), yes) CHECK_LIBUSB0 = yes FEATURE_CFLAGS += -D'NEED_USB=1' -USBLIBS := $(shell ([ -n "$(PKG_CONFIG_LIBDIR)" ] && export PKG_CONFIG_LIBDIR="$(PKG_CONFIG_LIBDIR)" ); pkg-config --libs libusb || printf "%s" "-lusb") +USBLIBS := $(call debug_shell,[ -n "$(PKG_CONFIG_LIBDIR)" ] && export PKG_CONFIG_LIBDIR="$(PKG_CONFIG_LIBDIR)"; { $(PKG_CONFIG) --libs libusb || printf "%s" "-lusb" ; } ) +endif + +ifeq ($(NEED_LIBUSB1), yes) +CHECK_LIBUSB1 = yes +FEATURE_CFLAGS += -D'NEED_LIBUSB1=1' +USBLIBS += $(call debug_shell,[ -n "$(PKG_CONFIG_LIBDIR)" ] && export PKG_CONFIG_LIBDIR="$(PKG_CONFIG_LIBDIR)"; { $(PKG_CONFIG) --libs libusb-1.0 || printf "%s" "-lusb-1.0"; } ) endif ifeq ($(CONFIG_PRINT_WIKI), yes) @@ -769,10 +779,10 @@ FEATURE_CFLAGS += -D'CONFIG_PRINT_WIKI=1' CLI_OBJS += print_wiki.o endif -FEATURE_CFLAGS += $(shell LC_ALL=C grep -q "UTSNAME := yes" .features && printf "%s" "-D'HAVE_UTSNAME=1'") +FEATURE_CFLAGS += $(call debug_shell,grep -q "UTSNAME := yes" .features && printf "%s" "-D'HAVE_UTSNAME=1'") # We could use PULLED_IN_LIBS, but that would be ugly. -FEATURE_LIBS += $(shell LC_ALL=C grep -q "NEEDLIBZ := yes" .libdeps && printf "%s" "-lz") +FEATURE_LIBS += $(call debug_shell,grep -q "NEEDLIBZ := yes" .libdeps && printf "%s" "-lz") LIBFLASHROM_OBJS = $(CHIP_OBJS) $(PROGRAMMER_OBJS) $(LIB_OBJS) OBJS = $(CLI_OBJS) $(LIBFLASHROM_OBJS) @@ -801,7 +811,7 @@ TAROPTIONS = $(shell LC_ALL=C tar --version|grep -q GNU && echo "--owner=root -- # This includes all frontends and libflashrom. # We don't use EXEC_SUFFIX here because we want to clean everything. clean: - rm -f $(PROGRAM) $(PROGRAM).exe libflashrom.a *.o *.d $(PROGRAM).8 + rm -f $(PROGRAM) $(PROGRAM).exe libflashrom.a *.o *.d $(PROGRAM).8 $(BUILD_DETAILS_FILE) @+$(MAKE) -C util/ich_descriptors_tool/ clean distclean: clean @@ -824,11 +834,11 @@ endef export COMPILER_TEST compiler: featuresavailable - @printf "Checking for a C compiler... " + @printf "Checking for a C compiler... " | tee -a $(BUILD_DETAILS_FILE) @echo "$$COMPILER_TEST" > .test.c - @$(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) .test.c -o .test$(EXEC_SUFFIX) >/dev/null && \ - echo "found." || ( echo "not found."; \ - rm -f .test.c .test$(EXEC_SUFFIX); exit 1) + @{ { { { { $(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) .test.c -o .test$(EXEC_SUFFIX) >&2 && \ + echo "found." || { echo "not found."; \ + rm -f .test.c .test$(EXEC_SUFFIX); exit 1; }; } 2>>$(BUILD_DETAILS_FILE); echo $? >&3 ; } | tee -a $(BUILD_DETAILS_FILE) >&4; } 3>&1;} | { read rc ; exit ${rc}; } } 4>&1 @rm -f .test.c .test$(EXEC_SUFFIX) @printf "Target arch is " @# FreeBSD wc will output extraneous whitespace. @@ -906,43 +916,43 @@ export LIBUSB0_TEST hwlibs: compiler @printf "" > .libdeps ifeq ($(CHECK_LIBPCI), yes) - @printf "Checking for libpci headers... " + @printf "Checking for libpci headers... " | tee -a $(BUILD_DETAILS_FILE) @echo "$$LIBPCI_TEST" > .test.c - @$(CC) -c $(CPPFLAGS) $(CFLAGS) .test.c -o .test.o >/dev/null && \ - echo "found." || ( echo "not found."; echo; \ - echo "Please install libpci headers (package pciutils-devel)."; \ + @{ { { { { $(CC) -c $(CPPFLAGS) $(CFLAGS) .test.c -o .test.o >&2 && \ + echo "found." || { echo "not found."; echo; \ + echo "Please install libpci headers."; \ echo "See README for more information."; echo; \ - rm -f .test.c .test.o; exit 1) - @printf "Checking version of pci_get_dev... " + rm -f .test.c .test.o; exit 1; }; } 2>>$(BUILD_DETAILS_FILE); echo $? >&3 ; } | tee -a $(BUILD_DETAILS_FILE) >&4; } 3>&1;} | { read rc ; exit ${rc}; } } 4>&1 + @printf "Checking version of pci_get_dev... " | tee -a $(BUILD_DETAILS_FILE) @echo "$$PCI_GET_DEV_TEST" > .test.c - @$(CC) -c $(CPPFLAGS) $(CFLAGS) .test.c -o .test.o >/dev/null 2>&1 && \ + @ { $(CC) -c $(CPPFLAGS) $(CFLAGS) .test.c -o .test.o >&2 && \ ( echo "new version (including PCI domain parameter)."; echo "OLD_PCI_GET_DEV := no" >> .libdeps ) || \ - ( echo "old version (without PCI domain parameter)."; echo "OLD_PCI_GET_DEV := yes" >> .libdeps ) - @printf "Checking if libpci is present and sufficient... " - @$(CC) $(LDFLAGS) .test.o -o .test$(EXEC_SUFFIX) $(LIBS) $(PCILIBS) >/dev/null && \ - echo "yes." || ( echo "no."; \ - printf "Checking if libz+libpci are present and sufficient..."; \ - $(CC) $(LDFLAGS) .test.o -o .test$(EXEC_SUFFIX) $(LIBS) $(PCILIBS) -lz >/dev/null && \ - ( echo "yes."; echo "NEEDLIBZ := yes" > .libdeps ) || ( echo "no."; echo; \ + ( echo "old version (without PCI domain parameter)."; echo "OLD_PCI_GET_DEV := yes" >> .libdeps ) } 2>>$(BUILD_DETAILS_FILE) | tee -a $(BUILD_DETAILS_FILE) + @printf "Checking if libpci is present and sufficient... " | tee -a $(BUILD_DETAILS_FILE) + @{ { { { $(CC) $(LDFLAGS) .test.o -o .test$(EXEC_SUFFIX) $(LIBS) $(PCILIBS) 2>>$(BUILD_DETAILS_FILE) >&2 && \ + echo "yes." || { echo "no."; \ + printf "Checking if libz+libpci are present and sufficient..." ; \ + { $(CC) $(LDFLAGS) .test.o -o .test$(EXEC_SUFFIX) $(LIBS) $(PCILIBS) -lz >&2 && \ + echo "yes." && echo "NEEDLIBZ := yes" > .libdeps } || { echo "no."; echo; \ echo "Please install libpci (package pciutils) and/or libz."; \ echo "See README for more information."; echo; \ - rm -f .test.c .test.o .test$(EXEC_SUFFIX); exit 1) ) + rm -f .test.c .test.o .test$(EXEC_SUFFIX); exit 1; }; }; } 2>>$(BUILD_DETAILS_FILE); echo $? >&3 ; } | tee -a $(BUILD_DETAILS_FILE) >&4; } 3>&1;} | { read rc ; exit ${rc}; } } 4>&1 @rm -f .test.c .test.o .test$(EXEC_SUFFIX) endif ifeq ($(CHECK_LIBUSB0), yes) - @printf "Checking for libusb-0.1/libusb-compat headers... " + @printf "Checking for libusb-0.1/libusb-compat headers... " | tee -a $(BUILD_DETAILS_FILE) @echo "$$LIBUSB0_TEST" > .test.c - @$(CC) -c $(CPPFLAGS) $(CFLAGS) .test.c -o .test.o >/dev/null && \ - echo "found." || ( echo "not found."; echo; \ + @{ { { { { $(CC) -c $(CPPFLAGS) $(CFLAGS) .test.c -o .test.o >&2 && \ + echo "found." || { echo "not found."; echo; \ echo "Please install libusb-0.1 headers or libusb-compat headers."; \ echo "See README for more information."; echo; \ - rm -f .test.c .test.o; exit 1) - @printf "Checking if libusb-0.1 is usable... " - @$(CC) $(LDFLAGS) .test.o -o .test$(EXEC_SUFFIX) $(LIBS) $(USBLIBS) >/dev/null && \ - echo "yes." || ( echo "no."; \ + rm -f .test.c .test.o; exit 1; }; } 2>>$(BUILD_DETAILS_FILE); echo $? >&3 ; } | tee -a $(BUILD_DETAILS_FILE) >&4; } 3>&1;} | { read rc ; exit ${rc}; } } 4>&1 + @printf "Checking if libusb-0.1 is usable... " | tee -a $(BUILD_DETAILS_FILE) + @{ { { { { $(CC) $(LDFLAGS) .test.o -o .test$(EXEC_SUFFIX) $(LIBS) $(USBLIBS) >&2 && \ + echo "yes." || { echo "no."; \ echo "Please install libusb-0.1 or libusb-compat."; \ echo "See README for more information."; echo; \ - rm -f .test.c .test.o .test$(EXEC_SUFFIX); exit 1) + rm -f .test.c .test.o .test$(EXEC_SUFFIX); exit 1; }; } 2>>$(BUILD_DETAILS_FILE); echo $? >&3 ; } | tee -a $(BUILD_DETAILS_FILE) >&4; } 3>&1;} | { read rc ; exit ${rc}; } } 4>&1 @rm -f .test.c .test.o .test$(EXEC_SUFFIX) endif @@ -1023,36 +1033,37 @@ export LINUX_I2C_TEST features: compiler @echo "FEATURES := yes" > .features.tmp ifeq ($(NEED_FTDI), yes) - @printf "Checking for FTDI support... " + @printf "Checking for FTDI support... " | tee -a $(BUILD_DETAILS_FILE) @echo "$$FTDI_TEST" > .featuretest.c - @$(CC) $(CPPFLAGS) $(CFLAGS) $(FTDI_INCLUDES) $(LDFLAGS) .featuretest.c -o .featuretest$(EXEC_SUFFIX) $(FTDILIBS) $(LIBS) >/dev/null 2>&1 && \ - ( echo "found."; echo "FTDISUPPORT := yes" >> .features.tmp ) || \ - ( echo "not found."; echo "FTDISUPPORT := no" >> .features.tmp ) - @printf "Checking for FT232H support in libftdi... " - @echo "$$FTDI_232H_TEST" >> .featuretest.c - @$(CC) $(CPPFLAGS) $(CFLAGS) $(FTDI_INCLUDES) $(LDFLAGS) .featuretest.c -o .featuretest$(EXEC_SUFFIX) $(FTDILIBS) $(LIBS) >/dev/null 2>&1 && \ - ( echo "found."; echo "FT232H := yes" >> .features.tmp ) || \ - ( echo "not found."; echo "FT232H := no" >> .features.tmp ) + @ { $(CC) $(CPPFLAGS) $(CFLAGS) $(FTDI_INCLUDES) $(LDFLAGS) .featuretest.c -o .featuretest$(EXEC_SUFFIX) $(FTDILIBS) $(LIBS) >&2 && \ + ( echo "found."; echo "FTDISUPPORT := yes" >> .features.tmp ; \ + printf "Checking for FT232H support in libftdi... " | tee -a $(BUILD_DETAILS_FILE) ; \ + echo "$$FTDI_232H_TEST" >> .featuretest.c ; \ + { $(CC) $(CPPFLAGS) $(CFLAGS) $(FTDI_INCLUDES) $(LDFLAGS) .featuretest.c -o .featuretest$(EXEC_SUFFIX) $(FTDILIBS) $(LIBS) >&2 && \ + ( echo "found."; echo "FT232H := yes" >> .features.tmp ) || \ + ( echo "not found."; echo "FT232H := no" >> .features.tmp ) } 2>>$(BUILD_DETAILS_FILE) | tee -a $(BUILD_DETAILS_FILE) \ + ) || \ + ( echo "not found."; echo "FTDISUPPORT := no" >> .features.tmp ) } 2>>$(BUILD_DETAILS_FILE) | tee -a $(BUILD_DETAILS_FILE) endif ifeq ($(CONFIG_LINUX_SPI), yes) - @printf "Checking if Linux SPI headers are present... " + @printf "Checking if Linux SPI headers are present... " | tee -a $(BUILD_DETAILS_FILE) @echo "$$LINUX_SPI_TEST" > .featuretest.c - @$(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) .featuretest.c -o .featuretest$(EXEC_SUFFIX) >/dev/null 2>&1 && \ + @ { $(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) .featuretest.c -o .featuretest$(EXEC_SUFFIX) >&2 && \ ( echo "yes."; echo "LINUX_SPI_SUPPORT := yes" >> .features.tmp ) || \ - ( echo "no."; echo "LINUX_SPI_SUPPORT := no" >> .features.tmp ) + ( echo "no."; echo "LINUX_SPI_SUPPORT := no" >> .features.tmp ) } 2>>$(BUILD_DETAILS_FILE) | tee -a $(BUILD_DETAILS_FILE) endif ifeq ($(NEED_LINUX_I2C), yes) - @printf "Checking if Linux I2C headers are present... " + @printf "Checking if Linux I2C headers are present... " | tee -a $(BUILD_DETAILS_FILE) @echo "$$LINUX_I2C_TEST" > .featuretest.c - @$(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) .featuretest.c -o .featuretest$(EXEC_SUFFIX) >/dev/null 2>&1 && \ + @ { $(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) .featuretest.c -o .featuretest$(EXEC_SUFFIX) >&2 && \ ( echo "yes."; echo "LINUX_I2C_SUPPORT := yes" >> .features.tmp ) || \ - ( echo "no."; echo "LINUX_I2C_SUPPORT := no" >> .features.tmp ) + ( echo "no."; echo "LINUX_I2C_SUPPORT := no" >> .features.tmp ) } 2>>$(BUILD_DETAILS_FILE) | tee -a $(BUILD_DETAILS_FILE) endif - @printf "Checking for utsname support... " + @printf "Checking for utsname support... " | tee -a $(BUILD_DETAILS_FILE) @echo "$$UTSNAME_TEST" > .featuretest.c - @$(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) .featuretest.c -o .featuretest$(EXEC_SUFFIX) >/dev/null 2>&1 && \ + @ { $(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) .featuretest.c -o .featuretest$(EXEC_SUFFIX) >&2 && \ ( echo "found."; echo "UTSNAME := yes" >> .features.tmp ) || \ - ( echo "not found."; echo "UTSNAME := no" >> .features.tmp ) + ( echo "not found."; echo "UTSNAME := no" >> .features.tmp ) } 2>>$(BUILD_DETAILS_FILE) | tee -a $(BUILD_DETAILS_FILE) @$(DIFF) -q .features.tmp .features >/dev/null 2>&1 && rm .features.tmp || mv .features.tmp .features @rm -f .featuretest.c .featuretest$(EXEC_SUFFIX) @@ -1085,4 +1096,7 @@ libpayload: clean .PHONY: all install clean distclean compiler hwlibs features export tarball djgpp-dos featuresavailable libpayload +# Disable implicit suffixes and built-in rules (for performance and profit) +.SUFFIXES: + -include $(OBJS:.o=.d) -- Kind regards, Stefan Tauner

1 0

[PATCH 1/3] Add support for libftdi1.
by Stefan Tauner 15 Nov '15

15 Nov '15

Many distros no longer provide libftdi 0.2, and as a result, programmers that depend on libftdi must be disabled. This means that popular programmers, such as ft2232_spi are now disabled in modern distros. Luckily the libftdi API did not change significantly, so for our purposes, we can simply use the newer headers and link to the newer library. Signed-off-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com> Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> --- Makefile | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index c439d8d..e68b106 100644 --- a/Makefile +++ b/Makefile @@ -634,8 +634,10 @@ NEED_USB := yes endif ifeq ($(NEED_FTDI), yes) -FTDILIBS := $(shell ([ -n "$(PKG_CONFIG_LIBDIR)" ] && export PKG_CONFIG_LIBDIR="$(PKG_CONFIG_LIBDIR)" ); pkg-config --libs libftdi || printf "%s" "-lftdi -lusb") +FTDILIBS := $(shell ([ -n "$(PKG_CONFIG_LIBDIR)" ] && export PKG_CONFIG_LIBDIR="$(PKG_CONFIG_LIBDIR)" ); pkg-config --libs libftdi1 || pkg-config --libs libftdi || printf "%s" "-lftdi -lusb") FEATURE_CFLAGS += $(shell LC_ALL=C grep -q "FT232H := yes" .features && printf "%s" "-D'HAVE_FT232H=1'") +FTDI_INCLUDES := $(shell ([ -n "$(PKG_CONFIG_LIBDIR)" ] && export PKG_CONFIG_LIBDIR="$(PKG_CONFIG_LIBDIR)" ); pkg-config --cflags-only-I libftdi1) +FEATURE_CFLAGS += $(FTDI_INCLUDES) FEATURE_LIBS += $(shell LC_ALL=C grep -q "FTDISUPPORT := yes" .features && printf "%s" "$(FTDILIBS)") # We can't set NEED_USB here because that would transform libftdi auto-enabling # into a hard requirement for libusb, defeating the purpose of auto-enabling. @@ -759,7 +761,7 @@ endif ifeq ($(NEED_USB), yes) CHECK_LIBUSB0 = yes FEATURE_CFLAGS += -D'NEED_USB=1' -USBLIBS := $(shell ([ -n "$(PKG_CONFIG_LIBDIR)" ] && export PKG_CONFIG_LIBDIR="$(PKG_CONFIG_LIBDIR)" ); pkg-config --libs libusb || printf "%s" "-lusb") +USBLIBS := $(shell ([ -n "$(PKG_CONFIG_LIBDIR)" ] && export PKG_CONFIG_LIBDIR="$(PKG_CONFIG_LIBDIR)" ); pkg-config --libs libusb || printf "%s" "-lusb") endif ifeq ($(CONFIG_PRINT_WIKI), yes) @@ -1023,12 +1025,12 @@ features: compiler ifeq ($(NEED_FTDI), yes) @printf "Checking for FTDI support... " @echo "$$FTDI_TEST" > .featuretest.c - @$(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) .featuretest.c -o .featuretest$(EXEC_SUFFIX) $(FTDILIBS) $(LIBS) >/dev/null 2>&1 && \ + @$(CC) $(CPPFLAGS) $(CFLAGS) $(FTDI_INCLUDES) $(LDFLAGS) .featuretest.c -o .featuretest$(EXEC_SUFFIX) $(FTDILIBS) $(LIBS) >/dev/null 2>&1 && \ ( echo "found."; echo "FTDISUPPORT := yes" >> .features.tmp ) || \ ( echo "not found."; echo "FTDISUPPORT := no" >> .features.tmp ) @printf "Checking for FT232H support in libftdi... " @echo "$$FTDI_232H_TEST" >> .featuretest.c - @$(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) .featuretest.c -o .featuretest$(EXEC_SUFFIX) $(FTDILIBS) $(LIBS) >/dev/null 2>&1 && \ + @$(CC) $(CPPFLAGS) $(CFLAGS) $(FTDI_INCLUDES) $(LDFLAGS) .featuretest.c -o .featuretest$(EXEC_SUFFIX) $(FTDILIBS) $(LIBS) >/dev/null 2>&1 && \ ( echo "found."; echo "FT232H := yes" >> .features.tmp ) || \ ( echo "not found."; echo "FT232H := no" >> .features.tmp ) endif -- Kind regards, Stefan Tauner

1 0

[PATCH 0/3] The makefile is too simple - let's improve on that
by Stefan Tauner 15 Nov '15

15 Nov '15

Hi, the first patch comes from mrnuke who had to jump through some hoops to get flashrom compile on newer fedora releases due to the removal of the old libftdi. The second patch deals with the numerous background jobs our makefile does, e.g. to detect support for certain libraries. I was always annoyed by the bad usability in that regard - we did not inform the user properly. With the patch we separate the easy to read messages from the debugging information in another file. It also fixes some minor bugs I might have introduced previously, and also highlights how bad we do some things... like expaning a make variable that contains multiple shell invocations for *every* C file we compile (still better than autotools). The last one was the actual goal of the second patch... to simply enable static linking of flashrom. But as always I was touching lots of other stuff... that's what the second patch became and so this one is very simply actually. Stefan Tauner (3): Add support for libftdi1. Make make errors more less flashily. Add support for linking statically with CONFIG_STATIC=yes. Makefile | 139 ++++++++++++++++++++++++++++++++++++--------------------------- 1 file changed, 80 insertions(+), 59 deletions(-) -- Kind regards, Stefan Tauner

1 0

flashrom -V
by Alexey Belyaev 15 Nov '15

15 Nov '15

$ sudo flashrom -V --programmer internal flashrom v0.9.6.1-r1563 on Linux 3.19.0-22-generic (x86_64) flashrom is free software, get the source code at http://www.flashrom.org flashrom was built with libpci 3.1.9, GCC 4.7.1, little endian Command line (3 args): flashrom -V --programmer internal Calibrating delay loop... OS timer resolution is 1 usecs, 1296M loops per second, 10 myus = 10 us, 100 myus = 95 us, 1000 myus = 957 us, 10000 myus = 9598 us, 4 myus = 4 us, OK. Initializing internal programmer No coreboot table found. DMI string system-manufacturer: "To Be Filled By O.E.M." DMI string system-product-name: "To Be Filled By O.E.M." DMI string system-version: "To Be Filled By O.E.M." DMI string baseboard-manufacturer: "ASRock" DMI string baseboard-product-name: "N68C-S UCC" DMI string baseboard-version: " " DMI string chassis-type: "Desktop" Found chipset "NVIDIA MCP61" with PCI ID 10de:03e1. Enabling flash write... This chipset is not really supported yet. Guesswork... ISA/LPC bridge reg 0x8a contents: 0x40, bit 6 is 1, bit 5 is 0 Flash bus type is SPI SPI on this chipset is WIP. Please report any success or failure by mailing us the verbose output to flashrom(a)flashrom.org, thanks! Found SMBus device 10de:03eb at 00:01:1 MCP SPI BAR is at 0xfec80000 Mapping NVIDIA MCP6x SPI at 0xfec80000, unaligned size 0x544. SPI control is 0x0002, req=0, gnt=0 Please send the output of "flashrom -V" to flashrom(a)flashrom.org with your board name: flashrom -V as the subject to help us finish support for your chipset. Thanks. OK. WARNING: unexpected second chipset match: "NVIDIA MCP61" ignoring, please report lspci and board URL to flashrom(a)flashrom.org with 'CHIPSET: your board name' in the subject line. The following protocols are supported: SPI. Probing for AMIC A25L05PT, 64 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for AMIC A25L05PU, 64 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for AMIC A25L10PT, 128 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for AMIC A25L10PU, 128 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for AMIC A25L20PT, 256 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for AMIC A25L20PU, 256 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for AMIC A25L40PT, 512 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for AMIC A25L40PU, 512 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for AMIC A25L80P, 1024 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for AMIC A25L16PT, 2048 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for AMIC A25L16PU, 2048 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for AMIC A25L512, 64 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for AMIC A25L010, 128 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for AMIC A25L020, 256 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for AMIC A25L040, 512 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for AMIC A25L080, 1024 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for AMIC A25L016, 2048 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for AMIC A25L032, 4096 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for AMIC A25LQ032, 4096 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Atmel AT25DF021, 256 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Atmel AT25DF041A, 512 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Atmel AT25DF081, 1024 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Atmel AT25DF081A, 1024 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Atmel AT25DF161, 2048 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Atmel AT25DF321, 4096 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Atmel AT25DF321A, 4096 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Atmel AT25DF641(A), 8192 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Atmel AT25DQ161, 2048 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Atmel AT25F512B, 64 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Atmel AT25FS010, 128 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Atmel AT25FS040, 512 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Atmel AT26DF041, 512 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Atmel AT26DF081A, 1024 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Atmel AT26DF161, 2048 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Atmel AT26DF161A, 2048 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Atmel AT26F004, 512 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Atmel AT45CS1282, 16896 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Atmel AT45DB011D, 128 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Atmel AT45DB021D, 256 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Atmel AT45DB041D, 512 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Atmel AT45DB081D, 1024 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Atmel AT45DB161D, 2048 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Atmel AT45DB321C, 4224 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Atmel AT45DB321D, 4096 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Atmel AT45DB642D, 8192 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for EMST F25L008A, 1024 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25B05, 64 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25B05T, 64 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25B10, 128 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25B10T, 128 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25B20, 256 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25B20T, 256 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25B40, 512 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25B40T, 512 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25B80, 1024 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25B80T, 1024 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25B16, 2048 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25B16T, 2048 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25B32, 4096 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25B32T, 4096 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25B64, 8192 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25B64T, 8192 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25F05, 64 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25F10, 128 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25F20, 256 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25F40, 512 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25F80, 1024 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25F16, 2048 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25F32, 4096 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25Q40, 512 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25Q80(A), 1024 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25Q16, 2048 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25Q32(A/B), 4096 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25Q64, 8192 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25Q128, 16384 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25QH16, 2048 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon EN25QH32, 4096 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for GigaDevice GD25Q20, 256 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for GigaDevice GD25Q40, 512 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for GigaDevice GD25Q80, 1024 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for GigaDevice GD25Q16, 2048 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for GigaDevice GD25Q32, 4096 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for GigaDevice GD25Q64, 8192 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for GigaDevice GD25Q128, 16384 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Macronix MX25L512, 64 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Macronix MX25L1005, 128 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Macronix MX25L2005, 256 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Macronix MX25L4005, 512 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Macronix MX25L8005, 1024 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Macronix MX25L1605, 2048 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Macronix MX25L1635D, 2048 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Macronix MX25L1635E, 2048 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Macronix MX25L3205, 4096 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Macronix MX25L3235D, 4096 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Macronix MX25L6405, 8192 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Macronix MX25L12805, 16384 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Numonyx M25PE10, 128 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Numonyx M25PE20, 256 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Numonyx M25PE40, 512 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Numonyx M25PE80, 1024 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Numonyx M25PE16, 2048 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Numonyx N25Q064, 8192 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for PMC Pm25LV010, 128 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for PMC Pm25LV016B, 2048 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for PMC Pm25LV020, 256 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for PMC Pm25LV040, 512 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for PMC Pm25LV080B, 1024 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for PMC Pm25LV512, 64 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Sanyo LF25FW203A, 2048 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Spansion S25FL004A, 512 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Spansion S25FL008A, 1024 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Spansion S25FL016A, 2048 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Spansion S25FL032A, 4096 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Spansion S25FL064A, 8192 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for SST SST25LF040A, 512 kB: probe_spi_res2: id1 0x13, id2 0x13 Probing for SST SST25LF080A, 1024 kB: probe_spi_res2: id1 0x13, id2 0x13 Probing for SST SST25VF010, 128 kB: probe_spi_rems: id1 0xef, id2 0x13 Probing for SST SST25VF016B, 2048 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for SST SST25VF032B, 4096 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for SST SST25VF064C, 8192 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for SST SST25VF040, 512 kB: probe_spi_rems: id1 0xef, id2 0x13 Probing for SST SST25VF040B, 512 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for SST SST25VF040B.REMS, 512 kB: probe_spi_rems: id1 0xef, id2 0x13 Probing for SST SST25VF080B, 1024 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for ST M25P05-A, 64 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for ST M25P05, 64 kB: Ignoring RES in favour of RDID. Probing for ST M25P10-A, 128 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for ST M25P10, 128 kB: Ignoring RES in favour of RDID. Probing for ST M25P20, 256 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for ST M25P40, 512 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for ST M25P40-old, 512 kB: Ignoring RES in favour of RDID. Probing for ST M25P80, 1024 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for ST M25P16, 2048 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for ST M25P32, 4096 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for ST M25P64, 8192 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for ST M25P128, 16384 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for ST M25PX16, 2048 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for ST M25PX32, 4096 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for ST M25PX64, 8192 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Winbond W25Q80, 1024 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Chip status register is 00 Found Winbond flash chip "W25Q80" (1024 kB, SPI) at physical address 0xfff00000. Probing for Winbond W25Q16, 2048 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Winbond W25Q32, 4096 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Winbond W25Q64, 8192 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Winbond W25Q128, 16384 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Winbond W25X10, 128 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Winbond W25X20, 256 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Winbond W25X40, 512 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Winbond W25X80, 1024 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Winbond W25X16, 2048 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Winbond W25X32, 4096 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Winbond W25X64, 8192 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Unknown SFDP-capable chip, 0 kB: No SFDP signature found. Probing for AMIC unknown AMIC SPI chip, 0 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Atmel unknown Atmel SPI chip, 0 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Eon unknown Eon SPI chip, 0 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Macronix unknown Macronix SPI chip, 0 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for PMC unknown PMC SPI chip, 0 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for SST unknown SST SPI chip, 0 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for ST unknown ST SPI chip, 0 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Sanyo unknown Sanyo SPI chip, 0 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Generic unknown SPI chip (RDID), 0 kB: probe_spi_rdid_generic: id1 0xef, id2 0x4014 Probing for Generic unknown SPI chip (REMS), 0 kB: probe_spi_rems: id1 0xef, id2 0x13 Found Winbond flash chip "W25Q80" (1024 kB, SPI). This chip may contain one-time programmable memory. flashrom cannot read and may never be able to write it, hence it may not be able to completely clone the contents of this chip (see man page for details). No operations were specified.

1 0

Re: [flashrom] [PATCH] Use nanosleep() instead of usleep() where available.
by Stefan Tauner 14 Nov '15

14 Nov '15

On Sun, 1 Nov 2015 05:16:27 +0100 Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> wrote: > usleep() has been obsolete for quite a while. > The only target where it is currently used without alternative is DOS. > > Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Committed in r1899. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

Re: [flashrom] [PATCH] Add (implicit) support for musl libc.
by Stefan Tauner 14 Nov '15

14 Nov '15

On Sat, 31 Oct 2015 21:50:59 +0100 Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> wrote: > This is mostly achieved by fixing or refining the inclusion of header > files and replacing glibc-specific ifdefs with more generic ones. > > - <sys/io.h>: Contains iopl(2) and x86 I/O port access functions (inb, outb etc). > Generally Linux-specific but also availble on debian/kFreeBSD. > Provided by glibc as well as musl and uclibc. > Include it if we are running Linux or if glibc is detected. > - <sys/fcntl.h>: should be (and is) replaced by <fcntl.h> (without the > "sys" prefix). > - <linux/spi/spidev.h>: Does not include all necessary headers, namely > _IOC_SIZEBITS that is used in the definition of > SPI_MSGSIZE is not brought in via <linux/ioctl.h> > but instead we relied so far on glibc's including > it via <sys/ioctl.h>. Change that to explicitly > including <linux/ioctl.h>. > - <endian.h>: Would also be available in musl but there is no easy way > to detect it so we do not try yet. > > The bug report and initial patches were > Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou(a)trabucayre.com> > > Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Committed in r1898. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

[commit] r1899 - trunk
by repository service 14 Nov '15

14 Nov '15

Author: stefanct Date: Sat Nov 14 03:55:22 2015 New Revision: 1899 URL: http://flashrom.org/trac/flashrom/changeset/1899 Log: Use nanosleep() instead of usleep() where available. usleep() has been obsolete for quite a while. The only target that uses it without alternative is DOS. Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Acked-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Modified: trunk/udelay.c Modified: trunk/udelay.c ============================================================================== --- trunk/udelay.c Sat Nov 14 03:55:12 2015 (r1898) +++ trunk/udelay.c Sat Nov 14 03:55:22 2015 (r1899) @@ -22,6 +22,7 @@ #ifndef __LIBPAYLOAD__ #include <unistd.h> +#include <time.h> #include <sys/time.h> #include <stdlib.h> #include <limits.h> @@ -174,9 +175,11 @@ { #if IS_WINDOWS Sleep((usecs + 999) / 1000); -#else +#elif defined(__DJGPP__) sleep(usecs / 1000000); usleep(usecs % 1000000); +#else + nanosleep(&(struct timespec){usecs / 1000000, (usecs * 1000) % 1000000000UL}, NULL); #endif }

1 0

[commit] r1898 - trunk
by repository service 14 Nov '15

14 Nov '15

Author: stefanct Date: Sat Nov 14 03:55:12 2015 New Revision: 1898 URL: http://flashrom.org/trac/flashrom/changeset/1898 Log: Add (implicit) support for musl libc. This is mostly achieved by fixing or refining the inclusion of header files and replacing glibc-specific ifdefs with more generic ones. - <sys/io.h>: Contains iopl(2) and x86 I/O port access functions (inb, outb etc). Generally Linux-specific but also availble on debian/kFreeBSD. Provided by glibc as well as musl and uclibc. Include it if we are running Linux or if glibc is detected. - <sys/fcntl.h>: should be (and is) replaced by <fcntl.h> (without the "sys" prefix). - <linux/spi/spidev.h>: Does not include all necessary headers, namely _IOC_SIZEBITS that is used in the definition of SPI_MSGSIZE is not brought in via <linux/ioctl.h> but instead we relied so far on glibc's including it via <sys/ioctl.h>. Change that to explicitly including <linux/ioctl.h>. - <endian.h>: Would also be available in musl but there is no easy way to detect it so we do not try yet. The bug report and initial patches were Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou(a)trabucayre.com> Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Acked-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Modified: trunk/hwaccess.h trunk/linux_spi.c Modified: trunk/hwaccess.h ============================================================================== --- trunk/hwaccess.h Fri Oct 16 04:16:20 2015 (r1897) +++ trunk/hwaccess.h Sat Nov 14 03:55:12 2015 (r1898) @@ -26,12 +26,6 @@ #include "platform.h" -#if IS_X86 -#if defined(__GLIBC__) -#include <sys/io.h> -#endif -#endif - #if NEED_PCI == 1 /* * libpci headers use the variable name "index" which triggers shadowing @@ -115,6 +109,7 @@ #if !defined (__FLASHROM_BIG_ENDIAN__) && !defined (__FLASHROM_LITTLE_ENDIAN__) /* Nonstandard libc-specific macros for determining endianness. */ +/* musl provides an endian.h as well... but it can not be detected from within C. */ #if defined(__GLIBC__) #include <endian.h> #if BYTE_ORDER == LITTLE_ENDIAN @@ -204,6 +199,13 @@ #if NEED_PCI == 1 #if IS_X86 +/* sys/io.h provides iopl(2) and x86 I/O port access functions (inb, outb etc). + * It is included in glibc (thus available also on debian/kFreeBSD) but also in other libcs that mimic glibc, + * e.g. musl and uclibc. */ +#if defined(__linux__) || defined(__GLIBC__) +#include <sys/io.h> +#endif + #define __FLASHROM_HAVE_OUTB__ 1 /* for iopl and outb under Solaris */ Modified: trunk/linux_spi.c ============================================================================== --- trunk/linux_spi.c Fri Oct 16 04:16:20 2015 (r1897) +++ trunk/linux_spi.c Sat Nov 14 03:55:12 2015 (r1898) @@ -22,13 +22,14 @@ #include <stdio.h> #include <string.h> #include <stdlib.h> -#include <sys/fcntl.h> +#include <fcntl.h> #include <errno.h> #include <ctype.h> #include <unistd.h> +#include <sys/ioctl.h> #include <linux/types.h> #include <linux/spi/spidev.h> -#include <sys/ioctl.h> +#include <linux/ioctl.h> #include "flash.h" #include "chipdrivers.h" #include "programmer.h"

1 0

Re: [flashrom] Error write Spansion S25FL023P0XMFI011
by Stefan Tauner 12 Nov '15

12 Nov '15

On Thu, 12 Nov 2015 13:07:54 +0200 Daniel Stelian Dobre <dobredanielstelian(a)gmail.com> wrote: > Hello, > > I have a little problem writeing Spansion S25FL023P0XMFI011 (32Mb). > I am using flashrom-0.9.6.1-r1705 and the DLP-USB1232H. > > The schematic is http://flashrom.org/File:Dlp_usb1232h_spi_programmer.jpg > > it works to reat the momty but when i try to write it it gives this error: > > *C:\Users\mxxxxx\Desktop\PirateBuss\flashrom-0.9.6.1-r1705-mingw\flashrom-0.9.6.1* > *-r1705-mingw>flashrom -p ft2232_spi:type=2232H,port=A -w S25FL_ORIG.mcs* > *flashrom v0.9.6.1-r1704 on Windows 6.1 (x86)* > *flashrom is free software, get the source code at http://www.flashrom.org > <http://www.flashrom.org>* > > *Calibrating delay loop... OK.* > *Found Spansion flash chip "S25FL032A/P" (4096 kB, SPI) on ft2232_spi.* > *Error: Image size (936773 B) doesn't match the flash chip's size (4194304 > B)!* > > Any ideas ? That you should not try to write random files to your flash chip... I think the error message is quite clear? -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

Re: [flashrom] Will FlashROM support SPI programmer based on CH341A?
by Stefan Tauner 12 Nov '15

12 Nov '15

On Tue, 10 Nov 2015 17:55:08 +0300 Sergey SFH <arhichief(a)gmail.com> wrote: > Greatings. I want to buy SPI FLASH programmer based on CH341A. Will > FlashROM work with this type of programmers? And if it will, how I have to > use FlashROM with this programmer? Hi Sergey, it does not yet, but it will eventually. I have a programmer with that chip and some code but it is not completely ready. And it is in this state since July and I did not find time to complete it yet. So to be honest... it might take another few months until I finish it. There is another open source utility that supports the programmer but is a bit limited compared to flashrom. You can find the other software here: https://github.com/setarcos/ch341prog -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

2 1

Error write Spansion S25FL023P0XMFI011
by Daniel Stelian Dobre 12 Nov '15

12 Nov '15

Hello, I have a little problem writeing Spansion S25FL023P0XMFI011 (32Mb). I am using flashrom-0.9.6.1-r1705 and the DLP-USB1232H. The schematic is http://flashrom.org/File:Dlp_usb1232h_spi_programmer.jpg it works to reat the momty but when i try to write it it gives this error: *C:\Users\mxxxxx\Desktop\PirateBuss\flashrom-0.9.6.1-r1705-mingw\flashrom-0.9.6.1* *-r1705-mingw>flashrom -p ft2232_spi:type=2232H,port=A -w S25FL_ORIG.mcs* *flashrom v0.9.6.1-r1704 on Windows 6.1 (x86)* *flashrom is free software, get the source code at http://www.flashrom.org <http://www.flashrom.org>* *Calibrating delay loop... OK.* *Found Spansion flash chip "S25FL032A/P" (4096 kB, SPI) on ft2232_spi.* *Error: Image size (936773 B) doesn't match the flash chip's size (4194304 B)!* Any ideas ? *Best regards,* *Daniel Stelian Dobre*

1 0

New Log
by Jose Luis León 11 Nov '15

11 Nov '15

New Log flashrom -p serprog:dev=/dev/ttyACM0:115200 -o test.txt

1 0

[PATCH 1/3] 128 bytes write granularity support
by Paul Kocialkowski 11 Nov '15

11 Nov '15

Some chips such as the ENE KB9012 internal flash require a write granularity of 128 bytes. Signed-off-by: Paul Kocialkowski <contact(a)paulk.fr> --- flash.h | 1 + flashrom.c | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/flash.h b/flash.h index 2c2839f..24861ba 100644 --- a/flash.h +++ b/flash.h @@ -85,6 +85,7 @@ enum write_granularity { write_gran_1bit, /* Each bit can be cleared individually. */ write_gran_1byte, /* A byte can be written once. Further writes to an already written byte cause * its contents to be either undefined or to stay unchanged. */ + write_gran_128bytes, /* If less than 128 bytes are written, the unwritten bytes are undefined. */ write_gran_264bytes, /* If less than 264 bytes are written, the unwritten bytes are undefined. */ write_gran_512bytes, /* If less than 512 bytes are written, the unwritten bytes are undefined. */ write_gran_528bytes, /* If less than 528 bytes are written, the unwritten bytes are undefined. */ diff --git a/flashrom.c b/flashrom.c index d51a44c..c9c7e31 100644 --- a/flashrom.c +++ b/flashrom.c @@ -781,6 +781,9 @@ int need_erase(const uint8_t *have, const uint8_t *want, unsigned int len, enum break; } break; + case write_gran_128bytes: + result = need_erase_gran_bytes(have, want, len, 128); + break; case write_gran_256bytes: result = need_erase_gran_bytes(have, want, len, 256); break; @@ -847,6 +850,9 @@ static unsigned int get_next_write(const uint8_t *have, const uint8_t *want, uns case write_gran_1byte_implicit_erase: stride = 1; break; + case write_gran_128bytes: + stride = 128; + break; case write_gran_256bytes: stride = 256; break; -- 1.9.1

4 16

[PATCH v2 1/2] Flag-driven erased bit value
by Paul Kocialkowski 11 Nov '15

11 Nov '15

Most flash chips are erased to ones and programmed to zeros. However, some other flash chips, such as the ENE KB9012 internal flash, work the opposite way. Signed-off-by: Paul Kocialkowski <contact(a)paulk.fr> --- flash.h | 5 ++++- flashrom.c | 39 +++++++++++++++++++++------------------ 2 files changed, 25 insertions(+), 19 deletions(-) diff --git a/flash.h b/flash.h index 24861ba..55d02de 100644 --- a/flash.h +++ b/flash.h @@ -123,6 +123,9 @@ enum write_granularity { #define FEATURE_WRSR_EITHER (FEATURE_WRSR_EWSR | FEATURE_WRSR_WREN) #define FEATURE_OTP (1 << 8) #define FEATURE_QPI (1 << 9) +#define FEATURE_ERASED_ZERO (1 << 10) + +#define ERASED_VALUE(flash) ((flash->chip->feature_bits & FEATURE_ERASED_ZERO) ? 0x00 : 0xff) enum test_state { OK = 0, @@ -275,7 +278,7 @@ int probe_flash(struct registered_master *mst, int startchip, struct flashctx *f int read_flash_to_file(struct flashctx *flash, const char *filename); char *extract_param(const char *const *haystack, const char *needle, const char *delim); int verify_range(struct flashctx *flash, const uint8_t *cmpbuf, unsigned int start, unsigned int len); -int need_erase(const uint8_t *have, const uint8_t *want, unsigned int len, enum write_granularity gran); +int need_erase(const uint8_t *have, const uint8_t *want, unsigned int len, enum write_granularity gran, const uint8_t erased_value); void print_version(void); void print_buildinfo(void); void print_banner(void); diff --git a/flashrom.c b/flashrom.c index c9c7e31..bd8ef3f 100644 --- a/flashrom.c +++ b/flashrom.c @@ -673,12 +673,13 @@ int check_erased_range(struct flashctx *flash, unsigned int start, { int ret; uint8_t *cmpbuf = malloc(len); + const uint8_t erased_value = ERASED_VALUE(flash); if (!cmpbuf) { msg_gerr("Could not allocate memory!\n"); exit(1); } - memset(cmpbuf, 0xff, len); + memset(cmpbuf, erased_value, len); ret = verify_range(flash, cmpbuf, start, len); free(cmpbuf); return ret; @@ -731,7 +732,7 @@ out_free: } /* Helper function for need_erase() that focuses on granularities of gran bytes. */ -static int need_erase_gran_bytes(const uint8_t *have, const uint8_t *want, unsigned int len, unsigned int gran) +static int need_erase_gran_bytes(const uint8_t *have, const uint8_t *want, unsigned int len, unsigned int gran, const uint8_t erased_value) { unsigned int i, j, limit; for (j = 0; j < len / gran; j++) { @@ -741,7 +742,7 @@ static int need_erase_gran_bytes(const uint8_t *have, const uint8_t *want, unsig continue; /* have needs to be in erased state. */ for (i = 0; i < limit; i++) - if (have[j * gran + i] != 0xff) + if (have[j * gran + i] != erased_value) return 1; } return 0; @@ -761,7 +762,7 @@ static int need_erase_gran_bytes(const uint8_t *have, const uint8_t *want, unsig * @gran write granularity (enum, not count) * @return 0 if no erase is needed, 1 otherwise */ -int need_erase(const uint8_t *have, const uint8_t *want, unsigned int len, enum write_granularity gran) +int need_erase(const uint8_t *have, const uint8_t *want, unsigned int len, enum write_granularity gran, const uint8_t erased_value) { int result = 0; unsigned int i; @@ -776,31 +777,31 @@ int need_erase(const uint8_t *have, const uint8_t *want, unsigned int len, enum break; case write_gran_1byte: for (i = 0; i < len; i++) - if ((have[i] != want[i]) && (have[i] != 0xff)) { + if ((have[i] != want[i]) && (have[i] != erased_value)) { result = 1; break; } break; case write_gran_128bytes: - result = need_erase_gran_bytes(have, want, len, 128); + result = need_erase_gran_bytes(have, want, len, 128, erased_value); break; case write_gran_256bytes: - result = need_erase_gran_bytes(have, want, len, 256); + result = need_erase_gran_bytes(have, want, len, 256, erased_value); break; case write_gran_264bytes: - result = need_erase_gran_bytes(have, want, len, 264); + result = need_erase_gran_bytes(have, want, len, 264, erased_value); break; case write_gran_512bytes: - result = need_erase_gran_bytes(have, want, len, 512); + result = need_erase_gran_bytes(have, want, len, 512, erased_value); break; case write_gran_528bytes: - result = need_erase_gran_bytes(have, want, len, 528); + result = need_erase_gran_bytes(have, want, len, 528, erased_value); break; case write_gran_1024bytes: - result = need_erase_gran_bytes(have, want, len, 1024); + result = need_erase_gran_bytes(have, want, len, 1024, erased_value); break; case write_gran_1056bytes: - result = need_erase_gran_bytes(have, want, len, 1056); + result = need_erase_gran_bytes(have, want, len, 1056, erased_value); break; case write_gran_1byte_implicit_erase: /* Do not erase, handle content changes from anything->0xff by writing 0xff. */ @@ -1424,6 +1425,7 @@ static int erase_and_write_block_helper(struct flashctx *flash, unsigned int starthere = 0, lenhere = 0; int ret = 0, skip = 1, writecount = 0; enum write_granularity gran = flash->chip->gran; + const uint8_t erased_value = ERASED_VALUE(flash); /* curcontents and newcontents are opaque to walk_eraseregions, and * need to be adjusted here to keep the impression of proper abstraction @@ -1431,7 +1433,7 @@ static int erase_and_write_block_helper(struct flashctx *flash, curcontents += start; newcontents += start; msg_cdbg(":"); - if (need_erase(curcontents, newcontents, len, gran)) { + if (need_erase(curcontents, newcontents, len, gran, erased_value)) { msg_cdbg("E"); ret = erasefn(flash, start, len); if (ret) @@ -1441,7 +1443,7 @@ static int erase_and_write_block_helper(struct flashctx *flash, return -1; } /* Erase was successful. Adjust curcontents. */ - memset(curcontents, 0xff, len); + memset(curcontents, erased_value, len); skip = 0; } /* get_next_write() sets starthere to a new value after the call. */ @@ -1938,6 +1940,7 @@ int doit(struct flashctx *flash, int force, const char *filename, int read_it, int ret = 0; unsigned long size = flash->chip->total_size * 1024; int read_all_first = 1; /* FIXME: Make this configurable. */ + const uint8_t erased_value = ERASED_VALUE(flash); if (chip_safety_check(flash, force, read_it, write_it, erase_it, verify_it)) { msg_cerr("Aborting.\n"); @@ -1964,15 +1967,15 @@ int doit(struct flashctx *flash, int force, const char *filename, int read_it, msg_gerr("Out of memory!\n"); exit(1); } - /* Assume worst case: All bits are 0. */ - memset(oldcontents, 0x00, size); + /* Assume worst case: All bits are not erased. */ + memset(oldcontents, ~erased_value, size); newcontents = malloc(size); if (!newcontents) { msg_gerr("Out of memory!\n"); exit(1); } - /* Assume best case: All bits should be 1. */ - memset(newcontents, 0xff, size); + /* Assume best case: All bits should be erased. */ + memset(newcontents, erased_value, size); /* Side effect of the assumptions above: Default write action is erase * because newcontents looks like a completely erased chip, and * oldcontents being completely 0x00 means we have to erase everything -- 2.4.3

2 5

Re: [flashrom] [coreboot] Re : FOSDEM deadlines now!
by Carl-Daniel Hailfinger 11 Nov '15

11 Nov '15

[DEADLINE IS NOW+48 hours!] Hi, thanks to Paul and Florentin for announcing they will come and thanks to Paul for submitting a talk! Who else is coming? Do we want one or two tables? Regards, Carl-Daniel On 21.10.2015 10:15, echelon(a)free.fr (Florentin) wrote: > +1 > > * for the stands count me in : I can bring my AMD boards and if all is going well I will be able to do demos on my G505s laptop. (I will also bring various electronic stuff and tools..) > * for the main tracks I cannot help unfortunately > * for the lightining traks I have some (bold!) ideeas but they are not mature yet (and I must first discuss with you about this .. maybe on irc..) On 31.10.2015 10:41, Paul Kocialkowski wrote: > I will definitely be around at FOSDEM, not sure I should have a seat at > the table at this point (I'm still pretty new to the community), but I'd > be happy to come by! > ----- Mail d'origine ----- > De: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> > À: coreboot <coreboot(a)coreboot.org>, flashrom <flashrom(a)flashrom.org> > Envoyé: Tue, 20 Oct 2015 23:20:56 +0200 (CEST) > Objet: [coreboot] FOSDEM deadlines now! > > Hi, > > we obviously want to participate in FOSDEM. > https://fosdem.org/2016/news/2015-09-24-call-for-participation/ > > ACT NOW! > > Some deadlines already expired. Some can still be managed. > > Main track talks: Deadline 2015-10-30 (10 days left) > One hour of entertainment, huge audience. > Anyone up for the challenge? > > Stands: Deadline 2015-11-13 (24 days left) > I can send in the proposal if I'm not going to be alone there. > How many tables do we want for our stand/booth(s)? > Who is coming? > > Lightning talks: Deadline 2015-11-27 (38 days left) > Short and to the point. Your 15-minute elevator pitch. > Can you sell the project? > > All deadlines are at 23.59 UTC > > Developer room proposal: Deadline EXPIRED > Maybe some developer room will accept talks/demos from us. > > Regards, > Carl-Daniel > >

1 0

Re: [flashrom] Other Log, have information relevant
by Stefan Tauner 11 Nov '15

11 Nov '15

On Mon, 9 Nov 2015 19:27:49 -0700 Jose Luis León <zenky1(a)gmail.com> wrote: > I did modify the file patch and replace this: > + .name = "LE25FU406C/LE25U40CMC", > > for this: > + .name = "LE25FU406C", > > and execute the command: > flashrom -p serprog:dev=/dev/ttyACM0:115200 -V -c LE25FU406C -o log2.txt > > and show information interesting Hi Jose, please leave out the -c LE25FU406C parameter. We need to see how the chip replies to probes for other chips as well. flashrom -p serprog:dev=/dev/ttyACM0:115200 -o probe.txt The command above should suffice. Please reply again with the probe.txt attached. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

2 1

Re: [flashrom] please, helpme. AMI BIOS SPI FLASH ROM 96 MB
by Idwer Vollering 10 Nov '15

10 Nov '15

2015-11-09 23:42 GMT+01:00 Alberto Perez <ksian1685(a)gmail.com>: > please, helpme. i want flashear mi notebook > (http://bangho.com.ar/wp-content/uploads/2015/04/Ultrabook-Bangho-ZERO-1430-…) > but I do not know how to do it. > I do not know what parameter to use in --programmer. You'll want to look at this page, for hardware 'friendly names': http://www.flashrom.org/Supported_hardware#USB_Devices > my bios is AMI BIOS SPI Flash ROM de 96 M b > Por favor, alguien puede ayudarme: Quiero hacer un volcado de la memoria rom > de mi notebook pero no sé cómo hacerlo. flashrom (as a CLI binary) doesn't handle translations. > > > _______________________________________________ > flashrom mailing list > flashrom(a)flashrom.org > http://www.flashrom.org/mailman/listinfo/flashrom

1 0

Will FlashROM support SPI programmer based on CH341A?
by Sergey SFH 10 Nov '15

10 Nov '15

Greatings. I want to buy SPI FLASH programmer based on CH341A. Will FlashROM work with this type of programmers? And if it will, how I have to use FlashROM with this programmer? Thanks in advance. P.S. Here is the link to programmer, I want to buy: http://www.aliexpress.com/item/CH341A-Series-24-EEPROM-Writer-25-SPI-routin…

1 0

Other Log, have information relevant
by Jose Luis León 10 Nov '15

10 Nov '15

I did modify the file patch and replace this: + .name = "LE25FU406C/LE25U40CMC", for this: + .name = "LE25FU406C", and execute the command: flashrom -p serprog:dev=/dev/ttyACM0:115200 -V -c LE25FU406C -o log2.txt and show information interesting Link in choapp http://chopapp.com/#f81lkgy7 attach of log:

1 0

Log Full Flashrom
by Jose Luis León 10 Nov '15

10 Nov '15

Log full: http://chopapp.com/#i794hbux ----------- Other command: flashrom -p serprog:dev=/dev/ttyACM0:115200 -V -c LE25FU406C flashrom v0.9.8-r1888 on Linux 3.19.0-25-generic (i686) flashrom is free software, get the source code at http://www.flashrom.org flashrom was built with libpci 3.2.1, GCC 4.8.4, little endian Command line (5 args): flashrom -p serprog:dev=/dev/ttyACM0:115200 -V -c LE25FU406C Error: Unknown chip 'LE25FU406C' specified. Run flashrom -L to view the hardware supported in this flashrom version. ----------------------------- look this information: zenky@zenky-HP-Mini-110-1000:~/Descargas/flashrom-0.9.8$ flashrom -L | grep LE25FU406CSanyo LE25FU406C/ 512 SPI is it normal the / about last character?

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom