- flashrom - mail.coreboot.org

[PATCH] Switch to AAI for some more SST chips
by Joshua Roys 07 Oct '10

07 Oct '10

Hello, Attached is a patch to switch a few more chips to AAI write. A comment is added to two entries due to the datasheets claiming AAI support but via a different opcode. I was able to test programming on one chip and the write time was more than halved. Signed-off-by: Joshua Roys <roysjosh(a)gmail.com> Josh

1 0

[commit] r1199 - trunk
by repository service 07 Oct '10

07 Oct '10

Author: hailfinger Date: Thu Oct 7 01:48:34 2010 New Revision: 1199 URL: http://flashrom.org/trac/flashrom/changeset/1199 Log: flashrom -L output did not contain a list of programmers nor were all programmers listed. Fix it and mention at least the name of each programmer. Wiki output is unchanged, and will need separate fixups. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/atahpt.c trunk/cli_classic.c trunk/flash.h trunk/flashrom.c trunk/ft2232_spi.c trunk/pcidev.c trunk/print.c Modified: trunk/atahpt.c ============================================================================== --- trunk/atahpt.c Thu Oct 7 01:16:10 2010 (r1198) +++ trunk/atahpt.c Thu Oct 7 01:48:34 2010 (r1199) @@ -30,7 +30,7 @@ #define PCI_VENDOR_ID_HPT 0x1103 -struct pcidev_status ata_hpt[] = { +const struct pcidev_status ata_hpt[] = { {0x1103, 0x0004, NT, "Highpoint", "HPT366/368/370/370A/372/372N"}, {0x1103, 0x0005, NT, "Highpoint", "HPT372A/372N"}, {0x1103, 0x0006, NT, "Highpoint", "HPT302/302N"}, Modified: trunk/cli_classic.c ============================================================================== --- trunk/cli_classic.c Thu Oct 7 01:16:10 2010 (r1198) +++ trunk/cli_classic.c Thu Oct 7 01:48:34 2010 (r1199) @@ -33,11 +33,6 @@ static void cli_classic_usage(const char *name) { - const char *pname; - int pnamelen; - int remaining = 0; - enum programmer p; - printf("Usage: flashrom [-n] [-V] [-f] [-h|-R|-L|" #if CONFIG_PRINT_WIKI == 1 "-z|" @@ -83,32 +78,9 @@ "in wiki syntax\n" #endif " -p | --programmer <name>[:<param>] specify the programmer " - "device"); - - for (p = 0; p < PROGRAMMER_INVALID; p++) { - pname = programmer_table[p].name; - pnamelen = strlen(pname); - if (remaining - pnamelen - 2 < 0) { - printf("\n "); - remaining = 43; - } else { - printf(" "); - remaining--; - } - if (p == 0) { - printf("("); - remaining--; - } - printf("%s", pname); - remaining -= pnamelen; - if (p < PROGRAMMER_INVALID - 1) { - printf(","); - remaining--; - } else { - printf(")\n"); - } - } + "device\n"); + list_programmers_linebreak(37, 80, 1); printf("\nYou can specify one of -h, -R, -L, " #if CONFIG_PRINT_WIKI == 1 "-z, " Modified: trunk/flash.h ============================================================================== --- trunk/flash.h Thu Oct 7 01:16:10 2010 (r1198) +++ trunk/flash.h Thu Oct 7 01:48:34 2010 (r1199) @@ -200,6 +200,7 @@ char *strcat_realloc(char *dest, const char *src); void print_version(void); void print_banner(void); +void list_programmers_linebreak(int startcol, int cols, int paren); int selfcheck(void); int doit(struct flashchip *flash, int force, char *filename, int read_it, int write_it, int erase_it, int verify_it); Modified: trunk/flashrom.c ============================================================================== --- trunk/flashrom.c Thu Oct 7 01:16:10 2010 (r1198) +++ trunk/flashrom.c Thu Oct 7 01:48:34 2010 (r1199) @@ -1332,6 +1332,47 @@ msg_ginfo("\n"); } +void list_programmers_linebreak(int startcol, int cols, int paren) +{ + const char *pname; + int pnamelen; + int remaining = 0; + int firstline = 1; + enum programmer p; + int i; + + for (p = 0; p < PROGRAMMER_INVALID; p++) { + pname = programmer_table[p].name; + pnamelen = strlen(pname); + if (remaining - pnamelen - 2 < 0) { + if (firstline) + firstline = 0; + else + printf("\n"); + for (i = 0; i < startcol; i++) + printf(" "); + remaining = cols - startcol; + } else { + printf(" "); + remaining--; + } + if (paren && (p == 0)) { + printf("("); + remaining--; + } + printf("%s", pname); + remaining -= pnamelen; + if (p < PROGRAMMER_INVALID - 1) { + printf(","); + remaining--; + } else { + if (paren) + printf(")"); + printf("\n"); + } + } +} + void print_sysinfo(void) { #if HAVE_UTSNAME == 1 Modified: trunk/ft2232_spi.c ============================================================================== --- trunk/ft2232_spi.c Thu Oct 7 01:16:10 2010 (r1198) +++ trunk/ft2232_spi.c Thu Oct 7 01:48:34 2010 (r1199) @@ -346,6 +346,7 @@ { int i; + msg_pinfo("USB devices:\n"); for (i = 0; devs[i].vendor_name != NULL; i++) { msg_pinfo("%s %s [%04x:%04x]%s\n", devs[i].vendor_name, devs[i].device_name, devs[i].vendor_id, Modified: trunk/pcidev.c ============================================================================== --- trunk/pcidev.c Thu Oct 7 01:16:10 2010 (r1198) +++ trunk/pcidev.c Thu Oct 7 01:48:34 2010 (r1199) @@ -132,6 +132,7 @@ { int i; + msg_pinfo("PCI devices:\n"); for (i = 0; devs[i].vendor_name != NULL; i++) { msg_pinfo("%s %s [%02x:%02x]%s\n", devs[i].vendor_name, devs[i].device_name, devs[i].vendor_id, Modified: trunk/print.c ============================================================================== --- trunk/print.c Thu Oct 7 01:16:10 2010 (r1198) +++ trunk/print.c Thu Oct 7 01:48:34 2010 (r1199) @@ -223,49 +223,89 @@ void print_supported(void) { - print_supported_chips(); + print_supported_chips(); + + printf("\nSupported programmers:\n"); + list_programmers_linebreak(0, 80, 0); #if CONFIG_INTERNAL == 1 - print_supported_chipsets(); - print_supported_boards_helper(boards_known, "boards"); - print_supported_boards_helper(laptops_known, "laptops"); -#endif -#if CONFIG_NIC3COM+CONFIG_NICREALTEK+CONFIG_NICNATSEMI+CONFIG_GFXNVIDIA+CONFIG_DRKAISER+CONFIG_SATASII+CONFIG_ATAHPT >= 1 - printf("\nSupported PCI devices flashrom can use " - "as programmer:\n\n"); + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_INTERNAL].name); + print_supported_chipsets(); + print_supported_boards_helper(boards_known, "boards"); + print_supported_boards_helper(laptops_known, "laptops"); +#endif +#if CONFIG_DUMMY == 1 + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_DUMMY].name); + /* FIXME */ #endif #if CONFIG_NIC3COM == 1 - print_supported_pcidevs(nics_3com); + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_NIC3COM].name); + print_supported_pcidevs(nics_3com); #endif #if CONFIG_NICREALTEK == 1 - print_supported_pcidevs(nics_realtek); - print_supported_pcidevs(nics_realteksmc1211); + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_NICREALTEK].name); + print_supported_pcidevs(nics_realtek); + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_NICREALTEK2].name); + print_supported_pcidevs(nics_realteksmc1211); #endif #if CONFIG_NICNATSEMI == 1 - print_supported_pcidevs(nics_natsemi); + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_NICNATSEMI].name); + print_supported_pcidevs(nics_natsemi); #endif #if CONFIG_GFXNVIDIA == 1 - print_supported_pcidevs(gfx_nvidia); + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_GFXNVIDIA].name); + print_supported_pcidevs(gfx_nvidia); #endif #if CONFIG_DRKAISER == 1 - print_supported_pcidevs(drkaiser_pcidev); + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_DRKAISER].name); + print_supported_pcidevs(drkaiser_pcidev); #endif #if CONFIG_SATASII == 1 - print_supported_pcidevs(satas_sii); + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_SATASII].name); + print_supported_pcidevs(satas_sii); #endif #if CONFIG_ATAHPT == 1 - print_supported_pcidevs(ata_hpt); -#endif -#if CONFIG_NICINTEL_SPI == 1 - print_supported_pcidevs(nics_intel_spi); -#endif - -#if CONFIG_FT2232_SPI+CONFIG_DEDIPROG >= 1 - printf("\nSupported USB devices flashrom can use " - "as programmer:\n\n"); + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_ATAHPT].name); + print_supported_pcidevs(ata_hpt); #endif - #if CONFIG_FT2232_SPI == 1 - print_supported_usbdevs(devs_ft2232spi); + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_FT2232_SPI].name); + print_supported_usbdevs(devs_ft2232spi); +#endif +#if CONFIG_SERPROG == 1 + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_SERPROG].name); + /* FIXME */ +#endif +#if CONFIG_BUSPIRATE_SPI == 1 + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_BUSPIRATE_SPI].name); + /* FIXME */ +#endif +#if CONFIG_DEDIPROG == 1 + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_DEDIPROG].name); + /* FIXME */ +#endif +#if CONFIG_RAYER_SPI == 1 + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_RAYER_SPI].name); + /* FIXME */ +#endif +#if CONFIG_NICINTEL_SPI == 1 + printf("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_NICINTEL_SPI].name); + print_supported_pcidevs(nics_intel_spi); #endif }

1 0

[PATCH] Rename DirectIO to DirectHW
by Carl-Daniel Hailfinger 07 Oct '10

07 Oct '10

The Direct I/O library for Mac OS X is now called DirectHW to make sure people can find it via an internet search. DirectIO was a generic name for a concept and thus not a good distinguisher for a library. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: flashrom-directio_directhw_rename/hwaccess.h =================================================================== --- flashrom-directio_directhw_rename/hwaccess.h (Revision 1194) +++ flashrom-directio_directhw_rename/hwaccess.h (Arbeitskopie) @@ -193,6 +193,7 @@ #define INL(x) __extension__ ({ u_int inl_tmp = (x); inl(inl_tmp); }) #else #if defined(__DARWIN__) + /* Header is part of the DirectHW library. */ #include <DirectIO/darwinio.h> #define off64_t off_t #define lseek64 lseek Index: flashrom-directio_directhw_rename/Makefile =================================================================== --- flashrom-directio_directhw_rename/Makefile (Revision 1194) +++ flashrom-directio_directhw_rename/Makefile (Arbeitskopie) @@ -42,6 +42,7 @@ endif ifeq ($(OS_ARCH), Darwin) CPPFLAGS += -I/opt/local/include -I/usr/local/include +# DirectIO framework can be found in the DirectHW library. LDFLAGS += -framework IOKit -framework DirectIO -L/opt/local/lib -L/usr/local/lib endif ifeq ($(OS_ARCH), FreeBSD) Index: flashrom-directio_directhw_rename/cbtable.c =================================================================== --- flashrom-directio_directhw_rename/cbtable.c (Revision 1194) +++ flashrom-directio_directhw_rename/cbtable.c (Arbeitskopie) @@ -204,7 +204,7 @@ struct lb_record *rec, *last; #ifdef __DARWIN__ - /* This is a hack. DirectIO fails to map physical address 0x00000000. + /* This is a hack. DirectHW fails to map physical address 0x00000000. * Why? */ start = 0x400; Index: flashrom-directio_directhw_rename/physmap.c =================================================================== --- flashrom-directio_directhw_rename/physmap.c (Revision 1194) +++ flashrom-directio_directhw_rename/physmap.c (Arbeitskopie) @@ -131,6 +131,7 @@ } #elif defined(__DARWIN__) +/* Header is part of the DirectHW library. */ #include <DirectIO/darwinio.h> #define MEM_DEV "DirectIO" Index: flashrom-directio_directhw_rename/README =================================================================== --- flashrom-directio_directhw_rename/README (Revision 1194) +++ flashrom-directio_directhw_rename/README (Arbeitskopie) @@ -87,8 +87,8 @@ To compile and run on Darwin/Mac OS X: - Install DirectIO from coresystems GmbH. - DirectIO is available at http://www.coresystems.de/en/directio. + Install DirectHW from coresystems GmbH. + DirectHW is available at http://www.coresystems.de/en/directhw . To cross-compile on Linux for DOS: -- http://www.hailfinger.org/

2 2

[commit] r1198 - trunk
by repository service 07 Oct '10

07 Oct '10

Author: hailfinger Date: Thu Oct 7 01:16:10 2010 New Revision: 1198 URL: http://flashrom.org/trac/flashrom/changeset/1198 Log: The Direct I/O library for Mac OS X is now called DirectHW to make sure people can find it via an internet search. DirectIO was a generic name for a concept and thus not a good distinguisher for a library. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Idwer Vollering <vidwer(a)gmail.com> Modified: trunk/Makefile trunk/README trunk/cbtable.c trunk/hwaccess.h Modified: trunk/Makefile ============================================================================== --- trunk/Makefile Thu Oct 7 01:03:21 2010 (r1197) +++ trunk/Makefile Thu Oct 7 01:16:10 2010 (r1198) @@ -42,6 +42,7 @@ endif ifeq ($(OS_ARCH), Darwin) CPPFLAGS += -I/opt/local/include -I/usr/local/include +# DirectIO framework can be found in the DirectHW library. LDFLAGS += -framework IOKit -framework DirectIO -L/opt/local/lib -L/usr/local/lib endif ifeq ($(OS_ARCH), FreeBSD) Modified: trunk/README ============================================================================== --- trunk/README Thu Oct 7 01:03:21 2010 (r1197) +++ trunk/README Thu Oct 7 01:16:10 2010 (r1198) @@ -87,8 +87,8 @@ To compile and run on Darwin/Mac OS X: - Install DirectIO from coresystems GmbH. - DirectIO is available at http://www.coresystems.de/en/directio. + Install DirectHW from coresystems GmbH. + DirectHW is available at http://www.coresystems.de/en/directhw . To cross-compile on Linux for DOS: Modified: trunk/cbtable.c ============================================================================== --- trunk/cbtable.c Thu Oct 7 01:03:21 2010 (r1197) +++ trunk/cbtable.c Thu Oct 7 01:16:10 2010 (r1198) @@ -203,7 +203,7 @@ struct lb_record *rec, *last; #ifdef __DARWIN__ - /* This is a hack. DirectIO fails to map physical address 0x00000000. + /* This is a hack. DirectHW fails to map physical address 0x00000000. * Why? */ start = 0x400; Modified: trunk/hwaccess.h ============================================================================== --- trunk/hwaccess.h Thu Oct 7 01:03:21 2010 (r1197) +++ trunk/hwaccess.h Thu Oct 7 01:16:10 2010 (r1198) @@ -193,6 +193,7 @@ #define INL(x) __extension__ ({ u_int inl_tmp = (x); inl(inl_tmp); }) #else #if defined(__DARWIN__) + /* Header is part of the DirectHW library. */ #include <DirectIO/darwinio.h> #define off64_t off_t #define lseek64 lseek

1 0

[commit] r1197 - trunk
by repository service 07 Oct '10

07 Oct '10

Author: hailfinger Date: Thu Oct 7 01:03:21 2010 New Revision: 1197 URL: http://flashrom.org/trac/flashrom/changeset/1197 Log: Update the author list in the man page. Update programmer parameter documentation. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/flashrom.8 trunk/pcidev.c Modified: trunk/flashrom.8 ============================================================================== --- trunk/flashrom.8 Wed Oct 6 04:56:44 2010 (r1196) +++ trunk/flashrom.8 Thu Oct 7 01:03:21 2010 (r1197) @@ -97,7 +97,7 @@ .sp * Force chip read and pretend the chip is there. .sp -* Force chip access even if the chip is bigger than the maximum supported\ +* Force chip access even if the chip is bigger than the maximum supported \ size for the flash bus. .sp * Force erase even if erase is known bad. @@ -169,6 +169,9 @@ .sp .BR "* nicsmc1211" " (for flash ROMs on RTL8139-compatible SMC2 network cards)" .sp +.BR "* nicnatsemi" " (for flash ROMs on National Semiconductor DP838* network \ +cards)" +.sp .BR "* gfxnvidia" " (for flash ROMs on NVIDIA graphics cards)" .sp .BR "* drkaiser" " (for flash ROMs on Dr. Kaiser PC-Waechter PCI cards)" @@ -187,6 +190,8 @@ .sp .BR "* buspirate_spi" " (for SPI flash ROMs attached to a Bus Pirate)" .sp +.BR "* dediprog" " (for SPI flash ROMs attached to a Dediprog SF100)" +.sp .BR "* rayer_spi" " (for SPI flash ROMs attached to a RayeR parport \ based programmer)" .sp @@ -313,8 +318,8 @@ Example: .B "flashrom \-p dummy:bus=lpc+fwh" .TP -.BR "nic3com" , " nicrealtek" , " nicsmc1211" , " gfxnvidia" , " satasii \ -" and " atahpt " programmers +.BR "nic3com" , " nicrealtek" , " nicsmc1211" , " nicnatsemi" , " gfxnvidia\ +" , " satasii " and " atahpt " programmers These programmers have an option to specify the PCI address of the card your want to use, which must be specified if more than one card supported by the selected programmer is installed in your system. The syntax is @@ -396,6 +401,9 @@ .BR 30k ", " 125k ", " 250k ", " 1M ", " 2M ", " 2.6M ", " 4M ", " 8M (in Hz). The default is the maximum frequency of 8 MHz. .TP +.BR "dediprog " programmer +No parameters defined yet. +.TP .BR "rayer_spi " programmer The default I/O base address used for the parallel port is 0x378 and you can use the optional @@ -484,28 +492,48 @@ .br Please see the individual files. .SH AUTHORS +Andrew Morgan <ziltro(a)ziltro.com> +.br Carl-Daniel Hailfinger .br Claus Gindhart <claus.gindhart(a)kontron.com> .br +David Borg <borg.db(a)gmail.com> +.br +David Hendricks <dhendrix(a)google.com> +.br Dominik Geyer <dominik.geyer(a)kontron.com> .br Eric Biederman .br Giampiero Giancipoli <gianci(a)email.it> .br +Helge Wagner <helge.wagner(a)ge.com> +.br +Idwer Vollering <vidwer+flashrom(a)gmail.com> +.br Joe Bao <Zheng.Bao(a)amd.com> .br +Jörg Fischer <turboj(a)gmx.de> +.br +Joshua Roys <roysjosh(a)gmail.com> +.br Luc Verhaegen <libv(a)skynet.be> .br Li-Ta Lo .br Markus Boas <ryven(a)ryven.de> .br +Mattias Mattsson <vitplister(a)gmail.com> +.br Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> .br Nikolay Petukhov <nikolay.petukhov(a)gmail.com> .br +Patrick Georgi <patrick.georgi(a)coresystems.de> +.br +Peter Lemenkov <lemenkov(a)gmail.com> +.br Peter Stuge <peter(a)stuge.se> .br Reinder E.N. de Haan <lb_reha(a)mveas.com> @@ -520,6 +548,8 @@ .br Stefan Wildemann <stefan.wildemann(a)kontron.com> .br +Stephan Guilloux <stephan.guilloux(a)free.fr> +.br Steven James <pyro(a)linuxlabs.com> .br Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/pcidev.c ============================================================================== --- trunk/pcidev.c Wed Oct 6 04:56:44 2010 (r1196) +++ trunk/pcidev.c Thu Oct 7 01:03:21 2010 (r1197) @@ -119,7 +119,7 @@ exit(1); } else if (found > 1) { msg_perr("Error: Multiple supported PCI devices found. " - "Use 'flashrom -p xxxx:bb:dd.f' \n" + "Use 'flashrom -p xxxx:pci=bb:dd.f' \n" "to explicitly select the card with the given BDF " "(PCI bus, device, function).\n"); exit(1);

1 0

[PATCH] remove duplicate includes
by Stefan Reinauer 06 Oct '10

06 Oct '10

See patch. -- coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br. Tel.: +49 761 7668825 • Fax: +49 761 7664613 Email: info(a)coresystems.de • http://www.coresystems.de/ Registergericht: Amtsgericht Freiburg • HRB 7656 Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866

2 2

[commit] r1196 - trunk
by repository service 06 Oct '10

06 Oct '10

Author: stepan Date: Wed Oct 6 04:56:44 2010 New Revision: 1196 URL: http://flashrom.org/trac/flashrom/changeset/1196 Log: Remove duplicate includes from the code. Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/atahpt.c trunk/bitbang_spi.c trunk/buspirate_spi.c trunk/cbtable.c trunk/chipset_enable.c trunk/cli_classic.c trunk/dummyflasher.c trunk/ft2232_spi.c trunk/gfxnvidia.c trunk/hwaccess.h trunk/internal.c trunk/mcp6x_spi.c trunk/pcidev.c trunk/physmap.c trunk/serial.c trunk/serprog.c Modified: trunk/atahpt.c ============================================================================== --- trunk/atahpt.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/atahpt.c Wed Oct 6 04:56:44 2010 (r1196) @@ -20,7 +20,6 @@ #include <stdlib.h> #include <string.h> -#include <sys/types.h> #include "flash.h" #include "programmer.h" Modified: trunk/bitbang_spi.c ============================================================================== --- trunk/bitbang_spi.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/bitbang_spi.c Wed Oct 6 04:56:44 2010 (r1196) @@ -18,7 +18,6 @@ */ #include <stdio.h> -#include <stdint.h> #include <string.h> #include <stdlib.h> #include <ctype.h> Modified: trunk/buspirate_spi.c ============================================================================== --- trunk/buspirate_spi.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/buspirate_spi.c Wed Oct 6 04:56:44 2010 (r1196) @@ -18,7 +18,6 @@ */ #include <stdio.h> -#include <stdint.h> #include <string.h> #include <stdlib.h> #include <ctype.h> Modified: trunk/cbtable.c ============================================================================== --- trunk/cbtable.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/cbtable.c Wed Oct 6 04:56:44 2010 (r1196) @@ -25,7 +25,6 @@ #include <unistd.h> #include <stdio.h> #include <stdlib.h> -#include <sys/types.h> #include <string.h> #include "flash.h" #include "programmer.h" Modified: trunk/chipset_enable.c ============================================================================== --- trunk/chipset_enable.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/chipset_enable.c Wed Oct 6 04:56:44 2010 (r1196) @@ -29,7 +29,6 @@ #include <stdlib.h> #include <string.h> -#include <sys/types.h> #include <unistd.h> #include "flash.h" #include "programmer.h" Modified: trunk/cli_classic.c ============================================================================== --- trunk/cli_classic.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/cli_classic.c Wed Oct 6 04:56:44 2010 (r1196) @@ -23,7 +23,6 @@ #include <stdio.h> #include <fcntl.h> -#include <sys/types.h> #include <sys/stat.h> #include <string.h> #include <stdlib.h> Modified: trunk/dummyflasher.c ============================================================================== --- trunk/dummyflasher.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/dummyflasher.c Wed Oct 6 04:56:44 2010 (r1196) @@ -21,7 +21,6 @@ #include <string.h> #include <stdlib.h> #include <ctype.h> -#include <sys/types.h> #include "flash.h" #include "chipdrivers.h" #include "programmer.h" Modified: trunk/ft2232_spi.c ============================================================================== --- trunk/ft2232_spi.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/ft2232_spi.c Wed Oct 6 04:56:44 2010 (r1196) @@ -21,7 +21,6 @@ #if CONFIG_FT2232_SPI == 1 #include <stdio.h> -#include <stdint.h> #include <string.h> #include <stdlib.h> #include <ctype.h> Modified: trunk/gfxnvidia.c ============================================================================== --- trunk/gfxnvidia.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/gfxnvidia.c Wed Oct 6 04:56:44 2010 (r1196) @@ -20,7 +20,6 @@ #include <stdlib.h> #include <string.h> -#include <sys/types.h> #include "flash.h" #include "programmer.h" Modified: trunk/hwaccess.h ============================================================================== --- trunk/hwaccess.h Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/hwaccess.h Wed Oct 6 04:56:44 2010 (r1196) @@ -252,7 +252,6 @@ #define iopl amd64_iopl #endif #endif - #include <stdint.h> static inline void outb(uint8_t value, uint16_t port) { Modified: trunk/internal.c ============================================================================== --- trunk/internal.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/internal.c Wed Oct 6 04:56:44 2010 (r1196) @@ -18,10 +18,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -#include <stdint.h> #include <string.h> #include <stdlib.h> -#include <sys/types.h> #include "flash.h" #include "programmer.h" Modified: trunk/mcp6x_spi.c ============================================================================== --- trunk/mcp6x_spi.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/mcp6x_spi.c Wed Oct 6 04:56:44 2010 (r1196) @@ -25,7 +25,6 @@ #if defined(__i386__) || defined(__x86_64__) -#include <stdint.h> #include <stdlib.h> #include <ctype.h> #include "flash.h" Modified: trunk/pcidev.c ============================================================================== --- trunk/pcidev.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/pcidev.c Wed Oct 6 04:56:44 2010 (r1196) @@ -20,7 +20,6 @@ #include <stdlib.h> #include <string.h> -#include <sys/types.h> #include "flash.h" #include "programmer.h" Modified: trunk/physmap.c ============================================================================== --- trunk/physmap.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/physmap.c Wed Oct 6 04:56:44 2010 (r1196) @@ -22,7 +22,6 @@ #include <unistd.h> #include <stdio.h> -#include <sys/types.h> #include <stdlib.h> #include <string.h> #include "flash.h" @@ -135,8 +134,6 @@ } #elif defined(__DARWIN__) -#include <DirectIO/darwinio.h> - #define MEM_DEV "DirectIO" static void *sys_physmap(unsigned long phys_addr, size_t len) Modified: trunk/serial.c ============================================================================== --- trunk/serial.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/serial.c Wed Oct 6 04:56:44 2010 (r1196) @@ -25,7 +25,6 @@ #include <string.h> #include <ctype.h> #include <fcntl.h> -#include <sys/types.h> #include <sys/stat.h> #include <errno.h> #include <inttypes.h> Modified: trunk/serprog.c ============================================================================== --- trunk/serprog.c Wed Oct 6 01:21:51 2010 (r1195) +++ trunk/serprog.c Wed Oct 6 04:56:44 2010 (r1196) @@ -25,7 +25,6 @@ #include <string.h> #include <ctype.h> #include <fcntl.h> -#include <sys/types.h> #include <sys/socket.h> #include <arpa/inet.h> #include <netinet/in.h>

1 0

Multiple PCI devices found, typo
by Iain Paton 06 Oct '10

06 Oct '10

Hi, When testing the with a dual port nic recently I saw a small typo in the error message when flashrom finds multiple devices: Error: Multiple supported PCI devices found. Use 'flashrom -p xxxx:bb:dd.f' to explicitly select the card with the given BDF (PCI bus, device, function). From the man page it seems this should really be 'flashrom -p xxxx:pci=bb:dd.f' as the first form has no effect. Rgds, Iain

2 1

flashrom bios ecs k725a help
by I N 06 Oct '10

06 Oct '10

can someone please help me understand this from the output: No coreboot table found. sh: dmidecode: command not found dmidecode execution unsucessfull - continuing without DMI info Found ITE Super I/O, id 8705 Found chipset "SiS 735", enabling flash write... OK. This chipset supports the following protocols: Non-SPI. Calibrating delay loop... OK. No EEPROM/flash device found. Note: flashrom can never write if the flash chip isn't found automatically. i provide as requested on irc attachments of 'flashrom -V', 'lspci -nnvvvxxx', 'superiotool -deV', exact name board: EliteGroup K7S5A, link to bios update: http://www.ecs.com.tw/ECSWebSite/Product/Product_Detail.aspx?CategoryID=1&D… i really don't know which one to get from that page. please tell me if i can use flashrom to update my bios. thank you.

2 1

[PATCH] Mark SST49LF160C tested for erase
by Ed Swierk 06 Oct '10

06 Oct '10

I have tested the erase operation with the SST49LF160C LPC flash chip. Signed-off-by: Ed Swierk <eswierk(a)aristanetworks.com> --- Index: flashrom-0.9.2-r1057/flashchips.c =================================================================== --- flashrom-0.9.2-r1057.orig/flashchips.c +++ flashrom-0.9.2-r1057/flashchips.c @@ -4582,7 +4582,7 @@ struct flashchip flashchips[] = { .total_size = 2048, .page_size = 4 * 1024, .feature_bits = FEATURE_REGISTERMAP, - .tested = TEST_OK_PRW, + .tested = TEST_OK_PREW, .probe = probe_82802ab, .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (sst49lfxxxc.c) */ .block_erasers =

2 1

[PATCH] DJGPP: Avoid leak on lowmem mapping error
by Carl-Daniel Hailfinger 06 Oct '10

06 Oct '10

DJGPP: Avoid leaking memory on lowmem mapping error. Add a clarifying comment about why low memory is never unmapped. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: flashrom-djgpp_physmap_noleaks/physmap.c =================================================================== --- flashrom-djgpp_physmap_noleaks/physmap.c (Revision 1194) +++ flashrom-djgpp_physmap_noleaks/physmap.c (Arbeitskopie) @@ -56,6 +56,8 @@ } if (__djgpp_map_physical_memory(realmem_map, (1024 * 1024), 0)) { + free(realmem_map); + realmem_map = NULL; return ERROR_PTR; } @@ -95,7 +97,9 @@ { __dpmi_meminfo mi; - /* we ignore unmaps for our first 1MB */ + /* There is no known way to unmap the first 1 MB. The DPMI server will + * do this for us on exit. + */ if ((virt_addr >= realmem_map) && ((virt_addr + len) <= (realmem_map + (1024 * 1024)))) { return; } -- http://www.hailfinger.org/

1 1

[commit] r1195 - trunk
by repository service 06 Oct '10

06 Oct '10

Author: hailfinger Date: Wed Oct 6 01:21:51 2010 New Revision: 1195 URL: http://flashrom.org/trac/flashrom/changeset/1195 Log: DJGPP: Avoid leaking memory on lowmem mapping error. Add a clarifying comment about why low memory is never unmapped. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Rudolf Marek <r.marek(a)assembler.cz> Modified: trunk/physmap.c Modified: trunk/physmap.c ============================================================================== --- trunk/physmap.c Wed Oct 6 00:29:08 2010 (r1194) +++ trunk/physmap.c Wed Oct 6 01:21:51 2010 (r1195) @@ -56,6 +56,8 @@ } if (__djgpp_map_physical_memory(realmem_map, (1024 * 1024), 0)) { + free(realmem_map); + realmem_map = NULL; return ERROR_PTR; } @@ -95,7 +97,9 @@ { __dpmi_meminfo mi; - /* we ignore unmaps for our first 1MB */ + /* There is no known way to unmap the first 1 MB. The DPMI server will + * do this for us on exit. + */ if ((virt_addr >= realmem_map) && ((virt_addr + len) <= (realmem_map + (1024 * 1024)))) { return; }

1 0

flash log of a LENOVO A57 - 97048HG
by Maurizio Pedrazzi 06 Oct '10

06 Oct '10

3 2

Re: [flashrom] Speedup SST 25VF032B and 25VF064C programming
by Carl-Daniel Hailfinger 06 Oct '10

06 Oct '10

Hi Helge, I'm very sorry, it seems that the patch repeatedly slipped through the cracks because patchwork didn't pick it up (application/octet-stream for the attachment may have been the reason, but that is fixed now). On 06.08.2010 15:28, Wagner, Helge (GE Intelligent Platforms) wrote: > I have tested both SST 25VF032B and SST 25VF064C on a QM57 (IbexPeak) > system and found that the reprogramming of these chips is very slow. > > So i have changed the programming engine for the 25VF064C from > "spi_chip_write_1" to "spi_chip_write_256". > I have tested the 25VF064C with the new engine and it works fine. > > For the 25VF032B i have changed the programming engine from > "spi_chip_write_1" to "spi_aai_write". > I have tested this engine, too, and found it working (speedup was from > 228 to 113 seconds). > > While testing i found that some commands needed by some of the > algorithms are not in the OPCODE table. So i have implemented the > on-the-fly reprogramming of the OPCODE table (in the ICH engine). > > Signed-off-by: Helge Wagner <helge.wagner(a)ge.com> > > Speedup for new 25VF032B programming algorithm: from 3091 [sic!] to 123 > seconds > This patch is a huge step forward for many Intel chipsets. Thank you! > diff -urN flashrom-0.9.2/ichspi.c flashrom/ichspi.c > --- flashrom-0.9.2/ichspi.c 2010-07-28 00:41:39.000000000 +0200 > +++ flashrom/ichspi.c 2010-08-06 14:46:47.000000000 +0200 > @@ -708,11 +777,11 @@ > /* find cmd in opcodes-table */ > opcode_index = find_opcode(curopcodes, cmd); > if (opcode_index == -1) { > - /* FIXME: Reprogram opcodes if possible. Autodetect type of > - * opcode by checking readcnt/writecnt. > - */ > - msg_pdbg("Invalid OPCODE 0x%02x\n", cmd); > - return SPI_INVALID_OPCODE; > + opcode_index = reprogram_opcode_on_the_fly(cmd, writecnt, readcnt); > This line should be conditional on !ichspi_lock. I have changed that in the commit. > + if (opcode_index == -1) { > + msg_pdbg("Invalid OPCODE 0x%02x\n", cmd); > + return SPI_INVALID_OPCODE; > + } > } > > opcode = &(curopcodes->opcode[opcode_index]); > Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> ICH dynamic opcode reprogramming patch committed in r1193. AAI write for SST25VF032B and page write for SST25VF064C committed in r1194. Regards, Carl-Daniel -- http://www.hailfinger.org/

1 0

[commit] r1194 - trunk
by repository service 06 Oct '10

06 Oct '10

Author: hailfinger Date: Wed Oct 6 00:29:08 2010 New Revision: 1194 URL: http://flashrom.org/trac/flashrom/changeset/1194 Log: Use AAI write for SST SST25VF032B. Speedup from 228 to 113 seconds. Use page (256 byte) write for SST SST25VF064C. Speedup from 3091 to 123 seconds. Signed-off-by: Helge Wagner <helge.wagner(a)ge.com> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/chipdrivers.h trunk/flashchips.c trunk/spi25.c Modified: trunk/chipdrivers.h ============================================================================== --- trunk/chipdrivers.h Wed Oct 6 00:06:05 2010 (r1193) +++ trunk/chipdrivers.h Wed Oct 6 00:29:08 2010 (r1194) @@ -63,7 +63,8 @@ int spi_nbyte_read(int addr, uint8_t *bytes, int len); int spi_read_chunked(struct flashchip *flash, uint8_t *buf, int start, int len, int chunksize); int spi_write_chunked(struct flashchip *flash, uint8_t *buf, int start, int len, int chunksize); -int spi_aai_write(struct flashchip *flash, uint8_t *buf, int start, int len); +int spi_aai_write_new(struct flashchip *flash, uint8_t *buf, int start, int len); +int spi_aai_write(struct flashchip *flash, uint8_t *buf); /* 82802ab.c */ uint8_t wait_82802ab(chipaddr bios); Modified: trunk/flashchips.c ============================================================================== --- trunk/flashchips.c Wed Oct 6 00:06:05 2010 (r1193) +++ trunk/flashchips.c Wed Oct 6 00:29:08 2010 (r1194) @@ -4860,7 +4860,7 @@ .model_id = SST_SST25VF032B, .total_size = 4096, .page_size = 256, - .tested = TEST_OK_PRW, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = @@ -4883,7 +4883,7 @@ }, }, .unlock = spi_disable_blockprotect, - .write = spi_chip_write_1, + .write = spi_aai_write, .read = spi_chip_read, }, @@ -4918,7 +4918,7 @@ }, }, .unlock = spi_disable_blockprotect, - .write = spi_chip_write_1, + .write = spi_chip_write_256, .read = spi_chip_read, }, Modified: trunk/spi25.c ============================================================================== --- trunk/spi25.c Wed Oct 6 00:06:05 2010 (r1193) +++ trunk/spi25.c Wed Oct 6 00:29:08 2010 (r1194) @@ -1300,7 +1300,7 @@ return spi_chip_write_1_new(flash, buf, 0, flash->total_size * 1024); } -int spi_aai_write(struct flashchip *flash, uint8_t *buf, int start, int len) +int spi_aai_write_new(struct flashchip *flash, uint8_t *buf, int start, int len) { uint32_t pos = start; int result; @@ -1391,3 +1391,17 @@ spi_write_disable(); return 0; } + +int spi_aai_write(struct flashchip *flash, uint8_t *buf) +{ + /* Erase first */ + msg_cinfo("Erasing flash before programming... "); + if (erase_flash(flash)) { + msg_cerr("ERASE FAILED!\n"); + return -1; + } + msg_cinfo("done.\n"); + + return spi_aai_write_new(flash, buf, 0, flash->total_size * 1024); +} +

1 0

Flashrom Tutorial
by Kyle Wood 06 Oct '10

06 Oct '10

I am Interested in exploring the uses of this software with my Bus Pirate. Have you made a tutorial for using this? I have looked over the Wiki and have found no explanation on how to use this and a severe lack of documentation. A valid tutorial would really help the vast majority of potential users and donators. Sincerely, Kyle D Wood

1 0

[commit] r1193 - trunk
by repository service 06 Oct '10

06 Oct '10

Author: hailfinger Date: Wed Oct 6 00:06:05 2010 New Revision: 1193 URL: http://flashrom.org/trac/flashrom/changeset/1193 Log: Implement on-the-fly reprogramming of the ICH SPI OPCODE table. Signed-off-by: Helge Wagner <helge.wagner(a)ge.com> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/ichspi.c Modified: trunk/ichspi.c ============================================================================== --- trunk/ichspi.c Tue Oct 5 23:48:43 2010 (r1192) +++ trunk/ichspi.c Wed Oct 6 00:06:05 2010 (r1193) @@ -30,6 +30,7 @@ * ST M25P32 already tested * ST M25P64 * AT 25DF321 already tested + * ... and many more SPI flash devices * */ @@ -197,8 +198,76 @@ } }; +/* List of opcodes with their corresponding spi_type + * It is used to reprogram the chipset OPCODE table on-the-fly if an opcode + * is needed which is currently not in the chipset OPCODE table + */ +static OPCODE POSSIBLE_OPCODES[] = { + {JEDEC_BYTE_PROGRAM, SPI_OPCODE_TYPE_WRITE_WITH_ADDRESS, 0}, // Write Byte + {JEDEC_READ, SPI_OPCODE_TYPE_READ_WITH_ADDRESS, 0}, // Read Data + {JEDEC_BE_D8, SPI_OPCODE_TYPE_WRITE_WITH_ADDRESS, 0}, // Erase Sector + {JEDEC_RDSR, SPI_OPCODE_TYPE_READ_NO_ADDRESS, 0}, // Read Device Status Reg + {JEDEC_REMS, SPI_OPCODE_TYPE_READ_WITH_ADDRESS, 0}, // Read Electronic Manufacturer Signature + {JEDEC_WRSR, SPI_OPCODE_TYPE_WRITE_NO_ADDRESS, 0}, // Write Status Register + {JEDEC_RDID, SPI_OPCODE_TYPE_READ_NO_ADDRESS, 0}, // Read JDEC ID + {JEDEC_CE_C7, SPI_OPCODE_TYPE_WRITE_NO_ADDRESS, 0}, // Bulk erase + {JEDEC_SE, SPI_OPCODE_TYPE_WRITE_WITH_ADDRESS, 0}, // Sector erase + {JEDEC_BE_52, SPI_OPCODE_TYPE_WRITE_WITH_ADDRESS, 0}, // Block erase + {JEDEC_AAI_WORD_PROGRAM, SPI_OPCODE_TYPE_WRITE_NO_ADDRESS, 0}, // Auto Address Increment +}; + static OPCODES O_EXISTING = {}; +static uint8_t lookup_spi_type(uint8_t opcode) +{ + int a; + + for (a = 0; a < sizeof(POSSIBLE_OPCODES)/sizeof(POSSIBLE_OPCODES[0]); a++) { + if (POSSIBLE_OPCODES[a].opcode == opcode) + return POSSIBLE_OPCODES[a].spi_type; + } + + return 0xFF; +} + +static int reprogram_opcode_on_the_fly(uint8_t opcode, unsigned int writecnt, unsigned int readcnt) +{ + uint8_t spi_type; + + spi_type = lookup_spi_type(opcode); + if (spi_type > 3) { + /* Try to guess spi type from read/write sizes. + * The following valid writecnt/readcnt combinations exist: + * writecnt = 4, readcnt >= 0 + * writecnt = 1, readcnt >= 0 + * writecnt >= 4, readcnt = 0 + * writecnt >= 1, readcnt = 0 + * writecnt >= 1 is guaranteed for all commands. + */ + if (readcnt == 0) + /* if readcnt=0 and writecount >= 4, we don't know if it is WRITE_NO_ADDRESS + * or WRITE_WITH_ADDRESS. But if we use WRITE_NO_ADDRESS and the first 3 data + * bytes are actual the address, they go to the bus anyhow + */ + spi_type = SPI_OPCODE_TYPE_WRITE_NO_ADDRESS; + else if (writecnt == 1) // and readcnt is > 0 + spi_type = SPI_OPCODE_TYPE_READ_NO_ADDRESS; + else if (writecnt == 4) // and readcnt is > 0 + spi_type = SPI_OPCODE_TYPE_READ_WITH_ADDRESS; + // else we have an invalid case, will be handled below + } + if (spi_type <= 3) { + int oppos=2; // use original JEDEC_BE_D8 offset + curopcodes->opcode[oppos].opcode = opcode; + curopcodes->opcode[oppos].spi_type = spi_type; + program_opcodes(curopcodes); + oppos = find_opcode(curopcodes, opcode); + msg_pdbg ("on-the-fly OPCODE (0x%02X) re-programmed, op-pos=%d\n", opcode, oppos); + return oppos; + } + return -1; +} + static int find_opcode(OPCODES *op, uint8_t opcode) { int a; @@ -710,11 +779,12 @@ /* find cmd in opcodes-table */ opcode_index = find_opcode(curopcodes, cmd); if (opcode_index == -1) { - /* FIXME: Reprogram opcodes if possible. Autodetect type of - * opcode by checking readcnt/writecnt. - */ - msg_pdbg("Invalid OPCODE 0x%02x\n", cmd); - return SPI_INVALID_OPCODE; + if (!ichspi_lock) + opcode_index = reprogram_opcode_on_the_fly(cmd, writecnt, readcnt); + if (opcode_index == -1) { + msg_pdbg("Invalid OPCODE 0x%02x\n", cmd); + return SPI_INVALID_OPCODE; + } } opcode = &(curopcodes->opcode[opcode_index]); @@ -827,21 +897,10 @@ * No need to bother with fixups. */ if (!ichspi_lock) { - msg_pdbg("%s: FIXME: Add on-the-fly" - " reprogramming of the " - "chipset opcode list.\n", - __func__); - /* FIXME: Reprogram opcode menu. - * Find a less-useful opcode, replace it - * with the wanted opcode, detect optype - * and reprogram the opcode menu. - * Update oppos so the next if-statement - * can do something useful. - */ - //curopcodes.opcode[lessusefulindex] = (cmds + 1)->writearr[0]); - //update_optypes(curopcodes); - //program_opcodes(curopcodes); - //oppos = find_opcode(curopcodes, (cmds + 1)->writearr[0]); + oppos = reprogram_opcode_on_the_fly((cmds + 1)->writearr[0], (cmds + 1)->writecnt, (cmds + 1)->readcnt); + if (oppos == -1) + continue; + curopcodes->opcode[oppos].atomic = preoppos + 1; continue; } }

1 0

[PATCH] Add a board-enable for the ASRock K7S41, chipset-enable for SiS 741
by Uwe Hermann 05 Oct '10

05 Oct '10

See patch. I literally guessed this board-enable and was lucky at the very first try :) Not sure if DMI matching is required (I guess it is), please let me know if I should change that. lspci/superiotool/flashrom -w are attached. Uwe. -- http://hermann-uwe.de | http://sigrok.org http://randomprojects.org | http://unmaintained-free-software.org

3 3

[commit] r1192 - trunk
by repository service 05 Oct '10

05 Oct '10

Author: uwe Date: Tue Oct 5 23:48:43 2010 New Revision: 1192 URL: http://flashrom.org/trac/flashrom/changeset/1192 Log: Add a board-enable for the ASRock K7S41, chipset-enable for SiS 741. This also adds (and marks as tested) a chipset-enable for the SiS 741. All operations successfully tested on hardware. lspci/superiotool: http://www.flashrom.org/pipermail/flashrom/2010-September/004710.html Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/board_enable.c trunk/chipset_enable.c trunk/print.c Modified: trunk/board_enable.c ============================================================================== --- trunk/board_enable.c Tue Oct 5 23:32:29 2010 (r1191) +++ trunk/board_enable.c Tue Oct 5 23:48:43 2010 (r1192) @@ -390,6 +390,7 @@ * - MSI KM4M-V and KM4AM-V: VIA KM400/KM400A + VT8237 * - MSI MS-6561 (745 Ultra): SiS 745 + W83697HF * - MSI MS-6787 (P4MAM-V/P4MAM-L): VIA P4M266 + VT8235 + * - ASRock K7S41: SiS 741 + SiS 963 + W83697HF */ static int w836xx_memw_enable_2e(void) { @@ -1885,6 +1886,7 @@ {0x1106, 0x3177, 0x17F2, 0x3177, 0x1106, 0x3148, 0x17F2, 0x3148, NULL, NULL, NULL, "Albatron", "PM266A Pro", 0, OK, w836xx_memw_enable_2e}, {0x1022, 0x2090, 0, 0, 0x1022, 0x2080, 0, 0, NULL, "artecgroup", "dbe61", "Artec Group", "DBE61", 0, OK, board_artecgroup_dbe6x}, {0x1022, 0x2090, 0, 0, 0x1022, 0x2080, 0, 0, NULL, "artecgroup", "dbe62", "Artec Group", "DBE62", 0, OK, board_artecgroup_dbe6x}, + {0x1039, 0x0741, 0x1849, 0x0741, 0x1039, 0x5513, 0x1849, 0x5513, "^K7S41 $", NULL, NULL, "ASRock", "K7S41", 0, OK, w836xx_memw_enable_2e}, {0x8086, 0x24D4, 0x1849, 0x24D0, 0x8086, 0x24D5, 0x1849, 0x9739, NULL, NULL, NULL, "ASRock", "P4i65GV", 0, OK, intel_ich_gpio23_raise}, {0x8086, 0x2570, 0x1849, 0x2570, 0x8086, 0x24d3, 0x1849, 0x24d0, NULL, NULL, NULL, "ASRock", "775i65G", 0, OK, intel_ich_gpio23_raise}, {0x1106, 0x3189, 0x1043, 0x807F, 0x1106, 0x3065, 0x1043, 0x80ED, NULL, NULL, NULL, "ASUS", "A7V600-X", 0, OK, it8712f_gpio3_1_raise}, Modified: trunk/chipset_enable.c ============================================================================== --- trunk/chipset_enable.c Tue Oct 5 23:32:29 2010 (r1191) +++ trunk/chipset_enable.c Tue Oct 5 23:48:43 2010 (r1192) @@ -1153,6 +1153,7 @@ {0x1039, 0x0733, NT, "SiS", "733", enable_flash_sis540}, {0x1039, 0x0735, OK, "SiS", "735", enable_flash_sis540}, {0x1039, 0x0740, NT, "SiS", "740", enable_flash_sis540}, + {0x1039, 0x0741, OK, "SiS", "741", enable_flash_sis540}, {0x1039, 0x0745, OK, "SiS", "745", enable_flash_sis540}, {0x1039, 0x0746, NT, "SiS", "746", enable_flash_sis540}, {0x1039, 0x0748, NT, "SiS", "748", enable_flash_sis540}, Modified: trunk/print.c ============================================================================== --- trunk/print.c Tue Oct 5 23:32:29 2010 (r1191) +++ trunk/print.c Tue Oct 5 23:48:43 2010 (r1192) @@ -307,6 +307,7 @@ B("ASRock", "A330GC", 1, "http://www.asrock.com/mb/overview.asp?Model=A330GC", NULL), B("ASRock", "A770CrossFire", 1, "http://www.asrock.com/mb/overview.asp?Model=A770CrossFire&s=AM2\%2b", NULL), B("ASRock", "ALiveNF6G-DVI", 1, "http://www.asrock.com/mb/overview.asp?Model=ALiveNF6G-DVI", NULL), + B("ASRock", "K7S41", 1, "http://www.asrock.com/mb/overview.asp?Model=K7S41", NULL), B("ASRock", "K7VT4A+", 0, "http://www.asrock.com/mb/overview.asp?Model=K7VT4A%%2b&s=", "No chip found, probably due to flash translation. http://www.flashrom.org/pipermail/flashrom/2009-August/000393.html"), B("ASRock", "K8S8X", 1, "http://www.asrock.com/mb/overview.asp?Model=K8S8X", NULL), B("ASRock", "M3A790GXH/128M", 1, "http://www.asrock.com/MB/overview.asp?Model=M3A790GXH/128M", NULL),

1 0

[PATCH] Board enable for Dell OptiPlex GX1 (try 2)
by Mattias Mattsson 05 Oct '10

05 Oct '10

Add board enable for Dell OptiPlex GX1. This is a new version of an earlier patch. - Change matching PCI ID:s to ethernet and north bridge. - Truncate board name to "OptiPlex GX1" as this patch probably apply to the whole series (they share the same vendor BIOS download). - Add URL to print.c - Marked board as OK. This was tested with an earlier version of flashrom (r1092), but nothing has changed that affects this patch (GPO30 is still always available on PIIX4). lspci output: http://www.flashrom.org/pipermail/flashrom/2010-July/004042.html Signed-off-by: Mattias Mattsson <vitplister(a)gmail.com> Thanks! -mattias

3 4

[commit] r1191 - trunk
by repository service 05 Oct '10

05 Oct '10

Author: mhm Date: Tue Oct 5 23:32:29 2010 New Revision: 1191 URL: http://flashrom.org/trac/flashrom/changeset/1191 Log: Add board enable for Dell OptiPlex GX1 and mark Intel 28F002BC/BL/BV/BX-T as tested. Match on ethernet and north bridge. This is tested on an OptiPlex GX1 400L+ but will probably work for the whole GX1 series as they all share the same vendor BIOS. lspci/flashrom output http://www.flashrom.org/pipermail/flashrom/2010-July/004042.html lspci output (OptiPlex GX1 unknown model) http://www.coreboot.org/pipermail/coreboot/2010-May/058040.html superiotool output (OptiPlex GX1 266L+) http://www.flashrom.org/pipermail/flashrom/2009-July/000207.html lspci/dmidecode output (OptiPlex GX1 266L+) http://www.coreboot.org/pipermail/coreboot/2009-July/050958.html Signed-off-by: Mattias Mattsson <vitplister(a)gmail.com> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/board_enable.c trunk/flashchips.c trunk/print.c Modified: trunk/board_enable.c ============================================================================== --- trunk/board_enable.c Tue Oct 5 23:21:09 2010 (r1190) +++ trunk/board_enable.c Tue Oct 5 23:32:29 2010 (r1191) @@ -1195,6 +1195,15 @@ } /* + * Suited for: + * - Dell OptiPlex GX1 + */ +static int intel_piix4_gpo30_lower(void) +{ + return intel_piix4_gpo_set(30, 0); +} + +/* * Set a GPIO line on a given Intel ICH LPC controller. */ static int intel_ich_gpio_set(int gpio, int raise) @@ -1904,6 +1913,7 @@ {0x8086, 0x266a, 0x1043, 0x80a6, 0x8086, 0x2668, 0x1043, 0x813d, NULL, NULL, NULL, "ASUS", "P5GDC Deluxe", 0, OK, intel_ich_gpio21_raise}, {0x10DE, 0x0030, 0x1043, 0x818a, 0x8086, 0x100E, 0x1043, 0x80EE, NULL, NULL, NULL, "ASUS", "P5ND2-SLI Deluxe", 0, OK, nvidia_mcp_gpio10_raise}, {0x8086, 0x24dd, 0x1043, 0x80a6, 0x8086, 0x2570, 0x1043, 0x8157, NULL, NULL, NULL, "ASUS", "P5PE-VM", 0, OK, intel_ich_gpio21_raise}, + {0x10b7, 0x9055, 0x1028, 0x0082, 0x8086, 0x7190, 0, 0, NULL, NULL, NULL, "Dell", "OptiPlex GX1", 0, OK, intel_piix4_gpo30_lower}, {0x8086, 0x3590, 0x1028, 0x016c, 0x1000, 0x0030, 0x1028, 0x016c, NULL, NULL, NULL, "Dell", "PowerEdge 1850", 0, OK, intel_ich_gpio23_raise}, {0x10de, 0x03ea, 0x1019, 0x2602, 0x10de, 0x03e0, 0x1019, 0x2602, NULL, NULL, NULL, "Elitegroup", "GeForce6100SM-M", 0, OK, board_ecs_geforce6100sm_m}, {0x1106, 0x3038, 0x1019, 0x0996, 0x1106, 0x3177, 0x1019, 0x0996, NULL, NULL, NULL, "Elitegroup", "K7VTA3", 256, OK, NULL}, Modified: trunk/flashchips.c ============================================================================== --- trunk/flashchips.c Tue Oct 5 23:21:09 2010 (r1190) +++ trunk/flashchips.c Tue Oct 5 23:32:29 2010 (r1191) @@ -3196,7 +3196,7 @@ .model_id = INTEL_28F002T, .total_size = 256, .page_size = 256 * 1024, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = probe_82802ab, .probe_timing = TIMING_ZERO, /* Datasheet has no timing info specified */ .block_erasers = Modified: trunk/print.c ============================================================================== --- trunk/print.c Tue Oct 5 23:21:09 2010 (r1190) +++ trunk/print.c Tue Oct 5 23:32:29 2010 (r1191) @@ -390,6 +390,7 @@ B("Biostar", "TA780G M2+", 1, "http://www.biostar.com.tw/app/en/t-series/content.php?S_ID=344", NULL), B("Boser", "HS-6637", 0, "http://www.boser.com.tw/manual/HS-62376637v3.4.pdf", "Reported by Mark Robinson <mark(a)zl2tod.net> to flashrom(a)coreboot.org, no public archive. Missing board enable and/or F29C51002T unlocking. May work now."), B("Congatec", "conga-X852", 1, "http://www.congatec.com/single_news+M57715f6263d.html?&L=1", NULL), + B("Dell", "OptiPlex GX1", 1, "http://support.dell.com/support/edocs/systems/ban_gx1/en/index.htm", NULL), B("Dell", "PowerEdge 1850", 1, "http://support.dell.com/support/edocs/systems/pe1850/en/index.htm", NULL), B("DFI", "855GME-MGF", 0, "http://www.dfi.com.tw/portal/CM/cmproduct/XX_cmproddetail/XX_WbProdsWindow?…", "Probably needs a board enable. http://www.coreboot.org/pipermail/coreboot/2009-May/048549.html"), B("DFI", "Blood-Iron P35 T2RL", 1, "http://lp.lanparty.com.tw/portal/CM/cmproduct/XX_cmproddetail/XX_WbProdsWin…", NULL),

1 0

Quickfix for broken writes on FT2232H based programmers
by Uwe Hermann 05 Oct '10

05 Oct '10

See patch. Uwe. -- http://hermann-uwe.de | http://sigrok.org http://randomprojects.org | http://unmaintained-free-software.org

2 2

[commit] r1190 - trunk
by repository service 05 Oct '10

05 Oct '10

Author: uwe Date: Tue Oct 5 23:21:09 2010 New Revision: 1190 URL: http://flashrom.org/trac/flashrom/changeset/1190 Log: Quickfix for broken writes on FT2232H based programmers. Not sure if this is the final/correct fix, but for now it definately fixes writes on FT2232H hardware. I have tested this on both, the DLP Design DLP-USB1232H, and the openbiosprog-spi hardware. Thanks to Joshua Roys <roysjosh(a)gmail.com> for the hint on IRC. Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/ft2232_spi.c Modified: trunk/ft2232_spi.c ============================================================================== --- trunk/ft2232_spi.c Tue Oct 5 22:28:36 2010 (r1189) +++ trunk/ft2232_spi.c Tue Oct 5 23:21:09 2010 (r1190) @@ -195,7 +195,7 @@ msg_perr("Unable to set latency timer\n"); } - if (ftdi_write_data_set_chunksize(ftdic, 512)) { + if (ftdi_write_data_set_chunksize(ftdic, 256)) { msg_perr("Unable to set chunk size\n"); }

1 0

[PATCH] Intel chip id fix-up (ver 3)
by Mattias Mattsson 05 Oct '10

05 Oct '10

This is a new version of an earlier patch. Make sure all chip variants are present in .name strings in flashchips.c Strip package prefix in constant names (everything before "28F"). Prefix every constant name with INTEL_ Sort intel chip constants by id. Rename the following constants to their "canonical" name: P28F400BT (0x70) -> INTEL_28F400T (28F400BV/BX/CE/CV-T) P28F400BB (0x71) -> INTEL_28F400B (28F400BV/BX/CE/CV-B) P28F004BT (0x78) -> INTEL_28F004T (28F004B5/BE/BV/BX-T) P28F004BB (0x79) -> INTEL_28F004B (28F004B5/BE/BV/BX-B) E_28F008S5 (0xA6) -> INTEL_28F008S3 (28F008S3/S5/SC) E_28F004S5 (0xA7) -> INTEL_28F004S3 (28F008S3/S5/SC) P28F001BXT (0x94) -> INTEL_28F001T (28F001BN/BX-T) P28F001BXB (0x95) -> INTEL_28F001B (28F001BN/BX-B) E_28F016S5 (0xAA) -> INTEL_28F016S3 (28F016S3/S5/SC) Also add chip ids for the following chips: 28F320J5 28F640J5 28F320J3 28F640J3 28F128J3 28F256J3 28F200BL/BV/BX/CV-T 28F200BL/BV/BX/CV-B 28F002BL/BV/BX-B 28F008BE/BV-T 28F008BE/BV-B 28F800B5/BV/CE/CV-T 28F800B5/BV/CE/CV-B 28F016SA/SV 28F008SA 28F008S3/S5/SC 28F008S3/S5/SC 28F016XS 28F010 28F512 28F256A 28F020 28F016B3-T 28F016B3-B 28F008B3-T 28F008B3-B 28F004B3-T 28F004B3-B Signed-off-by: Mattias Mattsson <vitplister(a)gmail.com>

2 2

MSI MS-6163 Pro / Winbond W29C020C
by Mattias Mattsson 05 Oct '10

05 Oct '10

Hi, I have tested flashrom r1143 patched with board enable (raise GPO14) on an MSI MS-6163 with Winbond W29C020C flash. Probe, read, erase, write all work. Logs attached. Thanks, -mattias

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom