- flashrom - mail.coreboot.org

Report for chipset "Intel Q67" on a GA-Q67M-D2H-B3 motheboard.
by user 09 Mar '12

09 Mar '12

Sorry for my previous report. Report for chipset "Intel Q67" on a GA-Q67M-D2H-B3 motheboard for READ operation.

1 0

working card
by RiCH ＠ gmail 09 Mar '12

09 Mar '12

rfm6@amd64:~/ipxe/src$ sudo flashrom -p nicintel flashrom v0.9.4-r1394 on Linux 3.0.0-12-generic (i686), built with libpci 3.1.7, GCC 4.6.1, little endian flashrom is free software, get the source code at http://www.flashrom.org Calibrating delay loop... OK. Found "Intel 82557/8/9/0/1 Ethernet Pro 100" (8086:1229, BDF 04:08.0). === This PCI device is UNTESTED. Please report the 'flashrom -p xxxx' output to flashrom(a)flashrom.org if it works for you. Please add the name of your PCI device to the subject. Thank you for your help! === Found "Intel 82557/8/9/0/1 Ethernet Pro 100" (8086:1229, BDF 04:08.0). === This PCI device is UNTESTED. Please report the 'flashrom -p xxxx' output to flashrom(a)flashrom.org if it works for you. Please add the name of your PCI device to the subject. Thank you for your help! === Mapping Intel NIC control/status reg at 0xfdaff000, unaligned size 0x10. Found Atmel flash chip "AT49BV512" (64 kB, Parallel) on nicintel. No operations were specified. rfm6@amd64:~/ipxe/src$ sudo flashrom -p nicintel -w test.rom [sudo] password for rfm6: flashrom v0.9.4-r1394 on Linux 3.0.0-12-generic (i686), built with libpci 3.1.7, GCC 4.6.1, little endian flashrom is free software, get the source code at http://www.flashrom.org Calibrating delay loop... OK. Found "Intel 82557/8/9/0/1 Ethernet Pro 100" (8086:1229, BDF 04:08.0). === This PCI device is UNTESTED. Please report the 'flashrom -p xxxx' output to flashrom(a)flashrom.org if it works for you. Please add the name of your PCI device to the subject. Thank you for your help! === Found "Intel 82557/8/9/0/1 Ethernet Pro 100" (8086:1229, BDF 04:08.0). === This PCI device is UNTESTED. Please report the 'flashrom -p xxxx' output to flashrom(a)flashrom.org if it works for you. Please add the name of your PCI device to the subject. Thank you for your help! === Mapping Intel NIC control/status reg at 0xfdaff000, unaligned size 0x10. Found Atmel flash chip "AT49BV512" (64 kB, Parallel) on nicintel. Reading old flash chip contents... done. Erasing and writing flash chip... Erase/write done. Verifying flash... VERIFIED.

1 0

[PATCH] flashrom 0.9.5.1
by Carl-Daniel Hailfinger 08 Mar '12

08 Mar '12

Increase flashrom release number to 0.9.5.2 Informal ack by Stefan Tauner on IRC. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Index: flashrom-0.9.5.2-release/Makefile =================================================================== --- flashrom-0.9.5.2-release/Makefile (Revision 1513) +++ flashrom-0.9.5.2-release/Makefile (Arbeitskopie) @@ -277,7 +277,7 @@ # will not require subversion. The downloadable snapshots are already exported. SVNVERSION := $(shell LC_ALL=C svnversion -cn . 2>/dev/null | sed -e "s/.*://" -e "s/$[0-9]*$.*/\1/" | grep "[0-9]" || LC_ALL=C svn info . 2>/dev/null | awk '/^Revision:/ {print $$2 }' | grep "[0-9]" || LC_ALL=C git svn info . 2>/dev/null | awk '/^Revision:/ {print $$2 }' | grep "[0-9]" || echo unknown) -RELEASE := 0.9.5.1 +RELEASE := 0.9.5.2 VERSION := $(RELEASE)-r$(SVNVERSION) RELEASENAME ?= $(VERSION) -- http://www.hailfinger.org/

1 2

[commit] r1515 - tags/flashrom-0.9.5.2
by repository service 08 Mar '12

08 Mar '12

Author: hailfinger Date: Thu Mar 8 23:01:25 2012 New Revision: 1515 URL: http://flashrom.org/trac/flashrom/changeset/1515 Log: Tag flashrom 0.9.5.2 Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Added: tags/flashrom-0.9.5.2/ - copied from r1514, trunk/

1 0

[commit] r1514 - trunk
by repository service 08 Mar '12

08 Mar '12

Author: hailfinger Date: Thu Mar 8 22:58:40 2012 New Revision: 1514 URL: http://flashrom.org/trac/flashrom/changeset/1514 Log: Increase flashrom release number to 0.9.5.2 Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Modified: trunk/Makefile Modified: trunk/Makefile ============================================================================== --- trunk/Makefile Tue Mar 6 23:17:06 2012 (r1513) +++ trunk/Makefile Thu Mar 8 22:58:40 2012 (r1514) @@ -277,7 +277,7 @@ # will not require subversion. The downloadable snapshots are already exported. SVNVERSION := $(shell LC_ALL=C svnversion -cn . 2>/dev/null | sed -e "s/.*://" -e "s/$[0-9]*$.*/\1/" | grep "[0-9]" || LC_ALL=C svn info . 2>/dev/null | awk '/^Revision:/ {print $$2 }' | grep "[0-9]" || LC_ALL=C git svn info . 2>/dev/null | awk '/^Revision:/ {print $$2 }' | grep "[0-9]" || echo unknown) -RELEASE := 0.9.5.1 +RELEASE := 0.9.5.2 VERSION := $(RELEASE)-r$(SVNVERSION) RELEASENAME ?= $(VERSION)

1 0

Realtek NIC (8169)
by Mark Brown 07 Mar '12

07 Mar '12

Wonder if there is a way to support the RTL8169 chipset, for SPI based programming. Very common and inexpensive card. Would be wonderful to support something like gPXE/iPXE PXE ROMs on those NICs. The typical 128kbit SPI rom/eprom/prom variations are often ATMEL or like. e.f. ATMEL518 93C64 Marc

1 0

Re: [flashrom] [PATCH] Prevent submission of empty read requests in linux_spi
by Stefan Tauner 06 Mar '12

06 Mar '12

On Sat, 3 Mar 2012 16:28:47 +0100 Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> wrote: > The submission of zero-sized read requests in a write-only transaction > fails at least for omap2_mcspi drivers and is pointless in general. > > Even with this patch, zero-sized write requests might be submitted for > read-only transactions, but for most SPI chips, there always is a command > transferred (written) before reading data, so there is no such thing as > a pure-read transaction. maybe we should nevertheless guard against that with an if (readcnt != 0 && writecnt == 0) return SPI_INVALID_LENGTH; or so? > > Signed-off-by: Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> > --- > linux_spi.c | 10 +++++++++- > 1 files changed, 9 insertions(+), 1 deletions(-) > > diff --git a/linux_spi.c b/linux_spi.c > index d994389..3d1ca3e 100644 > --- a/linux_spi.c > +++ b/linux_spi.c > @@ -114,6 +114,7 @@ static int linux_spi_send_command(struct flashctx *flash, unsigned int writecnt, > const unsigned char *txbuf, > unsigned char *rxbuf) > { > + unsigned iocontrol_code; hm... afaics ioctl commands are always exactly 32b wide. naive kernel newbie question: why not use uint32_t? if there is a reason against that, please add "int" at least to match the rest of our code base. > struct spi_ioc_transfer msg[2] = { > { > .tx_buf = (uint64_t)(ptrdiff_t)txbuf, > @@ -128,7 +129,14 @@ static int linux_spi_send_command(struct flashctx *flash, unsigned int writecnt, > if (fd == -1) > return -1; > > - if (ioctl(fd, SPI_IOC_MESSAGE(2), msg) == -1) { > + /* Just submit the first (write) request in case there is nothing > + to read. Otherwise submit both requests */ missing full stop, if one likes to nitpick... :) (in the subject too btw). > + if (readcnt == 0) > + iocontrol_code = SPI_IOC_MESSAGE(1); > + else > + iocontrol_code = SPI_IOC_MESSAGE(2); > + > + if (ioctl(fd, iocontrol_code, msg) == -1) { > msg_cerr("%s: ioctl: %s\n", __func__, strerror(errno)); > return -1; > } if (ioctl(fd, SPI_IOC_MESSAGE((readcnt == 0) ? 1 : 2), msg) == -1) would work too i guess (it compiles on my machine at least), but it has disadvantages too. one could get rid of the first problem (correct type of IOC) by assigning 1 or 2 instead of the expanded SPI_IOC_MESSAGE(x) value to the local variable and use the macro in the argument list with the variable as parameter. i have no preference for any of those solutions... the posted one is fine too. regarding correctness i think it is ok too, although i have to admit that my review is probably not as thorough as carldani's would have been. i have looked at most of the macros involved; i have looked at spidev_ioctl and spidev_message and everything makes sense... since it's also tested on hardware i think it is good to go so it is... Acked-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

2 1

[commit] r1513 - trunk
by repository service 06 Mar '12

06 Mar '12

Author: mkarcher Date: Tue Mar 6 23:17:06 2012 New Revision: 1513 URL: http://flashrom.org/trac/flashrom/changeset/1513 Log: Prevent submission of empty read requests in linux_spi. The submission of zero-sized read requests in a write-only transaction fails at least for omap2_mcspi drivers and is pointless in general. This patch does not address the implementation of zero-sized writes (which would need to skip the write command), as there are no flash transactions not starting with a command. Signed-off-by: Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> Acked-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Modified: trunk/linux_spi.c Modified: trunk/linux_spi.c ============================================================================== --- trunk/linux_spi.c Sat Mar 3 19:09:33 2012 (r1512) +++ trunk/linux_spi.c Tue Mar 6 23:17:06 2012 (r1513) @@ -130,6 +130,7 @@ const unsigned char *txbuf, unsigned char *rxbuf) { + int iocontrol_code; struct spi_ioc_transfer msg[2] = { { .tx_buf = (uint64_t)(ptrdiff_t)txbuf, @@ -143,8 +144,19 @@ if (fd == -1) return -1; + /* The implementation currently does not support requests that + don't start with sending a command. */ + if (writecnt == 0) + return SPI_INVALID_LENGTH; - if (ioctl(fd, SPI_IOC_MESSAGE(2), msg) == -1) { + /* Just submit the first (write) request in case there is nothing + to read. Otherwise submit both requests. */ + if (readcnt == 0) + iocontrol_code = SPI_IOC_MESSAGE(1); + else + iocontrol_code = SPI_IOC_MESSAGE(2); + + if (ioctl(fd, iocontrol_code, msg) == -1) { msg_cerr("%s: ioctl: %s\n", __func__, strerror(errno)); return -1; }

1 0

Codes for noobs
by Thomas Saunders 05 Mar '12

05 Mar '12

Hi there :) We are building a mushroom farm out here in Denmark and were just wondering whether it was possible to change a chips code? We need the minimum temperature raised in the code. The chip itself is a G80F910C. Any help, however brief, is very much appreciated! Best wishes Thomas Saunders Danske Shiitake Hjelmagervej 7 8541 Skødstrup Danmark Tel: +4553144423 CVR: 33278721

1 0

Re: [flashrom] Ubuntu daily builds PPA
by Stefan Tauner 05 Mar '12

05 Mar '12

On Sun, 4 Mar 2012 15:00:08 -0800 Svetoslav Trochev <svetoslav.trochev(a)gmail.com> wrote: > On Sun, Mar 4, 2012 at 2:23 PM, Stefan Tauner > <stefan.tauner(a)student.tuwien.ac.at> wrote: > > On Sun, 4 Mar 2012 14:05:20 -0800 > > Svetoslav Trochev <svetoslav.trochev(a)gmail.com> wrote: > > > >> > i have setup a flashrom poject at http://launchpad.net/flashrom which > >> > auto-imports the svn every 6 hours and a package archive at > >> > http://launchpad.net/~flashrom-developers/+archive/flashrom-daily > >> > where new binaries are generated once a day whenever the svn has > >> > changed. > >> I found about daily PPA about couple days ago here: > >> http://flashrom.org/Downloads. And used it to collect data from > >> several boards. Is there plan to update the wiki page with info about > >> the new PPA? > > > > jup, i have updated the wiki page before sending the "announce" mail. > > what information do you think is missing/should be added? > > > > -- > > Kind regards/Mit freundlichen Grüßen, Stefan Tauner > > Ok. I was a bit confused as new person to the project. > There are 4 links: (package overview) [1], (questions) [2], (bugreports) [3] > Let say, I am using Ubuntu 10.04LTS and I want to download and install > latest well tested (stable) version of flashrom. I tried the first > link and there only can see version: 0.9.1+r946-1ubuntu1. > Next two links didn't help at all. Finally I found the > 0.9.5.1+r1508-1-20120303~lucid1 version in daily build PPA [4]. I > don't know how the releases are handled, but my experience is that > most of the daily PPAs brake without any notice. This made me quite > uncomfortable to flash M/B using daily build version. I am sure that I > sound quite stupid right now, but I hope that we can provide a bit > more clear picture how the binaries for Ubuntu are maintained and what > version should be used. I hope that this small improvement will lower > the barrier for entrance of new people and help flashrom project as > whole. > > [1] http://launchpad.net/ubuntu/+source/flashrom > [2] http://answers.launchpad.net/ubuntu/+source/flashrom/+questions?field.statu… > [3] http://bugs.launchpad.net/ubuntu/+source/flashrom/+bugs?field.status:list=N… > [4] http://code.launchpad.net/~flashrom-developers/+archive/flashrom-daily thanks for the verbose explanation! i have removed the answers and bugs links (nice idea of whoever added them, but i don't think they are useful. ubuntu users should be able to follow the links on the package overview page to that sections) and i have added more detail to the PPA description and the safety of the binaries. lowering the barrier for new and unexperienced ubuntu users might not necessarily help flashrom on the whole nor those users ;) if they are unsure they should ask us first. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

2 1

Re: [flashrom] Zotac ZBOX-AD02-PLUS-U: System Testing
by Stefan Tauner 04 Mar '12

04 Mar '12

On Sat, 3 Mar 2012 16:05:11 -0800 Svetoslav Trochev <svetoslav.trochev(a)gmail.com> wrote: > Hi Everyone, > > I just tested (read-only) one more system: Zotac ZBOX-AD02-PLUS-U. I > am attaching the output files. Hello, and thanks for your mail. read tests are only useful in some cases (e.g. untested chips), for testing full board support we need a erase/write cycle. that does not mean that you should now erase your chip immediately, but the log as such does not help. if you ever try to update the firmware on that board on the other hand please send us a note. > I have question. Should I be concern very much about "This chip may > contain one-time programmable memory. flashrom cannot read and may > never be able to write it, hence it may not be able to completely > clone the contents of this chip (see man page for details)."? > > I suspect this is about the UEFI secure boot option where the keys > are( or would) be stored. Is this correct? we can neither confirm nor deny this presumption. seriously... no that has nothing to do with secure boot afaik. these chips are used in many other devices not just PCs. the OTP area is usually just a few dozen bytes large, which might be enough for a few key hashes or so, but i doubt anyone would use them for this. it is just a feature to store a few bytes forever* and is probably only used in a few embedded devices. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

2 1

Re: [flashrom] Ubuntu daily builds PPA
by Stefan Tauner 04 Mar '12

04 Mar '12

On Sun, 4 Mar 2012 14:05:20 -0800 Svetoslav Trochev <svetoslav.trochev(a)gmail.com> wrote: > > i have setup a flashrom poject at http://launchpad.net/flashrom which > > auto-imports the svn every 6 hours and a package archive at > > http://launchpad.net/~flashrom-developers/+archive/flashrom-daily > > where new binaries are generated once a day whenever the svn has > > changed. > I found about daily PPA about couple days ago here: > http://flashrom.org/Downloads. And used it to collect data from > several boards. Is there plan to update the wiki page with info about > the new PPA? jup, i have updated the wiki page before sending the "announce" mail. what information do you think is missing/should be added? -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

2 1

Ubuntu daily builds PPA
by Stefan Tauner 04 Mar '12

04 Mar '12

Hi, i have setup a flashrom poject at http://launchpad.net/flashrom which auto-imports the svn every 6 hours and a package archive at http://launchpad.net/~flashrom-developers/+archive/flashrom-daily where new binaries are generated once a day whenever the svn has changed. currently there is a bug in launchpad itself that makes it impossible to use version 0.4 recipes (recipes are used to configure the autobuilders). this is the reason the package names are a bit awkward (e.g. 0.9.5.1+r1508-1-20120303 for svn r1512). it is basically named by {debversion}-{date}. it is the best i could come up with, that indicates the included source in at least some way (date), will upgrade to newer ubuntu versions when they become available and actually build in current launchpad. another problem is that the autobuilt binaries will output this: flashrom v0.9.5.1-runknown on Linux 2.6.35-32-generic (x86_64), built with libpci 3.1.7, GCC 4.4.5, little endian i.e. no svn revision. the only way to work around this would be a second svn tree with an already (auto-)exported version of flashrom... if we could manage to set that up, we could probably build our own package too without launchpad :) maybe it is useful anyway for someone... -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

3 3

Re: [flashrom] Raspberry Pi support as a programmer
by Carl-Daniel Hailfinger 04 Mar '12

04 Mar '12

Hi cemede, Am 04.03.2012 14:20 schrieb cmd_: > Recently has appeared a ultra-cheap board named Raspberry Pi (perhaps you > know http://www.raspberrypi.org/ ). This board has a powerful broadcom SoC > that comes with USB, UART, I2C, SPI, GPIO ports... all for 25/35$, awsome. > It could be a really versatile and powerful external/independent programmer > for flashrom! > > Just take a look here: http://elinux.org/RPi_Low-level_peripherals > > The SPI bus could be used to program SPI flash chips (obviously) and GPIO > for the other types. > I propose two ideas, first one, support the board by flashrom software, I already wrote a flashrom driver for the Raspberry Pi, I only need someone with hardware to test it. > second one, develop a daughter-board for the Raspberry-Pi to make a easy > use of all (with sockets to program IC's or some buffers if necessary for > other ones). I hope the Gertboard will accomplish some of that functionality. Designing our own PCB would be possible, sure, but my first focus is on getting the driver tested. Regards, Carl-Daniel -- http://www.hailfinger.org/

1 0

Re: [flashrom] Raspberry Pi support as a programmer
by cmd_ 04 Mar '12

04 Mar '12

Just I missed some links in my mast mail with great info: http://elinux.org/Rpi_Datasheet_751_GPIO_Registers http://elinux.org/Rpi_Hardware http://dmkenr5gtnd8f.cloudfront.net/wp-content/uploads/2012/02/BCM2835-ARM-… http://elinux.org/BCM2835_datasheet_errata 2012/3/4 cmd_ <cemede(a)gmail.com> > Hi guys, has past a lot of time since my last inquiry! > > Recently has appeared a ultra-cheap board named Raspberry Pi (perhaps you > know http://www.raspberrypi.org/ ). This board has a powerful broadcom > SoC that comes with USB, UART, I2C, SPI, GPIO ports... all for 25/35$, > awsome. It could be a really versatile and powerful external/independent > programmer for flashrom! > > Just take a look here: http://elinux.org/RPi_Low-level_peripherals > > The SPI bus could be used to program SPI flash chips (obviously) and GPIO > for the other types. > I propose two ideas, first one, support the board by flashrom software, > second one, develop a daughter-board for the Raspberry-Pi to make a easy > use of all (with sockets to program IC's or some buffers if necessary for > other ones). > > That's all, greetings! >

1 0

Raspberry Pi support as a programmer
by cmd_ 04 Mar '12

04 Mar '12

Hi guys, has past a lot of time since my last inquiry! Recently has appeared a ultra-cheap board named Raspberry Pi (perhaps you know http://www.raspberrypi.org/ ). This board has a powerful broadcom SoC that comes with USB, UART, I2C, SPI, GPIO ports... all for 25/35$, awsome. It could be a really versatile and powerful external/independent programmer for flashrom! Just take a look here: http://elinux.org/RPi_Low-level_peripherals The SPI bus could be used to program SPI flash chips (obviously) and GPIO for the other types. I propose two ideas, first one, support the board by flashrom software, second one, develop a daughter-board for the Raspberry-Pi to make a easy use of all (with sockets to program IC's or some buffers if necessary for other ones). That's all, greetings!

1 0

Zotac ZBOX-AD02-PLUS-U: System Testing
by Svetoslav Trochev 03 Mar '12

03 Mar '12

Hi Everyone, I just tested (read-only) one more system: Zotac ZBOX-AD02-PLUS-U. I am attaching the output files. I have question. Should I be concern very much about "This chip may contain one-time programmable memory. flashrom cannot read and may never be able to write it, hence it may not be able to completely clone the contents of this chip (see man page for details)."? I suspect this is about the UEFI secure boot option where the keys are( or would) be stored. Is this correct? Thank you, Svetoslav Trochev

1 0

ASRock H67M: Board Testing
by Svetoslav Trochev 03 Mar '12

03 Mar '12

Hi Everyone, I just run test on ASRock H67M mainboard. I am attaching the output files from "flashrom -V" and "lspci -nnvvxxx". After a quick search I could not find how to run "superiotool -deV" on Ubuntu, but once I figure it out I will attach the output as well. I hope the current info is useful for now. Thanks, Svetoslav Trochev

1 0

flashrom output
by Cavit VURAL 03 Mar '12

03 Mar '12

root@cvural64:/home/cvural/flashrom-0.9.5.1# ./flashrom -V flashrom v0.9.5.1-r1509 on Linux 3.2.0-1-amd64 (x86_64), built with libpci 3.1.8, GCC 4.6.2, little endian flashrom is free software, get the source code at http://www.flashrom.org Calibrating delay loop... OS timer resolution is 1 usecs, 1316M loops per second, 10 myus = 10 us, 100 myus = 99 us, 1000 myus = 993 us, 10000 myus = 10037 us, 4 myus = 4 us, OK. Initializing internal programmer No coreboot table found. DMI string system-manufacturer: "Dell Inc." DMI string system-product-name: "Inspiron 580 " DMI string system-version: "Not Specified" DMI string baseboard-manufacturer: "Dell Inc." DMI string baseboard-product-name: "033FF6" DMI string baseboard-version: "A00" DMI string chassis-type: "Desktop" Found ITE Super I/O, ID 0x8721 on port 0x2e Found chipset "Intel H57" with PCI ID 8086:3b08. This chipset is marked as untested. If you are using an up-to-date version of flashrom please email a report to flashrom(a)flashrom.org including a verbose (-V) log. Thank you! Enabling flash write... 0xfff80000/0xffb80000 FWH IDSEL: 0x0 0xfff00000/0xffb00000 FWH IDSEL: 0x0 0xffe80000/0xffa80000 FWH IDSEL: 0x1 0xffe00000/0xffa00000 FWH IDSEL: 0x1 0xffd80000/0xff980000 FWH IDSEL: 0x2 0xffd00000/0xff900000 FWH IDSEL: 0x2 0xffc80000/0xff880000 FWH IDSEL: 0x3 0xffc00000/0xff800000 FWH IDSEL: 0x3 0xff700000/0xff300000 FWH IDSEL: 0x4 0xff600000/0xff200000 FWH IDSEL: 0x5 0xff500000/0xff100000 FWH IDSEL: 0x6 0xff400000/0xff000000 FWH IDSEL: 0x7 0xfff80000/0xffb80000 FWH decode enabled 0xfff00000/0xffb00000 FWH decode enabled 0xffe80000/0xffa80000 FWH decode disabled 0xffe00000/0xffa00000 FWH decode disabled 0xffd80000/0xff980000 FWH decode disabled 0xffd00000/0xff900000 FWH decode disabled 0xffc80000/0xff880000 FWH decode disabled 0xffc00000/0xff800000 FWH decode disabled 0xff700000/0xff300000 FWH decode disabled 0xff600000/0xff200000 FWH decode disabled 0xff500000/0xff100000 FWH decode disabled 0xff400000/0xff000000 FWH decode disabled Maximum FWH chip size: 0x100000 bytes BIOS Lock Enable: disabled, BIOS Write Enable: disabled, BIOS_CNTL is 0x8 Root Complex Register Block address = 0xfed1c000 GCS = 0xc64: BIOS Interface Lock-Down: disabled, Boot BIOS Straps: 0x3 (SPI) Top Swap : not enabled SPIBAR = 0xfed1c000 + 0x3800 0x04: 0x6008 (HSFS) HSFS: FDONE=0, FCERR=0, AEL=0, BERASE=1, SCIP=0, FDOPSS=1, FDV=1, FLOCKDN=0 Programming OPCODES... program_opcodes: preop=5006 optype=463b opmenu=05d80302c79f0190 done 0x06: 0x0000 (HSFC) HSFC: FGO=0, FCYCLE=0, FDBC=0, SME=0 0x08: 0x00000000 (FADDR) 0x50: 0x00000a0b (FRAP) BMWAG 0x00, BMRAG 0x00, BRWA 0x0a, BRRA 0x0b 0x54: 0x00000000 FREG0: WARNING: Flash Descriptor region (0x00000000-0x00000fff) is read-only. 0x58: 0x07ff0700 FREG1: BIOS region (0x00700000-0x007fffff) is read-write. 0x5C: 0x06ff0001 FREG2: WARNING: Management Engine region (0x00001000-0x006fffff) is locked. Please send a verbose log to flashrom(a)flashrom.org if this board is not listed on http://flashrom.org/Supported_hardware#Supported_mainboards yet. Writes have been disabled. You can enforce write support with the ich_spi_force programmer option, but it will most likely harm your hardware! If you force flashrom you will get no support if something breaks. 0x90: 0x04 (SSFS) SSFS: SCIP=0, FDONE=1, FCERR=0, AEL=0 0x91: 0xf84140 (SSFC) SSFC: SCGO=0, ACS=0, SPOP=0, COP=4, DBC=1, SME=0, SCF=0 0x94: 0x5006 (PREOP) 0x96: 0x463b (OPTYPE) 0x98: 0x05d80302 (OPMENU) 0x9C: 0xc79f0190 (OPMENU+4) 0xA0: 0x00000000 (BBAR) 0xC4: 0x00000000 (LVSCC) LVSCC: BES=0x0, WG=0, WSR=0, WEWS=0, EO=0x0, VCL=0 0xC8: 0x00002001 (UVSCC) UVSCC: BES=0x1, WG=0, WSR=0, WEWS=0, EO=0x20, VCL=0 0xD0: 0x00000000 (FPB) SPI Read Configuration: prefetching enabled, caching enabled, OK. Super I/O ID 0x8721 is not on the list of flash capable controllers. The following protocols are supported: FWH, SPI. Probing for AMIC A25L05PT, 64 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for AMIC A25L05PU, 64 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for AMIC A25L10PT, 128 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for AMIC A25L10PU, 128 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for AMIC A25L20PT, 256 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for AMIC A25L20PU, 256 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for AMIC A25L40PT, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for AMIC A25L40PU, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for AMIC A25L80P, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for AMIC A25L16PT, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for AMIC A25L16PU, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for AMIC A25L512, 64 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for AMIC A25L010, 128 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for AMIC A25L020, 256 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for AMIC A25L040, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for AMIC A25L080, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for AMIC A25L016, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for AMIC A25L032, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for AMIC A25LQ032, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Atmel AT25DF021, 256 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Atmel AT25DF041A, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Atmel AT25DF081, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Atmel AT25DF081A, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Atmel AT25DF161, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Atmel AT25DF321, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Atmel AT25DF321A, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Atmel AT25DF641(A), 8192 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Atmel AT25DQ161, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Atmel AT25F512B, 64 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Atmel AT25FS010, 128 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Atmel AT25FS040, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Atmel AT26DF041, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Atmel AT26DF081A, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Atmel AT26DF161, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Atmel AT26DF161A, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Atmel AT26F004, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Atmel AT45CS1282, 16896 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Atmel AT45DB011D, 128 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Atmel AT45DB021D, 256 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Atmel AT45DB041D, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Atmel AT45DB081D, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Atmel AT45DB161D, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Atmel AT45DB321C, 4224 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Atmel AT45DB321D, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Atmel AT45DB642D, 8192 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for EMST F25L008A, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon EN25B05, 64 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon EN25B05T, 64 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon EN25B10, 128 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon EN25B10T, 128 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon EN25B20, 256 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon EN25B20T, 256 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon EN25B40, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon EN25B40T, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon EN25B80, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon EN25B80T, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon EN25B16, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon EN25B16T, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon EN25B32, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon EN25B32T, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon EN25B64, 8192 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon EN25B64T, 8192 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon EN25F05, 64 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon EN25F10, 128 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon EN25F20, 256 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon EN25F40, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon EN25F80, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon EN25F16, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon EN25F32, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon EN25Q40, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon EN25Q80(A), 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon EN25Q16, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon EN25Q32(A/B), 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon EN25Q64, 8192 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon EN25Q128, 16384 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon EN25QH16, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Macronix MX25L512, 64 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Macronix MX25L1005, 128 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Macronix MX25L2005, 256 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Macronix MX25L4005, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Macronix MX25L8005, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Macronix MX25L1605, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Macronix MX25L1635D, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Macronix MX25L1635E, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Macronix MX25L3205, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Macronix MX25L3235D, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Macronix MX25L6405, 8192 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Chip status register is 00 Chip status register: Status Register Write Disable (SRWD) is not set Chip status register: Bit 6 is not set Chip status register: Bit 5 / Block Protect 3 (BP3) is not set Chip status register: Bit 4 / Block Protect 2 (BP2) is not set Chip status register: Bit 3 / Block Protect 1 (BP1) is not set Chip status register: Bit 2 / Block Protect 0 (BP0) is not set Chip status register: Write Enable Latch (WEL) is not set Chip status register: Write In Progress (WIP/BUSY) is not set Found Macronix flash chip "MX25L6405" (8192 kB, SPI) at physical address 0xff800000. Probing for Macronix MX25L12805, 16384 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Numonyx M25PE10, 128 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Numonyx M25PE20, 256 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Numonyx M25PE40, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Numonyx M25PE80, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Numonyx M25PE16, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for PMC Pm25LV010, 128 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for PMC Pm25LV016B, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for PMC Pm25LV020, 256 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for PMC Pm25LV040, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for PMC Pm25LV080B, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for PMC Pm25LV512, 64 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Sanyo LF25FW203A, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Spansion S25FL004A, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Spansion S25FL008A, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Spansion S25FL016A, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Spansion S25FL032A, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Spansion S25FL064A, 8192 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for SST SST25LF040A, 512 kB: program_opcodes: preop=5006 optype=462b opmenu=05ab0302c79f0190 on-the-fly OPCODE (0xAB) re-programmed, op-pos=2 probe_spi_res2: id1 0x16, id2 0x16 Probing for SST SST25LF080A, 1024 kB: probe_spi_res2: id1 0x16, id2 0x16 Probing for SST SST25VF010, 128 kB: probe_spi_rems: id1 0xc2, id2 0x16 Probing for SST SST25VF016B, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for SST SST25VF032B, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for SST SST25VF064C, 8192 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for SST SST25VF040, 512 kB: probe_spi_rems: id1 0xc2, id2 0x16 Probing for SST SST25VF040B, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for SST SST25VF040B.REMS, 512 kB: probe_spi_rems: id1 0xc2, id2 0x16 Probing for SST SST25VF080B, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for ST M25P05-A, 64 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for ST M25P05, 64 kB: Ignoring RES in favour of RDID. Probing for ST M25P10-A, 128 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for ST M25P10, 128 kB: Ignoring RES in favour of RDID. Probing for ST M25P20, 256 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for ST M25P40, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for ST M25P40-old, 512 kB: Ignoring RES in favour of RDID. Probing for ST M25P80, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for ST M25P16, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for ST M25P32, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for ST M25P64, 8192 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for ST M25P128, 16384 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for ST M25PX16, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for ST M25PX32, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for ST M25PX64, 8192 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Winbond W25Q80, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Winbond W25Q16, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Winbond W25Q32, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Winbond W25Q64, 8192 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Winbond W25Q128, 16384 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Winbond W25X10, 128 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Winbond W25X20, 256 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Winbond W25X40, 512 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Winbond W25X80, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Winbond W25X16, 2048 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Winbond W25X32, 4096 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Winbond W25X64, 8192 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Unknown SFDP-capable chip, 0 kB: program_opcodes: preop=5006 optype=462b opmenu=055a0302c79f0190 on-the-fly OPCODE (0x5A) re-programmed, op-pos=2 No SFDP signature found. Probing for AMIC unknown AMIC SPI chip, 0 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Atmel unknown Atmel SPI chip, 0 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Eon unknown Eon SPI chip, 0 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Macronix unknown Macronix SPI chip, 0 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for PMC unknown PMC SPI chip, 0 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for SST unknown SST SPI chip, 0 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for ST unknown ST SPI chip, 0 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Sanyo unknown Sanyo SPI chip, 0 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Generic unknown SPI chip (RDID), 0 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2017 Probing for Generic unknown SPI chip (REMS), 0 kB: probe_spi_rems: id1 0xc2, id2 0x16 Probing for Atmel AT49LH002, 256 kB: probe_82802ab: id1 0x41, id2 0x4d, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Intel 82802AB, 512 kB: probe_82802ab: id1 0x41, id2 0x4d, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Intel 82802AC, 1024 kB: probe_82802ab: id1 0x4e, id2 0x56, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for PMC Pm49FL002, 256 kB: probe_jedec_common: id1 0x41, id2 0x4d, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for PMC Pm49FL004, 512 kB: probe_jedec_common: id1 0x41, id2 0x4d, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Sharp LHF00L04, 1024 kB: probe_82802ab: id1 0x4e, id2 0x56, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for SST SST49LF002A/B, 256 kB: probe_jedec_common: id1 0x41, id2 0x4d, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for SST SST49LF003A/B, 384 kB: probe_jedec_common: id1 0x6b, id2 0xb7, id1 is normal flash content, id2 is normal flash content Probing for SST SST49LF004A/B, 512 kB: probe_jedec_common: id1 0x41, id2 0x4d, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for SST SST49LF004C, 512 kB: probe_82802ab: id1 0x41, id2 0x4d, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for SST SST49LF008A, 1024 kB: probe_jedec_common: id1 0x4e, id2 0x56, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for SST SST49LF008C, 1024 kB: probe_82802ab: id1 0x4e, id2 0x56, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for SST SST49LF016C, 2048 kB: Chip size 2048 kB is bigger than supported size 1024 kB of chipset/board/programmer for FWH interface, probe/read/erase/write may fail. probe_82802ab: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for ST M50FLW040A, 512 kB: probe_82802ab: id1 0x41, id2 0x4d, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for ST M50FLW040B, 512 kB: probe_82802ab: id1 0x41, id2 0x4d, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for ST M50FLW080A, 1024 kB: probe_82802ab: id1 0x4e, id2 0x56, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for ST M50FLW080B, 1024 kB: probe_82802ab: id1 0x4e, id2 0x56, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for ST M50FW002, 256 kB: probe_82802ab: id1 0x41, id2 0x4d, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for ST M50FW016, 2048 kB: Chip size 2048 kB is bigger than supported size 1024 kB of chipset/board/programmer for FWH interface, probe/read/erase/write may fail. probe_82802ab: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for ST M50FW040, 512 kB: probe_82802ab: id1 0x41, id2 0x4d, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for ST M50FW080, 1024 kB: probe_82802ab: id1 0x4e, id2 0x56, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Winbond W39V040FA, 512 kB: probe_jedec_common: id1 0x41, id2 0x4d, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Winbond W39V040FB, 512 kB: probe_jedec_common: id1 0x41, id2 0x4d, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Winbond W39V040FC, 512 kB: probe_jedec_common: id1 0x41, id2 0x4d, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Winbond W49V002FA, 256 kB: probe_jedec_common: id1 0x41, id2 0x4d, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Winbond W39V080FA, 1024 kB: probe_jedec_common: id1 0x4e, id2 0x56, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Winbond W39V080FA (dual mode), 512 kB: probe_jedec_common: id1 0x41, id2 0x4d, id1 parity violation, id1 is normal flash content, id2 is normal flash content Found Macronix flash chip "MX25L6405" (8192 kB, SPI). No operations were specified. Restoring MMIO space at 0x7f8cda8698a0 Restoring MMIO space at 0x7f8cda86989c Restoring MMIO space at 0x7f8cda869898 Restoring MMIO space at 0x7f8cda869896 Restoring MMIO space at 0x7f8cda869894 Restoring PCI config space for 00:1f:0 reg 0xdc

2 1

Re: [flashrom] [PATCH] linux_spi.c: set SPI mode, bit order and bits per word on init.
by Carl-Daniel Hailfinger 03 Mar '12

03 Mar '12

Am 03.03.2012 14:48 schrieb Stefan Tauner: > Previously we relied on a correctly set up state. > > Also, we start to rely on the shutdown function for cleanup after > registering it, i.e. we no longer explicitly call close(fd) after > register_shutdown(). > > Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Thanks for reworking this patch! Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Regards, Carl-Daniel -- http://www.hailfinger.org/

1 0

[PATCH 7/7] [RFC] Unify usbdev_status and pcidev_status into dev_status.
by Stefan Tauner 03 Mar '12

03 Mar '12

usbdev_status was created for the ft2232 programmer. Its IDs are semantically different because they indicate USB instead of PCI IDs, but apart from that both data structures are equal. This change makes life easier for everything involved in handling and printing the status of devices that is noted in that structure. --- It is still possible to distinguish between PCI and USB devices by using the struct programmer's type field. It still seems a bit hacky, but i think we are better off with it anyway. If we really would want to distinguish between the different types of IDs i'd rater make the IDs a union of different ID types inside struct dev_status. Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> --- drkaiser.c | 2 +- flashrom.c | 38 ++++++++++++++++++------------------ ft2232_spi.c | 2 +- gfxnvidia.c | 2 +- nic3com.c | 2 +- nicintel.c | 2 +- nicintel_spi.c | 2 +- nicrealtek.c | 2 +- ogp_spi.c | 2 +- pcidev.c | 6 ++-- print.c | 23 +++------------------ print_wiki.c | 51 ++++++++---------------------------------------- programmer.h | 58 ++++++++++++++++++++++++------------------------------- satamv.c | 2 +- satasii.c | 2 +- 15 files changed, 70 insertions(+), 126 deletions(-) diff --git a/drkaiser.c b/drkaiser.c index 362db57..faa7035 100644 --- a/drkaiser.c +++ b/drkaiser.c @@ -32,7 +32,7 @@ /* Mask to restrict flash accesses to the 128kB memory window. */ #define DRKAISER_MEMMAP_MASK ((1 << 17) - 1) -const struct pcidev_status drkaiser_pcidev[] = { +const struct dev_status drkaiser_pcidev[] = { {0x1803, 0x5057, OK, "Dr. Kaiser", "PC-Waechter (Actel FPGA)"}, {}, }; diff --git a/flashrom.c b/flashrom.c index bf1e157..20a41f2 100644 --- a/flashrom.c +++ b/flashrom.c @@ -63,7 +63,7 @@ const struct programmer_entry programmer_table[] = { { .name = "internal", .type = OTHER, - .devices.note = NULL, + .devs.note = NULL, .init = internal_init, .map_flash_region = physmap, .unmap_flash_region = physunmap, @@ -76,7 +76,7 @@ const struct programmer_entry programmer_table[] = { .name = "dummy", .type = OTHER, /* FIXME */ - .devices.note = "Dummy device, does nothing and logs all accesses\n", + .devs.note = "Dummy device, does nothing and logs all accesses\n", .init = dummy_init, .map_flash_region = dummy_map, .unmap_flash_region = dummy_unmap, @@ -88,7 +88,7 @@ const struct programmer_entry programmer_table[] = { { .name = "nic3com", .type = PCI, - .devices.pci = nics_3com, + .devs.status = nics_3com, .init = nic3com_init, .map_flash_region = fallback_map, .unmap_flash_region = fallback_unmap, @@ -101,7 +101,7 @@ const struct programmer_entry programmer_table[] = { /* This programmer works for Realtek RTL8139 and SMC 1211. */ .name = "nicrealtek", .type = PCI, - .devices.pci = nics_realtek, + .devs.status = nics_realtek, //.name = "nicsmc1211", .init = nicrealtek_init, .map_flash_region = fallback_map, @@ -114,7 +114,7 @@ const struct programmer_entry programmer_table[] = { { .name = "nicnatsemi", .type = PCI, - .devices.pci = nics_natsemi, + .devs.status = nics_natsemi, .init = nicnatsemi_init, .map_flash_region = fallback_map, .unmap_flash_region = fallback_unmap, @@ -126,7 +126,7 @@ const struct programmer_entry programmer_table[] = { { .name = "gfxnvidia", .type = PCI, - .devices.pci = gfx_nvidia, + .devs.status = gfx_nvidia, .init = gfxnvidia_init, .map_flash_region = fallback_map, .unmap_flash_region = fallback_unmap, @@ -138,7 +138,7 @@ const struct programmer_entry programmer_table[] = { { .name = "drkaiser", .type = PCI, - .devices.pci = drkaiser_pcidev, + .devs.status = drkaiser_pcidev, .init = drkaiser_init, .map_flash_region = fallback_map, .unmap_flash_region = fallback_unmap, @@ -150,7 +150,7 @@ const struct programmer_entry programmer_table[] = { { .name = "satasii", .type = PCI, - .devices.pci = satas_sii, + .devs.status = satas_sii, .init = satasii_init, .map_flash_region = fallback_map, .unmap_flash_region = fallback_unmap, @@ -162,7 +162,7 @@ const struct programmer_entry programmer_table[] = { { .name = "atahpt", .type = PCI, - .devices.pci = ata_hpt, + .devs.status = ata_hpt, .init = atahpt_init, .map_flash_region = fallback_map, .unmap_flash_region = fallback_unmap, @@ -174,7 +174,7 @@ const struct programmer_entry programmer_table[] = { { .name = "ft2232_spi", .type = USB, - .devices.usb = devs_ft2232spi, + .devs.status = devs_ft2232spi, .init = ft2232_spi_init, .map_flash_region = fallback_map, .unmap_flash_region = fallback_unmap, @@ -187,7 +187,7 @@ const struct programmer_entry programmer_table[] = { .name = "serprog", .type = OTHER, /* FIXME */ - .devices.note = "All programmer devices speaking the serprog protocol\n", + .devs.note = "All programmer devices speaking the serprog protocol\n", .init = serprog_init, .map_flash_region = fallback_map, .unmap_flash_region = fallback_unmap, @@ -200,7 +200,7 @@ const struct programmer_entry programmer_table[] = { .name = "buspirate_spi", .type = OTHER, /* FIXME */ - .devices.note = "Dangerous Prototypes Bus Pirate\n", + .devs.note = "Dangerous Prototypes Bus Pirate\n", .init = buspirate_spi_init, .map_flash_region = fallback_map, .unmap_flash_region = fallback_unmap, @@ -213,7 +213,7 @@ const struct programmer_entry programmer_table[] = { .name = "dediprog", .type = OTHER, /* FIXME */ - .devices.note = "Dediprog SF100\n", + .devs.note = "Dediprog SF100\n", .init = dediprog_init, .map_flash_region = fallback_map, .unmap_flash_region = fallback_unmap, @@ -226,7 +226,7 @@ const struct programmer_entry programmer_table[] = { .name = "rayer_spi", .type = OTHER, /* FIXME */ - .devices.note = "RayeR parallel port programmer\n", + .devs.note = "RayeR parallel port programmer\n", .init = rayer_spi_init, .map_flash_region = fallback_map, .unmap_flash_region = fallback_unmap, @@ -238,7 +238,7 @@ const struct programmer_entry programmer_table[] = { { .name = "nicintel", .type = PCI, - .devices.pci = nics_intel, + .devs.status = nics_intel, .init = nicintel_init, .map_flash_region = fallback_map, .unmap_flash_region = fallback_unmap, @@ -250,7 +250,7 @@ const struct programmer_entry programmer_table[] = { { .name = "nicintel_spi", .type = PCI, - .devices.pci = nics_intel_spi, + .devs.status = nics_intel_spi, .init = nicintel_spi_init, .map_flash_region = fallback_map, .unmap_flash_region = fallback_unmap, @@ -262,7 +262,7 @@ const struct programmer_entry programmer_table[] = { { .name = "ogp_spi", .type = PCI, - .devices.pci = ogp_spi, + .devs.status = ogp_spi, .init = ogp_spi_init, .map_flash_region = fallback_map, .unmap_flash_region = fallback_unmap, @@ -274,7 +274,7 @@ const struct programmer_entry programmer_table[] = { { .name = "satamv", .type = PCI, - .devices.pci = satas_mv, + .devs.status = satas_mv, .init = satamv_init, .map_flash_region = fallback_map, .unmap_flash_region = fallback_unmap, @@ -286,7 +286,7 @@ const struct programmer_entry programmer_table[] = { { .name = "linux_spi", .type = OTHER, - .devices.note = "Device files /dev/spidev*.*\n", + .devs.note = "Device files /dev/spidev*.*\n", .init = linux_spi_init, .map_flash_region = fallback_map, .unmap_flash_region = fallback_unmap, diff --git a/ft2232_spi.c b/ft2232_spi.c index ec4934e..069421c 100644 --- a/ft2232_spi.c +++ b/ft2232_spi.c @@ -49,7 +49,7 @@ #define OLIMEX_ARM_OCD_H_PID 0x002B #define OLIMEX_ARM_TINY_H_PID 0x002A -const struct usbdev_status devs_ft2232spi[] = { +const struct dev_status devs_ft2232spi[] = { {FTDI_VID, FTDI_FT2232H_PID, OK, "FTDI", "FT2232H"}, {FTDI_VID, FTDI_FT4232H_PID, OK, "FTDI", "FT4232H"}, {FTDI_VID, TIAO_TUMPA_PID, OK, "TIAO", "USB Multi-Protocol Adapter"}, diff --git a/gfxnvidia.c b/gfxnvidia.c index b8750b3..bcd53a7 100644 --- a/gfxnvidia.c +++ b/gfxnvidia.c @@ -33,7 +33,7 @@ uint8_t *nvidia_bar; -const struct pcidev_status gfx_nvidia[] = { +const struct dev_status gfx_nvidia[] = { {0x10de, 0x0010, NT, "NVIDIA", "Mutara V08 [NV2]" }, {0x10de, 0x0018, NT, "NVIDIA", "RIVA 128" }, {0x10de, 0x0020, NT, "NVIDIA", "RIVA TNT" }, diff --git a/nic3com.c b/nic3com.c index 473c7b1..2fff346 100644 --- a/nic3com.c +++ b/nic3com.c @@ -35,7 +35,7 @@ static uint32_t internal_conf; static uint16_t id; -const struct pcidev_status nics_3com[] = { +const struct dev_status nics_3com[] = { /* 3C90xB */ {0x10b7, 0x9055, OK, "3COM", "3C90xB: PCI 10/100 Mbps; shared 10BASE-T/100BASE-TX"}, {0x10b7, 0x9001, NT, "3COM", "3C90xB: PCI 10/100 Mbps; shared 10BASE-T/100BASE-T4" }, diff --git a/nicintel.c b/nicintel.c index 0415f46..5261263 100644 --- a/nicintel.c +++ b/nicintel.c @@ -26,7 +26,7 @@ uint8_t *nicintel_bar; uint8_t *nicintel_control_bar; -const struct pcidev_status nics_intel[] = { +const struct dev_status nics_intel[] = { {PCI_VENDOR_ID_INTEL, 0x1209, NT, "Intel", "8255xER/82551IT Fast Ethernet Controller"}, {PCI_VENDOR_ID_INTEL, 0x1229, OK, "Intel", "82557/8/9/0/1 Ethernet Pro 100"}, diff --git a/nicintel_spi.c b/nicintel_spi.c index 4ff8554..132673a 100644 --- a/nicintel_spi.c +++ b/nicintel_spi.c @@ -64,7 +64,7 @@ uint8_t *nicintel_spibar; -const struct pcidev_status nics_intel_spi[] = { +const struct dev_status nics_intel_spi[] = { {PCI_VENDOR_ID_INTEL, 0x105e, OK, "Intel", "82571EB Gigabit Ethernet Controller"}, {PCI_VENDOR_ID_INTEL, 0x1076, OK, "Intel", "82541GI Gigabit Ethernet Controller"}, {PCI_VENDOR_ID_INTEL, 0x107c, OK, "Intel", "82541PI Gigabit Ethernet Controller"}, diff --git a/nicrealtek.c b/nicrealtek.c index 32aa434..66f5eda 100644 --- a/nicrealtek.c +++ b/nicrealtek.c @@ -30,7 +30,7 @@ #define BIOS_ROM_ADDR 0xD4 #define BIOS_ROM_DATA 0xD7 -const struct pcidev_status nics_realtek[] = { +const struct dev_status nics_realtek[] = { {0x10ec, 0x8139, OK, "Realtek", "RTL8139/8139C/8139C+"}, {0x1113, 0x1211, OK, "SMC2", "1211TX"}, /* RTL8139 clone */ {}, diff --git a/ogp_spi.c b/ogp_spi.c index 812420c..231c110 100644 --- a/ogp_spi.c +++ b/ogp_spi.c @@ -45,7 +45,7 @@ static uint32_t ogp_reg_siso; static uint32_t ogp_reg__ce; static uint32_t ogp_reg_sck; -const struct pcidev_status ogp_spi[] = { +const struct dev_status ogp_spi[] = { {PCI_VENDOR_ID_OGP, 0x0000, OK, "Open Graphics Project", "Development Board OGD1"}, {}, }; diff --git a/pcidev.c b/pcidev.c index 6e5d0f1..13031d5 100644 --- a/pcidev.c +++ b/pcidev.c @@ -36,7 +36,7 @@ enum pci_bartype { }; uintptr_t pcidev_validate(struct pci_dev *dev, int bar, - const struct pcidev_status *devs) + const struct dev_status *devs) { int i; uint64_t addr; @@ -188,7 +188,7 @@ uintptr_t pcidev_validate(struct pci_dev *dev, int bar, return 0; } -uintptr_t pcidev_init(int bar, const struct pcidev_status *devs) +uintptr_t pcidev_init(int bar, const struct dev_status *devs) { struct pci_dev *dev; struct pci_filter filter; @@ -240,7 +240,7 @@ uintptr_t pcidev_init(int bar, const struct pcidev_status *devs) return curaddr; } -void print_supported_pcidevs(const struct pcidev_status *devs) +void print_supported_devs(const struct dev_status *devs) { int i; diff --git a/print.c b/print.c index 8bab8e3..4e5e086 100644 --- a/print.c +++ b/print.c @@ -422,21 +422,6 @@ static void print_supported_boards_helper(const struct board_info *boards, } #endif -#if CONFIG_FT2232_SPI == 1 -void print_supported_usbdevs(const struct usbdev_status *devs) -{ - int i; - - msg_pinfo("USB devices:\n"); - for (i = 0; devs[i].vendor_name != NULL; i++) { - msg_pinfo("%s %s [%04x:%04x]%s\n", devs[i].vendor_name, - devs[i].device_name, devs[i].vendor_id, - devs[i].device_id, - (devs[i].status == NT) ? " (untested)" : ""); - } -} -#endif - void print_supported(void) { unsigned int i; @@ -459,19 +444,19 @@ void print_supported(void) case USB: msg_ginfo("\nSupported USB devices for the %s programmer:\n", prog.name); - print_supported_usbdevs(prog.devices.usb); + print_supported_devs(prog.devs.status); break; case PCI: msg_ginfo("\nSupported PCI devices for the %s programmer:\n", prog.name); - print_supported_pcidevs(prog.devices.pci); + print_supported_devs(prog.devs.status); break; case OTHER: - if (prog.devices.note == NULL) + if (prog.devs.note == NULL) break; msg_ginfo("\nSupported devices for the %s programmer:\n", prog.name); - msg_ginfo("%s", prog.devices.note); + msg_ginfo("%s", prog.devs.note); break; default: break; diff --git a/print_wiki.c b/print_wiki.c index c25ec28..479f426 100644 --- a/print_wiki.c +++ b/print_wiki.c @@ -294,54 +294,21 @@ static void print_supported_chips_wiki(int cols) printf("|}\n\n"); } -/* Not needed for CONFIG_INTERNAL, but for all other PCI-based programmers. */ -#if CONFIG_NIC3COM+CONFIG_NICREALTEK+CONFIG_NICNATSEMI+CONFIG_GFXNVIDIA+CONFIG_DRKAISER+CONFIG_SATASII+CONFIG_ATAHPT+CONFIG_NICINTEL+CONFIG_NICINTEL_SPI+CONFIG_OGP_SPI+CONFIG_SATAMV >= 1 -static int count_supported_pcidevs_wiki(const struct pcidev_status *devs) +static int count_supported_devs_wiki(const struct dev_status *devs) { unsigned int count = 0; unsigned int i = 0; for (i = 0; devs[i].vendor_name != NULL; i++) - count++; + count++; return count; } -static void print_supported_pcidevs_wiki_helper(const struct programmer_entry prog) +static void print_supported_devs_wiki_helper(const struct programmer_entry prog) { int i = 0; static int c = 0; - const struct pcidev_status *devs = prog.devices.pci; - const unsigned int count = count_supported_pcidevs_wiki(devs); - - /* Alternate colors if the vendor changes. */ - c = !c; - - for (i = 0; devs[i].vendor_name != NULL; i++) { - printf("|- bgcolor=\"#%s\"\n", (c) ? "eeeeee" : "dddddd"); - if (i == 0) - printf("| rowspan=\"%u\" | %s |", count, prog.name); - printf("| %s || %s || %04x:%04x || {{%s}}\n", - devs[i].vendor_name, devs[i].device_name, - devs[i].vendor_id, devs[i].device_id, - (devs[i].status == NT) ? "?3" : "OK"); - } -} -#endif - -static int count_supported_usbdevs_wiki(const struct usbdev_status *devs) -{ - unsigned int count = 0; - unsigned int i = 0; - for (i = 0; devs[i].vendor_name != NULL; i++) - count++; - return count; -} - -static void print_supported_usbdevs_wiki_helper(const struct programmer_entry prog) -{ - int i = 0; - static int c = 0; - const struct usbdev_status *devs = prog.devices.usb; - const unsigned int count = count_supported_usbdevs_wiki(devs); + const struct dev_status *devs = prog.devs.status; + const unsigned int count = count_supported_devs_wiki(devs); /* Alternate colors if the vendor changes. */ c = !c; @@ -367,10 +334,10 @@ static void print_supported_devs_wiki() const struct programmer_entry prog = programmer_table[i]; switch (prog.type) { case USB: - usb_count += count_supported_usbdevs_wiki(prog.devices.usb); + usb_count += count_supported_devs_wiki(prog.devs.status); break; case PCI: - pci_count += count_supported_pcidevs_wiki(prog.devices.pci); + pci_count += count_supported_devs_wiki(prog.devs.status); break; case OTHER: default: @@ -387,7 +354,7 @@ static void print_supported_devs_wiki() for (i = 0; i < PROGRAMMER_INVALID; i++) { const struct programmer_entry prog = programmer_table[i]; if (prog.type == PCI) { - print_supported_pcidevs_wiki_helper(prog); + print_supported_devs_wiki_helper(prog); } } printf("\n|}\n"); @@ -401,7 +368,7 @@ static void print_supported_devs_wiki() for (i = 0; i < PROGRAMMER_INVALID; i++) { const struct programmer_entry prog = programmer_table[i]; if (prog.type == USB) { - print_supported_usbdevs_wiki_helper(prog); + print_supported_devs_wiki_helper(prog); } } printf("\n|}\n"); diff --git a/programmer.h b/programmer.h index 9f90fe5..b52727e 100644 --- a/programmer.h +++ b/programmer.h @@ -93,15 +93,22 @@ enum programmer_type { OTHER, }; +struct dev_status { + uint16_t vendor_id; + uint16_t device_id; + const enum test_state status; + const char *vendor_name; + const char *device_name; +}; + struct programmer_entry { const char *vendor; const char *name; enum programmer_type type; union { - const struct pcidev_status *const pci; - const struct usbdev_status *const usb; + const struct dev_status *const status; const char * const note; - } devices; + } devs; int (*init) (void); @@ -226,15 +233,8 @@ void internal_delay(int usecs); extern uint32_t io_base_addr; extern struct pci_access *pacc; extern struct pci_dev *pcidev_dev; -struct pcidev_status { - uint16_t vendor_id; - uint16_t device_id; - const enum test_state status; - const char *vendor_name; - const char *device_name; -}; -uintptr_t pcidev_validate(struct pci_dev *dev, int bar, const struct pcidev_status *devs); -uintptr_t pcidev_init(int bar, const struct pcidev_status *devs); +uintptr_t pcidev_validate(struct pci_dev *dev, int bar, const struct dev_status *devs); +uintptr_t pcidev_init(int bar, const struct dev_status *devs); /* rpci_write_* are reversible writes. The original PCI config space register * contents will be restored on shutdown. */ @@ -245,7 +245,7 @@ int rpci_write_long(struct pci_dev *dev, int reg, uint32_t data); /* print.c */ #if CONFIG_NIC3COM+CONFIG_NICREALTEK+CONFIG_NICNATSEMI+CONFIG_GFXNVIDIA+CONFIG_DRKAISER+CONFIG_SATASII+CONFIG_ATAHPT+CONFIG_NICINTEL+CONFIG_NICINTEL_SPI+CONFIG_OGP_SPI+CONFIG_SATAMV >= 1 -void print_supported_pcidevs(const struct pcidev_status *devs); +void print_supported_devs(const struct dev_status *devs); #endif #if CONFIG_INTERNAL == 1 @@ -360,81 +360,73 @@ void dummy_unmap(void *virt_addr, size_t len); /* nic3com.c */ #if CONFIG_NIC3COM == 1 int nic3com_init(void); -extern const struct pcidev_status nics_3com[]; +extern const struct dev_status nics_3com[]; #endif /* gfxnvidia.c */ #if CONFIG_GFXNVIDIA == 1 int gfxnvidia_init(void); -extern const struct pcidev_status gfx_nvidia[]; +extern const struct dev_status gfx_nvidia[]; #endif /* drkaiser.c */ #if CONFIG_DRKAISER == 1 int drkaiser_init(void); -extern const struct pcidev_status drkaiser_pcidev[]; +extern const struct dev_status drkaiser_pcidev[]; #endif /* nicrealtek.c */ #if CONFIG_NICREALTEK == 1 int nicrealtek_init(void); -extern const struct pcidev_status nics_realtek[]; +extern const struct dev_status nics_realtek[]; #endif /* nicnatsemi.c */ #if CONFIG_NICNATSEMI == 1 int nicnatsemi_init(void); -extern const struct pcidev_status nics_natsemi[]; +extern const struct dev_status nics_natsemi[]; #endif /* nicintel.c */ #if CONFIG_NICINTEL == 1 int nicintel_init(void); -extern const struct pcidev_status nics_intel[]; +extern const struct dev_status nics_intel[]; #endif /* nicintel_spi.c */ #if CONFIG_NICINTEL_SPI == 1 int nicintel_spi_init(void); -extern const struct pcidev_status nics_intel_spi[]; +extern const struct dev_status nics_intel_spi[]; #endif /* ogp_spi.c */ #if CONFIG_OGP_SPI == 1 int ogp_spi_init(void); -extern const struct pcidev_status ogp_spi[]; +extern const struct dev_status ogp_spi[]; #endif /* satamv.c */ #if CONFIG_SATAMV == 1 int satamv_init(void); -extern const struct pcidev_status satas_mv[]; +extern const struct dev_status satas_mv[]; #endif /* satasii.c */ #if CONFIG_SATASII == 1 int satasii_init(void); -extern const struct pcidev_status satas_sii[]; +extern const struct dev_status satas_sii[]; #endif /* atahpt.c */ #if CONFIG_ATAHPT == 1 int atahpt_init(void); -extern const struct pcidev_status ata_hpt[]; +extern const struct dev_status ata_hpt[]; #endif /* ft2232_spi.c */ #if CONFIG_FT2232_SPI == 1 -struct usbdev_status { - uint16_t vendor_id; - uint16_t device_id; - const enum test_state status; - const char *vendor_name; - const char *device_name; -}; int ft2232_spi_init(void); -extern const struct usbdev_status devs_ft2232spi[]; -void print_supported_usbdevs(const struct usbdev_status *devs); +extern const struct dev_status devs_ft2232spi[]; #endif /* rayer_spi.c */ diff --git a/satamv.c b/satamv.c index e39385b..689855f 100644 --- a/satamv.c +++ b/satamv.c @@ -28,7 +28,7 @@ uint8_t *mv_bar; uint16_t mv_iobar; -const struct pcidev_status satas_mv[] = { +const struct dev_status satas_mv[] = { /* 88SX6041 and 88SX6042 are the same according to the datasheet. */ {0x11ab, 0x7042, OK, "Marvell", "88SX7042 PCI-e 4-port SATA-II"}, diff --git a/satasii.c b/satasii.c index 387c605..eac1f37 100644 --- a/satasii.c +++ b/satasii.c @@ -31,7 +31,7 @@ uint8_t *sii_bar; static uint16_t id; -const struct pcidev_status satas_sii[] = { +const struct dev_status satas_sii[] = { {0x1095, 0x0680, OK, "Silicon Image", "PCI0680 Ultra ATA-133 Host Ctrl"}, {0x1095, 0x3112, OK, "Silicon Image", "SiI 3112 [SATALink/SATARaid] SATA Ctrl"}, {0x1095, 0x3114, OK, "Silicon Image", "SiI 3114 [SATALink/SATARaid] SATA Ctrl"}, -- 1.7.1

1 0

[PATCH 6/7] print_wiki.c: add a programmer column to the PCI and USB devices lists
by Stefan Tauner 03 Mar '12

03 Mar '12

Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> --- print_wiki.c | 28 ++++++++++++++++++---------- 1 files changed, 18 insertions(+), 10 deletions(-) diff --git a/print_wiki.c b/print_wiki.c index 43fab47..c25ec28 100644 --- a/print_wiki.c +++ b/print_wiki.c @@ -73,8 +73,8 @@ static const char chip_th[] = "{\ | align=\"center\" | Min \n| align=\"center\" | Max\n\n"; static const char programmer_th[] = "{| border=\"0\" style=\"font-size: \ -smaller\" valign=\"top\"\n|- bgcolor=\"#6699dd\"\n! align=\"left\" | Vendor\n\ -! align=\"left\" | Device\n! align=\"center\" | IDs\n\ +smaller\" valign=\"top\"\n|- bgcolor=\"#6699dd\"\n! align=\"left\" | Programmer\n\ +! align=\"left\" | Vendor\n ! align=\"left\" | Device\n! align=\"center\" | IDs\n\ ! align=\"center\" | Status\n\n"; #if CONFIG_INTERNAL == 1 @@ -305,17 +305,21 @@ static int count_supported_pcidevs_wiki(const struct pcidev_status *devs) return count; } -static void print_supported_pcidevs_wiki_helper(const struct pcidev_status *devs) +static void print_supported_pcidevs_wiki_helper(const struct programmer_entry prog) { int i = 0; static int c = 0; + const struct pcidev_status *devs = prog.devices.pci; + const unsigned int count = count_supported_pcidevs_wiki(devs); /* Alternate colors if the vendor changes. */ c = !c; for (i = 0; devs[i].vendor_name != NULL; i++) { - printf("|- bgcolor=\"#%s\"\n| %s || %s || " - "%04x:%04x || {{%s}}\n", (c) ? "eeeeee" : "dddddd", + printf("|- bgcolor=\"#%s\"\n", (c) ? "eeeeee" : "dddddd"); + if (i == 0) + printf("| rowspan=\"%u\" | %s |", count, prog.name); + printf("| %s || %s || %04x:%04x || {{%s}}\n", devs[i].vendor_name, devs[i].device_name, devs[i].vendor_id, devs[i].device_id, (devs[i].status == NT) ? "?3" : "OK"); @@ -332,17 +336,21 @@ static int count_supported_usbdevs_wiki(const struct usbdev_status *devs) return count; } -static void print_supported_usbdevs_wiki_helper(const struct usbdev_status *devs) +static void print_supported_usbdevs_wiki_helper(const struct programmer_entry prog) { int i = 0; static int c = 0; + const struct usbdev_status *devs = prog.devices.usb; + const unsigned int count = count_supported_usbdevs_wiki(devs); /* Alternate colors if the vendor changes. */ c = !c; for (i = 0; devs[i].vendor_name != NULL; i++) { - printf("|- bgcolor=\"#%s\"\n| %s || %s || " - "%04x:%04x || {{%s}}\n", (c) ? "eeeeee" : "dddddd", + printf("|- bgcolor=\"#%s\"\n", (c) ? "eeeeee" : "dddddd"); + if (i == 0) + printf("| rowspan=\"%u\" | %s |", count, prog.name); + printf("| %s || %s || %04x:%04x || {{%s}}\n", devs[i].vendor_name, devs[i].device_name, devs[i].vendor_id, devs[i].device_id, (devs[i].status == NT) ? "?3" : "OK"); @@ -379,7 +387,7 @@ static void print_supported_devs_wiki() for (i = 0; i < PROGRAMMER_INVALID; i++) { const struct programmer_entry prog = programmer_table[i]; if (prog.type == PCI) { - print_supported_pcidevs_wiki_helper(prog.devices.pci); + print_supported_pcidevs_wiki_helper(prog); } } printf("\n|}\n"); @@ -393,7 +401,7 @@ static void print_supported_devs_wiki() for (i = 0; i < PROGRAMMER_INVALID; i++) { const struct programmer_entry prog = programmer_table[i]; if (prog.type == USB) { - print_supported_usbdevs_wiki_helper(prog.devices.usb); + print_supported_usbdevs_wiki_helper(prog); } } printf("\n|}\n"); -- 1.7.1

1 0

[PATCH 5/7] squash! print_wiki.c fix columns calculations
by Stefan Tauner 03 Mar '12

03 Mar '12

- chips Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> --- print_wiki.c | 30 ++++++++++++++++++------------ 1 files changed, 18 insertions(+), 12 deletions(-) diff --git a/print_wiki.c b/print_wiki.c index d55563c..43fab47 100644 --- a/print_wiki.c +++ b/print_wiki.c @@ -224,6 +224,7 @@ static void print_supported_chips_wiki(int cols) { int i = 0, c = 1, chipcount = 0; const struct flashchip *f, *old = NULL; + unsigned int lines_per_col; uint32_t t; char *s; char vmax[6]; @@ -238,21 +239,28 @@ static void print_supported_chips_wiki(int cols) chipcount++; } + /* +1 to force the resulting number of columns to be < cols */ + lines_per_col = chipcount / cols + ((chipcount%cols) > 0 ? 1 : 0); + printf("\n== Supported chips ==\n\nTotal amount of supported " - "chips: '''%d'''\n\n{| border=\"0\" valign=\"top\"\n" - "| valign=\"top\"|\n\n%s", chipcount, chip_th); + "chips: '''%d'''\n\n{| border=\"0\" valign=\"top\"\n", + chipcount); - for (f = flashchips; f->name != NULL; f++, i++) { + for (f = flashchips; f->name != NULL; f++) { /* Don't print generic entries. */ if (!strncmp(f->vendor, "Unknown", 7) || !strncmp(f->vendor, "Programmer", 10) || !strncmp(f->name, "unknown", 7)) continue; + if ((i % lines_per_col) == 0) + printf("| valign=\"top\"|\n\n%s", chip_th); + /* Alternate colors if the vendor changes. */ if (old != NULL && strcmp(old->vendor, f->vendor)) c = !c; + old = f; t = f->tested; s = flashbuses_to_text(f->bustype); sprintf(vmin, "%0.03f", f->voltage.min / (double)1000); @@ -276,16 +284,14 @@ static void print_supported_chips_wiki(int cols) f->voltage.min ? vmax : "N/A"); free(s); - /* Split table into 'cols' columns. */ - if (i >= (chipcount / cols + 1)) { - printf("\n|}\n\n| valign=\"top\"|\n\n%s", chip_th); - i = 0; - } - - old = f; + if (((i % lines_per_col) + 1) == lines_per_col) + printf("\n|}\n\n"); + i++; } - - printf("\n|}\n\n|}\n"); + /* end inner table if it did not fill the last column fully */ + if (((i % lines_per_col)) > 0) + printf("\n|}\n\n"); + printf("|}\n\n"); } /* Not needed for CONFIG_INTERNAL, but for all other PCI-based programmers. */ -- 1.7.1

1 0

[PATCH 4/7] squash! print_wiki.c fix columns calculations
by Stefan Tauner 03 Mar '12

03 Mar '12

- boards Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> --- print_wiki.c | 26 ++++++++++++++++---------- 1 files changed, 16 insertions(+), 10 deletions(-) diff --git a/print_wiki.c b/print_wiki.c index e0b5ff3..d55563c 100644 --- a/print_wiki.c +++ b/print_wiki.c @@ -134,11 +134,12 @@ static void print_supported_chipsets_wiki(int cols) static void print_supported_boards_wiki_helper(const char *devicetype, int cols, const struct board_info boards[]) { - int i, j, k = 0, color = 1; + int i, k = 0, color = 1; int num_notes = 0; char *notes = calloc(1, 1); const struct board_match *b = board_matches; unsigned int boardcount = 0, boardcount_good = 0, boardcount_bad = 0; + unsigned int lines_per_col; char tmp[900 + 1]; for (i = 0; boards[i].vendor != NULL; i++) { @@ -149,12 +150,17 @@ static void print_supported_boards_wiki_helper(const char *devicetype, int cols, boardcount++; } + /* +1 to force the resulting number of columns to be < cols */ + lines_per_col = boardcount / cols + ((boardcount%cols) > 0 ? 1 : 0); + printf("\n\nTotal amount of supported %s: '''%d'''. " "Not yet supported (i.e., known-bad): '''%d'''.\n\n" - "{| border=\"0\" valign=\"top\"\n| valign=\"top\"|\n\n%s", - devicetype, boardcount_good, boardcount_bad, board_th); + "{| border=\"0\" valign=\"top\"\n", + devicetype, boardcount_good, boardcount_bad); - for (i = 0, j = 0; boards[i].vendor != NULL; i++, j++) { + for (i = 0; boards[i].vendor != NULL; i++) { + if ((i % lines_per_col) == 0) + printf("| valign=\"top\"|\n\n%s", board_th); /* Alternate colors if the vendor changes. */ if (i > 0 && strcmp(boards[i].vendor, boards[i - 1].vendor)) @@ -190,14 +196,14 @@ static void print_supported_boards_wiki_helper(const char *devicetype, int cols, printf("\n"); } - /* Split table in 'cols' columns. */ - if (j >= (boardcount / cols + 1)) { - printf("\n|}\n\n| valign=\"top\"|\n\n%s", board_th); - j = 0; - } + if (((i % lines_per_col) + 1) == lines_per_col) + printf("\n|}\n\n"); } - printf("\n|}\n\n|}\n"); + /* end inner table if it did not fill the last column fully */ + if (((i % lines_per_col)) > 0) + printf("\n|}\n\n"); + printf("\n\n|}\n"); if (num_notes > 0) printf("\n<small>\n%s</small>\n", notes); -- 1.7.1

1 0

[PATCH 3/7] print_wiki.c fix columns calculations
by Stefan Tauner 03 Mar '12

03 Mar '12

for - chipsets --- i noticed that the chipset columns were not uniformly divided at all and looked at the code in more detail... out came this series of patches that changes all three major sections of the wiki page similarly (hopefully to the better) and it split respectively for easier reviewing. getting this right is not trivial due to the possible corner cases... and it makes one cry when aware of real programming languages ;) Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> --- print_wiki.c | 36 +++++++++++++++++++++++------------- 1 files changed, 23 insertions(+), 13 deletions(-) diff --git a/print_wiki.c b/print_wiki.c index 756f8d4..e0b5ff3 100644 --- a/print_wiki.c +++ b/print_wiki.c @@ -91,18 +91,26 @@ wrong (a working backup flash chip and/or good soldering skills).\n</div>\n"; static void print_supported_chipsets_wiki(int cols) { - int i, j, enablescount = 0, color = 1; + int enablescount = 0, color = 1; + int i; + unsigned int lines_per_col; const struct penable *e; for (e = chipset_enables; e->vendor_name != NULL; e++) enablescount++; + /* +1 to force the resulting number of columns to be < cols */ + lines_per_col = enablescount / cols + ((enablescount%cols) > 0 ? 1 : 0); + printf("\n== Supported chipsets ==\n\nTotal amount of supported " - "chipsets: '''%d'''\n\n{| border=\"0\" valign=\"top\"\n| " - "valign=\"top\"|\n\n%s", enablescount, chipset_th); + "chipsets: '''%d'''\n\n{| border=\"0\" valign=\"top\"\n", + enablescount); e = chipset_enables; - for (i = 0, j = 0; e[i].vendor_name != NULL; i++, j++) { + for (i = 0; e[i].vendor_name != NULL; i++) { + if ((i % lines_per_col) == 0) + printf("| valign=\"top\"|\n\n%s", chipset_th); + /* Alternate colors if the vendor changes. */ if (i > 0 && strcmp(e[i].vendor_name, e[i - 1].vendor_name)) color = !color; @@ -113,30 +121,32 @@ static void print_supported_chipsets_wiki(int cols) e[i].vendor_id, e[i].device_id, (e[i].status == OK) ? "{{OK}}" : "{{?3}}"); - /* Split table in 'cols' columns. */ - if (j >= (enablescount / cols + 1)) { - printf("\n|}\n\n| valign=\"top\"|\n\n%s", chipset_th); - j = 0; - } + if (((i % lines_per_col) + 1) == lines_per_col) + printf("\n|}\n\n"); } - printf("\n|}\n\n|}\n"); + /* end inner table if it did not fill the last column fully */ + if (((i % lines_per_col)) > 0) + printf("\n|}\n\n"); + printf("\n\n|}\n"); } static void print_supported_boards_wiki_helper(const char *devicetype, int cols, const struct board_info boards[]) { - int i, j, k = 0, boardcount_good = 0, boardcount_bad = 0, color = 1; + int i, j, k = 0, color = 1; int num_notes = 0; char *notes = calloc(1, 1); - char tmp[900 + 1]; const struct board_match *b = board_matches; + unsigned int boardcount = 0, boardcount_good = 0, boardcount_bad = 0; + char tmp[900 + 1]; for (i = 0; boards[i].vendor != NULL; i++) { if (boards[i].working == OK) boardcount_good++; if (boards[i].working == BAD) boardcount_bad++; + boardcount++; } printf("\n\nTotal amount of supported %s: '''%d'''. " @@ -181,7 +191,7 @@ static void print_supported_boards_wiki_helper(const char *devicetype, int cols, } /* Split table in 'cols' columns. */ - if (j >= ((boardcount_good + boardcount_bad) / cols + 1)) { + if (j >= (boardcount / cols + 1)) { printf("\n|}\n\n| valign=\"top\"|\n\n%s", board_th); j = 0; } -- 1.7.1

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom