On Tue, 23 Aug 2011 14:35:36 +0200
Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> wrote:
> This looks suspiciously like intel_ich_gpio_set.
>
> Based on that, add board enables for the ASUS P5N-D and P5N-E SLI.
> This was tested by Guillaume Poirier-Morency on a P5N-D:
> http://www.flashrom.org/pipermail/flashrom/2011-August/007706.html
>
> Signed-off-by: Joshua Roys <roysjosh(a)gmail.com>
> Acked-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at>
> ---
> i have made a few changes:
> - renamed functions to our usual scheme
> - marked the P5E (board enable) as not tested
> - use a pointer to the config entry to access it instead of its index
>
> the latter together with the goto makes the execution flow more obvious imho.
>
> if anyone asks this is of course also
> Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at>
> but i don't deserve it imo.
as discussed on IRC i have committed this in r1466 with a few further
modifications (better and earlier input validation).
--
Kind regards/Mit freundlichen Grüßen, Stefan Tauner
Am 18.09.2011 02:31 schrieb Stefan Tauner:
> Move the serprog specification there and document a few things we could not
> figure out on intel platforms yet.
>
> Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net>
Regards,
Carl-Daniel
--
http://www.hailfinger.org/
Author: stefanct
Date: Mon Nov 14 00:03:30 2011
New Revision: 1465
URL: http://flashrom.org/trac/flashrom/changeset/1465
Log:
Create a directory for documentation files
Move the serprog specification there and document a few things we could not
figure out on intel platforms yet.
Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net>
Added:
trunk/Documentation/
trunk/Documentation/mysteries_intel.txt (contents, props changed)
trunk/Documentation/serprog-protocol.txt (contents, props changed)
- copied, changed from r1464, trunk/serprog-protocol.txt
Deleted:
trunk/serprog-protocol.txt
Added: trunk/Documentation/mysteries_intel.txt
==============================================================================
--- /dev/null 00:00:00 1970 (empty, because file is newly added)
+++ trunk/Documentation/mysteries_intel.txt Mon Nov 14 00:03:30 2011 (r1465)
@@ -0,0 +1,18 @@
+= BBAR on ICH8 =
+ There is no sign of BBAR (BIOS Base Address Configuration Register) in the
+ public datasheet (or specification update) of the ICH8. Also, the offset of
+ that register has changed between ICH7 (SPIBAR + 50h) and ICH9 (SPIBAR +
+ A0h), so we have no clue if or where it is on ICH8. Out current policy is to
+ not touch it at all and assume/hope it is 0.
+
+= Accesses beyond region bounds in descriptor mode =
+ Intel's flash image tool will always expand the last region so that it covers
+ the whole flash chip, but some boards ship with a different configuration.
+ It seems that in descriptor mode all addresses outside the used regions can not
+ be accessed whatsoever. This is not specified anywhere publicly as far as we
+ could tell. flashrom does not handle this explicitly yet. It will just fail
+ when trying to touch an address outside of any region.
+ See also http://www.flashrom.org/pipermail/flashrom/2011-August/007606.html
+
+= Unlocking the ME region =
+TODO
Copied and modified: trunk/Documentation/serprog-protocol.txt (from r1464, trunk/serprog-protocol.txt)
==============================================================================
Author: stefanct
Date: Sun Nov 13 16:17:10 2011
New Revision: 1464
URL: http://flashrom.org/trac/flashrom/changeset/1464
Log:
ichspi: fix ich_init_opcodes() calls in ich_init_spi()
By calling it early ichspi_lock was not set up correctly in accordance
with the corresponding register, hence ich_init_opcodes() was always
trying to programming the opcodes instead of reading them in from the
opmenu in case of a locked down configuration.
Thanks to Jonathan A. Kollasch for reporting this bug.
Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net>
Modified:
trunk/ichspi.c
Modified: trunk/ichspi.c
==============================================================================
--- trunk/ichspi.c Thu Nov 10 00:40:00 2011 (r1463)
+++ trunk/ichspi.c Sun Nov 13 16:17:10 2011 (r1464)
@@ -1562,8 +1562,6 @@
/* Assign Virtual Address */
ich_spibar = rcrb + spibar_offset;
- ich_init_opcodes();
-
switch (ich_generation) {
case CHIPSET_ICH7:
msg_pdbg("0x00: 0x%04x (SPIS)\n",
@@ -1601,6 +1599,7 @@
msg_pinfo("WARNING: SPI Configuration Lockdown activated.\n");
ichspi_lock = 1;
}
+ ich_init_opcodes();
ich_set_bbar(0);
register_spi_programmer(&spi_programmer_ich7);
break;
@@ -1643,6 +1642,7 @@
"by the FRAP and FREG registers are NOT in "
"effect. Please note that Protected\n"
"Range (PR) restrictions still apply.\n");
+ ich_init_opcodes();
if (desc_valid) {
tmp2 = mmio_readw(ich_spibar + ICH9_REG_HSFC);