flashrom

flashrom@flashrom.org

3 participants
9188 discussions

Re: [flashrom] [PATCH] linux_spi.c: set SPI mode, word justification and bits per word on init.
by Michael Karcher 02 Mar '12

02 Mar '12

Am Freitag, den 02.03.2012, 00:43 +0100 schrieb Stefan Tauner: > Previously we relied on a correctly set up state. Looks good. Still untested, though. > Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Acked-by: Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> A test would be nice, though, but I'm afraid we can't find a tester quickly. Regards, Michael Karcher

1 0

[PATCH] linux_spi.c: set SPI mode, word justification and bits per word on init.
by Stefan Tauner 01 Mar '12

01 Mar '12

Previously we relied on a correctly set up state. --- untested. Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> --- linux_spi.c | 23 +++++++++++++++++++++++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/linux_spi.c b/linux_spi.c index d994389..d29c59a 100644 --- a/linux_spi.c +++ b/linux_spi.c @@ -57,6 +57,8 @@ int linux_spi_init(void) { char *p, *endp, *dev; uint32_t speed = 0; + /* FIXME: make the following configurable by CLI options. */ + uint8_t mode = SPI_MODE_0, lsb = 0, bits = 0; /* mode 0, msb first, 8 bits */ dev = extract_programmer_param("dev"); if (!dev || !strlen(dev)) { @@ -92,6 +94,27 @@ int linux_spi_init(void) msg_pdbg("Using %d kHz clock\n", speed); } + if (ioctl(fd, SPI_IOC_WR_MODE, &mode) == -1) { + msg_perr("%s: failed to set SPI mode to %u: %s\n", + __func__, mode, strerror(errno)); + close(fd); + return 1; + } + + if (ioctl(fd, SPI_IOC_WR_LSB_FIRST, &lsb) == -1) { + msg_perr("%s: failed to set SPI justification to %u: %s\n", + __func__, lsb, strerror(errno)); + close(fd); + return 1; + } + + if (ioctl(fd, SPI_IOC_WR_BITS_PER_WORD, &bits) == -1) { + msg_perr("%s: failed to set the number of bits in an SPI word to %u: %s\n", + __func__, bits, strerror(errno)); + close(fd); + return 1; + } + if (register_shutdown(linux_spi_shutdown, NULL)) return 1; -- 1.7.1

1 0

[PATCH] Fix parallel-style programmer access from SPI
by Carl-Daniel Hailfinger 01 Mar '12

01 Mar '12

Joey: This patch applies to current svn HEAD. Patch is untested, but it should work and not spit out any new error messages. RFC: Are those checks with abort a good idea or do they break stuff? exit(1) is not a nice thing for libflashrom, but then again, it's probably better than exploding. I'm also unsure about the parameter order of mmio_readn. The IT87 SPI driver has one quirk to speed up reading and writing: If a flash chip is 512 kByte or less, the flash chip can be completely mapped in memory and both read and write accesses are faster that way. The current IT87 SPI code did use the parallel programmer interface for memory mapped reads and writes, but that's the wrong abstraction. It has been fixed to use mmio_read*/mmio_write* for that purpose. Introduce sanity checks for all SPI/Parallel-style accesses before a possibly undefined union member is dereferenced. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: flashrom-fix_par_programmer_access_from_spi/hwaccess.c =================================================================== --- flashrom-fix_par_programmer_access_from_spi/hwaccess.c (Revision 1510) +++ flashrom-fix_par_programmer_access_from_spi/hwaccess.c (Arbeitskopie) @@ -169,6 +169,12 @@ return *(volatile uint32_t *) addr; } +void mmio_readn(void *addr, uint8_t *buf, size_t len) +{ + memcpy(buf, addr, len); + return; +} + void mmio_le_writeb(uint8_t val, void *addr) { mmio_writeb(cpu_to_le8(val), addr); Index: flashrom-fix_par_programmer_access_from_spi/flash.h =================================================================== --- flashrom-fix_par_programmer_access_from_spi/flash.h (Revision 1510) +++ flashrom-fix_par_programmer_access_from_spi/flash.h (Arbeitskopie) @@ -247,6 +247,7 @@ void print_banner(void); void list_programmers_linebreak(int startcol, int cols, int paren); int selfcheck(void); +void shutdown_and_exit(int exitcode); int doit(struct flashctx *flash, int force, const char *filename, int read_it, int write_it, int erase_it, int verify_it); int read_buf_from_file(unsigned char *buf, unsigned long size, const char *filename); int write_buf_to_file(unsigned char *buf, unsigned long size, const char *filename); Index: flashrom-fix_par_programmer_access_from_spi/it87spi.c =================================================================== --- flashrom-fix_par_programmer_access_from_spi/it87spi.c (Revision 1510) +++ flashrom-fix_par_programmer_access_from_spi/it87spi.c (Arbeitskopie) @@ -330,7 +330,7 @@ OUTB(0x06, it8716f_flashport + 1); OUTB(((2 + (fast_spi ? 1 : 0)) << 4), it8716f_flashport); for (i = 0; i < flash->page_size; i++) - chip_writeb(flash, buf[i], bios + start + i); + mmio_writeb(buf[i], (void *)(bios + start + i)); OUTB(0, it8716f_flashport); /* Wait until the Write-In-Progress bit is cleared. * This usually takes 1-10 ms, so wait in 1 ms steps. @@ -356,7 +356,7 @@ if ((flash->total_size * 1024 > 512 * 1024)) { spi_read_chunked(flash, buf, start, len, 3); } else { - read_memmapped(flash, buf, start, len); + mmio_readn((void *)(flash->virtual_memory + start), buf, len); } return 0; Index: flashrom-fix_par_programmer_access_from_spi/internal.c =================================================================== --- flashrom-fix_par_programmer_access_from_spi/internal.c (Revision 1510) +++ flashrom-fix_par_programmer_access_from_spi/internal.c (Arbeitskopie) @@ -387,6 +387,6 @@ static void internal_chip_readn(const struct flashctx *flash, uint8_t *buf, const chipaddr addr, size_t len) { - memcpy(buf, (void *)addr, len); + mmio_readn((void *)addr, buf, len); return; } Index: flashrom-fix_par_programmer_access_from_spi/spi.c =================================================================== --- flashrom-fix_par_programmer_access_from_spi/spi.c (Revision 1510) +++ flashrom-fix_par_programmer_access_from_spi/spi.c (Arbeitskopie) @@ -34,12 +34,22 @@ unsigned int readcnt, const unsigned char *writearr, unsigned char *readarr) { + if (!(flash->pgm->buses_supported & BUS_SPI)) { + msg_perr("%s called for wrong programmer type! Please report " + "a bug at flashrom(a)flashrom.org.\n", __func__); + shutdown_and_exit(1); + } return flash->pgm->spi.command(flash, writecnt, readcnt, writearr, readarr); } int spi_send_multicommand(struct flashctx *flash, struct spi_command *cmds) { + if (!(flash->pgm->buses_supported & BUS_SPI)) { + msg_perr("%s called for wrong programmer type! Please report " + "a bug at flashrom(a)flashrom.org.\n", __func__); + shutdown_and_exit(1); + } return flash->pgm->spi.multicommand(flash, cmds); } @@ -78,7 +88,13 @@ int default_spi_read(struct flashctx *flash, uint8_t *buf, unsigned int start, unsigned int len) { - unsigned int max_data = flash->pgm->spi.max_data_read; + unsigned int max_data; + if (!(flash->pgm->buses_supported & BUS_SPI)) { + msg_perr("%s called for wrong programmer type! Please report " + "a bug at flashrom(a)flashrom.org.\n", __func__); + shutdown_and_exit(1); + } + max_data = flash->pgm->spi.max_data_read; if (max_data == MAX_DATA_UNSPECIFIED) { msg_perr("%s called, but SPI read chunk size not defined " "on this hardware. Please report a bug at " @@ -91,7 +107,13 @@ int default_spi_write_256(struct flashctx *flash, uint8_t *buf, unsigned int start, unsigned int len) { - unsigned int max_data = flash->pgm->spi.max_data_write; + unsigned int max_data; + if (!(flash->pgm->buses_supported & BUS_SPI)) { + msg_perr("%s called for wrong programmer type! Please report " + "a bug at flashrom(a)flashrom.org.\n", __func__); + shutdown_and_exit(1); + } + max_data = flash->pgm->spi.max_data_write; if (max_data == MAX_DATA_UNSPECIFIED) { msg_perr("%s called, but SPI write chunk size not defined " "on this hardware. Please report a bug at " @@ -106,6 +128,11 @@ { unsigned int addrbase = 0; + if (!(flash->pgm->buses_supported & BUS_SPI)) { + msg_perr("%s called for wrong programmer type! Please report " + "a bug at flashrom(a)flashrom.org.\n", __func__); + shutdown_and_exit(1); + } /* Check if the chip fits between lowest valid and highest possible * address. Highest possible address with the current SPI implementation * means 0xffffff, the highest unsigned 24bit number. @@ -138,6 +165,11 @@ int spi_chip_write_256(struct flashctx *flash, uint8_t *buf, unsigned int start, unsigned int len) { + if (!(flash->pgm->buses_supported & BUS_SPI)) { + msg_perr("%s called for wrong programmer type! Please report " + "a bug at flashrom(a)flashrom.org.\n", __func__); + shutdown_and_exit(1); + } return flash->pgm->spi.write_256(flash, buf, start, len); } @@ -148,6 +180,11 @@ */ uint32_t spi_get_valid_read_addr(struct flashctx *flash) { + if (!(flash->pgm->buses_supported & BUS_SPI)) { + msg_perr("%s called for wrong programmer type! Please report " + "a bug at flashrom(a)flashrom.org.\n", __func__); + shutdown_and_exit(1); + } switch (flash->pgm->spi.type) { #if CONFIG_INTERNAL == 1 #if defined(__i386__) || defined(__x86_64__) Index: flashrom-fix_par_programmer_access_from_spi/flashrom.c =================================================================== --- flashrom-fix_par_programmer_access_from_spi/flashrom.c (Revision 1510) +++ flashrom-fix_par_programmer_access_from_spi/flashrom.c (Arbeitskopie) @@ -357,43 +357,83 @@ void chip_writeb(const struct flashctx *flash, uint8_t val, chipaddr addr) { + if (!(flash->pgm->buses_supported & BUS_NONSPI)) { + msg_perr("%s called for wrong programmer type! Please report " + "a bug at flashrom(a)flashrom.org.\n", __func__); + shutdown_and_exit(1); + } flash->pgm->par.chip_writeb(flash, val, addr); } void chip_writew(const struct flashctx *flash, uint16_t val, chipaddr addr) { + if (!(flash->pgm->buses_supported & BUS_NONSPI)) { + msg_perr("%s called for wrong programmer type! Please report " + "a bug at flashrom(a)flashrom.org.\n", __func__); + shutdown_and_exit(1); + } flash->pgm->par.chip_writew(flash, val, addr); } void chip_writel(const struct flashctx *flash, uint32_t val, chipaddr addr) { + if (!(flash->pgm->buses_supported & BUS_NONSPI)) { + msg_perr("%s called for wrong programmer type! Please report " + "a bug at flashrom(a)flashrom.org.\n", __func__); + shutdown_and_exit(1); + } flash->pgm->par.chip_writel(flash, val, addr); } void chip_writen(const struct flashctx *flash, uint8_t *buf, chipaddr addr, size_t len) { + if (!(flash->pgm->buses_supported & BUS_NONSPI)) { + msg_perr("%s called for wrong programmer type! Please report " + "a bug at flashrom(a)flashrom.org.\n", __func__); + shutdown_and_exit(1); + } flash->pgm->par.chip_writen(flash, buf, addr, len); } uint8_t chip_readb(const struct flashctx *flash, const chipaddr addr) { + if (!(flash->pgm->buses_supported & BUS_NONSPI)) { + msg_perr("%s called for wrong programmer type! Please report " + "a bug at flashrom(a)flashrom.org.\n", __func__); + shutdown_and_exit(1); + } return flash->pgm->par.chip_readb(flash, addr); } uint16_t chip_readw(const struct flashctx *flash, const chipaddr addr) { + if (!(flash->pgm->buses_supported & BUS_NONSPI)) { + msg_perr("%s called for wrong programmer type! Please report " + "a bug at flashrom(a)flashrom.org.\n", __func__); + shutdown_and_exit(1); + } return flash->pgm->par.chip_readw(flash, addr); } uint32_t chip_readl(const struct flashctx *flash, const chipaddr addr) { + if (!(flash->pgm->buses_supported & BUS_NONSPI)) { + msg_perr("%s called for wrong programmer type! Please report " + "a bug at flashrom(a)flashrom.org.\n", __func__); + shutdown_and_exit(1); + } return flash->pgm->par.chip_readl(flash, addr); } void chip_readn(const struct flashctx *flash, uint8_t *buf, chipaddr addr, size_t len) { + if (!(flash->pgm->buses_supported & BUS_NONSPI)) { + msg_perr("%s called for wrong programmer type! Please report " + "a bug at flashrom(a)flashrom.org.\n", __func__); + shutdown_and_exit(1); + } flash->pgm->par.chip_readn(flash, buf, addr, len); } @@ -1700,6 +1740,15 @@ return 0; } +/* FIXME: Totally unacceptable for libflashrom, but it's better than a simple + * exit(1) for most places which just exit(1) for now. + */ +void shutdown_and_exit(int exitcode) +{ + programmer_shutdown(); + exit(exitcode); +} + /* This function signature is horrible. We need to design a better interface, * but right now it allows us to split off the CLI code. * Besides that, the function itself is a textbook example of abysmal code flow. Index: flashrom-fix_par_programmer_access_from_spi/programmer.h =================================================================== --- flashrom-fix_par_programmer_access_from_spi/programmer.h (Revision 1510) +++ flashrom-fix_par_programmer_access_from_spi/programmer.h (Arbeitskopie) @@ -312,6 +312,7 @@ uint8_t mmio_readb(void *addr); uint16_t mmio_readw(void *addr); uint32_t mmio_readl(void *addr); +void mmio_readn(void *addr, uint8_t *buf, size_t len); void mmio_le_writeb(uint8_t val, void *addr); void mmio_le_writew(uint16_t val, void *addr); void mmio_le_writel(uint32_t val, void *addr); -- http://www.hailfinger.org/

3 7

[commit] r1511 - trunk
by repository service 01 Mar '12

01 Mar '12

Author: hailfinger Date: Thu Mar 1 23:38:27 2012 New Revision: 1511 URL: http://flashrom.org/trac/flashrom/changeset/1511 Log: Fix parallel-style programmer access from ITE IT87/Winbond W83627 SPI The ITE IT87 SPI driver uses a trick to speed up reading and writing: If a flash chip is 512 kByte or less, the flash chip can be completely mapped in memory and both read and write accesses are faster that way. The current IT87 SPI code did use the parallel programmer interface for memory mapped reads and writes, but that's the wrong abstraction. It has been fixed to use mmio_read*/mmio_write* for that purpose. The Winbond W83627 SPI driver uses the same trick in its read path for all supported chip sizes. Fix it the same way. Switch internal_chip_readn to use mmio_readn as proper abstraction. Kudos to Michael Karcher for spotting the bugs. Reported-by: Johan Svensson <flashrom.js(a)crypt.se> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> Tested-by: Johan Svensson <flashrom.js(a)crypt.se> Modified: trunk/hwaccess.c trunk/internal.c trunk/it87spi.c trunk/programmer.h trunk/wbsio_spi.c Modified: trunk/hwaccess.c ============================================================================== --- trunk/hwaccess.c Mon Feb 27 20:44:16 2012 (r1510) +++ trunk/hwaccess.c Thu Mar 1 23:38:27 2012 (r1511) @@ -169,6 +169,12 @@ return *(volatile uint32_t *) addr; } +void mmio_readn(void *addr, uint8_t *buf, size_t len) +{ + memcpy(buf, addr, len); + return; +} + void mmio_le_writeb(uint8_t val, void *addr) { mmio_writeb(cpu_to_le8(val), addr); Modified: trunk/internal.c ============================================================================== --- trunk/internal.c Mon Feb 27 20:44:16 2012 (r1510) +++ trunk/internal.c Thu Mar 1 23:38:27 2012 (r1511) @@ -387,6 +387,6 @@ static void internal_chip_readn(const struct flashctx *flash, uint8_t *buf, const chipaddr addr, size_t len) { - memcpy(buf, (void *)addr, len); + mmio_readn((void *)addr, buf, len); return; } Modified: trunk/it87spi.c ============================================================================== --- trunk/it87spi.c Mon Feb 27 20:44:16 2012 (r1510) +++ trunk/it87spi.c Thu Mar 1 23:38:27 2012 (r1511) @@ -330,7 +330,7 @@ OUTB(0x06, it8716f_flashport + 1); OUTB(((2 + (fast_spi ? 1 : 0)) << 4), it8716f_flashport); for (i = 0; i < flash->page_size; i++) - chip_writeb(flash, buf[i], bios + start + i); + mmio_writeb(buf[i], (void *)(bios + start + i)); OUTB(0, it8716f_flashport); /* Wait until the Write-In-Progress bit is cleared. * This usually takes 1-10 ms, so wait in 1 ms steps. @@ -356,7 +356,7 @@ if ((flash->total_size * 1024 > 512 * 1024)) { spi_read_chunked(flash, buf, start, len, 3); } else { - read_memmapped(flash, buf, start, len); + mmio_readn((void *)(flash->virtual_memory + start), buf, len); } return 0; Modified: trunk/programmer.h ============================================================================== --- trunk/programmer.h Mon Feb 27 20:44:16 2012 (r1510) +++ trunk/programmer.h Thu Mar 1 23:38:27 2012 (r1511) @@ -312,6 +312,7 @@ uint8_t mmio_readb(void *addr); uint16_t mmio_readw(void *addr); uint32_t mmio_readl(void *addr); +void mmio_readn(void *addr, uint8_t *buf, size_t len); void mmio_le_writeb(uint8_t val, void *addr); void mmio_le_writew(uint16_t val, void *addr); void mmio_le_writel(uint32_t val, void *addr); Modified: trunk/wbsio_spi.c ============================================================================== --- trunk/wbsio_spi.c Mon Feb 27 20:44:16 2012 (r1510) +++ trunk/wbsio_spi.c Thu Mar 1 23:38:27 2012 (r1511) @@ -202,7 +202,8 @@ static int wbsio_spi_read(struct flashctx *flash, uint8_t *buf, unsigned int start, unsigned int len) { - return read_memmapped(flash, buf, start, len); + mmio_readn((void *)(flash->virtual_memory + start), buf, len); + return 0; } #endif

1 0

Re: [flashrom] flashrom with HP XW9300
by Stefan Tauner 01 Mar '12

01 Mar '12

On Mon, 27 Feb 2012 07:55:04 +0100 Jürgen Trapp <juergen.trapp(a)alice.de> wrote: > lspci -nnvvxxx > […] Hello Jürgen! The last thing we heard from you was that you are trying to find and play with a write protection jumper. Did you succeed? -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

2 1

Support for ASRock 890GX Extreme3 mainboard
by Svetoslav Trochev 29 Feb '12

29 Feb '12

Hi Everybody, I am new here, so my apology if I am doing something wrong. I have ASRock 890GX Extreme3 mainboard. This board has ability to be flashed using standard BIOS, but never the less I decided to test Flashrom. I read the "Board Testing HOWTO" [1]. First signs are that this board will work out of the box with "flashrom v0.9.4-r1394 on Linux 3.0.4-pmagic (i686), built with libpci 3.1.7, GCC 4.6.1, little endian" What I have done so far: 1. Ran 'flashrom' command and it detected the chip: Winbond W25Q80. 2. Ran 'flashrom -R xxxx.rom' and it completed with no errors. I examine the file and it looks like normal ROM file. 3. Ran 'flashrom -V' I am attaching the output. 4. I try comparing the backup copy of the EEPROM with the original file provided by ASRock. It is different. They have exact same header, but quite different. 5. Because I am not 100% sure that I have good backup I decided to order spare chip and continue with the test later. ( I have external EEPROM programmer ) I will continue this weekend. Thank you and any comments are welcome and highly appreciated, Svetoslav Trochev [1] http://www.flashrom.org/Board_Testing_HOWTO

1 0

Some specs for IT8518 buried in my laptops ESM
by Eric Appleman 28 Feb '12

28 Feb '12

http://www.mediafire.com/?t77ue8xx1cv49g9 Page 87 has a full blown schematic. Enjoy. - Eric

1 0

[PATCH] FT2232 programmer frequency divider parameter support
by Samir Ibradžić 27 Feb '12

27 Feb '12

Hello, I would like to submit a patch, that enables extra argument when using FT2232 external programmer, a frequency divider. For FT2232 programmer we have this divider set to 3 by default by DIVIDE_BY constant, which will result in 10MHz (H-chips) or 2MHz (non H-chips) SPI speeds. By providing divider as parameter, SPI interface frequency culd be overridden by user, resulting in different speeds (H-chip example): divider | freq ---------+-------- 1 | 30Mhz 2 | 15Mhz 3 | 10Mhz 4 | 7.5Mhz 5 | 6Mhz 6 | 5Mhz 15 | 2Mhz 30 | 1Mhz 60 | 0.5Mhz 600 | 0.05Mhz (and so on) These lower than default SPI speeds can be very useful when we have flawed flash chips that would not support 10Mhz or bad quality or too long cabling between programmer and the chip. Higher than default speeds might also be useful (if only flashrom AAI implementation was faster). Please note that this parameter is arbitrary integer, maybe only a value up to 255 would really make sense, but i can not be sure about that since it may be programmer hardware dependent. All values between 1-255 worked for me (PicoTAP programmer), as well as 300 & 600 (these resulted in extremely slow flash reads, as expected, 2MB flash that usually takes 16s to read @2-10Mhz, took more than 6 minutes @0.05Mhz). Others values i haven't tested. Signed-off-by: Samir Ibradžić <sibradzic(a)gmail.com> --- $ svn diff Index: ft2232_spi.c =================================================================== --- ft2232_spi.c (revision 1451) +++ ft2232_spi.c (working copy) @@ -168,6 +168,7 @@ enum ftdi_interface ft2232_interface = INTERFACE_B; char *arg; double mpsse_clk; + int divider = DIVIDE_BY; arg = extract_programmer_param("type"); if (arg) { @@ -237,6 +238,17 @@ } } free(arg); + arg = extract_programmer_param("divider"); + if (arg) { + if (isdigit(*arg) && (atoi(arg) > 0)) + divider = atoi(arg); + else { + msg_perr("Error: Invalid frequency divider specified.\n"); + free(arg); + return -2; + } + } + free(arg); msg_pdbg("Using device type %s %s ", get_ft2232_vendorname(ft2232_vid, ft2232_type), get_ft2232_devicename(ft2232_vid, ft2232_type)); @@ -298,16 +310,16 @@ msg_pdbg("Set clock divisor\n"); buf[0] = 0x86; /* command "set divisor" */ /* valueL/valueH are (desired_divisor - 1) */ - buf[1] = (DIVIDE_BY - 1) & 0xff; - buf[2] = ((DIVIDE_BY - 1) >> 8) & 0xff; + buf[1] = (divider - 1) & 0xff; + buf[2] = ((divider - 1) >> 8) & 0xff; if (send_buf(ftdic, buf, 3)) { ret = -6; goto ftdi_err; } msg_pdbg("MPSSE clock: %f MHz divisor: %d " - "SPI clock: %f MHz\n", mpsse_clk, DIVIDE_BY, - (double)(mpsse_clk / (((DIVIDE_BY - 1) + 1) * 2))); + "SPI clock: %f MHz\n", mpsse_clk, divider, + (double)(mpsse_clk / (((divider - 1) + 1) * 2))); /* Disconnect TDI/DO to TDO/DI for loopback. */ msg_pdbg("No loopback of TDI/DO TDO/DI\n"); -- R, S

2 2

Re: [flashrom] Test report Biostar M7VIQ - Chip not detected
by Carl-Daniel Hailfinger 27 Feb '12

27 Feb '12

Hi Gurken, Am 26.02.2012 22:46 schrieb Gurken Papst: > Winbond W49F002U flash chip is not detected on a Biostar M7VIQ. > Detection and reading flash works using UniFlash 1.40. Writing > untested. > > Output of flashrom -V: > flashrom v0.9.5-r1503 on Linux 2.6.39.3 (i686), built with libpci > 3.1.8, GCC 4.6.2, little endian > flashrom is free software, get the source code at http://www.flashrom.org > > Calibrating delay loop... OS timer resolution is 1 usecs, 832M loops > per second, 10 myus = 10 us, 100 myus = 100 us, 1000 myus = 1007 us, > 10000 myus = 10169 us, 4 myus = 4 us, OK. > Initializing internal programmer > No coreboot table found. > DMI string system-manufacturer: " " > DMI string system-product-name: " " > DMI string system-version: " " > DMI string baseboard-manufacturer: " " > DMI string baseboard-product-name: "KM266-8235" > DMI string baseboard-version: " " > DMI string chassis-type: "Desktop" > Found chipset "VIA VT8235" with PCI ID 1106:3177. Enabling flash write... OK. > The following protocols are supported: Non-SPI. > Probing for AMD Am29F010A/B, 128 kB: probe_jedec_common: id1 0xd6, id2 > 0x52, id1 is normal flash content, id2 is normal flash content > [...] > > superiotool -dV: > [...] > Found Winbond W83697HF/F/HG (id=0x60, rev=0x12) at 0x2e > Register dump: > idx 20 21 22 23 24 25 26 28 29 2a > val 60 12 ff fe 10 00 00 00 00 f0 > def 60 NA ff 00 00 00 00 00 00 MM Register 0x24 says ROM size is 2 Mbit. Register 0x2a says flash translation is enabled. We should autodetect this Super I/O and set bit 3 in register 0x24 to enable detection and writing. > LDN 0x00 (Floppy) > idx 30 60 61 70 74 f0 f1 f2 f4 f5 > val 01 03 f0 06 02 0e 00 ff 00 00 > def 01 03 f0 06 02 0e 00 ff 00 00 We have a patch for this somewhere, but it is probably pretty bitrotted and needs to be updated. Would you be willing to test a few patches? Regards, Carl-Daniel -- http://www.hailfinger.org/

2 1

Re: [flashrom] [PATCH 7/8] check if write enable is really set in nicintel_spi_init (and minor comment changes).
by Stefan Tauner 27 Feb '12

27 Feb '12

On Mon, 20 Feb 2012 19:49:06 +0100 Idwer Vollering <vidwer(a)gmail.com> wrote: > 2011/3/15 Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at>: > > Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> > > Adding "pci_mmio_writel(FLASH_WRITES_DISABLED, nicintel_spibar + > EECD);" right after the usage of register_shutdown() works as it > should: > > Initializing nicintel_spi programmer > Found "Intel 82541PI Gigabit Ethernet Controller" (8086:107c, BDF 01:01.0). > Requested BAR is MEM, 32bit, not prefetchable > Enabling flash write access failed. > Error: Programmer initialization failed. > > Acked-by: Idwer Vollering <vidwer(a)gmail.com> thanks! committed in r1510 -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom