flashrom

flashrom@flashrom.org

3 participants
9189 discussions

MSR access fix on ALIX2D13 running OpenBSD-5.3
by Leonardo Guardati 17 Apr '13

17 Apr '13

Using flashrom-trunk on PCEngines' ALIX2D13 board running OpenBSD-5.3 (current) doesn't work. The chipset is AMD Geode CS5536. Here the steps: 1. Applied patch amdmsr.patch to openbsd kernel (/usr/src/sys/arch/i386/i386/amdmsr.c) Explaination: the original code checks for GPU presence (alix has no GPU) and fails; I just skip the check. 2. got last flashrom version (trunk) 3. applied given patch http://patchwork.coreboot.org/patch/3932/ 4. applied given patch http://patchwork.coreboot.org/patch/3933/ 5. applied patch hwaccess.patch Explaination: openbsd uses a different way to retrieve IO Priviledge Level, see i386_iopl(2) man page. 6. applied patch physmap.patch Explaination: minor code mismatches fixed and /dev/amdmsr0 changed to /dev/amdmsr. The 3 patches are attached. I confirm running "./flashrom -p internal -r bios.bin" extracts the same bios image got from flashrom run on linux. (md5 checks) Thank You. Leonardo.

2 4

Re: [flashrom] Sapphire IPC-E350M1 mainboard read success
by Антон Кочков 16 Apr '13

16 Apr '13

Reading flash http://paste.flashrom.org/view.php?id=1607 Writing flash http://paste.flashrom.org/view.php?id=1608 Best regards, Anton Kochkov. On Tue, Apr 16, 2013 at 4:06 PM, Антон Кочков <anton.kochkov(a)gmail.com> wrote: > Here is full read log on trunk flashrom > https://mega.co.nz/#!ndQhQLxL!NgMxOTwHi_oCGUD0663wjXKIcQoGWO1VU_XnXM_sY50 > > Sorry for using fileshare service, but full log is about 75Mb. > > Best regards, > Anton Kochkov.

1 0

flashrom layout patches testing on Intel DQ77MK mainboard
by Антон Кочков 16 Apr '13

16 Apr '13

Layout file - http://paste.flashrom.org/view.php?id=1602 Reading descriptors http://paste.flashrom.org/view.php?id=1603 Reading main image http://paste.flashrom.org/view.php?id=1604 Reading GbE http://paste.flashrom.org/view.php?id=1605 Reading ME (fail) http://paste.flashrom.org/view.php?id=1606 Best regards, Anton Kochkov.

1 0

Sapphire IPC-E350M1 mainboard read success
by Антон Кочков 16 Apr '13

16 Apr '13

Here is full read log on trunk flashrom https://mega.co.nz/#!ndQhQLxL!NgMxOTwHi_oCGUD0663wjXKIcQoGWO1VU_XnXM_sY50 Sorry for using fileshare service, but full log is about 75Mb. Best regards, Anton Kochkov.

1 0

problem with ASUS motherboard
by Carlos 15 Apr '13

15 Apr '13

hello, to update the chip w39v040bp w39v040fb and having the corrupted BIOS on a motherboard ASUS P4GE-mx erasing fault so could not write, and I need to get those bios urgent Thanks

2 2

Re: [flashrom] [PATCH] Introduce serialport_config().
by Stefan Tauner 13 Apr '13

13 Apr '13

On Mon, 1 Apr 2013 18:35:47 +0200 Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> wrote: > Also, initialize sp_fd and fix baud rate setting on windows. I have extracted those two changes into a separate patch and committed them in r1669 - because... that's almost 2 weeks again. :/ -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

[commit] r1669 - trunk
by repository service 13 Apr '13

13 Apr '13

Author: stefanct Date: Sat Apr 13 02:29:30 2013 New Revision: 1669 URL: http://flashrom.org/trac/flashrom/changeset/1669 Log: Initialize sp_fd and fix baud rate setting on windows. Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Acked-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Modified: trunk/serial.c Modified: trunk/serial.c ============================================================================== --- trunk/serial.c Sun Apr 7 15:08:30 2013 (r1668) +++ trunk/serial.c Sat Apr 13 02:29:30 2013 (r1669) @@ -39,7 +39,7 @@ #include "flash.h" #include "programmer.h" -fdtype sp_fd; +fdtype sp_fd = SER_INV_FD; void __attribute__((noreturn)) sp_die(char *msg) { @@ -189,7 +189,7 @@ goto out_close; } const struct baudentry *entry = round_baud(baud); - dcb.BaudRate = entry->baud; + dcb.BaudRate = entry->flag; dcb.ByteSize = 8; dcb.Parity = NOPARITY; dcb.StopBits = ONESTOPBIT;

1 0

[PATCH 2/2] Add support for AMD Geode's MSR on OpenBSD.
by Stefan Tauner 13 Apr '13

13 Apr '13

Previously the default implementation was used, which always failed. On other systems than the Geode the code is not equal to that anymore, but should not explode because setup_cpu_msr() returns an error and therefore no other MSR functions should be called. Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> --- physmap.c | 94 ++++++++++++++++++++++++++++++++++++++++++++++++++++++------- 1 file changed, 84 insertions(+), 10 deletions(-) diff --git a/physmap.c b/physmap.c index 4ebfb06..b6a9163 100644 --- a/physmap.c +++ b/physmap.c @@ -282,6 +282,8 @@ void *physmap_try_ro(const char *descr, unsigned long phys_addr, size_t len) PHYSMAP_RO); } +/* MSR abstraction implementations for Linux, OpenBSD, FreeBSD/Dragonfly, OSX, libpayload + * and a non-working default implemenation on the bottom. See also hwaccess.h for some (re)declarations. */ #if defined(__i386__) || defined(__x86_64__) #ifdef __linux__ @@ -381,8 +383,83 @@ void cleanup_cpu_msr(void) /* Clear MSR file descriptor. */ fd_msr = -1; } -#else -#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || defined(__DragonFly__) +#elif defined(__OpenBSD__) /* This does only work for certain AMD Geode LX systems see amdmsr(4). */ +#include <sys/ioctl.h> +#include <machine/amdmsr.h> + +static int fd_msr = -1; + +msr_t rdmsr(int addr) +{ + struct amdmsr_req args; + + msr_t msr = { 0xffffffff, 0xffffffff }; + + args.addr = (uint32_t)addr; + + if (ioctl(fd_msr, RDMSR, &args) < 0) { + msg_perr("Error while executing RDMSR ioctl: %s\n", strerror(errno)); + close(fd_msr); + exit(1); + } + + msr.lo = args.val & 0xffffffff; + msr.hi = args.val >> 32; + + return msr; +} + +int wrmsr(int addr, msr_t msr) +{ + struct amdmsr_req args; + + args.msr = addr; + args.val = (((uint64_t)msr.hi) << 32) | msr.lo; + + if (ioctl(fd_msr, WRMSR, &args) < 0) { + msg_perr("Error while executing WRMSR ioctl: %s\n", strerror(errno)); + close(fd_msr); + exit(1); + } + + return 0; +} + +int setup_cpu_msr(int cpu) +{ + char msrfilename[64]; + memset(msrfilename, 0, sizeof(msrfilename)); + snprintf(msrfilename, sizeof(msrfilename), "/dev/amdmsr"); + + if (fd_msr != -1) { + msg_pinfo("MSR was already initialized\n"); + return -1; + } + + fd_msr = open(msrfilename, O_RDWR); + + if (fd_msr < 0) { + msg_perr("Error while opening %s: %s\n", msrfilename, strerror(errno)); + return -1; + } + + return 0; +} + +void cleanup_cpu_msr(void) +{ + if (fd_msr == -1) { + msg_pinfo("No MSR initialized.\n"); + return; + } + + close(fd_msr); + + /* Clear MSR file descriptor. */ + fd_msr = -1; +} + +#elif defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || defined(__DragonFly__) #include <sys/ioctl.h> typedef struct { @@ -465,9 +542,7 @@ void cleanup_cpu_msr(void) fd_msr = -1; } -#else - -#if defined(__MACH__) && defined(__APPLE__) +#elif defined(__MACH__) && defined(__APPLE__) int setup_cpu_msr(int cpu) { // Always succeed for now @@ -494,6 +569,7 @@ int libpayload_wrmsr(int addr, msr_t msr) return 0; } #else +/* default MSR implementation */ msr_t rdmsr(int addr) { msr_t ret = { 0xffffffff, 0xffffffff }; @@ -516,9 +592,7 @@ void cleanup_cpu_msr(void) { // Nothing, yet. } -#endif -#endif -#endif -#else +#endif // OS switches for MSR code +#else // x86 /* Does MSR exist on non-x86 architectures? */ -#endif +#endif // arch switches for MSR code -- Kind regards, Stefan Tauner

1 0

[PATCH 1/2] Fix hwaccess (again).
by Stefan Tauner 13 Apr '13

13 Apr '13

Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> --- hwaccess.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/hwaccess.c b/hwaccess.c index 598aa67..df0306f 100644 --- a/hwaccess.c +++ b/hwaccess.c @@ -26,10 +26,9 @@ #error Unknown architecture #endif -#define IS_BSD (defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || defined(__DragonFly__) || defined(__OpenBSD__)) #define IS_LINUX (defined(__gnu_linux__) || defined(__linux__)) #define IS_MACOSX (defined(__APPLE__) && defined(__MACH__)) -#if !(IS_BSD || IS_LINUX || IS_MACOSX || defined(__DJGPP__) || defined(__LIBPAYLOAD__) || defined(__sun)) +#if !(IS_LINUX || IS_MACOSX || defined(__NetBSD__) || defined(__OpenBSD__) || defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || defined(__DragonFly__) || defined(__DJGPP__) || defined(__LIBPAYLOAD__) || defined(__sun)) #error "Unknown operating system" #endif @@ -47,7 +46,10 @@ #include "flash.h" #include "hwaccess.h" -#if IS_X86 && IS_BSD +#define USE_IOPL (IS_LINUX || IS_MACOSX || defined(__NetBSD__) || defined(__OpenBSD__)) +#define USE_DEV_IO (defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || defined(__DragonFly__)) + +#if IS_X86 && USE_DEV_IO int io_fd; #endif @@ -71,9 +73,9 @@ static int release_io_perms(void *p) { #if defined (__sun) sysi86(SI86V86, V86SC_IOPL, 0); -#elif IS_BSD +#elif USE_DEV_IO close(io_fd); -#elif IS_LINUX || IS_MACOSX +#elif USE_IOPL iopl(0); #endif return 0; @@ -86,14 +88,14 @@ int rget_io_perms(void) #if IS_X86 && !(defined(__DJGPP__) || defined(__LIBPAYLOAD__)) #if defined (__sun) if (sysi86(SI86V86, V86SC_IOPL, PS_IOPL) != 0) { -#elif IS_BSD +#elif USE_DEV_IO if ((io_fd = open("/dev/io", O_RDWR)) < 0) { -#elif IS_LINUX || IS_MACOSX +#elif USE_IOPL if (iopl(3) != 0) { #endif msg_perr("ERROR: Could not get I/O privileges (%s).\n" "You need to be root.\n", strerror(errno)); -#if defined (__OpenBSD__) +#if defined(__NetBSD__) || defined (__OpenBSD__) msg_perr("Please set securelevel=-1 in /etc/rc.securelevel and reboot, or reboot into \n"); msg_perr("single user mode.\n"); #endif -- Kind regards, Stefan Tauner

1 0

Re: [flashrom] Added chipsets
by Stefan Tauner 12 Apr '13

12 Apr '13

> On Apr 12, 2013 1:42 AM, "Николай Николаев" <evrinoma(a)gmail.com> wrote: > > i think if the flashrom wiki page to give the link on chip documentation > that It will be great decision to avoid problem with name chip and > searching documentations. the problem is that most flash chip datasheets are not available (any longer) from the original manufacturer and that we can not host them on our own (although there might be some legal loopholes to do so, this is pretty much out of question). maintaining a list to somewhat stable manufacturer sites is a lot of work. i know that because i am mostly the one who maintains the mainboard links. maintaining a list of links to other sources like alldatasheets.com or whatever will be even more work because they change URLs or become otherwise defunct is even more frequently. if someone wants to do this feel free to create a wikipage for it, i certainly will not. the solution that has worked in the past is: naming the revision of datasheets and source links in reviews and patches, especially in cases of ambiguity; and if the datasheets are not available anymore one can share them privately without a huge legal risk. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom