flashrom May 2022

flashrom@flashrom.org

25 participants
33 discussions

Release preparations
by Nico Huber 17 May '22

17 May '22

Hi folks, people often ask me about a potential next release and what is holding me back. Long story short, I knew about some bad things in our master branch that make a release impossible and I was very much afraid that there could be more that I don't know about. I've been scrolling through the commit log from v1.1 (the last release I was involved) to today's master. Some of the things I found are simple like something missing for a flash chip entry. But most of it are things I'd rather not have on a release branch. And the list turned out to be much longer than I expected. OTOH, I didn't find issues of the worst kind I expected. Not sure how to go on from here. As this is a lot to do, I suggest that we freeze the master branch for everything that is neither a fix nor on the list (or a similar case that I missed). I noted sometimes that we could just drop the code from a release branch. If we'd decide to do that, we'd also need a plan how to stop the rot on the master branch. Below are my raw notes, I don't have the time to write things up nicely. I noted the commit hash where things began, but tried to take the cur- rent state into account. For instance, when it's about a new programmer driver, I was looking at the file, not the initial patch. Cheers, Nico Recommended clean-ups and investigations before v1.3 ==================================================== * cb973683 Added partial meson support which confuses package main- tainers. Should we remove it from or disable CLI building on release branches? * 71b706f5 Adds some libflashrom APIs with questionable design, buggy implementation and no visible user. Would be easiest to drop and add back when somebody needs it. Open comment. Partially fixed up. * 86fc9cf7 Open comment. Partially fixed up. * 05c629be Looks incomplete, flash would be fully erased with programmers that lack native 4BA command support. * ad08aef6 Undocumented programmer. disable? drop from realease branch? * 703de983 Added `spireadmode` param to sb600spi. (How) does it work? * 13a2ef6c Added `lspcon_i2c_spi`. Too generic name: LSPCon is a concept but driver seems to be about a specific vendor/chip. No pro- bing just starts to write to hardcoded addresses. WP code contains magic numbers, board specific? Implements `spi_ master` but contains hard-coded SPI opcodes. Not documented? disable? drop from release branch? * d97f87b0 Added `realtek_mst_i2c_spi`. No probing, starts by toggling a GPIO. Are GPIO settings board specific? Timeout checks seem to have regressed since original commit. Not documented? Changes clock settings, is this board specific? Implements `spi_master` with special cases in an opcode LUT, doesn't bail out on unknown codes. Falls back on unaligned reads/ writes, were these paths tested? Fixups suggest that the original code wasn't properly tested, was it by now? disable? drop from release branch? * be4682dc Might miss some block erasers. * f82dd300 Might miss some block erasers. * a2dc4f7f It seems `clear_spi_id_cache()` is never called. Probably, should be before probing. * 3149822c Added variable size in `dummy_programmer`. Didn't look at it right now, but I remember it caused a lot of trouble. Probably not fully fixed up yet. * cb9f3cd0 Possible division by zero. * ca2e3bce Fixed some libpci usage. IIRC, there are many more similar cases that might need a fix now that libpci is more strict. * 0386aa17 sb600spi refactoring. Looks like it dropped an error message from many error paths. * f745d0e6, adbae0e2 Added infrastructure for S25F chips. Code style looks a bit outdated. Probably needs upstream review. * 8fa792fb Added chips with oddities and w/o reasoning, e.g: .total_size = 16384, /* This is just half the size.... */ Complete patch needs review. * 855d6b6f Added Ryzen support to sb600spi. API violations. Stalled other cleanup work. Soft bricks machines with >16MiB flash. Patches on Gerrit. drop from release branch? * 32f4cb4f Looks like copy-pasta from Winbond chips. Might miss some block erasers. Missing 4BA_WRITE is probably wrong. * 45d50a10 Added support code for per-region file arguments. Review was interrupted, IIRC. Rebase was borked shortly before merge. Work never finished. * d4063bf3 Missed to update the manpage. Literal `-` shouldn't be in `<>`. * ce983bcc Missed to update the manpage. Filters only spaces when converting region names to file names. * 51e1d0e4 Still selects the wrong chipset, IIRC. * e98b2d11 Review never really started. See comments on Gerrit. Backport candidates =================== * 4ca575dc usbdev: Only match requested USB devices * 8bbb7648 spi95: Check for success before using send_command's returned data * b07c53d7 spi25: Debug flashrom crash when Write Protect is ON Looks like this covers up a general problem with flash-chip entries. Why would we know how to disable block protection if we don't know how to report it? Should probably be added to self checks. * 51261541 it87spi.c: Prevent use-after-free bug * da0825f0 chipset_enable.c: check return value from rphysmap() call * 705212da chipset_enable.c: Validate physmap() return rcrb value * b76d2810 dediprog: Fix segmentation fault on no device found * 1a21cc70 helpers.c: Fix undefined behavior in strndup() * a2f2f3f5 linux_mtd: Disable buffering on the mtd device * ab623c65 jlink_spi: Reduce transfer size * Many fixes in dummy_flasher, not sure if they were applicable earlier. * aedfb7eb flashrom.8: add missing entry for `--flash-contents` * 89c73b5a linux_mtd: check ioctl() return value properly

11 25

Updating Intel idaville BIOS failed.
by Jackie Tang 17 May '22

17 May '22

Hi Team, Excuse me, I am currently working on the BIOS of the Intel idaville platform, and the BIOS chip used is a 64M WINBOND W25Q512JVFIQ. After the machine boots into CentOS, I use the command "flashrom -w BIOS.ROM -p linux-spi" and it will return "No spi device given", and the BIOS update fails. May I ask what method can be used to solve this problem or update the BIOS with flashrom in the OS successfully, or how can I successfully mount the flash? Waiting for your reply. Best Regards, Celestica Technology Consultancy (Shanghai) Co.,Ltd Jackie

1 0

Gatekeeping, ACLs and Review Rules
by Nico Huber 16 May '22

16 May '22

Dear fellow flashrom developers, I've been reflecting lately about written and unwritten rules around our review process and our related privileges on Gerrit. I couldn't identify anything that works well, or let's say well enough. So it might be time we discuss some things and make changes :) Before the dawn of our Git repository and using Gerrit as a review plat- form, we had a Subversion repository. With very few people, usually one or two I think, that had write access. So practically we had gatekeepers that watched over the code. Eventually, they became a bottleneck so we widened that a little when starting the work on Gerrit. Today, I often catch myself falling back into such a gatekeeper mode. Which is futile anyway because I'm not the only one who can write to the repository. But I still wonder why this happens and if it's necessary. I guess first everyone needs to understand how we imagined things with Gerrit and how it looks like today. As mentioned above we set up a group "flashrom developers" which has exclusive write access to the reposi- tory. The idea was to only have people in this group who are long-term (I was thinking about years) contributors to flashrom, know each other from real-time communication (IRC) and trust each other. For the review right "+2", we used the "Reviewers" group from coreboot. IIRC, I pushed for the latter. I was hoping to grow the communities a little together that seemed to have gone separate ways in the years before. After all, a lot of coreboot developers use flashrom in their everyday work. Combined with the "flashrom developers" group it shouldn't have been an issue that people with little flashrom knowledge would review. Since the original setup (about 2017) things went on rather uncon- trolled. I think the gist of it is that people didn't expect that flashrom would need/have different rules compared to coreboot. At some point somebody whom I only knew from their work on coreboot sud- denly merged patches for flashrom. And I guess people pushing patches today pretty much expect that there is nothing more to be done once they see the first +2. No matter if the reviewer knows anything about flashrom. When reviewers disagree then, it can become frustrating for everyone. So currently, I lean towards aligning our process more with that of coreboot. The big difference seems to be that at coreboot merging patches, i.e. hitting the "Submit" button, is more or less considered an administrative task unrelated to one's opinion on the code. While for us it was supposed to replace the gatekeeping. Changing this would imply that we need our own group of reviewers. With this, a +2 would become both rarer and stronger. If this idea meets some consent, I would propose to copy the "flashrom developers" group for a start. And when we identify somebody over time who shows in-depth knowledge about at least a part of flashrom and good self-judgement if they are experienced enough for a +2, we could add them. Right now, some candidates come to mind already, Peter, Nikolai, and Thomas. The "flashrom developers" group also grants the privilege to block "-2" a change. I have very conflicting feelings about this. On one hand, this is a tool that is only ever necessary when people in said group can't trust each other. On the other, that seems to be the status quo already. Maybe we should have another group on top for this? This time really only for trusted, established, long-term contributors? Or maybe for those who maintain the codebase beyond what they are paid for? There is one related idea for a rule that crossed my mind: How about we forbid blocking reverts that fix a regression and apply cleanly (i.e. without needing to revert anything else in advance). Also, let them pass after review without waiting 24 hours. At least for myself this would reduce a lot pressure to fall back to gatekeeping if I knew I could keep things safe and sound without discussion. For maintainers, the patches that are already merged matter the most, cause the most work. This should also be the case for contributors, but alas many don't see it like this and don't help to fix things after a patch is merged. Easing reverts would push the hard work back to the people who break things. Looks a bit longer than what I intended to write, as usual when one starts writing ;) If we come to a conclusion wrt. Gerrit privileges, we could also discuss more rules for each role. While I'm not a fan of too many rules and would rather keep things to common sense, these things depend much on the people we add to the respective groups. I hope it's not too much to digest at once ;) Cheers, Nico

5 17

Questions regarding Easy project and GSoC
by Aarya Chaumal 16 May '22

16 May '22

Hello there, I hope you are well today when you receive this email. I am Aarya Chaumal, a Computer Engineering student at the College of Engineering Pune, India. While going through organizations for this year's Google's Summer of Code I came across your organization, Flashrom. I am a part of onboard computers subsystem at my college's satellite initiative. Through this, I have closely worked on Atmel SAM E70 XPLAINED board. Also, I have strong knowledge about C/C++ and assembly language. From your list of GSoC project ideas, I liked the idea of “Remove global state from flashrom” and "Optimize Erase-Function Selection", although I am not quite sure which one is more suitable for me. Can you guide me through this? As mentioned in your Contributor commitments and requirements, I started to do one of the easy projects - Add new flash chip definitions. For this, I read the relevant datasheets, one from the unlisted chips and another of a listed one (for reference) but still, I am not getting the information about some fields for the structure in the datasheet, namely the feature_bits, probe_timing. Also, do I have to write the probe, read, write and erase functions for the chip separately? Also, how do I test if my code is working as I don't have relevant hardware with me? Can you help me with this? Also what resources should I use to learn more about it? Thank you for looking into this for me. Sincerely, Aarya Chaumal

7 34

flash intel network adapter
by Denis 16 May '22

16 May '22

Hello. Do you have any plans to add support for 8086:1583 - Intel Ethernet Converged Network Adapter XL710-QDA2 ? After an unsuccessful firmware... BootUtil writes "Cannot initialize adapter". No standard ways to make rollback :((( It would be great to flash with your utility. Thanks in advance

1 0

how to enable the internal programmer
by Selva Harris 15 May '22

15 May '22

Hi, I have an Intel Apollo lake board. I want to read the SPI chip. When I run 'flashrom -p internal', this is the message I get: flashrom v1.2-735-gb728f4b on Linux 4.5.5-300.fc24.x86_64 (x86_64) flashrom is free software, get the source code at https://flashrom.org Using clock_gettime for delay loops (clk_id: 1, resolution: 1ns). Error: Unknown programmer "internal". Valid choices are: dummy, serprog, buspirate_spi, rayer_spi, pony_spi, linux_mtd, linux_spi. Please run "flashrom --help" for usage info. Thanks in advance, Selva

2 2

[PATCH] Add voltage data for chips
by Chinmay Lonkar 11 May '22

11 May '22

From: ChinmayLonkar <chinmay20220(a)gmail.com> This patch adds voltage data for following chips: * Intel 28F002BC/BL/BV/BX-T * Intel 28F004B5/BE/BV/BX-B * Intel 28F004B5/BE/BV/BX-T * Intel 28F008S3/S5/SC * Intel 28F400BV/BX/CE/CV-B * Intel 28F400BV/BX/CE/CV-T * Micron/Numonyx/ST M25P40-old * SyncMOS/MoselVitelic {F,S,V}29C51002T * Winbond W29C010(M)/W29C011A/W29EE011/W29EE012 * Winbond W29C010(M)/W29C011A/W29EE011/W29EE012-old Change-Id: I42bc546e03a899086c034c026231955088a7d400 Signed-off-by: Chinmay Lonkar <chinmay20220(a)gmail.com> --- flashchips.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/flashchips.c b/flashchips.c index d155b24..f9cb0cd 100644 --- a/flashchips.c +++ b/flashchips.c @@ -8112,6 +8112,7 @@ const struct flashchip flashchips[] = { }, .write = write_82802ab, .read = read_memmapped, + .voltage = {4500, 5500}, }, { @@ -8139,6 +8140,7 @@ const struct flashchip flashchips[] = { }, .write = write_82802ab, .read = read_memmapped, + .voltage = {4500, 5500}, }, { @@ -8166,6 +8168,7 @@ const struct flashchip flashchips[] = { }, .write = write_82802ab, .read = read_memmapped, + .voltage = {4500, 5500}, }, { @@ -8189,6 +8192,7 @@ const struct flashchip flashchips[] = { .unlock = unlock_28f004s5, .write = write_82802ab, .read = read_memmapped, + .voltage = {2700, 3300}, }, { @@ -8217,6 +8221,7 @@ const struct flashchip flashchips[] = { }, .write = write_82802ab, .read = read_memmapped, + .voltage = {2700, 3600}, }, { @@ -8245,6 +8250,7 @@ const struct flashchip flashchips[] = { }, .write = write_82802ab, .read = read_memmapped, + .voltage = {2700, 3600}, }, { @@ -10521,6 +10527,7 @@ const struct flashchip flashchips[] = { .unlock = spi_disable_blockprotect_bp3_srwd, .write = spi_chip_write_256, .read = spi_chip_read, + .voltage = {2300, 3600}, }, { @@ -16884,6 +16891,7 @@ const struct flashchip flashchips[] = { }, .write = write_jedec_1, .read = read_memmapped, + .voltage = {4500, 5500} }, { @@ -16910,6 +16918,7 @@ const struct flashchip flashchips[] = { }, .write = write_jedec_1, .read = read_memmapped, + .voltage = {4500, 5500} }, { @@ -18607,6 +18616,7 @@ const struct flashchip flashchips[] = { }, .write = write_jedec, .read = read_memmapped, + .voltage = {4500, 5500}, }, { @@ -18630,6 +18640,7 @@ const struct flashchip flashchips[] = { }, .write = write_jedec, .read = read_memmapped, + .voltage = {4500, 5500}, }, { -- 2.25.1

2 2

Flashrom sp_stream_buffer_op() API issue
by Chinmay Lonkar 07 May '22

07 May '22

Hi, I'm trying to fix the build errors of flashrom and came across an API error "Argument with 'nonnull' attribute passed null" which occurred in memcpy() function called inside sp_stream_buffer_op() in file serprog.c. We are passing the third argument of sp_stream_buffer_op() as NULL which gets passed on to the second argument of memcpy() and it expects that argument to be nonnull. Can anybody please provide me with the info and docs for knowing exactly what sp_stream_buffer_op() function does? Also, should we report an error when the third argument passed in the sp_stream_buffer_op() is NULL? Thank You! Regards, Chinmay Lonkar

2 2

flashrom dev meeting notes 5.05.22
by Felix Singer 05 May '22

05 May '22

# 5th May 2022, 6:00 - 7:00 am UTC+0 Attendees: Anastasia, David, Edward, Felix, Nico, Nikolai, Thomas ## Decisions Summary * Thomas gets submit rights * We want a separate reviewers group for flashrom so that reviewers are not mixed across different projects * Different tags for bug IDs are needed so that Google IDs (non-public) are not mixed with tickets from the flashrom issue tracker (public) * The mailing list should be used more for design discussions ## Agenda * [aklm] I wanted to remind that we have an ongoing item “to figure out criteria to give people submit rights”. It was raised on the very first meeting. I think it is in many people's heads. * There is a thread on the mailing list “Gatekeeping, ACLs and Review Rules” ([link](https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/threa… )). The topic is in scope of the thread. Currently the last message is mine, I can’t just talk to myself on the topic. Please share your thoughts! * In the absence of criteria I want to nominate Thomas to get submit rights. This is also an idea from the very first meeting. * In addition to commit stats that Martin gave in the first meeting, I have more points * Thomas is active on the project for a while, * he will be a gsoc Mentor, teaching our new contributors * Reachable and responding on the irc, by email, mailing list * Yes, no objections! * We need rules for this. Not too many people should just get submit rights so that we can keep track. * Separate Reviewers group for flashrom, everyone agrees. * Nik: better have a restricted group for Reviewers, and everyone can submit. * Let’s give Thomas submit rights. Congrats! * Anything that’s left to discuss from the item: “(in case somebody knows) What is Google’s current strategy to avoid repeating mistakes of the past?” * [dhendrix] Is this the kind of finger pointing that Edward mentioned above? At this point, CrOS has proved more than happy to move upstream. The Github mirror is probably more of a concern. Perhaps upstream should consider how to get developers to choose upstream rather than the Github mirror or some other fork. * [Nico] Pointing at Google, actually. If one company forks and later wants their code upstream without proper review, something seems wrong. As if they never reflected about the problems. * [aklm] I am not sure we are on the same page on what are “mistakes of the past”. Everyone has their own idea on what the mistakes were. I can start from myself. From my observations, converging the code was considered a purely technical task, and so it was done as a technical task. However, converging the code means converging the people/the teams, converging very different workflows and work cultures. This does not seem to be thought through or ever discussed, and to me this is a mistake. * Thomas : put GOOGLE_BUG tag and BUG is for public issue tracker * Edward BUG=g:1234566,b:544 * Edward: happens more on board bringup * Nikolai: maybe keep b: prefix for google bugs BUG=b:google_id,f:flashrom_id * Felix : [https://doc.coreboot.org/infrastructure/services.html#issue-tracker](https:… * [quasisec] I am also unclear how CrOS convergence had really much of an impact on upstream considering >99% of the work was adjusting the CrOS fork to realign with upstream. Only an extremely small amount of alignment was in the form of upstream commits, e.g., missing raiden_debug and some unfortunate part of sb600spi. Is there a specific area that stands out? * [Nico] No idea if related to the original reasons for the fork, but that the convergence is stalling new releases for years stands out pretty much. * [Nico]: How can we teach developers who got to know the [Chrome OS] fork first about the upstream project (if not during review)? * [PatrickG] Once upstream-first is established, downstream patches aren’t reviewed anymore and redirected to upstream. * [quasisec] I am not sure anyone really “got to know the fork” as such. The problem was the fork was treated as a means to an end. Hence all the additional investment in improving flashrom such as life-cycle API and unit-testing to name some recent examples. Other examples include upstreaming additional hardware support such as lspcon, mst’s and raiden or later generation PCH rev’s. * [quasisec]: Regarding “teaching” can you elaborate on what this actually means as I think there is more than one dimension to the intent of that. * [Nico] I see a lack of a forum to teach people about the project. Because the mailing list is basically rejected by Google developers (with exceptions of course), and people ask to keep comments on Gerrit to very specific “actionable” items, where should we teach people about the project, how we do things and what to focus on? Etc. * [quasisec]: No one “rejected” anything, the commit you refer to Nico is here [https://review.coreboot.org/c/flashrom/+/62768](https://review.coreboot.org… and the issue is the tone of the review. I’ll leave others to judge. * Nico: we need to use mailing list for design discussions, before starting the work * Edward: how to decide what is big and what is small? * **dunning kruger effect** * Nico: early engagement before writing code. * New programmers should be discussed first. * Infra change * Change touching multiple layers * aklm: What happens when the developer has already started? * Threshold to decide whether to send a patch without any prior discussion or conversation: are you ok to re-write the patch if the idea is not supported as is? * Price of the mistake? * quasisec: how to make the price not so high that we don’t scare people away also? * Felix: mention in the guidelines , recommend to discuss on mailing list first * Aklm: this is already recommended on the guidelines * Edward: developers think in code first, they think of design and write some draft code * Nik: whatever tool works best * Felix: An account is needed for Gerrit and thus not everyone is able to join the discussion. * Aklm: for a patch you need to know whom to add as reviewers. On the mailing list, you just post, everyone reads. * quasisec: How to make things like adding programmers a bit more template’ty? Common pattern guidance? Make flashrom API’s better? * Edward: can the code say “file a bug” instead of “write to the mailing list”? * Nico: it could be another mailing list? * Edward: prefix in the subject line, so that people can filter if they want, or not do anything. Create a bug, bug updates are sent on the mailing list. User has a handle on the issue. * Felix: people need an account to create bugs on redmine, but for the mailing list no account is needed.

1 0

Updated invitation: Flashrom Dev Meeting (monthly) @ Every 2 weeks from 4pm to 5pm on Thursday (AEST) (flashrom@flashrom.org)
by aklm＠chromium.org 03 May '22

03 May '22

This event has been changed. Title: Flashrom Dev Meeting (monthly) Monthly meeting of Flashrom project developers. Meeting notes doc: https://docs.google.com/document/d/18qKvEbfPszjsJJGJhwi8kRVDUG3GZ… When: Every 2 weeks from 4pm to 5pm on Thursday Eastern Australia Time - Sydney Joining info: Join with Google Meet https://meet.google.com/iuf-mtri-zva?hs=224 Join by phone (AU) +61 2 9051 6791 (PIN: 304642402) More phone numbers: https://tel.meet/iuf-mtri-zva?pin=9271993818880&hs=0 Calendar: flashrom(a)flashrom.org Who: * aklm(a)chromium.org - creator * felix.singer12(a)gmail.com * david.hendricks(a)gmail.com * quasisec(a)google.com * nico.h(a)gmx.de * Martin Roth * src(a)posteo.de * martonmiklosqdev(a)gmail.com * piotr.krol(a)3mdeb.com * Maciej Pijanowski * michal.zygowski(a)3mdeb.com * th3fanbus(a)gmail.com * stefan.k.reinauer(a)gmail.com * nartemiev(a)google.com * arthur(a)aheymans.xyz * flashrom(a)flashrom.org Event details: https://calendar.google.com/calendar/event?action=VIEW&eid=MmVscGY2cjNsdTZw… Invitation from Google Calendar: https://calendar.google.com/calendar/ You are receiving this courtesy email at the account flashrom(a)flashrom.org because you are an attendee of this event. To stop receiving future updates for this event, decline this event. Alternatively you can sign up for a Google account at https://calendar.google.com/calendar/ and control your notification settings for your entire calendar. Forwarding this invitation could allow any recipient to send a response to the organizer and be added to the guest list, or invite others regardless of their own invitation status, or to modify your RSVP. Learn more at https://support.google.com/calendar/answer/37135#forwarding

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom May 2022