flashrom May 2014

flashrom@flashrom.org

46 participants
188 discussions

Re: [flashrom] [PATCH 2/2] Utilize new tested states for chipsets as well.
by Carl-Daniel Hailfinger 02 Jun '14

02 Jun '14

Am 30.05.2014 05:15 schrieb Stefan Tauner: > Mark all ME-enabled Intel chipsets as DEP, alter print.c accordingly > (print_wiki.c was already prepared). > > Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Thanks for your patch! Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Regards, Carl-Daniel -- http://www.hailfinger.org/

2 2

Re: [flashrom] [PATCH] Add default arguments for the default programmer (only).
by Carl-Daniel Hailfinger 02 Jun '14

02 Jun '14

Am 30.05.2014 00:52 schrieb Stefan Tauner: > This code exists thanks to food for thought from Urja Rannikko. > > Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Interesting, to say the least. The default parameter only applies if -p is not specified at all, so there are no unexpected side effects. The only complaint I have (except the question "who would want to use that") is that you can run make CONFIG_DEFAULT_PROGRAMMER_ARGS="foobar" without having to specify CONFIG_DEFAULT_PROGRAMMER as well. CONFIG_DEFAULT_PROGRAMMER_ARGS won't have any effect in that case during runtime, but that might surprise someone who specified it. Hm. Maybe I should really ask who would want to use that... it's obviously not a feature distributions would use, although it seems some of them use CONFIG_DEFAULT_PROGRAMMER to keep the behavoir unchanged compared to previous releases. Not opposed to it, but not really convinced either. Regards, Carl-Daniel > diff --git a/Makefile b/Makefile > index 346d46a..998979d 100644 > --- a/Makefile > +++ b/Makefile > @@ -52,6 +52,11 @@ DOSLIBS_BASE ?= .. > # evaluated below, namely those that enable/disable the various programmers). > # Compilation will fail for unspecified values. > CONFIG_DEFAULT_PROGRAMMER ?= PROGRAMMER_INVALID > +# The following adds a default parameter for the default programmer set above (only). > +CONFIG_DEFAULT_PROGRAMMER_ARGS ?= '' > +# Example: compiling with > +# make CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_SERPROG CONFIG_DEFAULT_PROGRAMMER_ARGS="dev=/dev/ttyUSB0:1500000" > +# would make executing './flashrom' (almost) equivialent to './flashrom -p serprog:dev=/dev/ttyUSB0:1500000'. > > # If your compiler spits out excessive warnings, run make WARNERROR=no > # You shouldn't have to change this flag. > @@ -471,6 +476,7 @@ CONFIG_INTERNAL_DMI ?= yes > # Depending on the CONFIG_* variables set and verified above we set compiler flags and parameters below. > > FEATURE_CFLAGS += -D'CONFIG_DEFAULT_PROGRAMMER=$(CONFIG_DEFAULT_PROGRAMMER)' > +FEATURE_CFLAGS += -D'CONFIG_DEFAULT_PROGRAMMER_ARGS="$(CONFIG_DEFAULT_PROGRAMMER_ARGS)"' > > ifeq ($(CONFIG_INTERNAL), yes) > FEATURE_CFLAGS += -D'CONFIG_INTERNAL=1' > diff --git a/cli_classic.c b/cli_classic.c > index a32d55b..fc1b9ba 100644 > --- a/cli_classic.c > +++ b/cli_classic.c > @@ -396,8 +396,10 @@ int main(int argc, char *argv[]) > if (prog == PROGRAMMER_INVALID) { > if (CONFIG_DEFAULT_PROGRAMMER != PROGRAMMER_INVALID) { > prog = CONFIG_DEFAULT_PROGRAMMER; > - msg_pinfo("Using default programmer \"%s\".\n", > - programmer_table[CONFIG_DEFAULT_PROGRAMMER].name); > + /* We need to strdup here because we free(pparam) unconditionally later. */ > + pparam = strdup(CONFIG_DEFAULT_PROGRAMMER_ARGS); > + msg_pinfo("Using default programmer \"%s\" with arguments \"%s\".\n", > + programmer_table[CONFIG_DEFAULT_PROGRAMMER].name, pparam); > } else { > msg_perr("Please select a programmer with the --programmer parameter.\n" > "Previously this was not necessary because there was a default set.\n" -- http://www.hailfinger.org/

2 3

[PATCH] Add IT8212F as programmer
by Kyösti Mälkki 02 Jun '14

02 Jun '14

This PCI PATA controller can use 3V parallel flash upto 128kB. My card was identified as: PCI 1283:8212, subsystem 1283:0001. and labelled as: Innovision Multimedia LTD. EIO ATA133 RAID (DM-8401 Ver A) This particular card did not require setting of any GPIO signals to enable flash writing. My card has Pm39LV512 in PLCC32 package without socket. Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Index: flashrom-it8212f/Makefile =================================================================== --- flashrom-it8212f/Makefile (revision 1539) +++ flashrom-it8212f/Makefile (working copy) @@ -177,7 +177,12 @@ else override CONFIG_SATAMV = no endif +ifeq ($(CONFIG_IT8212), yes) +UNSUPPORTED_FEATURES += CONFIG_IT8212=yes +else +override CONFIG_IT8212 = no endif +endif ifeq ($(TARGET_OS), libpayload) CPPFLAGS += -DSTANDALONE @@ -344,6 +349,9 @@ # Enable Linux spidev interface by default. We disable it on non-Linux targets. CONFIG_LINUX_SPI ?= yes +# Always enable ITE IT8212F PATA controllers for now. +CONFIG_IT8212 ?= yes + # Disable wiki printing by default. It is only useful if you have wiki access. CONFIG_PRINT_WIKI ?= no @@ -503,6 +511,12 @@ PROGRAMMER_OBJS += linux_spi.o endif +ifeq ($(CONFIG_IT8212), yes) +FEATURE_CFLAGS += -D'CONFIG_IT8212=1' +PROGRAMMER_OBJS += it8212.o +NEED_PCI := yes +endif + ifeq ($(NEED_SERIAL), yes) LIB_OBJS += serial.o endif Index: flashrom-it8212f/print_wiki.c =================================================================== --- flashrom-it8212f/print_wiki.c (revision 1539) +++ flashrom-it8212f/print_wiki.c (working copy) @@ -338,6 +338,9 @@ #if CONFIG_SATAMV == 1 print_supported_pcidevs_wiki(satas_mv); #endif +#if CONFIG_IT8212 == 1 + print_supported_pcidevs_wiki(ata_it82); +#endif printf("\n|}\n"); } Index: flashrom-it8212f/it8212.c =================================================================== --- flashrom-it8212f/it8212.c (revision 0) +++ flashrom-it8212f/it8212.c (revision 0) @@ -0,0 +1,110 @@ +/* + * This file is part of the flashrom project. + * + * Copyright (C) 2011 Carl-Daniel Hailfinger + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#include <stdlib.h> +#include "flash.h" +#include "programmer.h" + +static uint8_t *it8212_bar; +static uint8_t it8212_rom_enable = 0; + +#define PCI_VENDOR_ID_ITE 0x1283 + +const struct pcidev_status ata_it82[] = { + {PCI_VENDOR_ID_ITE, 0x8212, OK, "ITE", "8212F PATA RAID"}, + {}, +}; + +#define IT8212_MEMMAP_SIZE (128 * 1024) +#define IT8212_MEMMAP_MASK (IT8212_MEMMAP_SIZE - 1) + +static void it8212_chip_writeb(const struct flashctx *flash, uint8_t val, + chipaddr addr); +static uint8_t it8212_chip_readb(const struct flashctx *flash, + const chipaddr addr); +static const struct par_programmer par_programmer_it8212 = { + .chip_readb = it8212_chip_readb, + .chip_readw = fallback_chip_readw, + .chip_readl = fallback_chip_readl, + .chip_readn = fallback_chip_readn, + .chip_writeb = it8212_chip_writeb, + .chip_writew = fallback_chip_writew, + .chip_writel = fallback_chip_writel, + .chip_writen = fallback_chip_writen, +}; + +static int it8212_shutdown(void *data) +{ + if (! it8212_rom_enable) { + uintptr_t addr = pci_read_long(pcidev_dev, PCI_ROM_ADDRESS); + pci_write_long(pcidev_dev, PCI_ROM_ADDRESS, addr & ~0x01); + } + physunmap(it8212_bar, IT8212_MEMMAP_SIZE); + pci_cleanup(pacc); + release_io_perms(); + return 0; +} + +int it8212_init(void) +{ + uintptr_t addr; + + /* Needed only for PCI accesses on some platforms. + * FIXME: Refactor that into get_mem_perms/get_io_perms/get_pci_perms? + */ + get_io_perms(); + + /* No need to check for errors, pcidev_init() will not return in case + * of errors. + */ + addr = pcidev_init(PCI_ROM_ADDRESS, ata_it82); + + it8212_bar = physmap("IT8212F flash", addr, IT8212_MEMMAP_SIZE); + if (it8212_bar == ERROR_PTR) + goto error_out_unmap; + if (register_shutdown(it8212_shutdown, NULL)) + return 1; + + /* To restore ROM BAR enable once we are done. */ + it8212_rom_enable = addr & 0x01; + if (! it8212_rom_enable) + pci_write_long(pcidev_dev, PCI_ROM_ADDRESS, addr | 0x01); + + max_rom_decode.parallel = IT8212_MEMMAP_SIZE; + register_par_programmer(&par_programmer_it8212, BUS_PARALLEL); + return 0; + +error_out_unmap: + physunmap(it8212_bar, IT8212_MEMMAP_SIZE); + pci_cleanup(pacc); + release_io_perms(); + return 1; +} + +static void it8212_chip_writeb(const struct flashctx *flash, uint8_t val, + chipaddr addr) +{ + pci_mmio_writeb(val, it8212_bar + (addr & IT8212_MEMMAP_MASK)); +} + +static uint8_t it8212_chip_readb(const struct flashctx *flash, + const chipaddr addr) +{ + return pci_mmio_readb(it8212_bar + (addr & IT8212_MEMMAP_MASK)); +} Index: flashrom-it8212f/flashrom.c =================================================================== --- flashrom-it8212f/flashrom.c (revision 1539) +++ flashrom-it8212f/flashrom.c (working copy) @@ -261,6 +261,16 @@ }, #endif +#if CONFIG_IT8212 == 1 + { + .name = "it8212", + .init = it8212_init, + .map_flash_region = fallback_map, + .unmap_flash_region = fallback_unmap, + .delay = internal_delay, + }, +#endif + {}, /* This entry corresponds to PROGRAMMER_INVALID. */ }; Index: flashrom-it8212f/programmer.h =================================================================== --- flashrom-it8212f/programmer.h (revision 1539) +++ flashrom-it8212f/programmer.h (working copy) @@ -87,6 +87,9 @@ #if CONFIG_LINUX_SPI == 1 PROGRAMMER_LINUX_SPI, #endif +#if CONFIG_IT8212 == 1 + PROGRAMMER_IT8212, +#endif PROGRAMMER_INVALID /* This must always be the last entry. */ }; @@ -456,6 +459,12 @@ int linux_spi_init(void); #endif +/* it8212.c */ +#if CONFIG_IT8212 == 1 +int it8212_init(void); +extern const struct pcidev_status ata_it82[]; +#endif + /* dediprog.c */ #if CONFIG_DEDIPROG == 1 int dediprog_init(void); Index: flashrom-it8212f/print.c =================================================================== --- flashrom-it8212f/print.c (revision 1539) +++ flashrom-it8212f/print.c (working copy) @@ -538,6 +538,11 @@ programmer_table[PROGRAMMER_LINUX_SPI].name); msg_ginfo("Device files /dev/spidev*.*\n"); #endif +#if CONFIG_IT8212 == 1 + msg_ginfo("\nSupported devices for the %s programmer:\n", + programmer_table[PROGRAMMER_IT8212].name); + print_supported_pcidevs(ata_it82); +#endif } #if CONFIG_INTERNAL == 1

2 3

PMC25LV010E
by The Raven 01 Jun '14

01 Jun '14

Hello, i have here an "PMC25LV010E" which is not recognized by flashrom. I am no sure whats the difference between "PMC25LV010" and "E". The log is attached, maybe it's only another ID? And i have an "Pm25LV010" here which is recognized as "Pm25LV010A". Maybe is the Description vice verse? If you need more logs or something else, let me know.

2 7

Re: [flashrom] [Patch] Add support for Atmel AT25DL161
by Stefan Tauner 01 Jun '14

01 Jun '14

On Mon, 17 Mar 2014 14:39:14 +0800 Allen Yan <lexkde(a)gmail.com> wrote: > This patch adds support for Atmel AT25DL161, 2Mbytes SPI flash which look > like the low voltage version of Atmel AT25DQ161. It has no pre test for now. Hello Allen, thanks for your patch! Please note that before we can include your patch you need to sign the Developer's Certificate of Origin by stating so in the patch/email. We can not include your patch as is! Please read http://flashrom.org/Development_Guidelines#Sign-off_Procedure for details, thanks. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 1

Re: [flashrom] [PATCH] Combine block_erase*_en29lv640b and block_erase*_m29f400bt respectively.
by Carl-Daniel Hailfinger 01 Jun '14

01 Jun '14

Am 29.05.2014 23:44 schrieb Stefan Tauner: > This patch combines two identical block and chip erase functions respectively: > - Merge block_erase_m29f400bt and block_erase_en29lv640b into > erase_block_shifted_jedec. > - Merge block_erase_chip_m29f400bt and block_erase_chip_en29lv640b into > erase_chip_block_shifted_jedec. > > Leave their implementations in en29lv640b.c for now. > > Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Excellent, a cleanup of old parallel 16bit-native chips. Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Regards, Carl-Daniel -- http://www.hailfinger.org/

2 1

Re: [flashrom] [PATCH 1/2] print.c: improve device printing.
by Carl-Daniel Hailfinger 01 Jun '14

01 Jun '14

Am 30.05.2014 05:15 schrieb Stefan Tauner: > Add headers and columns (i.e. print device entries in a table-like manner). > Also, add and use test_state_to_text() to support the new test states. > > Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Thanks! Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Regards, Carl-Daniel -- http://www.hailfinger.org/

2 1

[PATCH] Add support for S25FL128P and S25FL128P......0 chips.
by Stefan Tauner 31 May '14

31 May '14

S25FL128P is the predecessor family of S25FL128S. All these chips can not be distinguished without EDI. Additionally to the new S25FL128P chips, this patch also fixes the name of the previously supported S25FL128S model with uniform 256 kB sectors (S25FL128P......1 not 0) and adds the hybrid sector version as well. Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> --- Since flashrom can not distinguish the chips itself, the user has to select the right chip with the -c parameter. Liviu, please apply this patch on top of r1806 and run flashrom once without any operation and without -c .... E.g. flashrom -p usbblaster_spi -o probe.log And a second time with the correct chip selected to write *different* data to the chip. E.g. flashrom -p usbblaster_spi -o write.log -w newdata.bin -c "S25FL128P......0" Please report back with the two log files. flashchips.c | 102 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++-- flashchips.h | 2 +- 2 files changed, 100 insertions(+), 4 deletions(-) diff --git a/flashchips.c b/flashchips.c index c830436..c731e38 100644 --- a/flashchips.c +++ b/flashchips.c @@ -9675,7 +9675,69 @@ const struct flashchip flashchips[] = { { .vendor = "Spansion", - .name = "S25FL128S......0", /* uniform 256kB sectors */ + .name = "S25FL128P......0", /* uniform 64 kB sectors */ + .bustype = BUS_SPI, + .manufacture_id = SPANSION_ID, + .model_id = SPANSION_S25FL128, + .total_size = 16384, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_UNTESTED, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = { + { + .eraseblocks = { {256 * 1024, 64} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {256 * 1024, 64} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { { 16384 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { { 16384 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_bp3_srwd, + .unlock = spi_disable_blockprotect_bp3_srwd, + .write = spi_chip_write_256, + .read = spi_chip_read, /* Fast read (0x0B) supported */ + .voltage = {2700, 3600}, + }, + + { + .vendor = "Spansion", + .name = "S25FL128P......1", /* uniform 256kB sectors */ + .bustype = BUS_SPI, + .manufacture_id = SPANSION_ID, + .model_id = SPANSION_S25FL128, + .total_size = 16384, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_UNTESTED, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = { + { + .eraseblocks = { {64 * 1024, 256} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { { 16384 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_bp2_srwd, + .unlock = spi_disable_blockprotect_bp2_srwd, + .write = spi_chip_write_256, + .read = spi_chip_read, /* Fast read (0x0B) supported */ + .voltage = {2700, 3600}, + }, + + { + .vendor = "Spansion", + .name = "S25FL128S......0", /* hybrid 4 (top or bottom) + 64 kB sectors */ .bustype = BUS_SPI, .manufacture_id = SPANSION_ID, .model_id = SPANSION_S25FL128, @@ -9689,9 +9751,43 @@ const struct flashchip flashchips[] = { .probe_timing = TIMING_ZERO, .block_erasers = { { - .eraseblocks = { {4 * 1024, 4096} }, - .block_erase = spi_block_erase_20, +/* FIXME: erase opcodes 20h for (top or bottom) 4 kB parameter sectors and D8h for remaining 64 kB sectors + .eraseblocks = { + {4 * 1024, 32}, + {64 * 1024, 254}, + }, + .block_erase = NULL, + }, { */ + .eraseblocks = { { 16384 * 1024, 1} }, + .block_erase = spi_block_erase_60, }, { + .eraseblocks = { { 16384 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_bp2_ep_srwd, /* TODO: SR2 and many others */ + .unlock = spi_disable_blockprotect_bp2_srwd, /* TODO: various other locks */ + .write = spi_chip_write_256, /* Multi I/O supported */ + .read = spi_chip_read, /* Fast read (0x0B) and multi I/O supported */ + .voltage = {2700, 3600}, + }, + + { + .vendor = "Spansion", + .name = "S25FL128S......1", /* uniform 256 kB sectors */ + .bustype = BUS_SPI, + .manufacture_id = SPANSION_ID, + .model_id = SPANSION_S25FL128, + .total_size = 16384, + .page_size = 512, + /* supports 4B addressing */ + /* OTP: 1024B total, 32B reserved; read 0x4B; write 0x42 */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, + .tested = TEST_UNTESTED, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = { + { .eraseblocks = { {256 * 1024, 64} }, .block_erase = spi_block_erase_d8, }, { diff --git a/flashchips.h b/flashchips.h index 5fce532..2a5e84c 100644 --- a/flashchips.h +++ b/flashchips.h @@ -564,7 +564,7 @@ #define SPANSION_S25FL016A 0x0214 #define SPANSION_S25FL032A 0x0215 /* Same as S25FL032P, but the latter supports EDI and CFI */ #define SPANSION_S25FL064A 0x0216 /* Same as S25FL064P, but the latter supports EDI and CFI */ -#define SPANSION_S25FL128 0x2018 +#define SPANSION_S25FL128 0x2018 /* Same ID for various S25FL128P, S25FL128S and S25FL129P (including dual-die S70FL256P) variants (EDI supported) */ #define SPANSION_S25FL256 0x0219 #define SPANSION_S25FL512 0x0220 #define SPANSION_S25FL204 0x4013 -- Kind regards, Stefan Tauner

1 0

Re: [flashrom] "S25FL128S......0" on usbblaster_spi
by Stefan Tauner 31 May '14

31 May '14

On Sat, 31 May 2014 13:14:08 -0400 Liviu Toma <liviu.toma(a)gmail.com> wrote: > Hi, > > Thanks very much for the reply. Just to clarify, I am not concerned, I was > able to flash the chip. I was merely sending the info as instructed by the > tool. Oh, but I am ;) It should work at first try and this is a bug. > The inscription on the chip read Spansion FL128PIF (the next line reads > 92599012 but I assume that's some date / serial number). Thank you very much. So it is actually the predecessor of S25FL128S, namely the S25FL128P. I'll take a look at the differences/possible problems and how/if the chips could be told apart by software. Would you be able and willing to test a patch for that? -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

2 1

Re: [flashrom] "S25FL128S......0" on usbblaster_spi
by Stefan Tauner 31 May '14

31 May '14

On Fri, 30 May 2014 22:00:59 -0400 Liviu Toma <liviu.toma(a)gmail.com> wrote: > Hello, > > I had some success programming the Spansion "S25FL128S......0" with > usbblaster_spi (Altera USB blaster cheap clone). > The read function works OK. The write function fails the first time but if > I run it again it works the second time (this is consistent, I've done it > on 3 different chips). It appears the first time it does Erase then Write, > but only the erasing works. The second time it's already erased from the > first run and the write works OK. > Log attached. Hi Liviu, each erased block is verified to contain 0xFF before it is tried to be written. So the erase is successful when the W is printed. Now there are two possibilities: either the writes did not work, or after a write another delete undoes the write later. Can you please tell me the exact S25FL128S model you have? There are many versions of the chip (as the dots in the name suggests) and I presume that the problem is that the current implementation is not compatible with all models. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

2 1

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom May 2014