June 2012 - flashrom - mail.coreboot.org

Using flashrom with Intel Ibex Peak (PCH 3420) amd M25P64 flash works
by Gary Hannon June 8, 2012

June 8, 2012

Great tool. I found this after lunch and had it working and verified by 3:30. Attached are the Verbose output dumps that you were hoping to get on new arch's. I was able to read, erase, program and verify the flash. We will soon have a board that uses 2 flashes, each 64Mb. I will also send feedback of what that looks like. Can this tool specify which chip select to use when writing, or do I need to create a map? We will have the descriptors in each flash calling the other flash as the Platform Data region. Our board has a way to steer which chip gets CS0 and which gets CS1 for having a failover incase a BIOS setting makes the board unbootable. Thanks much Gary Hannon Sr. Software Engineer CSP Inc. 43 Manning Road Billerica, MA 01821 978-663-7598 x1509 ghannon(a)cspi.com

2 3

AMIC A25L032 success report
by Carl-Daniel Hailfinger June 7, 2012

June 7, 2012

Hi, AMIC A25L032 read/erase/write/verify is tested. flashrom v0.9.5.2-r1540 on Linux 2.6.34.10-0.6-default (i686) flashrom was built with libpci 3.1.7, GCC 4.5.0 20100604 [gcc-4_5-branch revision 160292], little endian Command line (9 args): ./flashrom -p buspirate_spi:dev=/dev/ttyUSB0 -c A25L032 -V -w randomimage.bin -o logfile.txt Calibrating delay loop... OS timer resolution is 2 usecs, 1011M loops per second, 10 myus = 11 us, 100 myus = 96 us, 1000 myus = 952 us, 10000 myus = 10738 us, 8 myus = 9 us, OK. Initializing buspirate_spi programmer SPI speed is 8MHz Raw bitbang mode version 1 Raw SPI mode version 1 The following protocols are supported: SPI. Probing for AMIC A25L032, 4096 kB: probe_spi_rdid_generic: id1 0x37, id2 0x3016 Chip status register is 00 Found AMIC flash chip "A25L032" (4096 kB, SPI) on buspirate_spi. Chip status register is 00 Chip status register: Status Register Write Disable (SRWD) is not set Chip status register: Sector Protect Size (SEC) is 64 KB Chip status register: Top/Bottom (TB) is top Chip status register: Bit 4 / Block Protect 2 (BP2) is not set Chip status register: Bit 3 / Block Protect 1 (BP1) is not set Chip status register: Bit 2 / Block Protect 0 (BP0) is not set Chip status register: Write Enable Latch (WEL) is not set Chip status register: Write In Progress (WIP/BUSY) is not set Chip status register 2 is NOT decoded! This chip may contain one-time programmable memory. flashrom cannot read and may never be able to write it, hence it may not be able to completely clone the contents of this chip (see man page for details). === This flash part has status UNTESTED for operations: PROBE READ ERASE WRITE Reading old flash chip contents... done. Erasing and writing flash chip... Trying erase function 0... 0x000000-0x000fff:EW [...] Erase/write done. Verifying flash... VERIFIED. Raw bitbang mode version 1 Bus Pirate shutdown completed. Regards, Carl-Daniel -- http://www.hailfinger.org/

2 1

M25P40 report
by VAN GALEN Marijn June 7, 2012

June 7, 2012

Writing reading erasing all work correctly with ft2232_spi programmer flashrom v0.9.4-r1395 on Linux 2.6.37.1 (i686), built with libpci 2.2.3, GCC 4.1.2 20080704 (Red Hat 4.1.2-48), little endian flashrom is free software, get the source code at http://www.flashrom.org Calibrating delay loop... OS timer resolution is 1 usecs, 527M loops per second, 10 myus = 15 us, 100 myus = 160 us, 1000 myus = 1094 us, 10000 myus = 10565 us, 4 myus = 7 us, OK. Initializing ft2232_spi programmer Extract Using device type FTDI FT2232H interface A busid 002:002 Bus ids found: 002:002 Disable divide-by-5 front stage Set clock divisor MPSSE clock: 60.000000 MHz divisor: 3 SPI clock: 10.000000 MHz No loopback of TDI/DO TDO/DI Set data bits Probing for TEST EPCS4, 128 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for AMIC A25L05PT, 64 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for AMIC A25L05PU, 64 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for AMIC A25L10PT, 128 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for AMIC A25L10PU, 128 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for AMIC A25L20PT, 256 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for AMIC A25L20PU, 256 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for AMIC A25L40PT, 512 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for AMIC A25L40PU, 512 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for AMIC A25L80P, 1024 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for AMIC A25L16PT, 2048 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for AMIC A25L16PU, 2048 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for AMIC A25L512, 64 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for AMIC A25L010, 128 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for AMIC A25L020, 256 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for AMIC A25L040, 512 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for AMIC A25L080, 1024 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for AMIC A25L016, 2048 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for AMIC A25L032, 4096 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for AMIC A25LQ032, 4096 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Atmel AT25DF021, 256 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Atmel AT25DF041A, 512 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Atmel AT25DF081, 1024 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Atmel AT25DF081A, 1024 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Atmel AT25DF161, 2048 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Atmel AT25DF321, 4096 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Atmel AT25DF321A, 4096 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Atmel AT25DF641, 8192 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Atmel AT25DQ161, 2048 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Atmel AT25F512B, 64 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Atmel AT25FS010, 128 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Atmel AT25FS040, 512 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Atmel AT26DF041, 512 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Atmel AT26DF081A, 1024 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Atmel AT26DF161, 2048 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Atmel AT26DF161A, 2048 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Atmel AT26F004, 512 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Atmel AT45CS1282, 16896 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Atmel AT45DB011D, 128 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Atmel AT45DB021D, 256 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Atmel AT45DB041D, 512 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Atmel AT45DB081D, 1024 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Atmel AT45DB161D, 2048 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Atmel AT45DB321C, 4224 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Atmel AT45DB321D, 4096 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Atmel AT45DB642D, 8192 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for EMST F25L008A, 1024 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon EN25B05, 64 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon EN25B05T, 64 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon EN25B10, 128 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon EN25B10T, 128 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon EN25B20, 256 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon EN25B20T, 256 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon EN25B40, 512 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon EN25B40T, 512 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon EN25B80, 1024 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon EN25B80T, 1024 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon EN25B16, 2048 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon EN25B16T, 2048 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon EN25B32, 4096 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon EN25B32T, 4096 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon EN25B64, 8192 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon EN25B64T, 8192 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon EN25F05, 64 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon EN25F10, 128 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon EN25F20, 256 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon EN25F40, 512 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon EN25F80, 1024 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon EN25F16, 2048 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon EN25F32, 4096 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon EN25Q40, 512 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon EN25Q80(A), 1024 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon EN25Q16, 2048 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon EN25Q32(A/B), 4096 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon EN25Q64, 8192 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon EN25Q128, 16384 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon EN25QH16, 2048 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Macronix MX25L512, 64 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Macronix MX25L1005, 128 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Macronix MX25L2005, 256 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Macronix MX25L4005, 512 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Macronix MX25L8005, 1024 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Macronix MX25L1605, 2048 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Macronix MX25L1635D, 2048 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Macronix MX25L1635E, 2048 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Macronix MX25L3205, 4096 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Macronix MX25L3235D, 4096 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Macronix MX25L6405, 8192 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Macronix MX25L12805, 16384 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Numonyx M25PE10, 128 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Numonyx M25PE20, 256 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Numonyx M25PE40, 512 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Numonyx M25PE80, 1024 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Numonyx M25PE16, 2048 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for PMC Pm25LV010, 128 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for PMC Pm25LV016B, 2048 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for PMC Pm25LV020, 256 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for PMC Pm25LV040, 512 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for PMC Pm25LV080B, 1024 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for PMC Pm25LV512, 64 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Sanyo LF25FW203A, 2048 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Spansion S25FL004A, 512 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Spansion S25FL008A, 1024 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Spansion S25FL016A, 2048 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Spansion S25FL032A, 4096 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Spansion S25FL064A, 8192 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for SST SST25VF010.REMS, 128 kB: probe_spi_rems: id1 0xff, id2 0xff Probing for SST SST25VF016B, 2048 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for SST SST25VF032B, 4096 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for SST SST25VF064C, 8192 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for SST SST25VF040.REMS, 512 kB: probe_spi_rems: id1 0xff, id2 0xff Probing for SST SST25VF040B, 512 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for SST SST25LF040A.RES, 512 kB: probe_spi_res2: id1 0x12, id2 0x12 Probing for SST SST25VF040B.REMS, 512 kB: probe_spi_rems: id1 0xff, id2 0xff Probing for SST SST25VF080B, 1024 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for ST M25P05-A, 64 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for ST M25P05.RES, 64 kB: Ignoring RES in favour of RDID. Probing for ST M25P10-A, 128 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for ST M25P10.RES, 128 kB: Ignoring RES in favour of RDID. Probing for ST M25P20, 256 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for ST M25P40, 512 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Chip status register is 00 Chip status register: Status Register Write Disable (SRWD) is not set Chip status register: Bit 6 is not set Chip status register: Bit 5 / Block Protect 3 (BP3) is not set Chip status register: Bit 4 / Block Protect 2 (BP2) is not set Chip status register: Bit 3 / Block Protect 1 (BP1) is not set Chip status register: Bit 2 / Block Protect 0 (BP0) is not set Chip status register: Write Enable Latch (WEL) is not set Chip status register: Write In Progress (WIP/BUSY) is not set Found ST flash chip "M25P40" (512 kB, SPI) on ft2232_spi. Probing for ST M25P40-old, 512 kB: Ignoring RES in favour of RDID. Probing for ST M25P80, 1024 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for ST M25P16, 2048 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for ST M25P32, 4096 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for ST M25P64, 8192 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for ST M25P128, 16384 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for ST M25PX16, 2048 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for ST M25PX32, 4096 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for ST M25PX64, 8192 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Winbond W25Q80, 1024 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Winbond W25Q16, 2048 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Winbond W25Q32, 4096 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Winbond W25Q64, 8192 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Winbond W25Q128, 16384 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Winbond W25X10, 128 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Winbond W25X20, 256 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Winbond W25X40, 512 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Winbond W25X80, 1024 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Winbond W25X16, 2048 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Winbond W25X32, 4096 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Winbond W25X64, 8192 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for AMIC unknown AMIC SPI chip, 0 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Atmel unknown Atmel SPI chip, 0 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Eon unknown Eon SPI chip, 0 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Macronix unknown Macronix SPI chip, 0 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for PMC unknown PMC SPI chip, 0 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for SST unknown SST SPI chip, 0 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for ST unknown ST SPI chip, 0 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Sanyo unknown Sanyo SPI chip, 0 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Generic unknown SPI chip (RDID), 0 kB: probe_spi_rdid_generic: id1 0x20, id2 0x2013 Probing for Generic unknown SPI chip (REMS), 0 kB: probe_spi_rems: id1 0xff, id2 0xff === This flash part has status UNTESTED for operations: ERASE WRITE The test status of this chip may have been updated in the latest development version of flashrom. If you are running the latest development version, please email a report to flashrom(a)flashrom.org if any of the above operations work correctly for you with this flash part. Please include the flashrom output with the additional -V option for all operations you tested (-V, -Vr, -Vw, -VE), and mention which mainboard or programmer you tested. Please mention your board in the subject line. Thanks for your help! Reading old flash chip contents... done. Erasing and writing flash chip... Trying erase function 0... 0x000000-0x00ffff:EW, 0x010000-0x01ffff:EW, 0x020000-0x02ffff:EW, 0x030000-0x03ffff:EW, 0x040000-0x04ffff:S, 0x050000-0x05ffff:S, 0x060000-0x06ffff:S, 0x070000-0x07ffff:S Erase/write done. Verifying flash... VERIFIED. +-----------------------------------------------------------------+ | Ir. M.P. van Galen Marijn van Galen (MSc) | | | | Advanced Development Engineer | | Surface Radar - Strategy, Technology & Innovations | | - Advanced Developments | | | | phone : +31 (0)152517 835 mobile : +31 (0)644250887 | |-----------------------------------------------------------------| | Thales Nederland BV, SR - ST&I - Advanced Developments Delft | | Delftechpark 24 - P.O. Box 90, 2600 AB Delft, The Netherlands | |-----------------------------------------------------------------| | Unclassified e-mail | +-----------------------------------------------------------------+ ------------------------------------------------------------------------------------------------------------ Disclaimer: If you are not the intended recipient of this email, please notify the sender and delete it. Any unauthorized copying, disclosure or distribution of this email or its attachment(s) is forbidden. Thales Nederland BV will not accept liability for any damage caused by this email or its attachment(s). Thales Nederland BV is seated in Hengelo and is registered at the Chamber of Commerce under number 06061578. ------------------------------------------------------------------------------------------------------------

2 1

Re: [flashrom] [PATCH] Add logfile support to flashrom
by Carl-Daniel Hailfinger June 6, 2012

June 6, 2012

Am 05.06.2012 23:37 schrieb Idwer Vollering: > 2012/6/3 Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net>: >> New version, all review comments addressed. >> Note: The log file is opened with mode "w", not "wb", and that means >> DOS/Windows/Mac users can open the log file with a text editor and the >> line breaks just work. It will require a bit more work on our side if >> the file is uploaded unmodified, though. >> >> Usage: flashrom --output logfile.txt >> >> Logfile output has at least dbg2 verbosity or screen verbosity, >> whichever is greater. >> >> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> > Tested on Windows and FreeBSD, not tested on DOS. > Acked-by: Idwer Vollering <vidwer(a)gmail.com> Thanks for the test and review! Committed in r1540 with one minor cosmetic fix. Regards, Carl-Daniel -- http://www.hailfinger.org/

1 0

[commit] r1540 - trunk
by repository service June 6, 2012

June 6, 2012

Author: hailfinger Date: Wed Jun 6 11:17:06 2012 New Revision: 1540 URL: http://flashrom.org/trac/flashrom/changeset/1540 Log: Add logfile support to flashrom Usage: flashrom --output logfile.txt Logfile output has at least dbg2 verbosity or screen verbosity, whichever is greater. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Tested on Linux, Windows and FreeBSD. Acked-by: Idwer Vollering <vidwer(a)gmail.com> Modified: trunk/cli_classic.c trunk/cli_output.c trunk/flash.h trunk/flashrom.c Modified: trunk/cli_classic.c ============================================================================== --- trunk/cli_classic.c Mon May 21 01:32:33 2012 (r1539) +++ trunk/cli_classic.c Wed Jun 6 11:17:06 2012 (r1540) @@ -106,7 +106,7 @@ "-z|" #endif "-E|-r <file>|-w <file>|-v <file>]\n" - " [-c <chipname>] [-l <file>]\n" + " [-c <chipname>] [-l <file>] [-o <file>]\n" " [-i <image>] [-p <programmername>[:<parameters>]]\n\n"); printf("Please note that the command line interface for flashrom has " @@ -135,6 +135,7 @@ "<file>\n" " -i | --image <name> only flash image <name> " "from flash layout\n" + " -o | --output <name> log to file <name>\n" " -L | --list-supported print supported devices\n" #if CONFIG_PRINT_WIKI == 1 " -z | --list-supported-wiki print supported devices " @@ -189,7 +190,7 @@ enum programmer prog = PROGRAMMER_INVALID; int ret = 0; - static const char optstring[] = "r:Rw:v:nVEfc:l:i:p:Lzh"; + static const char optstring[] = "r:Rw:v:nVEfc:l:i:p:Lzho:"; static const struct option long_options[] = { {"read", 1, NULL, 'r'}, {"write", 1, NULL, 'w'}, @@ -206,11 +207,13 @@ {"programmer", 1, NULL, 'p'}, {"help", 0, NULL, 'h'}, {"version", 0, NULL, 'R'}, + {"output", 1, NULL, 'o'}, {NULL, 0, NULL, 0}, }; char *filename = NULL; char *layoutfile = NULL; + char *logfile = NULL; char *tempstr = NULL; char *pparam = NULL; @@ -272,7 +275,9 @@ chip_to_probe = strdup(optarg); break; case 'V': - verbose++; + verbose_screen++; + if (verbose_screen > MSG_DEBUG2) + verbose_logfile = verbose_screen; break; case 'E': if (++operation_specified > 1) { @@ -378,6 +383,18 @@ cli_classic_usage(argv[0]); exit(0); break; + case 'o': +#ifdef STANDALONE + fprintf(stderr, "Log file not supported in standalone mode. Aborting.\n"); + cli_classic_abort_usage(); +#else /* STANDALONE */ + logfile = strdup(optarg); + if (logfile[0] == '\0') { + fprintf(stderr, "No log filename specified.\n"); + cli_classic_abort_usage(); + } +#endif /* STANDALONE */ + break; default: cli_classic_abort_usage(); break; @@ -396,6 +413,13 @@ cli_classic_abort_usage(); } +#ifndef STANDALONE + if (logfile && check_filename(logfile, "log")) + cli_classic_abort_usage(); + if (logfile && open_logfile(logfile)) + return 1; +#endif /* !STANDALONE */ + #if CONFIG_PRINT_WIKI == 1 if (list_supported_wiki) { print_supported_wiki(); @@ -410,6 +434,11 @@ goto out; } +#ifndef STANDALONE + start_logging(); +#endif /* !STANDALONE */ + + print_buildinfo(); msg_gdbg("Command line (%i args):", argc - 1); for (i = 0; i < argc; i++) { msg_gdbg(" %s", argv[i]); @@ -552,5 +581,8 @@ out_shutdown: programmer_shutdown(); out: +#ifndef STANDALONE + ret |= close_logfile(); +#endif /* !STANDALONE */ return ret; } Modified: trunk/cli_output.c ============================================================================== --- trunk/cli_output.c Mon May 21 01:32:33 2012 (r1539) +++ trunk/cli_output.c Wed Jun 6 11:17:06 2012 (r1540) @@ -2,6 +2,7 @@ * This file is part of the flashrom project. * * Copyright (C) 2009 Sean Nelson <audiohacked(a)gmail.com> + * Copyright (C) 2011 Carl-Daniel Hailfinger * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -20,8 +21,52 @@ #include <stdio.h> #include <stdarg.h> +#include <string.h> +#include <errno.h> #include "flash.h" +#ifndef STANDALONE +static FILE *logfile = NULL; + +int close_logfile(void) +{ + if (!logfile) + return 0; + /* No need to call fflush() explicitly, fclose() already does that. */ + if (fclose(logfile)) { + /* fclose returned an error. Stop writing to be safe. */ + logfile = NULL; + msg_perr("Closing the log file returned error %s\n", strerror(errno)); + return 1; + } + logfile = NULL; + return 0; +} + +int open_logfile(const char * const filename) +{ + if (!filename) { + msg_gerr("No filename specified.\n"); + return 1; + } + if ((logfile = fopen(filename, "w")) == NULL) { + perror(filename); + return 1; + } + return 0; +} + +void start_logging(void) +{ + enum msglevel oldverbose_screen = verbose_screen; + + /* Shut up the console. */ + verbose_screen = MSG_ERROR; + print_version(); + verbose_screen = oldverbose_screen; +} +#endif /* !STANDALONE */ + /* Please note that level is the verbosity, not the importance of the message. */ int print(enum msglevel level, const char *fmt, ...) { @@ -32,7 +77,7 @@ if (level == MSG_ERROR) output_type = stderr; - if (level <= verbose) { + if (level <= verbose_screen) { va_start(ap, fmt); ret = vfprintf(output_type, fmt, ap); va_end(ap); @@ -42,5 +87,14 @@ if (level != MSG_SPEW) fflush(output_type); } +#ifndef STANDALONE + if ((level <= verbose_logfile) && logfile) { + va_start(ap, fmt); + ret = vfprintf(logfile, fmt, ap); + va_end(ap); + if (level != MSG_SPEW) + fflush(logfile); + } +#endif /* !STANDALONE */ return ret; } Modified: trunk/flash.h ============================================================================== --- trunk/flash.h Mon May 21 01:32:33 2012 (r1539) +++ trunk/flash.h Wed Jun 6 11:17:06 2012 (r1540) @@ -228,7 +228,8 @@ write_gran_1byte, write_gran_256bytes, }; -extern int verbose; +extern int verbose_screen; +extern int verbose_logfile; extern const char flashrom_version[]; extern char *chip_to_probe; void map_flash_registers(struct flashctx *flash); @@ -244,6 +245,7 @@ int need_erase(uint8_t *have, uint8_t *want, unsigned int len, enum write_granularity gran); char *strcat_realloc(char *dest, const char *src); void print_version(void); +void print_buildinfo(void); void print_banner(void); void list_programmers_linebreak(int startcol, int cols, int paren); int selfcheck(void); @@ -268,6 +270,11 @@ #define ERROR_FLASHROM_LIMIT -201 /* cli_output.c */ +#ifndef STANDALONE +int open_logfile(const char * const filename); +int close_logfile(void); +void start_logging(void); +#endif enum msglevel { MSG_ERROR = 0, MSG_INFO = 1, Modified: trunk/flashrom.c ============================================================================== --- trunk/flashrom.c Mon May 21 01:32:33 2012 (r1539) +++ trunk/flashrom.c Wed Jun 6 11:17:06 2012 (r1540) @@ -40,7 +40,8 @@ const char flashrom_version[] = FLASHROM_VERSION; char *chip_to_probe = NULL; -int verbose = MSG_INFO; +int verbose_screen = MSG_INFO; +int verbose_logfile = MSG_DEBUG2; static enum programmer programmer = PROGRAMMER_INVALID; @@ -1493,43 +1494,48 @@ #else msg_ginfo(" on unknown machine"); #endif - msg_ginfo(", built with"); +} + +void print_buildinfo(void) +{ + msg_gdbg("flashrom was built with"); #if NEED_PCI == 1 #ifdef PCILIB_VERSION - msg_ginfo(" libpci %s,", PCILIB_VERSION); + msg_gdbg(" libpci %s,", PCILIB_VERSION); #else - msg_ginfo(" unknown PCI library,"); + msg_gdbg(" unknown PCI library,"); #endif #endif #ifdef __clang__ - msg_ginfo(" LLVM Clang"); + msg_gdbg(" LLVM Clang"); #ifdef __clang_version__ - msg_ginfo(" %s,", __clang_version__); + msg_gdbg(" %s,", __clang_version__); #else - msg_ginfo(" unknown version (before r102686),"); + msg_gdbg(" unknown version (before r102686),"); #endif #elif defined(__GNUC__) - msg_ginfo(" GCC"); + msg_gdbg(" GCC"); #ifdef __VERSION__ - msg_ginfo(" %s,", __VERSION__); + msg_gdbg(" %s,", __VERSION__); #else - msg_ginfo(" unknown version,"); + msg_gdbg(" unknown version,"); #endif #else - msg_ginfo(" unknown compiler,"); + msg_gdbg(" unknown compiler,"); #endif #if defined (__FLASHROM_LITTLE_ENDIAN__) - msg_ginfo(" little endian"); + msg_gdbg(" little endian"); #else - msg_ginfo(" big endian"); + msg_gdbg(" big endian"); #endif - msg_ginfo("\n"); + msg_gdbg("\n"); } void print_version(void) { msg_ginfo("flashrom v%s", flashrom_version); print_sysinfo(); + msg_ginfo("\n"); } void print_banner(void)

1 0

Re: [flashrom] [PATCH] Add logfile support to flashrom
by Carl-Daniel Hailfinger June 5, 2012

June 5, 2012

Am 08.05.2012 19:48 schrieb Idwer Vollering: > 2012/5/3 Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net>: >> I have decided to discard most of the logging code and rewrite it to be >> more readable. It even worked in preliminary tests. >> TODO: >> - Should "-o -" be a no-op which just redirects stderr to stdout? Right >> now "-" is treated as regular file name, but most Unix utilities are >> unable to handle a file with that name (try "less -" for amusement). > Is this a part of your long-term plan? Some people might want all messages (even error messages) to end up on stdout, but the more I think about it, the less I believe supporting - as placeholder for stdout makes sense. One of the biggest problems with that idea is that most messages would appear twice on screen, and that's just stupid. Unless someone objects, I'll remove this point from the TODO list. >> - Add man page entry >> - Is the log level difference for screen/logfile a good thing, and >> should we default the logfile level to dbg2 instead of dbg? >> >> Add log file support to flashrom. >> >> If you use cli_classic, the log file will always contain messages at >> a level which is one higher than the one specified. That way we get >> all verbose messages in the log even if the user doesn't specify -V. > This handles -VV and -VVV too, correct? Yes. If a user specifies -VV, the log file will get -VVV output, but the on-screen info will stay manageable. Not sure how we should handle it when the user specifies -VVV... for now, that would set msglevel to 5 (outside the defined range of the enum, but handled implicitly by the code like msglevel 4). We could make the log file always store logs at least at level -VV (to get all dbg2 output) regardless of whether -V was specified or not, and only if -VV or greater was specified, add 1 to the loglevel. What do you think? >> Convert all printf() after start of logging to msg_*(). >> >> Allow separate control of log level for screen and logfile in case >> other frontends (e.g. GUI, cli_mfg) want that. >> >> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> >> >> Index: flashrom-logfile/flash.h >> =================================================================== >> --- flashrom-logfile/flash.h (Revision 1528) >> +++ flashrom-logfile/flash.h (Arbeitskopie) >> @@ -268,13 +269,20 @@ >> #define ERROR_FLASHROM_LIMIT -201 >> >> /* cli_output.c */ >> +#ifndef STANDALONE >> +int open_logfile(const char * const filename); >> +int close_logfile(void); >> +void start_logging(void); >> +#endif >> /* Let gcc and clang check for correct printf-style format strings. */ >> -int print(int type, const char *fmt, ...) __attribute__((format(printf, 2, 3))); >> -#define MSG_ERROR 0 >> -#define MSG_INFO 1 >> -#define MSG_DEBUG 2 >> -#define MSG_DEBUG2 3 > http://review.coreboot.org/gitweb?p=coreboot.git;a=blob;f=src/include/conso… I think the coreboot loglevels have nice names, but coreboot has too many loglevels for an application like flashrom. > #define MSG_NOTICE 2 > #define MSG_DEBUG 3 > >> -#define MSG_BARF 4 > #define MSG_SPEW 4 BARF->SPEW changed everywhere. >> +enum msglevel { >> + MSG_ERROR = 0, >> + MSG_INFO = 1, >> + MSG_DEBUG = 2, >> + MSG_DEBUG2 = 3, >> + MSG_BARF = 4, >> +}; >> +int print(enum msglevel level, const char *fmt, ...) __attribute__((format(printf, 2, 3))); >> #define msg_gerr(...) print(MSG_ERROR, __VA_ARGS__) /* general errors */ >> #define msg_perr(...) print(MSG_ERROR, __VA_ARGS__) /* programmer errors */ >> #define msg_cerr(...) print(MSG_ERROR, __VA_ARGS__) /* chip errors */ >> Index: flashrom-logfile/cli_output.c >> =================================================================== >> --- flashrom-logfile/cli_output.c (Revision 1528) >> +++ flashrom-logfile/cli_output.c (Arbeitskopie) >> @@ -20,36 +21,80 @@ >> >> #include <stdio.h> >> #include <stdarg.h> >> +#include <string.h> >> +#include <errno.h> >> #include "flash.h" >> >> -int print(int type, const char *fmt, ...) >> +static FILE *logfile = NULL; >> + >> +#ifndef STANDALONE >> +int close_logfile(void) >> { >> + if (logfile && fclose(logfile)) { > No sync() / fsync() ? > From http://linux.die.net/man/3/fclose "Note that fclose() only > flushes the user space buffers provided by the C library. To ensure > that the data is physically stored on disk the kernel buffers must be > flushed too, for example, with sync(2) or fsync(2)." Good point, will do. I'll probably have to change the file open mode as well... Uwe mentioned that "wb" is needed for Windows to behave sanely. >> + /* fclose returned an error. Stop writing to be safe. */ >> + logfile = NULL; >> + msg_perr("Closing the log file returned error %s\n", >> + strerror(errno)); >> + return 1; >> + } >> + logfile = NULL; >> + return 0; >> +} >> + >> Index: flashrom-logfile/cli_classic.c >> =================================================================== >> --- flashrom-logfile/cli_classic.c (Revision 1528) >> +++ flashrom-logfile/cli_classic.c (Arbeitskopie) >> @@ -377,20 +394,40 @@ >> cli_classic_abort_usage(); >> } >> >> - /* FIXME: Print the actions flashrom will take. */ >> - >> - if (list_supported) { >> - print_supported(); >> - exit(0); >> + if ((read_it | write_it | verify_it) && !filename) { >> + fprintf(stderr, "Error: No filename specified.\n"); > "No log filename specified.\n" ? No, if anything, it should be "No image filename specified". Thoughts? >> + cli_classic_abort_usage(); >> } >> + if (filename && (filename[0] == '\0')) { >> + fprintf(stderr, "Error: No filename specified.\n"); > dito dito. >> + cli_classic_abort_usage(); >> + } >> + if (filename && (filename[0] == '-')) >> + fprintf(stderr, "Warning: Supplied file name starts with -\n"); >> >> +#ifndef STANDALONE >> + if (log_name && (log_name[0] == '-')) >> + fprintf(stderr, "Warning: Supplied file name starts with -\n"); >> + if (log_name && open_logfile(log_name)) > WARNING or Warning? Maybe add a line that says that this will change > in the future? I'd say "Warning" it totally OK... it's an indicator that the user did something unintended, but it's not an error per se. >> + return 1; >> +#endif /* !STANDALONE */ >> + >> Regards, Carl-Daniel -- http://www.hailfinger.org/

3 7

Re: [flashrom] external programmer
by Bicks Factory June 1, 2012

June 1, 2012

http://wildbagger.com/wordpress/tag/p5b/ This is the website that explains my problem and why it should be a sst chip. Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> wrote: On Thu, 31 May 2012 22:00:28 -0400 Bicks Factory <newforest333(a)hotmail.ca> wrote: > Found Macronix flash chip "MX25L8005" (1024 kB, SPI). > No operations were specified. > > > So it seems to find a flash chip. Unfortunately this is the flash chip of the board being flashed from. The chip it is supposed to see is. > SST SST25VF080B, 1024 kB: probe_spi_rdid_generic: id1 0xc2, id2 0x2014 how did you come to the conclusion that the chip is a SST SST25VF080B and not a Macronix MX25L8005? -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

Re: [flashrom] external programmer
by Bicks Factory June 1, 2012

June 1, 2012

Hey thanks for taking time to help out. So I went and got a copy of debian os to try. I installed it but had too many problems with network cards not being detected and getting root privlages etc. That was a waste of a cd. So I went to ubuntu 12.04. Installed on hard drive and couldnt get flashrom to install at all. Changed the server location were ubuntu was looking for flashrom from CAN site to default server. Worked. So now I have ubuntu installed with flashrom. I checked and libftdi is installed aswell. Unfortunately I get the same problem. Cant detect/see my external programmer. I am hoping someone that has got this thing to work can add some usefull instructions on how they got this to work. Thanks again. I hope Im responding in the right manner. Not sure if this is going to a personal email or if this is going to the mailing list. Sent From Android Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> wrote: On Thu, 24 May 2012 22:04:50 -0400 Bicks Factory <newforest333(a)hotmail.ca> wrote: > > > Trying to use an external programmer, specifically the > TIAO/DIYGADGET USB Multi-Protocol Adapter (TUMPA). > Running from a live cd of parted magic. Using flashrom v0.9.5.2-r1515. > Run command: flashrom -p ft2232_spi:type=tumpa > get back: unknown programmer ft2232_spi:type=tumpa. > Motherboard is a MSI G41M-F. > Flashrom can see the flash chip on the board. Intel ich7 > Not really used to using command prompt or linux. > I'm assuming I'm missing some usb drivers. > > > Any help would be greatly appreciated. hello! that's not your fault (and admittedly the error message could be a bit better). the problem seems to be that flashrom was compiled without support for the ft2232_spi programmer in parted magic to safe space. so you need to get another live cd or build flashrom yourself (not really recommended when you dont know linux and the command line :) i am not aware of any live cd that ships a full build of flashrom (i was not aware yet, that they actually strip them down. it is not the default to do so, so they did it on consciously). the livecds of the bigger distributions such as ubuntu should be able to install packages after boot, which is necessary because flashrom is not added to the cds themselves and they should be the complete version. this requires either internet access after boot or some manual preparation though... hth -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

2 3