flashrom July 2011

flashrom@flashrom.org

50 participants
275 discussions

[PATCH 0/4] AT25F* 2.0
by Stefan Tauner 29 Jul '11

29 Jul '11

I have rebased and improved my previous patch set according to the review from carl-daniel. debatable and/or remarkable bits: 1/4 changes the output and name of spi_prettyprint_status_register_bp3210 2/4 none, i hope 3/4 location of the code. could be moved to at25.c, but i don't see a reason to do so. 4/4 - handling of ATMEL_AT25F512 and ATMEL_AT25F512A: they are evil twins with different page sizes but same id (guessed id, none in datasheet). the current implementation will ask the user which version he has. dunno if that's necessary... also page_size will die soon-ish... - location and naming of AT25F_RDID macros Stefan Tauner (4): clean up a25.c, at25.c, spi25.c rename AT25F512B-specific code add spi_block_erase_62 Add support for Atmel's AT25F series of SPI flash chips. a25.c | 8 ++-- at25.c | 132 +++++++++++++++++++++++++++++++++++++++++++++++--------- chipdrivers.h | 6 ++- flashchips.c | 94 ++++++++++++++++++++++++++++++++++++++++ flashchips.h | 10 ++--- spi.h | 14 ++++-- spi25.c | 62 ++++++++++++++++++++++++--- 7 files changed, 283 insertions(+), 43 deletions(-)

1 0

Re: [flashrom] [PATCH 3/8] generify spi_rdid to allow passing different opcodes. This is needed to add support for Atmel's AT25F series.
by Carl-Daniel Hailfinger 29 Jul '11

29 Jul '11

Am 15.03.2011 16:29 schrieb Stefan Tauner: > Signed-off-by: Stefan Tauner<stefan.tauner(a)student.tuwien.ac.at> > Not sure about this one. We also have separate functions for each erase command. I'll let others comment. Regards, Carl-Daniel > --- > spi25.c | 24 ++++++++++++------------ > 1 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/spi25.c b/spi25.c > index 5d73411..c4cd6b2 100644 > --- a/spi25.c > +++ b/spi25.c > @@ -31,17 +31,17 @@ > > void spi_prettyprint_status_register(struct flashchip *flash); > > -static int spi_rdid(unsigned char *readarr, int bytes) > +static int spi_rdid(unsigned char *readarr, int bytes_in, unsigned char rdid_opcode) > { > - static const unsigned char cmd[JEDEC_RDID_OUTSIZE] = { JEDEC_RDID }; > + unsigned char cmd[] = { rdid_opcode }; > int ret; > int i; > > - ret = spi_send_command(sizeof(cmd), bytes, cmd, readarr); > + ret = spi_send_command(sizeof(cmd), bytes_in, cmd, readarr); > if (ret) > return ret; > msg_cspew("RDID returned"); > - for (i = 0; i< bytes; i++) > + for (i = 0; i< bytes_in; i++) > msg_cspew(" 0x%02x", readarr[i]); > msg_cspew(". "); > return 0; > @@ -115,13 +115,13 @@ int spi_write_disable(void) > return spi_send_command(sizeof(cmd), 0, cmd, NULL); > } > > -static int probe_spi_rdid_generic(struct flashchip *flash, int bytes) > +static int probe_spi_rdid_generic(struct flashchip *flash, int bytes_in, unsigned char rdid_opcode) > { > - unsigned char readarr[4]; > + unsigned char readarr[bytes_in]; > uint32_t id1; > uint32_t id2; > > - if (spi_rdid(readarr, bytes)) > + if (spi_rdid(readarr, bytes_in, rdid_opcode)) > return 0; > > if (!oddparity(readarr[0])) > @@ -135,7 +135,7 @@ static int probe_spi_rdid_generic(struct flashchip *flash, int bytes) > msg_cdbg("RDID byte 1 parity violation. "); > id1 = (readarr[0]<< 8) | readarr[1]; > id2 = readarr[2]; > - if (bytes> 3) { > + if (bytes_in> 3) { > id2<<= 8; > id2 |= readarr[3]; > } > @@ -170,7 +170,7 @@ static int probe_spi_rdid_generic(struct flashchip *flash, int bytes) > > int probe_spi_rdid(struct flashchip *flash) > { > - return probe_spi_rdid_generic(flash, 3); > + return probe_spi_rdid_generic(flash, JEDEC_RDID_INSIZE, JEDEC_RDID); > } > > int probe_spi_rdid4(struct flashchip *flash) > @@ -189,7 +189,7 @@ int probe_spi_rdid4(struct flashchip *flash) > #endif > #endif > default: > - return probe_spi_rdid_generic(flash, 4); > + return probe_spi_rdid_generic(flash, 4, JEDEC_RDID); > } > > return 0; > @@ -242,8 +242,8 @@ int probe_spi_res1(struct flashchip *flash) > /* Check if RDID is usable and does not return 0xff 0xff 0xff or > * 0x00 0x00 0x00. In that case, RES is pointless. > */ > - if (!spi_rdid(readarr, 3)&& memcmp(readarr, allff, 3)&& > - memcmp(readarr, all00, 3)) { > + if (!spi_rdid(readarr, JEDEC_RDID_INSIZE, JEDEC_RDID)&& memcmp(readarr, allff, 3)&& > + memcmp(readarr, all00, JEDEC_RDID_INSIZE)) { > msg_cdbg("Ignoring RES in favour of RDID.\n"); > return 0; > } > -- http://www.hailfinger.org/

2 1

[PATCH] Make flashrom build on PPC/PowerPC with just "make"
by Uwe Hermann 29 Jul '11

29 Jul '11

Hi, see patch. This complements the recent ppc patch to make builds simpler. Uwe. -- http://hermann-uwe.de | http://sigrok.org http://randomprojects.org | http://unmaintained-free-software.org

2 2

[commit] r1400 - trunk
by repository service 29 Jul '11

29 Jul '11

Author: uwe Date: Fri Jul 29 14:13:01 2011 New Revision: 1400 URL: http://flashrom.org/trac/flashrom/changeset/1400 Log: Make flashrom build on PPC/PowerPC with just "make". Build-tested in a QEMU ppc (Debian) image, and by Andrew Morgan <ziltro(a)ziltro.com> on real hardware. Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Andrew Morgan <ziltro(a)ziltro.com> Modified: trunk/Makefile Modified: trunk/Makefile ============================================================================== --- trunk/Makefile Fri Jul 29 14:06:04 2011 (r1399) +++ trunk/Makefile Fri Jul 29 14:13:01 2011 (r1400) @@ -202,6 +202,40 @@ endif endif +ifeq ($(ARCH), "ppc") +# There's no PCI port I/O support on PPC/PowerPC, yet. +ifeq ($(CONFIG_NIC3COM), yes) +UNSUPPORTED_FEATURES += CONFIG_NIC3COM=yes +else +override CONFIG_NIC3COM = no +endif +ifeq ($(CONFIG_NICREALTEK), yes) +UNSUPPORTED_FEATURES += CONFIG_NICREALTEK=yes +else +override CONFIG_NICREALTEK = no +endif +ifeq ($(CONFIG_NICNATSEMI), yes) +UNSUPPORTED_FEATURES += CONFIG_NICNATSEMI=yes +else +override CONFIG_NICNATSEMI = no +endif +ifeq ($(CONFIG_RAYER_SPI), yes) +UNSUPPORTED_FEATURES += CONFIG_RAYER_SPI=yes +else +override CONFIG_RAYER_SPI = no +endif +ifeq ($(CONFIG_ATAHPT), yes) +UNSUPPORTED_FEATURES += CONFIG_ATAHPT=yes +else +override CONFIG_ATAHPT = no +endif +ifeq ($(CONFIG_SATAMV), yes) +UNSUPPORTED_FEATURES += CONFIG_SATAMV=yes +else +override CONFIG_SATAMV = no +endif +endif + CHIP_OBJS = jedec.o stm50flw0x0x.o w39.o w29ee011.o \ sst28sf040.o m29f400bt.o 82802ab.o pm49fl00x.o \ sst49lfxxxc.o sst_fwhub.o flashchips.o spi.o spi25.o sharplhf00l04.o \

1 0

[commit] r1399 - trunk
by repository service 29 Jul '11

29 Jul '11

Author: stefanct Date: Fri Jul 29 14:06:04 2011 New Revision: 1399 URL: http://flashrom.org/trac/flashrom/changeset/1399 Log: extract spi_prettyprint_status_register_amic_a25_srwd extract spi_prettyprint_status_register_amic_a25_srwd from spi_prettyprint_status_register_amic_a25l* functions Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/a25.c Modified: trunk/a25.c ============================================================================== --- trunk/a25.c Thu Jul 28 21:23:09 2011 (r1398) +++ trunk/a25.c Fri Jul 29 14:06:04 2011 (r1399) @@ -23,6 +23,12 @@ /* Prettyprint the status register. Works for AMIC A25L series. */ +static void spi_prettyprint_status_register_amic_a25_srwd(uint8_t status) +{ + msg_cdbg("Chip status register: Status Register Write Disable " + "(SRWD) is %sset\n", (status & (1 << 7)) ? "" : "not "); +} + int spi_prettyprint_status_register_amic_a25l05p(struct flashchip *flash) { uint8_t status; @@ -30,8 +36,7 @@ status = spi_read_status_register(); msg_cdbg("Chip status register is %02x\n", status); - msg_cdbg("Chip status register: Status Register Write Disable " - "(SRWD) is %sset\n", (status & (1 << 7)) ? "" : "not "); + spi_prettyprint_status_register_amic_a25_srwd(status); spi_prettyprint_status_register_bit(status, 6); spi_prettyprint_status_register_bit(status, 5); spi_prettyprint_status_register_bit(status, 4); @@ -47,8 +52,7 @@ status = spi_read_status_register(); msg_cdbg("Chip status register is %02x\n", status); - msg_cdbg("Chip status register: Status Register Write Disable " - "(SRWD) is %sset\n", (status & (1 << 7)) ? "" : "not "); + spi_prettyprint_status_register_amic_a25_srwd(status); spi_prettyprint_status_register_bit(status, 6); spi_prettyprint_status_register_bit(status, 5); spi_prettyprint_status_register_bp3210(status, 2); @@ -63,8 +67,7 @@ status = spi_read_status_register(); msg_cdbg("Chip status register is %02x\n", status); - msg_cdbg("Chip status register: Status Register Write Disable " - "(SRWD) is %sset\n", (status & (1 << 7)) ? "" : "not "); + spi_prettyprint_status_register_amic_a25_srwd(status); msg_cdbg("Chip status register: Sector Protect Size (SEC) " "is %i KB\n", (status & (1 << 6)) ? 4 : 64); msg_cdbg("Chip status register: Top/Bottom (TB) " @@ -82,8 +85,7 @@ status = spi_read_status_register(); msg_cdbg("Chip status register is %02x\n", status); - msg_cdbg("Chip status register: Status Register Write Disable " - "(SRWD) is %sset\n", (status & (1 << 7)) ? "" : "not "); + spi_prettyprint_status_register_amic_a25_srwd(status); msg_cdbg("Chip status register: Sector Protect Size (SEC) " "is %i KB\n", (status & (1 << 6)) ? 4 : 64); msg_cdbg("Chip status register: Top/Bottom (TB) "

1 0

Re: [flashrom] [PATCH] extract spi_prettyprint_status_register_amic_a25_srwd from spi_prettyprint_status_register_amic_a25l* functions
by Carl-Daniel Hailfinger 29 Jul '11

29 Jul '11

Am 19.05.2011 16:29 schrieb Stefan Tauner: > Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> > Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Regards, Carl-Daniel -- http://www.hailfinger.org/

2 1

Re: [flashrom] SB700 - register to avoid issue due to IMC
by Carl-Daniel Hailfinger 29 Jul '11

29 Jul '11

Hi Frederic, I had a patch for SB700 IMC arbitration. Unfortunately it did not work: http://patchwork.coreboot.org/patch/1768/ IIRC my old patch uses BiosSemaphore, but maybe HostOwnLPC works better? You could modify my old patch to use HostOwnLPC, and test if that fixes the issue. The biggest problem is that BiosSemaphore only protects against write, but we have to protect against read as well because it uses the same internal registers in the chipset. Regards, Carl-Daniel -- http://www.hailfinger.org/

1 0

Re: [flashrom] My BIOS is unsupported/untested
by Stefan Tauner 28 Jul '11

28 Jul '11

On Thu, 28 Jul 2011 21:32:09 +0300 "Amr H. El-Sharnoby" <amr.el.sharnoby(a)gmail.com> wrote: > By the way, > After the upgrade the LAN stopped working. > hello amr, have you tried to upgrade your BIOS with flashrom? your mentioning of "the upgrade" seems to indicate so, but there was no log of writing in your mails... if so, did flashrom indicate any errors while writing? what (BIOS) file did you use? did you reboot after that? (if not, then please don't reboot yet, until we have figured out your situation) what do you mean exactly with "LAN stopped working"? i guess you are using linux. does lspci still show the lan controller? please explain more clearly what you have done and what happened. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

2 1

Re: [flashrom] My BIOS is unsupported/untested
by Bernd Blaauw 28 Jul '11

28 Jul '11

Op 28-7-2011 20:32, Amr H. El-Sharnoby schreef: > By the way, > After the upgrade the LAN stopped working. Hi Amr, you've posted a read log in both normal and verbose modes. Unfortunately not the write log, but all bits help. Did you write a different BIOS to EEPROM? Or simply wrote "bios.old" to EEPROM? Did your network card/chip stop working directly (in Linux?) after writing this BIOS? Or after reboot? I guess the network chip's hardware address (MAC-address) changed or was erased due to the firmware flashing, instead of being kept intact? I don't know if Flashrom can recognise and/or handle MAC-addresses in a safe way. > ./flashrom -r bios.old > flashrom v0.9.4-r1397 on Linux 2.6.39-3.dmz.2-liquorix-amd64 > root@station3:~/flashrom# ./flashrom -V -r bios.old > flashrom v0.9.4-r1397 on Linux 2.6.39-3.dmz.2-liquorix-amd64 > Reading flash... done. > Restoring MMIO space at 0x7f0a081a78a0 > Restoring MMIO space at 0x7f0a081a789c > Restoring MMIO space at 0x7f0a081a7898 > Restoring MMIO space at 0x7f0a081a7896 > Restoring MMIO space at 0x7f0a081a7894

1 0

[commit] r1398 - trunk
by repository service 28 Jul '11

28 Jul '11

Author: uwe Date: Thu Jul 28 21:23:09 2011 New Revision: 1398 URL: http://flashrom.org/trac/flashrom/changeset/1398 Log: manpage: Document all ft2232_spi and serprog variants. Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/flashrom.8 Modified: trunk/flashrom.8 ============================================================================== --- trunk/flashrom.8 Thu Jul 28 10:13:25 2011 (r1397) +++ trunk/flashrom.8 Thu Jul 28 21:23:09 2011 (r1398) @@ -183,8 +183,7 @@ .BR "* nicnatsemi" " (for flash ROMs on National Semiconductor DP838* network \ cards)" .sp -.BR "* nicintel" " (for parallel flash ROMs attached to Intel 10/100Mbit \ -network cards) +.BR "* nicintel" " (for parallel flash ROMs on Intel 10/100Mbit network cards) .sp .BR "* gfxnvidia" " (for flash ROMs on NVIDIA graphics cards)" .sp @@ -197,9 +196,15 @@ .BR "* atahpt" " (for flash ROMs on Highpoint ATA/RAID controllers)" .sp .BR "* ft2232_spi" " (for SPI flash ROMs attached to an FT2232/FT4232H family \ -based USB SPI programmer)" -.sp -.BR "* serprog" " (for flash ROMs attached to a programmer speaking serprog)" +based USB SPI programmer), including the DLP Design DLP-USB1232H, \ +FTDI FT2232H Mini-Module, FTDI FT4232H Mini-Module, openbiosprog-spi, Amontec \ +JTAGkey/JTAGkey-tiny/JTAGkey-2, Olimex ARM-USB-TINY/-H, and Olimex \ +ARM-USB-OCD/-H." +.sp +.BR "* serprog" " (for flash ROMs attached to a programmer speaking serprog), \ +including AVR flasher by Urja Rannikko, AVR flasher by eightdot, \ +Arduino Mega flasher by fritz, InSystemFlasher by Juhana Helovuo, and \ +atmegaXXu2-flasher by Stefan Tauner." .sp .BR "* buspirate_spi" " (for SPI flash ROMs attached to a Bus Pirate)" .sp @@ -208,11 +213,9 @@ .BR "* rayer_spi" " (for SPI flash ROMs attached to a RayeR parport \ based programmer)" .sp -.BR "* nicintel_spi" " (for SPI flash ROMs attached to an Intel Gigabit \ -network cards)" +.BR "* nicintel_spi" " (for SPI flash ROMs on Intel Gigabit network cards)" .sp -.BR "* ogp_spi" " (for SPI flash ROMs attached to an Open Graphics Project \ -graphics card)" +.BR "* ogp_spi" " (for SPI flash ROMs on Open Graphics Project graphics card)" .sp Some programmers have optional or mandatory parameters which are described in detail in the

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
28
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom July 2011