flashrom August 2009

flashrom@flashrom.org

28 participants
124 discussions

ICH6-ICH10 flash decode debug, IDSEL=0 hardcode
by Carl-Daniel Hailfinger 07 Aug '09

07 Aug '09

Add ICH6,ICH7,ICH8,ICH9,ICH10 FWH IDSEL settings and flash decode settings to the debug output. This can help debug cases where the BIOS does not set up a correct flash decode for the given flash size. The Intel docs state that the decode applies to FWH and SPI flash. Hardcode IDSEL=0 for the top 8 MB for now. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: flashrom-ich6_fwh_idsel_debug/chipset_enable.c =================================================================== --- flashrom-ich6_fwh_idsel_debug/chipset_enable.c (Revision 670) +++ flashrom-ich6_fwh_idsel_debug/chipset_enable.c (Arbeitskopie) @@ -192,11 +192,45 @@ static int enable_flash_ich_4e(struct pci_dev *dev, const char *name) { + /* + * Note: ICH5 has registers similar to FWH_SEL1, FWH_SEL2 and + * FWH_DEC_EN1, but they are called FB_SEL1, FB_SEL2, FB_DEC_EN1 and + * FB_DEC_EN2. + */ return enable_flash_ich(dev, name, 0x4e); } static int enable_flash_ich_dc(struct pci_dev *dev, const char *name) { + uint32_t fwh_conf; + int i; + + /* Ignore all legacy ranges below 1 MB. */ + /* FWH_SEL1 */ + fwh_conf = pci_read_long(dev, 0xd0); + for (i = 7; i >= 0; i--) + printf_debug("\n0xff%02x0000/0xff%02x0000 FWH IDSEL: 0x%x, ", + i * 0x8 + 0xc0, i * 0x8 + 0x80, + (fwh_conf >> (i * 4)) & 0xf); + /* FWH_SEL2 */ + fwh_conf = pci_read_word(dev, 0xd4); + for (i = 3; i >= 0; i--) + printf_debug("\n0xff%02x0000/0xff%02x0000 FWH IDSEL: 0x%x, ", + i * 0x10 + 0x40, i * 0x10, + (fwh_conf >> (i * 4)) & 0xf); + /* FWH_DEC_EN1 */ + fwh_conf = pci_read_word(dev, 0xd8); + for (i = 7; i >= 0; i--) + printf_debug("0xff%02x0000/0xff%02x0000 FWH decode %sabled, ", + i * 0x8 + 0xc0, i * 0x8 + 0x80, + (fwh_conf >> (i + 0x8)) & 0x1 ? "en" : "dis"); + for (i = 3; i >= 0; i--) + printf_debug("0xff%02x0000/0xff%02x0000 FWH decode %sabled, ", + i * 0x10 + 0x40, i * 0x10, + (fwh_conf >> i) & 0x1 ? "en" : "dis"); + /* Gross unmergeable hack to pick IDSEL=0 for top 8 MB */ + printf("\nSetting IDSEL=0 for top 8 MB"); + pci_write_word(dev, 0xd0, 0x00000000); return enable_flash_ich(dev, name, 0xdc); } -- http://www.hailfinger.org/

3 3

SPIPGM bug for SST25*
by Carl-Daniel Hailfinger 05 Aug '09

05 Aug '09

Hi RayeR, I found that SST25 flash only allows one-byte write and no page write. But it uses the normal page write opcode. To fix this, SPI_FLASH_PAGE_SIZE must be 1 instead of 256 for SST25 family. Regards, Carl-Daniel

1 0

[PATCH] Fix SPI multicommand endless loop
by Carl-Daniel Hailfinger 03 Aug '09

03 Aug '09

Fix SPI multicommand endless loop in default_spi_send_multicommand. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: flashrom-spi_multicommand_loopfix/spi.c =================================================================== --- flashrom-spi_multicommand_loopfix/spi.c (Revision 669) +++ flashrom-spi_multicommand_loopfix/spi.c (Arbeitskopie) @@ -147,6 +147,7 @@ while ((spicommands->writecnt || spicommands->readcnt) && !result) { result = spi_send_command(spicommands->writecnt, spicommands->readcnt, spicommands->writearr, spicommands->readarr); + spicommands++; } return result; } -- http://www.hailfinger.org/

2 2

[commit] r670 - trunk
by svn＠flashrom.org 03 Aug '09

03 Aug '09

Author: hailfinger Date: 2009-08-03 11:35:20 +0200 (Mon, 03 Aug 2009) New Revision: 670 Modified: trunk/spi.c Log: Fix SPI multicommand endless loop in default_spi_send_multicommand. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: trunk/spi.c =================================================================== --- trunk/spi.c 2009-07-30 13:32:26 UTC (rev 669) +++ trunk/spi.c 2009-08-03 09:35:20 UTC (rev 670) @@ -147,6 +147,7 @@ while ((spicommands->writecnt || spicommands->readcnt) && !result) { result = spi_send_command(spicommands->writecnt, spicommands->readcnt, spicommands->writearr, spicommands->readarr); + spicommands++; } return result; }

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom August 2009