Re: [OpenBIOS] [PATCH 3/3] Add initial implementation of "dir" word for HFS+ filesystems.

[Programmingkid]

On Sep 20, 2012, at 1:32 PM, [e-mail] wrote:
> Message: 4
> Date: Tue, 18 Sep 2012 16:31:40 +0100
> From: Mark Cave-Ayland 
> To: [e-mail]
> Cc: Mark Cave-Ayland 
> Subject: [OpenBIOS] [PATCH 3/3] Add initial implementation of "dir"
>    word for	HFS+ filesystems.
> Message-ID:
> Signed-off-by: Mark Cave-Ayland
>
> openbios-devel/fs/hfsplus/hfsp_fs.c |  140 ++++++++++++++++++++++++++++++++++-
> 1 file changed, 136 insertions(+), 4 deletions(-)
>
> diff --git a/openbios-devel/fs/hfsplus/hfsp_fs.c b/openbios-devel/fs/hfsplus/hfsp_fs.c
> index 83e4d8d..4cc6ddc 100644
> --- a/openbios-devel/fs/hfsplus/hfsp_fs.c
> +++ b/openbios-devel/fs/hfsplus/hfsp_fs.c
> @@ -437,14 +437,146 @@ hfsp_files_volume_name( hfsp_info_t *mi )
>    PUSH(pointer2cell(volname));

From the output you shown us, it looks like the patch works. Those were the files that were on the image file I sent you. I wanted to test it out myself but I couldn't apply your patch. Probably something I did wrong. I suggest applying the patches. They look good.

[PATCH 3/3] Add initial implementation of "dir" word for HFS+ filesystems.

[Mark Cave-Ayland]

On 23/09/12 22:01, Programmingkid wrote:
> From the output you shown us, it looks like the patch works. Those were
> the files that were on the image file I sent you. I wanted to test it
> out myself but I couldn't apply your patch. Probably something I did
> wrong. I suggest applying the patches. They look good.

Okay. I'll wait a few more days in case anyone else has any comment, and 
commit them if no-one objects (Alex? Andreas?).

ATB,

Mark.