Re: [OpenBIOS] new world (qemu -mac99), double nvram entry

[Mark Cave-Ayland]

On 28/01/13 11:35, Amadeusz Sławiński wrote:
> When looking at qemu -mac99 I noticed that there are two nvram entries in openbios:
>
> The first one (nvram@fff04000) has initialized .properties while the
> other one has words.
>
> 0>  dev / ls
> ...
> fff75e24 pci@f2000000
> fff77848 nvram@fff04000
> fff778e0 nvram
>   ok
> 0>  dev /nvram@fff04000  ok
> 0>  words
>   ok
> 0>  .properties
> name                      "nvram"
> #bytes                    2000
> reg                       fff04000   00004000
> device_type               "nvram"
> compatible                "nvram,flash"
>   ok
> 0>  dev /nvram@0  ok
> 0>  words close open seek write read size
>   ok
> 0>  .properties
> name                      "nvram"
>   ok
>
> Attached patch fixes initialization, so only one node is created
> containing both .properties and words.
>
> 0>  dev / ls
> ...
> fff75e24 pci@f2000000
> fff77868 nvram@fff04000
>   ok
> 0>  dev /nvram@fff04000  ok
> 0>  words close open seek write read size
>   ok
> 0>  .properties
> name                      "nvram"
> #bytes                    2000
> reg                       fff04000   00004000
> device_type               "nvram"
> compatible                "nvram,flash"
>   ok
>
> Signed-off-by: Amadeusz Sławiński

This patch looks good to me. Can you resubmit with a comment in exactly 
the same style as the existing entries in "git log" and then I can apply it?

Many thanks,

Mark.