[OpenBIOS] Re: [PATCH v3] Limit binary dump bytes in .properties output

[BALATON Zoltan]

On Sun, 18 Sep 2022, Mark Cave-Ayland wrote:
> On 11/09/2022 15:01, BALATON Zoltan wrote:
> > Some device trees can contain large chunks of binary data that result
> > in .properties output to get lost in the dump of all binary bytes. Put
> > an upper limit of the bytes dumped.
> > Signed-off-by: BALATON Zoltan
> >
> > forth/admin/devices.fs | 7 ++++---
> >   1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/forth/admin/devices.fs b/forth/admin/devices.fs
> > index 38f6ad6..879c271 100644
> > --- a/forth/admin/devices.fs
> > +++ b/forth/admin/devices.fs
> > @@ -307,15 +307,16 @@
> >     : .p-bytes? ( data len -- 1 | data len 0 )
> >     ." -- " dup . ." : "
> > swap >r 0
> > swap >r dup 100 min 0
> >  begin 2dup > while
> >    dup r@ + c@
> >    ( len n ch )
> >      2 0.r space
> >    1+
> > repeat
> > 2drop r> drop 1
> > repeat
> > drop > if ." ..." then
> > r> drop 1
> > ;
> >  \ this function tries to heuristically determine the data format
>
> I've given v3 a quick test and it looks good to me when browsing the QEMU,VGA 
> node, so I'll queue this for master.

Ping?
> ATB,
>
> Mark.