[PATCH v3] Limit binary dump bytes in .properties output
Some device trees can contain large chunks of binary data that result in .properties output to get lost in the dump of all binary bytes. Put an upper limit of the bytes dumped. Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu> --- forth/admin/devices.fs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/forth/admin/devices.fs b/forth/admin/devices.fs index 38f6ad6..879c271 100644 --- a/forth/admin/devices.fs +++ b/forth/admin/devices.fs @@ -307,15 +307,16 @@ : .p-bytes? ( data len -- 1 | data len 0 ) ." -- " dup . ." : " - swap >r 0 + swap >r dup 100 min 0 begin 2dup > while dup r@ + c@ ( len n ch ) 2 0.r space 1+ - repeat - 2drop r> drop 1 + repeat + drop > if ." ..." then + r> drop 1 ; \ this function tries to heuristically determine the data format -- 2.30.4
On 11/09/2022 15:01, BALATON Zoltan wrote:
Some device trees can contain large chunks of binary data that result in .properties output to get lost in the dump of all binary bytes. Put an upper limit of the bytes dumped.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu> --- forth/admin/devices.fs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/forth/admin/devices.fs b/forth/admin/devices.fs index 38f6ad6..879c271 100644 --- a/forth/admin/devices.fs +++ b/forth/admin/devices.fs @@ -307,15 +307,16 @@
: .p-bytes? ( data len -- 1 | data len 0 ) ." -- " dup . ." : " - swap >r 0 + swap >r dup 100 min 0 begin 2dup > while dup r@ + c@ ( len n ch )
2 0.r space 1+ - repeat - 2drop r> drop 1 + repeat + drop > if ." ..." then + r> drop 1 ;
\ this function tries to heuristically determine the data format
I've given v3 a quick test and it looks good to me when browsing the QEMU,VGA node, so I'll queue this for master. ATB, Mark.
On Sun, 18 Sep 2022, Mark Cave-Ayland wrote:
On 11/09/2022 15:01, BALATON Zoltan wrote:
Some device trees can contain large chunks of binary data that result in .properties output to get lost in the dump of all binary bytes. Put an upper limit of the bytes dumped.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu> --- forth/admin/devices.fs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/forth/admin/devices.fs b/forth/admin/devices.fs index 38f6ad6..879c271 100644 --- a/forth/admin/devices.fs +++ b/forth/admin/devices.fs @@ -307,15 +307,16 @@ : .p-bytes? ( data len -- 1 | data len 0 ) ." -- " dup . ." : " - swap >r 0 + swap >r dup 100 min 0 begin 2dup > while dup r@ + c@ ( len n ch ) 2 0.r space 1+ - repeat - 2drop r> drop 1 + repeat + drop > if ." ..." then + r> drop 1 ; \ this function tries to heuristically determine the data format
I've given v3 a quick test and it looks good to me when browsing the QEMU,VGA node, so I'll queue this for master.
Ping?
ATB,
Mark.
On 13/01/2023 21:26, BALATON Zoltan wrote:
On Sun, 18 Sep 2022, Mark Cave-Ayland wrote:
On 11/09/2022 15:01, BALATON Zoltan wrote:
Some device trees can contain large chunks of binary data that result in .properties output to get lost in the dump of all binary bytes. Put an upper limit of the bytes dumped.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu> --- forth/admin/devices.fs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/forth/admin/devices.fs b/forth/admin/devices.fs index 38f6ad6..879c271 100644 --- a/forth/admin/devices.fs +++ b/forth/admin/devices.fs @@ -307,15 +307,16 @@ : .p-bytes? ( data len -- 1 | data len 0 ) ." -- " dup . ." : " - swap >r 0 + swap >r dup 100 min 0 begin 2dup > while dup r@ + c@ ( len n ch ) 2 0.r space 1+ - repeat - 2drop r> drop 1 + repeat + drop > if ." ..." then + r> drop 1 ; \ this function tries to heuristically determine the data format
I've given v3 a quick test and it looks good to me when browsing the QEMU,VGA node, so I'll queue this for master.
Ping?
Ooops sorry - I'd applied this to my local master, but not pushed the branch to github. It should now be there. ATB, Mark.
On Thu, 26 Jan 2023, Mark Cave-Ayland wrote:
On 13/01/2023 21:26, BALATON Zoltan wrote:
On Sun, 18 Sep 2022, Mark Cave-Ayland wrote:
On 11/09/2022 15:01, BALATON Zoltan wrote:
Some device trees can contain large chunks of binary data that result in .properties output to get lost in the dump of all binary bytes. Put an upper limit of the bytes dumped.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu> --- forth/admin/devices.fs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/forth/admin/devices.fs b/forth/admin/devices.fs index 38f6ad6..879c271 100644 --- a/forth/admin/devices.fs +++ b/forth/admin/devices.fs @@ -307,15 +307,16 @@ : .p-bytes? ( data len -- 1 | data len 0 ) ." -- " dup . ." : " - swap >r 0 + swap >r dup 100 min 0 begin 2dup > while dup r@ + c@ ( len n ch ) 2 0.r space 1+ - repeat - 2drop r> drop 1 + repeat + drop > if ." ..." then + r> drop 1 ; \ this function tries to heuristically determine the data format
I've given v3 a quick test and it looks good to me when browsing the QEMU,VGA node, so I'll queue this for master.
Ping?
Ooops sorry - I'd applied this to my local master, but not pushed the branch to github. It should now be there.
One down... Can you please look at and merge these as well: drivers/pci: Implement config access words [PATCH 0/3] Add parse hex words for compatibility Regards, BALATON Zoltan
participants (2)
-
BALATON Zoltan -
Mark Cave-Ayland