Re: [OpenBIOS] [PATCH] Expose NVRAM compatibility

[Laurent Vivier]

Le 5 mars 09 à 22:24, Alexander Graf a écrit :
> Linux requires the NVRAM to expose a 'nvram,flash' compatibility
> in the device tree. Let's expose it so it's happy.
> Signed-off-by: Alexander Graf
>
> drivers/macio.c |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/macio.c b/drivers/macio.c
> index e150a18..86824aa 100644
> --- a/drivers/macio.c
> +++ b/drivers/macio.c
> @@ -71,6 +71,7 @@ void macio_nvram_init(const char *path, uint32_t  
> addr)
>    props[1] = __cpu_to_be32(nvram_size);
>    set_property(dnode, "reg", (char *)&props, sizeof(props));
>    set_property(dnode, "device_type", "nvram", 6);
> set_property(dnode, "compatible", "nvram,flash", 12);

This breaks oldworld nvram support, could you use something like:

NEWWORLD(set_property(dnode, "compatible", "nvram,flash", 12));
OLDWORLD(set_property(dnode, "compatible", "nvram", 6));

(OLDWORLD() already exists, you have to define NEWWORLD())
> chosen = find_dev("/chosen");
>    push_str(buf);
> -- 
> 1.6.0.2