Re: [OpenBIOS] PATCH v2: Rework CIF interface to handle parameters in reverse order

[Laurent Vivier]

Le dimanche 29 novembre 2009 à 13:30 +0000, Mark Cave-Ayland a écrit :
> Hi everyone,
>
> Here is a second version of the patch which attempts to reverse the 
> argument order of the CIF Forth words so that they can be called 
> correctly from both Forth and C.
>
> The patch is fairly straightforward; probably the only unexpected part 
> is the need to rename the existing /openprom/client-services "claim" and 
> "release" words to "cif-claim" and "cif-release" respectively. This is 
> because we need to use the "claim" and "release" words in 
> forth/system/ciface.fs to reverse the argument order before calling the 
> real underlying words.
>
> I've tested this on a FC12 PPC CD as well as my SPARC64 Milax CD and 
> with this version of the patch, the CIF words are called correctly in 
> both cases. I'd like to apply this reasonably soon, so please can people 
> test on their setups to make sure it doesn't break anything?
>
> Signed-off-by: Mark Cave-Ayland

Just one question about the patch: Why do you rename "claim" and
"release" to "cif-claim" and "cif-release" ?
Moreover, I think it is not compliant with OpenFirmware specification
(IEEE 1295).

Regards,
Laurent